[dpdk-dev] [PATCH] port: add kni interface support

2016-06-16 Thread Ethan
Hi Cristian, The new patch has been submitted just now. Please note that I do ignore some check patch errors this time. B.R. Ethan 2016-06-13 21:18 GMT+08:00 Dumitrescu, Cristian < cristian.dumitrescu at intel.com>: > Hi Ethan, > > > > Great, we?ll wait for your patch later this week then. I

[dpdk-dev] [PATCH] port: add kni interface support

2016-06-13 Thread Ethan
Hi Cristian, I've got your comments. Thank you for review the code from a DPDK newbie. :-) I plan to submit a new patch to fix all during this week hopefully. There are four places I'd like to discuss further: 1. Dedicated lcore for kni kernel thread First of all, it is a bug to add kni kernel

[dpdk-dev] [PATCH] port: add kni interface support

2016-06-13 Thread Dumitrescu, Cristian
Hi Ethan, Great, we?ll wait for your patch later this week then. I recommend you add any other changes that you might have on top of the latest code that I just send, as this will minimize your work, my work to further code reviews and number of future iterations to merge this patch. Answers

[dpdk-dev] [PATCH] port: add kni interface support

2016-06-13 Thread Dumitrescu, Cristian
Hi Ethan, In the process of testing your patch, I actually had to do the rebase on the latest code and fix all the comments that I previously sent as part of my reply. I also did a few other cosmetic changes and fixes required by the latest code (see below), therefore I think it makes sense to

[dpdk-dev] [PATCH] port: add kni interface support

2016-06-10 Thread Dumitrescu, Cristian
Hi Ethan, Great work! There are still several comments below that need to be addressed, but I am confident we can close on them quickly. Thank you! Please rebase the next version on top of the latest code on master branch. Please also update librte_port/rte_port_version.map file. >

[dpdk-dev] [PATCH] port: add kni interface support

2016-06-01 Thread Ethan
Hi Cristian, No problem. Enjoy your travel. :-) B.R. Ethan 2016-05-30 22:40 GMT+08:00 Dumitrescu, Cristian < cristian.dumitrescu at intel.com>: > Hi Wei Jie, > > Thank you for submitting this patch. I am currently travelling, I will > review your patch and come back to you hopefully later this

[dpdk-dev] [PATCH] port: add kni interface support

2016-05-30 Thread Dumitrescu, Cristian
Hi Wei Jie, Thank you for submitting this patch. I am currently travelling, I will review your patch and come back to you hopefully later this week or early next week. Regards, Cristian > -Original Message- > From: WeiJie Zhuang [mailto:zhuangwj at gmail.com] > Sent: Saturday, May 28,

[dpdk-dev] [PATCH] port: add kni interface support

2016-05-28 Thread WeiJie Zhuang
1. add KNI port type to the packet framework 2. add KNI support to the IP Pipeline sample Application Signed-off-by: WeiJie Zhuang --- v2: * Fix check patch error. --- doc/api/doxy-api-index.md | 1 + examples/ip_pipeline/Makefile | 6 +- examples/ip_pipeline/app.h

[dpdk-dev] [PATCH] port: add KNI interface support 1. add KNI port type to the packet framework 2. add KNI support to the IP Pipeline sample Application

2016-05-27 Thread WeiJie Zhuang
Signed-off-by: WeiJie Zhuang --- doc/api/doxy-api-index.md | 3 +- examples/ip_pipeline/Makefile | 6 +- examples/ip_pipeline/app.h | 74 examples/ip_pipeline/config/kni.cfg | 12 ++ examples/ip_pipeline/config_check.c | 30