[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-07-14 Thread Yuanhan Liu
On Wed, Jul 13, 2016 at 08:54:08AM -0700, Rich Lane wrote: > On Wednesday, July 13, 2016, Yuanhan Liu > wrote: > > On Wed, Jul 13, 2016 at 10:34:07AM +0300, Ilya Maximets wrote: > > This scenario fixed somehow, I agree. But this patch still needed to > protect > > vhost from

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-07-14 Thread Ilya Maximets
On 14.07.2016 04:42, Yuanhan Liu wrote: > On Wed, Jul 13, 2016 at 08:54:08AM -0700, Rich Lane wrote: >> On Wednesday, July 13, 2016, Yuanhan Liu >> wrote: >> >> On Wed, Jul 13, 2016 at 10:34:07AM +0300, Ilya Maximets wrote: >> > This scenario fixed somehow, I agree. But this patch still

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-07-13 Thread Yuanhan Liu
On Wed, Jul 13, 2016 at 10:34:07AM +0300, Ilya Maximets wrote: > On 12.07.2016 08:53, Ilya Maximets wrote: > > On 12.07.2016 05:43, Yuanhan Liu wrote: > >> On Mon, Jul 11, 2016 at 02:47:56PM +0300, Ilya Maximets wrote: > >>> On 11.07.2016 14:05, Yuanhan Liu wrote: > On Mon, Jul 11, 2016 at

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-07-13 Thread Ilya Maximets
On 12.07.2016 08:53, Ilya Maximets wrote: > On 12.07.2016 05:43, Yuanhan Liu wrote: >> On Mon, Jul 11, 2016 at 02:47:56PM +0300, Ilya Maximets wrote: >>> On 11.07.2016 14:05, Yuanhan Liu wrote: On Mon, Jul 11, 2016 at 12:50:24PM +0300, Ilya Maximets wrote: > On 11.07.2016 11:38, Yuanhan

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-07-13 Thread Rich Lane
On Wednesday, July 13, 2016, Yuanhan Liu wrote: > On Wed, Jul 13, 2016 at 10:34:07AM +0300, Ilya Maximets wrote: > > This scenario fixed somehow, I agree. But this patch still needed to > protect > > vhost from untrusted VM, from malicious or buggy virtio application. > > Maybe we could change

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-07-12 Thread Yuanhan Liu
On Mon, Jul 11, 2016 at 02:47:56PM +0300, Ilya Maximets wrote: > On 11.07.2016 14:05, Yuanhan Liu wrote: > > On Mon, Jul 11, 2016 at 12:50:24PM +0300, Ilya Maximets wrote: > >> On 11.07.2016 11:38, Yuanhan Liu wrote: > >>> On Sun, Jul 10, 2016 at 09:17:31PM +0800, Yuanhan Liu wrote: > On Fri,

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-07-12 Thread Ilya Maximets
On 12.07.2016 05:43, Yuanhan Liu wrote: > On Mon, Jul 11, 2016 at 02:47:56PM +0300, Ilya Maximets wrote: >> On 11.07.2016 14:05, Yuanhan Liu wrote: >>> On Mon, Jul 11, 2016 at 12:50:24PM +0300, Ilya Maximets wrote: On 11.07.2016 11:38, Yuanhan Liu wrote: > On Sun, Jul 10, 2016 at

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-07-11 Thread Yuanhan Liu
On Sun, Jul 10, 2016 at 09:17:31PM +0800, Yuanhan Liu wrote: > On Fri, Jul 08, 2016 at 02:48:56PM +0300, Ilya Maximets wrote: > > > > Another point is that crash constantly happens on queue_id=3 (second RX > > queue) in > > my scenario. It is newly allocated virtqueue while reconfiguration from

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-07-11 Thread Ilya Maximets
On 11.07.2016 11:38, Yuanhan Liu wrote: > On Sun, Jul 10, 2016 at 09:17:31PM +0800, Yuanhan Liu wrote: >> On Fri, Jul 08, 2016 at 02:48:56PM +0300, Ilya Maximets wrote: >>> >>> Another point is that crash constantly happens on queue_id=3 (second RX >>> queue) in >>> my scenario. It is newly

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-07-10 Thread Yuanhan Liu
On Fri, Jul 08, 2016 at 02:48:56PM +0300, Ilya Maximets wrote: > > Another point is that crash constantly happens on queue_id=3 (second RX > queue) in > my scenario. It is newly allocated virtqueue while reconfiguration from rxq=1 > to > rxq=2. That's a valuable message: what's your DPDK HEAD

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-07-08 Thread Ilya Maximets
On 06.07.2016 15:24, Yuanhan Liu wrote: > On Wed, Jul 06, 2016 at 02:19:12PM +0300, Ilya Maximets wrote: >> On 01.07.2016 10:35, Yuanhan Liu wrote: >>> Hi, >>> >>> Sorry for the long delay. >>> >>> On Fri, May 20, 2016 at 03:50:04PM +0300, Ilya Maximets wrote: In current implementation guest

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-07-06 Thread Yuanhan Liu
On Wed, Jul 06, 2016 at 02:19:12PM +0300, Ilya Maximets wrote: > On 01.07.2016 10:35, Yuanhan Liu wrote: > > Hi, > > > > Sorry for the long delay. > > > > On Fri, May 20, 2016 at 03:50:04PM +0300, Ilya Maximets wrote: > >> In current implementation guest application can reinitialize vrings > >>

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-07-06 Thread Ilya Maximets
On 01.07.2016 10:35, Yuanhan Liu wrote: > Hi, > > Sorry for the long delay. > > On Fri, May 20, 2016 at 03:50:04PM +0300, Ilya Maximets wrote: >> In current implementation guest application can reinitialize vrings >> by executing start after stop. In the same time host application >> can still

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-07-01 Thread Yuanhan Liu
Hi, Sorry for the long delay. On Fri, May 20, 2016 at 03:50:04PM +0300, Ilya Maximets wrote: > In current implementation guest application can reinitialize vrings > by executing start after stop. In the same time host application > can still poll virtqueue while device stopped in guest and it

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-06-03 Thread Ilya Maximets
On 02.06.2016 19:22, Rich Lane wrote: > On Thu, Jun 2, 2016 at 3:46 AM, Ilya Maximets > wrote: > > Hi, Rich. > Thank you for testing and analysing. > > On 01.06.2016 01:06, Rich Lane wrote: > > On Fri, May 20, 2016 at 5:50 AM, Ilya Maximets

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-06-02 Thread Ilya Maximets
Hi, Rich. Thank you for testing and analysing. On 01.06.2016 01:06, Rich Lane wrote: > On Fri, May 20, 2016 at 5:50 AM, Ilya Maximets > wrote: > > In current implementation guest application can reinitialize vrings > by executing start after stop. In

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-06-02 Thread Rich Lane
On Thu, Jun 2, 2016 at 3:46 AM, Ilya Maximets wrote: > Hi, Rich. > Thank you for testing and analysing. > > On 01.06.2016 01:06, Rich Lane wrote: > > On Fri, May 20, 2016 at 5:50 AM, Ilya Maximets > wrote: > > > > In current implementation guest application

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-05-31 Thread Rich Lane
On Fri, May 20, 2016 at 5:50 AM, Ilya Maximets wrote: > In current implementation guest application can reinitialize vrings > by executing start after stop. In the same time host application > can still poll virtqueue while device stopped in guest and it will > crash with segmentation fault

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-05-31 Thread Tan, Jianfeng
Hi, On 5/30/2016 8:24 PM, Ilya Maximets wrote: > On 30.05.2016 15:00, Tan, Jianfeng wrote: >> Hi, >> >>> -Original Message- >>> From: Ilya Maximets [mailto:i.maximets at samsung.com] >>> Sent: Friday, May 20, 2016 8:50 PM >>> To: dev at dpdk.org; Xie, Huawei; Yuanhan Liu >>> Cc: Dyasly

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-05-31 Thread Ilya Maximets
OK. On 30.05.2016 17:25, Yuanhan Liu wrote: > Hi Ilya, > > Generically speaking, this patch looks good to me. But I guess still > need more time to check this issue later; I still failed to reproduce > it on my side after all. So, please allow a late merge. > > Thanks. > > --yliu > > On

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-05-31 Thread Ilya Maximets
On 31.05.2016 09:53, Tan, Jianfeng wrote: > Hi, > > > On 5/30/2016 8:24 PM, Ilya Maximets wrote: >> On 30.05.2016 15:00, Tan, Jianfeng wrote: >>> Hi, >>> -Original Message- From: Ilya Maximets [mailto:i.maximets at samsung.com] Sent: Friday, May 20, 2016 8:50 PM To:

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-05-30 Thread Yuanhan Liu
Hi Ilya, Generically speaking, this patch looks good to me. But I guess still need more time to check this issue later; I still failed to reproduce it on my side after all. So, please allow a late merge. Thanks. --yliu On Mon, May 30, 2016 at 02:05:07PM +0300, Ilya Maximets wrote: >

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-05-30 Thread Ilya Maximets
On 30.05.2016 15:00, Tan, Jianfeng wrote: > Hi, > >> -Original Message- >> From: Ilya Maximets [mailto:i.maximets at samsung.com] >> Sent: Friday, May 20, 2016 8:50 PM >> To: dev at dpdk.org; Xie, Huawei; Yuanhan Liu >> Cc: Dyasly Sergey; Heetae Ahn; Tan, Jianfeng; Ilya Maximets >>

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-05-30 Thread Ilya Maximets
Ping. Best regards, Ilya Maximets. On 23.05.2016 14:04, Ilya Maximets wrote: > On 23.05.2016 13:57, Yuanhan Liu wrote: >> On Fri, May 20, 2016 at 03:50:04PM +0300, Ilya Maximets wrote: >>> In current implementation guest application can reinitialize vrings >>> by executing start after stop. In

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-05-30 Thread Tan, Jianfeng
Hi, > -Original Message- > From: Ilya Maximets [mailto:i.maximets at samsung.com] > Sent: Friday, May 20, 2016 8:50 PM > To: dev at dpdk.org; Xie, Huawei; Yuanhan Liu > Cc: Dyasly Sergey; Heetae Ahn; Tan, Jianfeng; Ilya Maximets > Subject: [PATCH] vhost: fix segfault on bad descriptor

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-05-23 Thread Yuanhan Liu
On Fri, May 20, 2016 at 03:50:04PM +0300, Ilya Maximets wrote: > In current implementation guest application can reinitialize vrings > by executing start after stop. In the same time host application > can still poll virtqueue while device stopped in guest and it will > crash with segmentation

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-05-23 Thread Ilya Maximets
On 23.05.2016 13:57, Yuanhan Liu wrote: > On Fri, May 20, 2016 at 03:50:04PM +0300, Ilya Maximets wrote: >> In current implementation guest application can reinitialize vrings >> by executing start after stop. In the same time host application >> can still poll virtqueue while device stopped in

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-05-20 Thread Ilya Maximets
In current implementation guest application can reinitialize vrings by executing start after stop. In the same time host application can still poll virtqueue while device stopped in guest and it will crash with segmentation fault while vring reinitialization because of dereferencing of bad