[dpdk-dev] [PATCH] virtio: fix the vq size issue

2015-07-21 Thread Ouyang, Changchun
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, July 20, 2015 6:42 PM > To: Ouyang, Changchun > Cc: Xu, Qian Q; Stephen Hemminger; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] virtio: fix the vq size issue >

[dpdk-dev] [PATCH] virtio: fix the vq size issue

2015-07-20 Thread Thomas Monjalon
2015-07-20 06:18, Ouyang, Changchun: > Another thing burst into my thought. > Can we think more about how to setup a mechanism to block those patches which > causes critical regression issue? Yes. Non-regression tests are needed. As it must be done with many hardwares and many configurations, it

[dpdk-dev] [PATCH] virtio: fix the vq size issue

2015-07-20 Thread Stephen Hemminger
Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] virtio: fix the vq size issue > > > > On Wed, 1 Jul 2015 15:48:50 +0800 > > Ouyang Changchun wrote: > > > > > This commit breaks virtio basic packets rx functionality: > > > d78dead

[dpdk-dev] [PATCH] virtio: fix the vq size issue

2015-07-20 Thread Stephen Hemminger
On Mon, 20 Jul 2015 06:18:53 + "Ouyang, Changchun" wrote: > Hi Thomas, > > I think we have 3 options for this issue. > 1) applying this patch; > 2) reverting Stephen's original patch; > 3) new patch to make both QEMU and GCE work. I am working on #3

[dpdk-dev] [PATCH] virtio: fix the vq size issue

2015-07-20 Thread Ouyang, Changchun
. > > > > Thanks > Qian > > > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen > Hemminger > Sent: Saturday, July 18, 2015 12:28 AM > To: Ouyang, Changchun > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH

[dpdk-dev] [PATCH] virtio: fix the vq size issue

2015-07-20 Thread Xu, Qian Q
Hemminger Sent: Saturday, July 18, 2015 12:28 AM To: Ouyang, Changchun Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH] virtio: fix the vq size issue On Wed, 1 Jul 2015 15:48:50 +0800 Ouyang Changchun wrote: > This commit breaks virtio basic packets rx functional

[dpdk-dev] [PATCH] virtio: fix the vq size issue

2015-07-18 Thread Ouyang, Changchun
Hi Stephen, > -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Saturday, July 18, 2015 12:28 AM > To: Ouyang, Changchun > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] virtio: fix the vq size issue > > On Wed, 1

[dpdk-dev] [PATCH] virtio: fix the vq size issue

2015-07-17 Thread Thomas Monjalon
Stephen, This patch is partially reverting yours: http://dpdk.org/browse/dpdk/commit/?id=d78deadae4dca240 A comment or a ack? 2015-07-07 02:32, Ouyang, Changchun: > > > -Original Message- > > From: Ouyang, Changchun > > Sent: Wednesday, July 1, 2015 3:49 PM > > To: dev at

[dpdk-dev] [PATCH] virtio: fix the vq size issue

2015-07-17 Thread Stephen Hemminger
On Wed, 1 Jul 2015 15:48:50 +0800 Ouyang Changchun wrote: > This commit breaks virtio basic packets rx functionality: > d78deadae4dca240e85054bf2d604a801676becc > > The QEMU use 256 as default vring size, also use this default value to > calculate the virtio > avail ring base address and

[dpdk-dev] [PATCH] virtio: fix the vq size issue

2015-07-13 Thread Ouyang, Changchun
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Friday, July 10, 2015 10:12 PM > To: Xie, Huawei > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] virtio: fix the vq size issue > > 2015-07-10 14:05,

[dpdk-dev] [PATCH] virtio: fix the vq size issue

2015-07-10 Thread Thomas Monjalon
2015-07-10 14:05, Xie, Huawei: > Thomas: > Could we roll back that commit or apply Changchun's patch? It is waiting an agreement with Changchun, symbolized by an Acked-by: > On 7/1/2015 11:53 PM, Xie, Huawei wrote: > > On 7/1/2015 3:49 PM, Ouyang Changchun wrote: > >> This commit breaks virtio

[dpdk-dev] [PATCH] virtio: fix the vq size issue

2015-07-10 Thread Xie, Huawei
Thomas: Could we roll back that commit or apply Changchun's patch? /Huawei On 7/1/2015 11:53 PM, Xie, Huawei wrote: > On 7/1/2015 3:49 PM, Ouyang Changchun wrote: >> This commit breaks virtio basic packets rx functionality: >> d78deadae4dca240e85054bf2d604a801676becc >> >> The QEMU use 256 as

[dpdk-dev] [PATCH] virtio: fix the vq size issue

2015-07-07 Thread Ouyang, Changchun
> -Original Message- > From: Ouyang, Changchun > Sent: Wednesday, July 1, 2015 3:49 PM > To: dev at dpdk.org > Cc: Cao, Waterman; Xu, Qian Q; Ouyang, Changchun > Subject: [PATCH] virtio: fix the vq size issue > > This commit breaks virtio basic packets rx functionality: >

[dpdk-dev] [PATCH] virtio: fix the vq size issue

2015-07-03 Thread Ouyang, Changchun
> -Original Message- > From: Xie, Huawei > Sent: Thursday, July 2, 2015 5:16 PM > To: Ouyang, Changchun > Cc: dev at dpdk.org; Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH] virtio: fix the vq size issue > > On 7/2/2015 10:16 AM, Ouyang, Changchun wrote

[dpdk-dev] [PATCH] virtio: fix the vq size issue

2015-07-02 Thread Xie, Huawei
On 7/2/2015 10:16 AM, Ouyang, Changchun wrote: > >> -Original Message- >> From: Xie, Huawei >> Sent: Thursday, July 2, 2015 10:02 AM >> To: Ouyang, Changchun; dev at dpdk.org; Thomas Monjalon >> Subject: Re: [dpdk-dev] [PATCH] virtio: fix the vq size issue

[dpdk-dev] [PATCH] virtio: fix the vq size issue

2015-07-02 Thread Ouyang, Changchun
> -Original Message- > From: Xie, Huawei > Sent: Thursday, July 2, 2015 10:02 AM > To: Ouyang, Changchun; dev at dpdk.org; Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH] virtio: fix the vq size issue > > On 7/2/2015 8:29 AM, Ouyang, Changchun

[dpdk-dev] [PATCH] virtio: fix the vq size issue

2015-07-02 Thread Xie, Huawei
On 7/2/2015 8:29 AM, Ouyang, Changchun wrote: > Hi huawei, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Xie, Huawei >> Sent: Wednesday, July 1, 2015 11:53 PM >> To: dev at dpdk.org; Thomas Monjalon >> Subject: Re: [

[dpdk-dev] [PATCH] virtio: fix the vq size issue

2015-07-02 Thread Ouyang, Changchun
Hi huawei, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Xie, Huawei > Sent: Wednesday, July 1, 2015 11:53 PM > To: dev at dpdk.org; Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH] virtio: fix the vq size issue > > On 7/1/2015 3:49

[dpdk-dev] [PATCH] virtio: fix the vq size issue

2015-07-01 Thread Xie, Huawei
On 7/1/2015 3:49 PM, Ouyang Changchun wrote: > This commit breaks virtio basic packets rx functionality: > d78deadae4dca240e85054bf2d604a801676becc > > The QEMU use 256 as default vring size, also use this default value to > calculate the virtio > avail ring base address and used ring base

[dpdk-dev] [PATCH] virtio: fix the vq size issue

2015-07-01 Thread Ouyang Changchun
This commit breaks virtio basic packets rx functionality: d78deadae4dca240e85054bf2d604a801676becc The QEMU use 256 as default vring size, also use this default value to calculate the virtio avail ring base address and used ring base address, and vhost in the backend use the ring base address

[dpdk-dev] [PATCH] virtio: fix the vq size issue

2015-07-01 Thread Xu, Qian Q
Tested-by: Qian Xu - Test Commit: c55e94f560ef5c9fcee4584952de1d0bd414aece - OS: Fedora 21 - GCC: gcc (GCC) 4.9.2 20141101 (Red Hat 4.9.2-1) - CPU: Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz - NIC: Intel Corporation 82599ES 10-Gigabit SFI/SFP+ Network Connection (rev 01) - Target: Intel