[dpdk-dev] [PATCH 1/3] vhost: Fix wrong handling of virtqueue array index

2015-10-27 Thread Tetsuya Mukawa
Hi Yuanhan, I appreciate your checking. I haven't noticed SET_BACKEND is only supported by vhost-cuse. :-( I will follow your comments, then submit again. Thanks, Tetsuya On 2015/10/27 15:47, Yuanhan Liu wrote: > On Tue, Oct 27, 2015 at 03:12:53PM +0900, Tetsuya Mukawa wrote: >> The patch fixes

[dpdk-dev] [PATCH 1/3] vhost: Fix wrong handling of virtqueue array index

2015-10-27 Thread Yuanhan Liu
On Tue, Oct 27, 2015 at 04:28:58PM +0900, Tetsuya Mukawa wrote: > Hi Yuanhan, > > I appreciate your checking. Welcome! And thank you for catching out my faults. --yliu > I haven't noticed SET_BACKEND is only supported by vhost-cuse. :-( > I will follow your comments, then submit again.

[dpdk-dev] [PATCH 1/3] vhost: Fix wrong handling of virtqueue array index

2015-10-27 Thread Tetsuya Mukawa
The patch fixes wrong handling of virtqueue array index. GET_VRING_BASE: The vhost backend will receive the message per virtqueue. Also we should call a destroy callback when both RXQ and TXQ receives the message. SET_BACKEND: Because vhost library supports multiple queue, the index may be over

[dpdk-dev] [PATCH 1/3] vhost: Fix wrong handling of virtqueue array index

2015-10-27 Thread Yuanhan Liu
On Tue, Oct 27, 2015 at 03:12:53PM +0900, Tetsuya Mukawa wrote: > The patch fixes wrong handling of virtqueue array index. > > GET_VRING_BASE: > The vhost backend will receive the message per virtqueue. > Also we should call a destroy callback when both RXQ and TXQ receives > the message. > >

[dpdk-dev] [PATCH 1/3] vhost: Fix wrong handling of virtqueue array index

2015-10-27 Thread Yuanhan Liu
On Tue, Oct 27, 2015 at 02:29:25PM +0800, Yuanhan Liu wrote: > On Tue, Oct 27, 2015 at 03:12:53PM +0900, Tetsuya Mukawa wrote: > > The patch fixes wrong handling of virtqueue array index. > > > > GET_VRING_BASE: > > The vhost backend will receive the message per virtqueue. > > No, that's not

[dpdk-dev] [PATCH 1/3] vhost: Fix wrong handling of virtqueue array index

2015-10-27 Thread Yuanhan Liu
On Tue, Oct 27, 2015 at 03:12:53PM +0900, Tetsuya Mukawa wrote: > The patch fixes wrong handling of virtqueue array index. > > GET_VRING_BASE: > The vhost backend will receive the message per virtqueue. No, that's not right, we will get GET_VRING_BASE for each queue pair, including RX and TX