[dpdk-dev] [PATCH 1/4] eal: provide functions to access PCI config

2015-07-09 Thread Stephen Hemminger
On Wed, 17 Jun 2015 14:44:31 + David Marchand wrote: > +? ? ? ?if (len == 3 || len > sizeof(pi.pi_data)) { > +? ? ? ? ? ? ? ?RTE_LOG(ERR, EAL, "%s(): invalid pci read length\n", > __func__); > +? ? ? ? ? ? ? ?goto error; > +? ? ? ?} > > A comment on length 3 would help to understand why it

[dpdk-dev] [PATCH 1/4] eal: provide functions to access PCI config

2015-07-09 Thread Stephen Hemminger
Some drivers need ability to access PCI config (for example for power management). This adds an abstraction to do this for both Linux and BSD. Signed-off-by: Stephen Hemminger --- lib/librte_eal/bsdapp/eal/eal_pci.c | 83 +

[dpdk-dev] [PATCH 1/4] eal: provide functions to access PCI config

2015-07-08 Thread Thomas Monjalon
2015-07-08 09:11, Stephen Hemminger: > On Wed, 8 Jul 2015 15:04:16 + > Thomas Monjalon wrote: > > > 2015-07-07 17:08, Stephen Hemminger: > > > --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map > > > +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map > > > @@ -98,3 +98,8 @@ DPDK_2.0 {

[dpdk-dev] [PATCH 1/4] eal: provide functions to access PCI config

2015-07-08 Thread Thomas Monjalon
2015-07-07 17:08, Stephen Hemminger: > --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map > +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map > @@ -98,3 +98,8 @@ DPDK_2.0 { > > local: *; > }; > + > +DPDK_2.1 { > + rte_eal_pci_read_config; > + rte_eal_pci_write_config;

[dpdk-dev] [PATCH 1/4] eal: provide functions to access PCI config

2015-07-08 Thread Stephen Hemminger
On Wed, 8 Jul 2015 15:04:16 + Thomas Monjalon wrote: > 2015-07-07 17:08, Stephen Hemminger: > > --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map > > +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map > > @@ -98,3 +98,8 @@ DPDK_2.0 { > > > > local: *; > > }; > > + > >

[dpdk-dev] [PATCH 1/4] eal: provide functions to access PCI config

2015-07-07 Thread Stephen Hemminger
From: Stephen Hemminger Some drivers need ability to access PCI config (for example for power management). This adds an abstraction to do this for both Linux and BSD. Signed-off-by: Stephen Hemminger --- v3 - put new symbols in DPDK 2.1 section ---

[dpdk-dev] [PATCH 1/4] eal: provide functions to access PCI config

2015-06-17 Thread David Marchand
On Wed, Jun 17, 2015 at 1:51 AM, Stephen Hemminger < stephen at networkplumber.org> wrote: > From: Stephen Hemminger > > Some drivers need ability to access PCI config (for example for power > management). This adds an abstraction to do this for both Linux > and BSD. > > Signed-off-by: Stephen

[dpdk-dev] [PATCH 1/4] eal: provide functions to access PCI config

2015-06-17 Thread Panu Matilainen
On 06/17/2015 02:51 AM, Stephen Hemminger wrote: > From: Stephen Hemminger > > Some drivers need ability to access PCI config (for example for power > management). This adds an abstraction to do this for both Linux > and BSD. > > Signed-off-by: Stephen Hemminger > --- [...] > diff --git

[dpdk-dev] [PATCH 1/4] eal: provide functions to access PCI config

2015-06-16 Thread Stephen Hemminger
From: Stephen Hemminger Some drivers need ability to access PCI config (for example for power management). This adds an abstraction to do this for both Linux and BSD. Signed-off-by: Stephen Hemminger --- lib/librte_eal/bsdapp/eal/eal_pci.c | 83