[dpdk-dev] [PATCH 1/4] net/virtio-user: fix return value not checked

On Tue, Jul 05, 2016 at 10:14:28AM +, Tan, Jianfeng wrote: > > On Wed, Jun 29, 2016 at 09:05:33AM +, Jianfeng Tan wrote: > > > - if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_CQ_NUM) == 1) > > > - rte_kvargs_process(kvlist, VIRTIO_USER_ARG_CQ_NUM, > > > -&

[dpdk-dev] [PATCH 1/4] net/virtio-user: fix return value not checked

Hi Yuanhan, > -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Friday, July 1, 2016 10:16 AM > To: Tan, Jianfeng > Cc: dev at dpdk.org; Xie, Huawei; Mcnamara, John > Subject: Re: [PATCH 1/4] net/virtio-user: fix return value not checked > > On Wed, Ju

[dpdk-dev] [PATCH 1/4] net/virtio-user: fix return value not checked

On Wed, Jun 29, 2016 at 09:05:33AM +, Jianfeng Tan wrote: > - if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_CQ_NUM) == 1) > - rte_kvargs_process(kvlist, VIRTIO_USER_ARG_CQ_NUM, > -&get_integer_arg, &cq); > + if (rte_kvargs_count(kvlist, VIRTIO_

[dpdk-dev] [PATCH 1/4] net/virtio-user: fix return value not checked

When return values of function calls are not checked, Coverity will report errors like: if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) == 1) >>> CID 127477:(CHECKED_RETURN) >>> Calling "rte_kvargs_process" without checking return value (as is done elsewhere