[dpdk-dev] [PATCH 2/2] bond: add mode 4 support

2014-09-22 Thread Neil Horman
to:nhorman at tuxdriver.com] > Sent: Monday, September 22, 2014 12:25 PM > To: Wodkowski, PawelX > Cc: dev at dpdk.org; Jastrzebski, MichalX K; Doherty, Declan > Subject: Re: [dpdk-dev] [PATCH 2/2] bond: add mode 4 support > > On Mon, Sep 22, 2014 at 06:26:21AM +, Wodkow

[dpdk-dev] [PATCH 2/2] bond: add mode 4 support

2014-09-22 Thread Wodkowski, PawelX
> I think that will work, but I believe you're making it more complicated (and > less reusable) than it needs to be. What I think you really need to do is > create a new rte api call, rte_eal_alarm_cancel_sync (something like the > equivalent of del_timer_sync in linux, that wraps up the >

[dpdk-dev] [PATCH 2/2] bond: add mode 4 support

2014-09-22 Thread Neil Horman
On Mon, Sep 22, 2014 at 06:26:21AM +, Wodkowski, PawelX wrote: > > I think that will work, but I believe you're making it more complicated (and > > less reusable) than it needs to be. What I think you really need to do is > > create a new rte api call, rte_eal_alarm_cancel_sync (something

[dpdk-dev] [PATCH 2/2] bond: add mode 4 support

2014-09-19 Thread Neil Horman
ki, MichalX K; Doherty, Declan > > Subject: Re: [dpdk-dev] [PATCH 2/2] bond: add mode 4 support > > > > On Thu, Sep 18, 2014 at 08:07:31AM +, Wodkowski, PawelX wrote: > > > > > +int > > > > > +bond_mode_8023ad_deactivate

[dpdk-dev] [PATCH 2/2] bond: add mode 4 support

2014-09-19 Thread Wodkowski, PawelX
> -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Thursday, September 18, 2014 18:03 > To: Wodkowski, PawelX > Cc: dev at dpdk.org; Jastrzebski, MichalX K; Doherty, Declan > Subject: Re: [dpdk-dev] [PATCH 2/2] bond: add mode 4 support &

[dpdk-dev] [PATCH 2/2] bond: add mode 4 support

2014-09-18 Thread Neil Horman
On Thu, Sep 18, 2014 at 08:07:31AM +, Wodkowski, PawelX wrote: > > > +int > > > +bond_mode_8023ad_deactivate_slave(struct rte_eth_dev *bond_dev, > > > + uint8_t slave_pos) > > > +{ > > > + struct bond_dev_private *internals = bond_dev->data->dev_private; > > > + struct mode8023ad_data

[dpdk-dev] [PATCH 2/2] bond: add mode 4 support

2014-09-18 Thread Wodkowski, PawelX
> > +int > > +bond_mode_8023ad_deactivate_slave(struct rte_eth_dev *bond_dev, > > + uint8_t slave_pos) > > +{ > > + struct bond_dev_private *internals = bond_dev->data->dev_private; > > + struct mode8023ad_data *data = >mode4; > > + struct port *port; > > + uint8_t i; > > + > > +

[dpdk-dev] [PATCH 2/2] bond: add mode 4 support

2014-09-17 Thread Pawel Wodkowski
Signed-off-by: Pawel Wodkowski Signed-off-by: Maciej T Gajdzica Reviewed-by: Declan Doherty --- lib/librte_ether/rte_ether.h |1 + lib/librte_pmd_bond/Makefile |1 + lib/librte_pmd_bond/rte_eth_bond.h |4 +

[dpdk-dev] [PATCH 2/2] bond: add mode 4 support

2014-09-17 Thread Neil Horman
On Wed, Sep 17, 2014 at 03:21:53PM +0100, Pawel Wodkowski wrote: > Signed-off-by: Pawel Wodkowski > Signed-off-by: Maciej T Gajdzica > Reviewed-by: Declan Doherty > --- > lib/librte_ether/rte_ether.h |1 + > lib/librte_pmd_bond/Makefile |1 + >