2015-06-05 17:24, Andrew Harvey:
> On 6/5/15, 5:47 AM, "Bruce Richardson" wrote:
> >> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> >> > That's why we need to understand what we (or you) are missing.
> >> > Maybe that it would be clearer with some code examples (which would
> >> >
2015-06-05 16:07, Andrew Harvey:
> On 6/5/15, 3:46 AM, "Thomas Monjalon" wrote:
> >Stephen and me say the same thing about using the ethdev API.
>
> And your would have a point would be valid if dpdk were available to every
> interface we support (it is not) and on every processor architecture
5, 2015 6:47 AM
>> > To: Andrew Harvey (agh)
>> > Cc: Stephen Hemminger; Wang, Liang-min; dev at dpdk.org
>> > Subject: Re: [dpdk-dev] [PATCH 2/2] ethtool: add new library to
>>provide
>> > ethtool-alike APIs
>> >
>> > 2015-06-04 22:10,
On 6/5/15, 3:46 AM, "Thomas Monjalon" wrote:
>2015-06-04 22:10, Andrew Harvey:
>> On 6/4/15, 7:58 AM, "Stephen Hemminger"
>>wrote:
>> >"Andrew Harvey (agh)" wrote:
>> >> I believe that their is value in this interface for software stacks
>>not
>> >> based on Linux being moved toward DPDK that
2015-06-05 11:25, Wang, Liang-min:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > Stephen and me say the same thing about using the ethdev API.
> > We don't understand why using a fake ethtool lib would be easier.
> > Though you are saying it "facilitated [your] adoption to
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Friday, June 05, 2015 9:41 AM
> To: Wang, Liang-min
> Cc: Andrew Harvey (agh); Stephen Hemminger; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 2/2] ethtool: add new library to
er; Wang, Liang-min; dev at dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH 2/2] ethtool: add new library to provide
> > ethtool-alike APIs
> >
> > 2015-06-04 22:10, Andrew Harvey:
> > > On 6/4/15, 7:58 AM, "Stephen Hemminger"
> > wrote:
> >
2015-06-04 22:10, Andrew Harvey:
> On 6/4/15, 7:58 AM, "Stephen Hemminger" wrote:
> >"Andrew Harvey (agh)" wrote:
> >> I believe that their is value in this interface for software stacks not
> >> based on Linux being moved toward DPDK that need simple operations like
> >> getting the mac
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Friday, June 05, 2015 6:47 AM
> To: Andrew Harvey (agh)
> Cc: Stephen Hemminger; Wang, Liang-min; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 2/2] ethtool: add new library to
On 6/4/15, 7:58 AM, "Stephen Hemminger" wrote:
>On Wed, 3 Jun 2015 02:09:39 +
>"Andrew Harvey (agh)" wrote:
>
>> I believe that their is value in this interface for software stacks not
>> based on Linux being moved toward DPDK that need simple operations like
>> getting the mac address.
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Andrew Harvey (agh)
> Sent: Wednesday, June 3, 2015 3:10 AM
> To: Thomas Monjalon; Wang, Liang-min
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 2/2] ethtool: add new library to provi
On Wed, 3 Jun 2015 02:09:39 +
"Andrew Harvey (agh)" wrote:
> I believe that their is value in this interface for software stacks not
> based on Linux being moved toward DPDK that need simple operations like
> getting the mac address. Some of these stacks have a dearth of resources
>
I believe that their is value in this interface for software stacks not
based on Linux being moved toward DPDK that need simple operations like
getting the mac address. Some of these stacks have a dearth of resources
available and dedicating a core/thread to KNI to get/set a mac address
is
)
> Subject: RE: [dpdk-dev] [PATCH 2/2] ethtool: add new library to provide
> ethtool-alike APIs
>
> >I have the feeling we are not progressing in this discussion.
> >Please bring new explanations or I'll give up.
> >David Harton already acked it so maybe he could expla
I have the feeling we are not progressing in this discussion.
Please bring new explanations or I'll give up.
David Harton already acked it so maybe he could explain why it is useful.
Comments below
2015-06-02 17:06, Wang, Liang-min:
> >2015-06-02 15:47, Wang, Liang-min:
> >> From: Thomas
>I have the feeling we are not progressing in this discussion.
>Please bring new explanations or I'll give up.
>David Harton already acked it so maybe he could explain why it is useful.
>
>Comments below
>
>2015-06-02 17:06, Wang, Liang-min:
>> >2015-06-02 15:47, Wang, Liang-min:
>> >> From:
2015-06-02 15:47, Wang, Liang-min:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > >>I'm curious to understand how renaming rte_eth_dev_set_mtu() to
> > >>rte_ethtool_net_change_mtu() will help anyone.
> >>
> >> As described, this interface is designed to provide API closely to
>2015-06-02 15:47, Wang, Liang-min:
>> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
>> > >>I'm curious to understand how renaming rte_eth_dev_set_mtu() to
>> > >>rte_ethtool_net_change_mtu() will help anyone.
>> >>
>> >> As described, this interface is designed to provide API
-Original Message-
From: Thomas Monjalon [mailto:thomas.monja...@6wind.com]
Sent: Tuesday, June 02, 2015 10:33 AM
To: Wang, Liang-min
Cc: dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] ethtool: add new library to provide
ethtool-alike APIs
>Wang, hope it's clear that any
2015-05-29 15:26, Liang-Min Larry Wang:
> adding a new library based upon ethdev APIs to provide API's that bear
> the same functionality as ethtool_ops (linux/ethtool.h) and net_device_ops
> (linux/netdevice.h).
>
> Signed-off-by: Liang-Min Larry Wang
> ---
> MAINTAINERS
>2015-05-29 15:26, Liang-Min Larry Wang:
>> adding a new library based upon ethdev APIs to provide API's that bear
>> the same functionality as ethtool_ops (linux/ethtool.h) and
>> net_device_ops (linux/netdevice.h).
>>
>> Signed-off-by: Liang-Min Larry Wang
>> ---
>> MAINTAINERS
Wang, hope it's clear that any new development is welcomed.
One step before integration is to clearly explain why your code
is needed. That's why a nack vote may help to discuss and decide.
Comments below
2015-06-02 13:15, Wang, Liang-min:
> >2015-05-29 15:26, Liang-Min Larry Wang:
> >> adding a
Acked-by: David Harton (dharton)
> -Original Message-
> From: Liang-Min Larry Wang [mailto:liang-min.wang at intel.com]
> Sent: Friday, May 29, 2015 8:38 PM
> To: dev at dpdk.org
> Cc: bruce.richardson at intel.com; konstantin.ananyev at intel.com; David
> Harton
> (dharton); Andrew
>>On Sat, 30 May 2015 19:40:46 +
>>"Wang, Liang-min" wrote:
>>
>>>
> >>On Sat, 30 May 2015 16:16:01 +
> >>"Wang, Liang-min" wrote:
> >>
> >> >>The design decision is to keep ethdev as THE interface for all the
> >> >>external API, so ethtool APIs are designed based upon ethdev API. At
>On Sat, 30 May 2015 19:40:46 +
>"Wang, Liang-min" wrote:
>
>>
> >On Sat, 30 May 2015 16:16:01 +
> >"Wang, Liang-min" wrote:
> >
> >> >The design decision is to keep ethdev as THE interface for all the
> >> >external API, so ethtool APIs are designed based upon ethdev API. At the
>
On Sat, 30 May 2015 19:40:46 +
"Wang, Liang-min" wrote:
>
> On Sat, 30 May 2015 16:16:01 +
> "Wang, Liang-min" wrote:
>
> > >The design decision is to keep ethdev as THE interface for all the
> > >external API, so ethtool APIs are designed based upon ethdev API. At the
> >
On Sat, 30 May 2015 16:16:01 +
"Wang, Liang-min" wrote:
> >The design decision is to keep ethdev as THE interface for all the external
> >API, so ethtool APIs are designed based upon ethdev API. At the meantime,
> >the ethtool APIs are designed to enable users to migrate designs based
>On Fri, 29 May 2015 20:37:56 -0400
>Liang-Min Larry Wang wrote:
>
>> adding a new library based upon ethdev APIs to provide API's that bear
>> the same functionality as ethtool_ops (linux/ethtool.h) and
> >net_device_ops (linux/netdevice.h).
>The API's for ethtool like things are valuable,
On Sat, 30 May 2015 16:16:01 +
"Wang, Liang-min" wrote:
> The design decision is to keep ethdev as THE interface for all the external
> API, so ethtool APIs are designed based upon ethdev API. At the meantime, the
> ethtool APIs are designed to enable users to migrate designs based upon
>
On Fri, 29 May 2015 20:37:56 -0400
Liang-Min Larry Wang wrote:
> adding a new library based upon ethdev APIs to provide API's that bear
> the same functionality as ethtool_ops (linux/ethtool.h) and net_device_ops
> (linux/netdevice.h).
The API's for ethtool like things are valuable, but please
adding a new library based upon ethdev APIs to provide API's that bear
the same functionality as ethtool_ops (linux/ethtool.h) and net_device_ops
(linux/netdevice.h).
Signed-off-by: Liang-Min Larry Wang
---
MAINTAINERS| 4 +
config/common_linuxapp
>On Fri, 29 May 2015 09:15:09 -0400
>Liang-Min Larry Wang wrote:
>
>> +drvinfo->n_stats = sizeof(struct rte_eth_stats) / sizeof(uint64_t);
> >+drvinfo->testinfo_len = 0;
>
>
>Providing a hook to access more functionality is good and compatiablity with
>old API's is helpful. Too bad
adding a new library based upon ethdev APIs to provide API's that bear
the same functionality as ethtool_ops (linux/ethtool.h) and net_device_ops
(linux/netdevice.h).
Signed-off-by: Liang-Min Larry Wang
---
MAINTAINERS| 4 +
config/common_linuxapp
adding a new library based upon ethdev APIs to provide API's that bear
the same functionality as ethtool_ops (linux/ethtool.h) and net_device_ops
(linux/netdevice.h).
Signed-off-by: Liang-Min Larry Wang
---
MAINTAINERS| 4 +
config/common_linuxapp
On Fri, 29 May 2015 09:15:09 -0400
Liang-Min Larry Wang wrote:
> + drvinfo->n_stats = sizeof(struct rte_eth_stats) / sizeof(uint64_t);
> + drvinfo->testinfo_len = 0;
Providing a hook to access more functionality is good and compatiablity
with old API's is helpful. Too bad ethtool is
35 matches
Mail list logo
