[dpdk-dev] [PATCH 2/3] lib/librte_vhost: vhost library support to facilitate integration with DPDK accelerated vswitch

2014-09-03 Thread Tetsuya.Mukawa
original cord. :) Thanks, Tetsuya >> -Original Message- >> From: Tetsuya.Mukawa [mailto:mukawa at igel.co.jp] >> Sent: Wednesday, September 03, 2014 11:39 AM >> To: Xie, Huawei; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 2/3] lib/librte_vhost: vhost library s

[dpdk-dev] [PATCH 2/3] lib/librte_vhost: vhost library support to facilitate integration with DPDK accelerated vswitch

2014-09-03 Thread Tetsuya.Mukawa
Hi Huawei, I added few comments. Mainly those comments are about source code indent. (2014/09/02 17:55), Huawei Xie wrote: > + > +/** > + * Structure contains variables relevant to RX/TX virtqueues. > + */ > +struct vhost_virtqueue { > + /**< descriptor ring. */ > + struct vring_desc*

[dpdk-dev] [PATCH 2/3] lib/librte_vhost: vhost library support to facilitate integration with DPDK accelerated vswitch

2014-09-03 Thread Ananyev, Konstantin
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen Hemminger > Sent: Wednesday, September 03, 2014 7:02 AM > To: Xie, Huawei > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/3] lib/librte_vhost: vhost library support > to facilitate integration with DPDK a

[dpdk-dev] [PATCH 2/3] lib/librte_vhost: vhost library support to facilitate integration with DPDK accelerated vswitch

2014-09-03 Thread Xie, Huawei
at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/3] lib/librte_vhost: vhost library support to > facilitate integration with DPDK accelerated vswitch > > Hi Huawei, > > I added few comments. Mainly those comments are about source code indent. > >

[dpdk-dev] [PATCH 2/3] lib/librte_vhost: vhost library support to facilitate integration with DPDK accelerated vswitch

2014-09-02 Thread Stephen Hemminger
On Wed, 3 Sep 2014 05:39:24 + "Xie, Huawei" wrote: > Thanks Tetsuya: > Some of them are due to 80 character limitation. Is it ok to break the > limitation for better indentation? Many of these comments could just be removed or shortened. Often removing comments makes code clearer and

[dpdk-dev] [PATCH 2/3] lib/librte_vhost: vhost library support to facilitate integration with DPDK accelerated vswitch

2014-09-02 Thread Huawei Xie
This library is turned off by default so that it doesn't break build on default system. Install fuse development library and turn it on. Signed-off-by: Huawei Xie Acked-by: Konstantin Ananyev Acked-by: Thomos Long --- config/common_linuxapp |7 + lib/Makefile