[dpdk-dev] [PATCH v1 01/10] app/test: introduce resources for tests

2016-05-12 Thread Jan Viktorin
On Thu, 12 May 2016 16:58:31 +0200 Thomas Monjalon wrote: > 2016-05-06 18:20, Jan Viktorin: > > On Fri, 06 May 2016 16:01:08 +0200 > > Thomas Monjalon wrote: > > > 2016-05-06 12:48, Jan Viktorin: > > > > +static struct resource linkres_ ##_n = { \ > > > > + .name = RTE_STR(_n),

[dpdk-dev] [PATCH v1 01/10] app/test: introduce resources for tests

2016-05-12 Thread Thomas Monjalon
2016-05-06 18:20, Jan Viktorin: > On Fri, 06 May 2016 16:01:08 +0200 > Thomas Monjalon wrote: > > 2016-05-06 12:48, Jan Viktorin: > > > +static struct resource linkres_ ##_n = { \ > > > + .name = RTE_STR(_n), \ > > > + .beg = _b, \ > > > + .end = _e, \ > > >

[dpdk-dev] [PATCH v1 01/10] app/test: introduce resources for tests

2016-05-09 Thread Jan Viktorin
On Fri, 06 May 2016 16:01:08 +0200 Thomas Monjalon wrote: > 2016-05-06 12:48, Jan Viktorin: > > --- /dev/null > > +++ b/app/test/resource.h > > @@ -0,0 +1,61 @@ > > +/*- > > + * BSD LICENSE > [...] > > + */ > > Please include a multi-line comment here to explain what is a resource > and

[dpdk-dev] [PATCH v1 01/10] app/test: introduce resources for tests

2016-05-06 Thread Jan Viktorin
On Fri, 06 May 2016 16:01:08 +0200 Thomas Monjalon wrote: > 2016-05-06 12:48, Jan Viktorin: > > --- /dev/null > > +++ b/app/test/resource.h > > @@ -0,0 +1,61 @@ > > +/*- > > + * BSD LICENSE > [...] > > + */ > > Please include a multi-line comment here to explain what is a resource > and

[dpdk-dev] [PATCH v1 01/10] app/test: introduce resources for tests

2016-05-06 Thread Thomas Monjalon
2016-05-06 12:48, Jan Viktorin: > --- /dev/null > +++ b/app/test/resource.h > @@ -0,0 +1,61 @@ > +/*- > + * BSD LICENSE [...] > + */ Please include a multi-line comment here to explain what is a resource and why it is needed. > + > +#ifndef _RESOURCE_H_ > +#define _RESOURCE_H_ > + |...] |> + >

[dpdk-dev] [PATCH v1 01/10] app/test: introduce resources for tests

2016-05-06 Thread Jan Viktorin
Certain internal mechanisms of DPDK access different file system structures (e.g. /sys/bus/pci/devices). It is difficult to test those cases automatically by a unit test when such path is not hard-coded and there is no simple way how to distribute fake ones with the current testing environment.