[dpdk-dev] [PATCH v2] VFIO: Avoid to enable vfio while the module not loaded

2014-12-09 Thread Burakov, Anatoly
Hi Michael, > > Yes, you are right, strncmp() will check 30 bytes if use sizeof(buffer). > > But any issue of strcmp() ? This rountin cares about exactly match. I think no > need to convert to strncmp() if it does have other issue. > > > fscanf with fgets would be better too, to make sure we

[dpdk-dev] [PATCH v2] VFIO: Avoid to enable vfio while the module not loaded

2014-12-08 Thread Qiu, Michael
On 12/5/2014 6:00 PM, Burakov, Anatoly wrote: > Hi Michael, > > Few nitpicks :-) (wording of the log message I guess is up to Thomas, I won't > comment on that) > >> lib/librte_eal/common/eal_private.h| 36 >> ++ >> lib/librte_eal/linuxapp/eal/eal_pci_vfio.c |