[dpdk-dev] [PATCH v2 01/10] igb_uio: use kernel standard log message

[Stephen Hemminger]

Use Linux kernel standard coding conventions for console messages.
Bare use of printk() is not desirable and is reported as a style
problem by checkpatch. Instead use pr_info() and dev_info()
 to print out log messages where appropriate.

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>

--- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
+++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
@@ -22,6 +22,8 @@
  *   Intel Corporation
  */

+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/device.h>
 #include <linux/module.h>
 #include <linux/pci.h>
@@ -314,7 +316,7 @@
        pci_unlock(pdev);
 spin_unlock:
        spin_unlock_irqrestore(&udev->lock, flags);
-       printk(KERN_INFO "irq 0x%x %s\n", irq, (ret == IRQ_HANDLED) ? "handled" 
: "not handled");
+       pr_info("irq 0x%x %s\n", irq, (ret == IRQ_HANDLED) ? "handled" : "not 
handled");

        return ret;
 }
@@ -477,7 +479,7 @@
         * memory
         */
        if (pci_enable_device(dev)) {
-               printk(KERN_ERR "Cannot enable PCI device\n");
+               dev_err(&dev->dev, "Cannot enable PCI device\n");
                goto fail_free;
        }

@@ -486,7 +488,7 @@
         * module
         */
        if (pci_request_regions(dev, "igb_uio")) {
-               printk(KERN_ERR "Cannot request regions\n");
+               dev_err(&dev->dev, "Cannot request regions\n");
                goto fail_disable;
        }

@@ -499,10 +501,10 @@

        /* set 64-bit DMA mask */
        if (pci_set_dma_mask(dev,  DMA_BIT_MASK(64))) {
-               printk(KERN_ERR "Cannot set DMA mask\n");
+               dev_err(&dev->dev, "Cannot set DMA mask\n");
                goto fail_release_iomem;
        } else if (pci_set_consistent_dma_mask(dev, DMA_BIT_MASK(64))) {
-               printk(KERN_ERR "Cannot set consistent DMA mask\n");
+               dev_err(&dev->dev, "Cannot set consistent DMA mask\n");
                goto fail_release_iomem;
        }

@@ -533,7 +535,7 @@
                }
                else {
                        pci_disable_msix(udev->pdev);
-                       printk(KERN_INFO "fail to enable pci msix, or not 
enough msix entries\n");
+                       pr_info("fail to enable pci msix, or not enough msix 
entries\n");
                }
        }
        switch (udev->mode) {
@@ -585,7 +587,7 @@
        struct uio_info *info = pci_get_drvdata(dev);

        if (info->priv == NULL) {
-               printk(KERN_DEBUG "Not igbuio device\n");
+               pr_notice("Not igbuio device\n");
                return;
        }

@@ -605,18 +607,18 @@
 igbuio_config_intr_mode(char *intr_str)
 {
        if (!intr_str) {
-               printk(KERN_INFO "Use MSIX interrupt by default\n");
+               pr_info("Use MSIX interrupt by default\n");
                return 0;
        }

        if (!strcmp(intr_str, "msix")) {
                igbuio_intr_mode_preferred = IGBUIO_MSIX_INTR_MODE;
-               printk(KERN_INFO "Use MSIX interrupt\n");
+               pr_info("Use MSIX interrupt\n");
        } else if (!strcmp(intr_str, "legacy")) {
                igbuio_intr_mode_preferred = IGBUIO_LEGACY_INTR_MODE;
-               printk(KERN_INFO "Use legacy interrupt\n");
+               pr_info("Use legacy interrupt\n");
        } else {
-               printk(KERN_INFO "Error: bad parameter - %s\n", intr_str);
+               pr_info("Error: bad parameter - %s\n", intr_str);
                return -EINVAL;
        }