[dpdk-dev] [PATCH v2 08/10] igb_uio: fix IRQ mode handling

2014-07-18 Thread Thomas Monjalon
Hi Stephen, I have other (inlined) comments on this patch. > udev->info.version = "0.1"; > udev->info.handler = igbuio_pci_irqhandler; > udev->info.irqcontrol = igbuio_pci_irqcontrol; > + udev->info.irq = dev->irq; [...] > + /* fall back to MSI */ > case

[dpdk-dev] [PATCH v2 08/10] igb_uio: fix IRQ mode handling

2014-07-18 Thread Thomas Monjalon
Hi Stephen, I cannot merge this part because some lines were removed from the context. I think I just have to add them but I would like confirmation. See below. > @@ -512,36 +499,36 @@ > #endif > udev->info.priv = udev; > udev->pdev = dev; > - udev->mode = 0; /* set the default

[dpdk-dev] [PATCH v2 08/10] igb_uio: fix IRQ mode handling

2014-06-06 Thread Stephen Hemminger
This pach reworks how IRQ mode handling is done. The biggest code change is to use the standard INTX management code that exists in more recent kernels (and provide backport version). This also fixes the pci_lock code which was broken, since it was not protecting against config access, and was