[dpdk-dev] [PATCH v2 1/3] ethdev: define ctrl_pkt filter type and its structure

Hi Jingjing, 2014-11-13 05:44, Wu, Jingjing: > The input set of control packet filter are dst_mac and ethertype in Ethernet > head. > To be clear, I think it's better to use the name ethertype filter. > > While there is already ethertype filter existing in igb and ixgbe driver. I > will rename

[dpdk-dev] [PATCH v2 1/3] ethdev: define ctrl_pkt filter type and its structure

> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, November 13, 2014 4:41 PM > To: Wu, Jingjing > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/3] ethdev: define ctrl_pkt filter type > and its structure > > Hi J

[dpdk-dev] [PATCH v2 1/3] ethdev: define ctrl_pkt filter type and its structure

> Subject: Re: [dpdk-dev] [PATCH v2 1/3] ethdev: define ctrl_pkt filter type > and its structure > > Hi Jingjing, > > I'm sorry, but your explanations are not sufficient. > Please keep in mind that the user of the API don't know i40e internals. >

[dpdk-dev] [PATCH v2 1/3] ethdev: define ctrl_pkt filter type and its structure

Hi Jingjing, I'm sorry, but your explanations are not sufficient. Please keep in mind that the user of the API don't know i40e internals. 2014-10-31 07:05, Wu, Jingjing: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2014-10-22 16:19, Jingjing Wu: > > > +/** > > > + * Define al

[dpdk-dev] [PATCH v2 1/3] ethdev: define ctrl_pkt filter type and its structure

Hi, Thomas Thanks for your comments Jingjing > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, October 31, 2014 6:47 AM > To: Wu, Jingjing > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/3] ethdev: define ct

[dpdk-dev] [PATCH v2 1/3] ethdev: define ctrl_pkt filter type and its structure

2014-10-22 16:19, Jingjing Wu: > +/** > + * Define all structures for Control Packet Filter type corresponding with > specific operations. > + */ Please explain what is a control packet. > + > +#define RTE_CONTROL_PACKET_FLAGS_IGNORE_MAC0x0001 > +#define RTE_CONTROL_PACKET_FLAGS_DROP

[dpdk-dev] [PATCH v2 1/3] ethdev: define ctrl_pkt filter type and its structure

define new filter type and its structure - RTE_ETH_FILTER_CTRL_PKT - struct rte_ctrl_pkt_filter Signed-off-by: Jingjing Wu --- lib/librte_ether/rte_eth_ctrl.h | 24 1 file changed, 24 insertions(+) diff --git a/lib/librte_ether/rte_eth_ctrl.h b/lib/librte_ether/rte_et