[dpdk-dev] [PATCH v2 2/3] examples/l2fwd: Handle SIGINT and SIGTERM in l2fwd

2015-12-28 Thread Wang, Zhihong
Hi Stephen, Really appreciate the detailed review! Please see comments below. > > +static int force_quit = -1; > > +static int signo_quit = -1; > > These need to be volatile otherwise you risk compiler optimizing away your > checks. Yes. Don't wanna take chances here. > > Also, don't use

[dpdk-dev] [PATCH v2 2/3] examples/l2fwd: Handle SIGINT and SIGTERM in l2fwd

2015-12-27 Thread Stephen Hemminger
On Thu, 24 Dec 2015 21:37:11 -0500 Zhihong Wang wrote: > Handle SIGINT and SIGTERM in l2fwd. > > Signed-off-by: Zhihong Wang > --- > examples/l2fwd/main.c | 60 > +++ > 1 file changed, 60 insertions(+) > > diff --git a/examples/l2fwd/main.c

[dpdk-dev] [PATCH v2 2/3] examples/l2fwd: Handle SIGINT and SIGTERM in l2fwd

2015-12-24 Thread Zhihong Wang
Handle SIGINT and SIGTERM in l2fwd. Signed-off-by: Zhihong Wang --- examples/l2fwd/main.c | 60 +++ 1 file changed, 60 insertions(+) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index 720fd5a..75899dd 100644 ---