[dpdk-dev] [PATCH v3 2/2] virtio/vdev: add a new vdev named eth_cvio

2016-04-22 Thread Tan, Jianfeng
Hi, On 4/22/2016 3:36 PM, David Marchand wrote: > Hello, > > On Fri, Apr 22, 2016 at 7:15 AM, Tan, Jianfeng > wrote: >> On 4/21/2016 4:51 PM, David Marchand wrote: >>> virtio code relies on drv_flags (even updating it while this should be >>> per-device). >>> So first, virtio should rely on

[dpdk-dev] [PATCH v3 2/2] virtio/vdev: add a new vdev named eth_cvio

2016-04-22 Thread Tan, Jianfeng
Hi Yuanhan, On 4/22/2016 6:14 AM, Yuanhan Liu wrote: > On Thu, Apr 21, 2016 at 02:56:36AM +, Jianfeng Tan wrote: >> Add a new virtual device named eth_cvio, it can be used just like >> eth_ring, eth_null, etc. >> >> Configured parameters include: >>- rx (optional, 1 by default), number of

[dpdk-dev] [PATCH v3 2/2] virtio/vdev: add a new vdev named eth_cvio

2016-04-22 Thread Tan, Jianfeng
Hi Thomas, On 4/21/2016 6:05 PM, Thomas Monjalon wrote: > 2016-04-21 02:56, Jianfeng Tan: >> Add a new virtual device named eth_cvio, it can be used just like >> eth_ring, eth_null, etc. > Why this name eth_cvio? > Why the prefix eth_? > The virtio-net driver uses a kernel device. Here it is a

[dpdk-dev] [PATCH v3 2/2] virtio/vdev: add a new vdev named eth_cvio

2016-04-22 Thread Tan, Jianfeng
Hi, On 4/21/2016 4:51 PM, David Marchand wrote: > Hello, > > On Thu, Apr 21, 2016 at 4:56 AM, Jianfeng Tan > wrote: >> Add a new virtual device named eth_cvio, it can be used just like >> eth_ring, eth_null, etc. >> >> Configured parameters include: >>- rx (optional, 1 by default), number

[dpdk-dev] [PATCH v3 2/2] virtio/vdev: add a new vdev named eth_cvio

2016-04-22 Thread Thomas Monjalon
2016-04-22 15:26, Tan, Jianfeng: > Hi Thomas, > > On 4/21/2016 6:05 PM, Thomas Monjalon wrote: > > 2016-04-21 02:56, Jianfeng Tan: > >> Add a new virtual device named eth_cvio, it can be used just like > >> eth_ring, eth_null, etc. > > Why this name eth_cvio? > > Why the prefix eth_? > > The

[dpdk-dev] [PATCH v3 2/2] virtio/vdev: add a new vdev named eth_cvio

2016-04-22 Thread David Marchand
Hello, On Fri, Apr 22, 2016 at 7:15 AM, Tan, Jianfeng wrote: > On 4/21/2016 4:51 PM, David Marchand wrote: >> virtio code relies on drv_flags (even updating it while this should be >> per-device). >> So first, virtio should rely on dev_flags. > > > Mainly drv_flags's RTE_PCI_DRV_INTR_LSC, and

[dpdk-dev] [PATCH v3 2/2] virtio/vdev: add a new vdev named eth_cvio

2016-04-21 Thread Yuanhan Liu
On Thu, Apr 21, 2016 at 02:56:36AM +, Jianfeng Tan wrote: > Add a new virtual device named eth_cvio, it can be used just like > eth_ring, eth_null, etc. > > Configured parameters include: > - rx (optional, 1 by default), number of rx, not used for now. > - tx (optional, 1 by default),

[dpdk-dev] [PATCH v3 2/2] virtio/vdev: add a new vdev named eth_cvio

2016-04-21 Thread Thomas Monjalon
2016-04-21 02:56, Jianfeng Tan: > Add a new virtual device named eth_cvio, it can be used just like > eth_ring, eth_null, etc. Why this name eth_cvio? Why the prefix eth_? The virtio-net driver uses a kernel device. Here it is a userland device. Why not virtio-user? > .. table:: Features

[dpdk-dev] [PATCH v3 2/2] virtio/vdev: add a new vdev named eth_cvio

2016-04-21 Thread David Marchand
Hello, On Thu, Apr 21, 2016 at 4:56 AM, Jianfeng Tan wrote: > Add a new virtual device named eth_cvio, it can be used just like > eth_ring, eth_null, etc. > > Configured parameters include: > - rx (optional, 1 by default), number of rx, not used for now. > - tx (optional, 1 by default),

[dpdk-dev] [PATCH v3 2/2] virtio/vdev: add a new vdev named eth_cvio

2016-04-21 Thread Jianfeng Tan
Add a new virtual device named eth_cvio, it can be used just like eth_ring, eth_null, etc. Configured parameters include: - rx (optional, 1 by default), number of rx, not used for now. - tx (optional, 1 by default), number of tx, not used for now. - cq (optional, 0 by default), not