Re: [dpdk-dev] [PATCH v4 04/10] lib: introduce ipsec library

2018-12-21 Thread Ananyev, Konstantin
> > > > > > On 12/20/2018 7:36 PM, Ananyev, Konstantin wrote: > > > > > >>> diff --git a/lib/librte_ipsec/sa.c b/lib/librte_ipsec/sa.c > > >>> new file mode 100644 > > >>> index 0..f927a82bf > > >>> --- /dev/null > > >>> +++ b/lib/librte_ipsec/sa.c > > >>> @@ -0,0 +1,327 @@ > > >>> +/* SPD

Re: [dpdk-dev] [PATCH v4 04/10] lib: introduce ipsec library

2018-12-21 Thread Ananyev, Konstantin
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, December 21, 2018 11:53 AM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: Thomas Monjalon ; Awal, Mohammad Abdul > > Subject: Re: [dpdk-dev] [PATCH v4 04/10] lib: introduce ipsec

Re: [dpdk-dev] [PATCH v4 04/10] lib: introduce ipsec library

2018-12-21 Thread Akhil Goyal
On 12/20/2018 11:47 PM, Ananyev, Konstantin wrote: + +static int +fill_crypto_xform(struct crypto_xform *xform, + const struct rte_ipsec_sa_prm *prm) +{ + struct rte_crypto_sym_xform *xf; + + memset(xform, 0, sizeof(*xform)); + + for (xf = prm

Re: [dpdk-dev] [PATCH v4 04/10] lib: introduce ipsec library

2018-12-21 Thread Akhil Goyal
On 12/20/2018 7:36 PM, Ananyev, Konstantin wrote: > >>> diff --git a/lib/librte_ipsec/sa.c b/lib/librte_ipsec/sa.c >>> new file mode 100644 >>> index 0..f927a82bf >>> --- /dev/null >>> +++ b/lib/librte_ipsec/sa.c >>> @@ -0,0 +1,327 @@ >>> +/* SPDX-License-Identifier: BSD-3-Clause >>> + *

Re: [dpdk-dev] [PATCH v4 04/10] lib: introduce ipsec library

2018-12-20 Thread Ananyev, Konstantin
> > > + > > > +static int > > > +fill_crypto_xform(struct crypto_xform *xform, > > > + const struct rte_ipsec_sa_prm *prm) > > > +{ > > > + struct rte_crypto_sym_xform *xf; > > > + > > > + memset(xform, 0, sizeof(*xform)); > > > + > > > + for (xf = prm->crypto_xform; xf != NULL; xf = xf->next) { >

Re: [dpdk-dev] [PATCH v4 04/10] lib: introduce ipsec library

2018-12-20 Thread Ananyev, Konstantin
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, December 20, 2018 2:14 PM > To: Ananyev, Konstantin > Cc: Akhil Goyal ; dev@dpdk.org; Awal, Mohammad Abdul > > Subject: Re: [dpdk-dev] [PATCH v4 04/10] lib: introduce ips

Re: [dpdk-dev] [PATCH v4 04/10] lib: introduce ipsec library

2018-12-20 Thread Thomas Monjalon
20/12/2018 15:06, Ananyev, Konstantin: > > > +enum { > > > + RTE_SATP_LOG_IPV, > > > + RTE_SATP_LOG_PROTO, > > > + RTE_SATP_LOG_DIR, > > > + RTE_SATP_LOG_MODE, > > > + RTE_SATP_LOG_NUM > > > +}; > > what is the significance of LOG here. > > _LOG_ is for logarithm of 2 here. _LOG2_ ?

Re: [dpdk-dev] [PATCH v4 04/10] lib: introduce ipsec library

2018-12-20 Thread Ananyev, Konstantin
> > diff --git a/lib/librte_ipsec/meson.build b/lib/librte_ipsec/meson.build > > new file mode 100644 > > index 0..52c78eaeb > > --- /dev/null > > +++ b/lib/librte_ipsec/meson.build > > @@ -0,0 +1,10 @@ > > +# SPDX-License-Identifier: BSD-3-Clause > > +# Copyright(c) 2018 Intel Corporatio

Re: [dpdk-dev] [PATCH v4 04/10] lib: introduce ipsec library

2018-12-19 Thread Thomas Monjalon
19/12/2018 13:08, Akhil Goyal: > On 12/14/2018 9:53 PM, Konstantin Ananyev wrote: > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -1071,6 +1071,11 @@ F: doc/guides/prog_guide/pdump_lib.rst > > F: app/pdump/ > > F: doc/guides/tools/pdump.rst > > > > +IPsec - EXPERIMENTAL > > +M: Konstantin

Re: [dpdk-dev] [PATCH v4 04/10] lib: introduce ipsec library

2018-12-19 Thread Akhil Goyal
On 12/14/2018 9:53 PM, Konstantin Ananyev wrote: > Introduce librte_ipsec library. > The library is supposed to utilize existing DPDK crypto-dev and > security API to provide application with transparent IPsec processing API. > That initial commit provides some base API to manage > IPsec Security

[dpdk-dev] [PATCH v4 04/10] lib: introduce ipsec library

2018-12-14 Thread Konstantin Ananyev
Introduce librte_ipsec library. The library is supposed to utilize existing DPDK crypto-dev and security API to provide application with transparent IPsec processing API. That initial commit provides some base API to manage IPsec Security Association (SA) object. Signed-off-by: Mohammad Abdul Awal