[dpdk-dev] [PATCH v4 08/13] testpmd: rework csum forward engine

2014-11-28 Thread Olivier MATZ
Hi Jijiang, On 11/28/2014 09:54 AM, Liu, Jijiang wrote: >>> My understanding of the meaning of the flags is: >>> >>>- PKT_TX_IP_CKSUM: tell the NIC to compute IP cksum > >> My initial thought: >> It tells the NIC that it is an IPV4 packet for which it has to compute >> checksum. >> >>> >>>

[dpdk-dev] [PATCH v4 08/13] testpmd: rework csum forward engine

2014-11-28 Thread Liu, Jijiang
Hi Olivier, > -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, November 27, 2014 7:02 PM > To: Olivier MATZ; dev at dpdk.org > Cc: Walukiewicz, Miroslaw; Liu, Jijiang; Liu, Yong; jigsaw at gmail.com; > Richardson, > Bruce > Subject: RE: [PATCH v4 08/13] testpmd: rework csu

[dpdk-dev] [PATCH v4 08/13] testpmd: rework csum forward engine

2014-11-27 Thread Ananyev, Konstantin
Hi Oliver, > -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Thursday, November 27, 2014 9:11 AM > To: Ananyev, Konstantin; dev at dpdk.org > Cc: Walukiewicz, Miroslaw; Liu, Jijiang; Liu, Yong; jigsaw at gmail.com; > Richardson, Bruce > Subject: Re: [PAT

[dpdk-dev] [PATCH v4 08/13] testpmd: rework csum forward engine

2014-11-27 Thread Olivier MATZ
Hi Konstantin, On 11/26/2014 09:02 PM, Ananyev, Konstantin wrote: >> +/* if possible, calculate the checksum of a packet in hw or sw, >> + * depending on the testpmd command line configuration */ >> +static uint64_t >> +process_inner_cksums(void *l3_hdr, uint16_t ethertype, uint16_t l3_len, >> +

[dpdk-dev] [PATCH v4 08/13] testpmd: rework csum forward engine

2014-11-27 Thread Liu, Jijiang
> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, November 27, 2014 4:03 AM > To: Olivier Matz; dev at dpdk.org > Cc: Walukiewicz, Miroslaw; Liu, Jijiang; Liu, Yong; jigsaw at gmail.com; > Richardson, > Bruce > Subject: RE: [PATCH v4 08/13] testpmd: rework csum forward e

[dpdk-dev] [PATCH v4 08/13] testpmd: rework csum forward engine

2014-11-26 Thread Ananyev, Konstantin
Hi Oliver, > -Original Message- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Wednesday, November 26, 2014 3:05 PM > To: dev at dpdk.org > Cc: olivier.matz at 6wind.com; Walukiewicz, Miroslaw; Liu, Jijiang; Liu, > Yong; jigsaw at gmail.com; Richardson, Bruce; Ananyev, Ko

[dpdk-dev] [PATCH v4 08/13] testpmd: rework csum forward engine

2014-11-26 Thread Olivier Matz
The csum forward engine was becoming too complex to be used and extended (the next commits want to add the support of TSO): - no explaination about what the code does - code is not factorized, lots of code duplicated, especially between ipv4/ipv6 - user command line api: use of bitmasks that nee