[dpdk-dev] [PATCH v4 2/2] ethdev: add sanity checks to functions

2015-11-24 Thread Thomas Monjalon
2015-11-24 15:45, Bruce Richardson: > On Tue, Nov 24, 2015 at 04:29:12PM +0100, Thomas Monjalon wrote: > > 2015-11-24 14:56, Bruce Richardson: > > > On Tue, Nov 17, 2015 at 07:53:09AM -0800, Stephen Hemminger wrote: > > > > On Tue, 17 Nov 2015 12:21:07 + > > > > Bruce Richardson wrote: > > >

[dpdk-dev] [PATCH v4 2/2] ethdev: add sanity checks to functions

2015-11-24 Thread Thomas Monjalon
2015-11-24 14:56, Bruce Richardson: > On Tue, Nov 17, 2015 at 07:53:09AM -0800, Stephen Hemminger wrote: > > On Tue, 17 Nov 2015 12:21:07 + > > Bruce Richardson wrote: > > > -static inline uint32_t > > > +static inline int Are we talking about this change only? Or the move in the first patch

[dpdk-dev] [PATCH v4 2/2] ethdev: add sanity checks to functions

2015-11-24 Thread Bruce Richardson
On Tue, Nov 24, 2015 at 04:29:12PM +0100, Thomas Monjalon wrote: > 2015-11-24 14:56, Bruce Richardson: > > On Tue, Nov 17, 2015 at 07:53:09AM -0800, Stephen Hemminger wrote: > > > On Tue, 17 Nov 2015 12:21:07 + > > > Bruce Richardson wrote: > > > > -static inline uint32_t > > > > +static

[dpdk-dev] [PATCH v4 2/2] ethdev: add sanity checks to functions

2015-11-24 Thread Bruce Richardson
On Tue, Nov 17, 2015 at 07:53:09AM -0800, Stephen Hemminger wrote: > On Tue, 17 Nov 2015 12:21:07 + > Bruce Richardson wrote: > > > The functions rte_eth_rx_queue_count and rte_eth_descriptor_done are > > supported by very few PMDs. Therefore, it is best to check for support > > for the

[dpdk-dev] [PATCH v4 2/2] ethdev: add sanity checks to functions

2015-11-17 Thread Bruce Richardson
The functions rte_eth_rx_queue_count and rte_eth_descriptor_done are supported by very few PMDs. Therefore, it is best to check for support for the functions in the ethdev library, so as to avoid run-time crashes at run-time if the application goes to use those APIs. Similarly, the port parameter

[dpdk-dev] [PATCH v4 2/2] ethdev: add sanity checks to functions

2015-11-17 Thread Stephen Hemminger
On Tue, 17 Nov 2015 12:21:07 + Bruce Richardson wrote: > The functions rte_eth_rx_queue_count and rte_eth_descriptor_done are > supported by very few PMDs. Therefore, it is best to check for support > for the functions in the ethdev library, so as to avoid run-time crashes > at run-time if