[dpdk-dev] [PATCH v5 09/11] virtio_pci: do not parse if interface is vfio-noiommu

2016-01-29 Thread Yuanhan Liu
On Fri, Jan 29, 2016 at 10:02:26AM +0100, Thomas Monjalon wrote: > 2016-01-29 15:34, Yuanhan Liu: > > There is another option for that: the git scissors option; you could > > check the git format-patch man page for more detailed info (by searching > > "scissors" keyword). I'm just not quite sure

[dpdk-dev] [PATCH v5 09/11] virtio_pci: do not parse if interface is vfio-noiommu

2016-01-29 Thread Yuanhan Liu
On Fri, Jan 29, 2016 at 12:52:53PM +0530, Santosh Shukla wrote: > On Fri, Jan 29, 2016 at 12:47 PM, Yuanhan Liu > wrote: > > Two minor nits. > > > > Firstly about your title, you should be consistent: sometimes you > > use virtio_pci, and sometimes you use virtio_pic.h. And for virtio > > pmd

[dpdk-dev] [PATCH v5 09/11] virtio_pci: do not parse if interface is vfio-noiommu

2016-01-29 Thread Yuanhan Liu
Two minor nits. Firstly about your title, you should be consistent: sometimes you use virtio_pci, and sometimes you use virtio_pic.h. And for virtio pmd driver, "virtio: " prefix is pretty enough, no need another extra "vfio: " or "pci: " prefix. And the same to your EAL changes. EAL is a

[dpdk-dev] [PATCH v5 09/11] virtio_pci: do not parse if interface is vfio-noiommu

2016-01-29 Thread Santosh Shukla
On Fri, Jan 29, 2016 at 2:32 PM, Thomas Monjalon wrote: > 2016-01-29 15:34, Yuanhan Liu: >> There is another option for that: the git scissors option; you could >> check the git format-patch man page for more detailed info (by searching >> "scissors" keyword). I'm just not quite sure Thomas like

[dpdk-dev] [PATCH v5 09/11] virtio_pci: do not parse if interface is vfio-noiommu

2016-01-29 Thread Thomas Monjalon
2016-01-29 15:34, Yuanhan Liu: > There is another option for that: the git scissors option; you could > check the git format-patch man page for more detailed info (by searching > "scissors" keyword). I'm just not quite sure Thomas like it or not. For simple discussions, patch after scissors may

[dpdk-dev] [PATCH v5 09/11] virtio_pci: do not parse if interface is vfio-noiommu

2016-01-19 Thread Santosh Shukla
If virtio interface attached to vfio-noiommu driver then do not parse for virtio resource. Instead exit with return 0; Note: Applicable for virtio spec 0.95. Signed-off-by: Santosh Shukla --- v4-->v5: - added _NOIOMMU drv check for lagecy virtio. No need for resource_init in vfio case. And