[dpdk-dev] [PATCH v5 2/8] virtio: clean up virtio_dev_queue_setup

2016-06-01 Thread Yuanhan Liu
On Wed, Jun 01, 2016 at 07:44:33AM +, Tan, Jianfeng wrote: > Hi Yuanhan, > > > -Original Message- > > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > > Sent: Wednesday, June 1, 2016 3:38 PM > > To: Tan, Jianfeng > > Cc: dev at dpdk.org; Xie, Huawei; rich.lane at

[dpdk-dev] [PATCH v5 2/8] virtio: clean up virtio_dev_queue_setup

2016-06-01 Thread Yuanhan Liu
On Mon, May 30, 2016 at 10:55:33AM +, Jianfeng Tan wrote: > Abstract vring hdr desc init as an inline method. What's this patch for then? In your last version, it will be invoked twice, but it turned out to be wrong. So, why keeping this change? I didn't see it improves anything.

[dpdk-dev] [PATCH v5 2/8] virtio: clean up virtio_dev_queue_setup

2016-06-01 Thread Tan, Jianfeng
Hi Yuanhan, > -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Wednesday, June 1, 2016 3:38 PM > To: Tan, Jianfeng > Cc: dev at dpdk.org; Xie, Huawei; rich.lane at bigswitch.com; mst at > redhat.com; > nakajima.yoshihiro at lab.ntt.co.jp; p.fedin at

[dpdk-dev] [PATCH v5 2/8] virtio: clean up virtio_dev_queue_setup

2016-05-30 Thread Jianfeng Tan
Abstract vring hdr desc init as an inline method. Signed-off-by: Huawei Xie Signed-off-by: Jianfeng Tan --- drivers/net/virtio/virtio_ethdev.c | 42 ++ 1 file changed, 24 insertions(+), 18 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c