[dpdk-dev] [RFC] scripts: make load-devel-config not to appear as executable

2016-08-03 Thread Christian Ehrhardt
On Wed, Aug 3, 2016 at 3:19 PM, Thomas Monjalon wrote: > > Do you want me to resubmit as-is but without RFC tag or would you accept > it > > as already submitted? > > I will apply it as is. As just discussed on #dpdk now that it is no more executable I'd even drop the #!/bin/echo. That is to

[dpdk-dev] [RFC] scripts: make load-devel-config not to appear as executable

2016-08-03 Thread Thomas Monjalon
2016-08-03 11:42, Christian Ehrhardt: > On Wed, Aug 3, 2016 at 11:26 AM, Bruce Richardson < > bruce.richardson at intel.com> wrote: > > > Definitely no objection on the file mode change. > > > > For the dropping of the .sh extension, I don't think it matters much. > > However, > > given that .sh

[dpdk-dev] [RFC] scripts: make load-devel-config not to appear as executable

2016-08-03 Thread Christian Ehrhardt
On Wed, Aug 3, 2016 at 11:26 AM, Bruce Richardson < bruce.richardson at intel.com> wrote: > Definitely no objection on the file mode change. > > For the dropping of the .sh extension, I don't think it matters much. > However, > given that .sh files are generally scripts to be executed, I think >

[dpdk-dev] [RFC] scripts: make load-devel-config not to appear as executable

2016-08-03 Thread Bruce Richardson
On Wed, Aug 03, 2016 at 10:11:32AM +0200, Christian Ehrhardt wrote: > sorry, I accidentally dropped dev list in one of my replies, readding. > > On Tue, Aug 2, 2016 at 11:29 PM, Thomas Monjalon 6wind.com> > wrote: > > > > > > Given that we should drop the .sh file ending as well as the > >

[dpdk-dev] [RFC] scripts: make load-devel-config not to appear as executable

2016-08-03 Thread Christian Ehrhardt
sorry, I accidentally dropped dev list in one of my replies, readding. On Tue, Aug 2, 2016 at 11:29 PM, Thomas Monjalon wrote: > > > > Given that we should drop the .sh file ending as well as the > executable > > > > flag - both are not needed to source the file. > > > > > > Hmmm, it is still a

[dpdk-dev] [RFC] scripts: make load-devel-config not to appear as executable

2016-08-02 Thread Thomas Monjalon
2016-08-02 15:54, Christian Ehrhardt: > Quoting the first line of the script: "#! /bin/echo must be loaded with ." > Given that we should drop the .sh file ending as well as the executable > flag - both are not needed to source the file. Hmmm, it is still a file containing some shell commands,

[dpdk-dev] [RFC] scripts: make load-devel-config not to appear as executable

2016-08-02 Thread Christian Ehrhardt
Quoting the first line of the script: "#! /bin/echo must be loaded with ." Given that we should drop the .sh file ending as well as the executable flag - both are not needed to source the file. Signed-off-by: Christian Ehrhardt --- MAINTAINERS | 2 +- scripts/checkpatches.sh