[dpdk-dev] [RFC] vhost user: add error handling for fd > 1023

2016-04-11 Thread Patrik Andersson R
Yes, that is correct. Closing the socket on failure needs to be added. Regards, Patrik On 04/11/2016 11:34 AM, Christian Ehrhardt wrote: > I like the approach as well to go for the fix for robustness first. > > I was accidentally able to find another testcase to hit the same root > cause. >

[dpdk-dev] [RFC] vhost user: add error handling for fd > 1023

2016-04-11 Thread Christian Ehrhardt
I like the approach as well to go for the fix for robustness first. I was accidentally able to find another testcase to hit the same root cause. Adding guests with 15 vhost_user based NICs each while having rxq for openvswitch-dpdk set to 4 and multiqueue for the guest devices at 4 already breaks

[dpdk-dev] [RFC] vhost user: add error handling for fd > 1023

2016-04-11 Thread Patrik Andersson R
I fully agree with this course of action. Thank you, Patrik On 04/08/2016 08:47 AM, Xie, Huawei wrote: > On 4/7/2016 10:52 PM, Christian Ehrhardt wrote: >> I totally agree to that there is no deterministic rule what to expect. >> The only rule is that #fd certainly always is > #vhost_user

[dpdk-dev] [RFC] vhost user: add error handling for fd > 1023

2016-04-08 Thread Xie, Huawei
On 4/7/2016 10:52 PM, Christian Ehrhardt wrote: > I totally agree to that there is no deterministic rule what to expect. > The only rule is that #fd certainly always is > #vhost_user devices. > In various setup variants I've crossed fd 1024 anywhere between 475 > and 970 vhost_user ports. > > Once

[dpdk-dev] [RFC] vhost user: add error handling for fd > 1023

2016-04-07 Thread Christian Ehrhardt
Hi Patrick, On Tue, Apr 5, 2016 at 10:40 AM, Patrik Andersson R < patrik.r.andersson at ericsson.com> wrote: > > The described fault situation arises due to the fact that there is a bug > in an OpenStack component, Neutron or Nova, that fails to release ports > on VM deletion. This typically

[dpdk-dev] [RFC] vhost user: add error handling for fd > 1023

2016-03-30 Thread Xie, Huawei
On 3/18/2016 5:15 PM, Patrik Andersson wrote: > Protect against DPDK crash when allocation of listen fd >= 1023. > For events on fd:s >1023, the current implementation will trigger > an abort due to access outside of allocated bit mask. > > Corrections would include: > > * Match fdset_add()

[dpdk-dev] [RFC] vhost user: add error handling for fd > 1023

2016-03-18 Thread Patrik Andersson
Protect against DPDK crash when allocation of listen fd >= 1023. For events on fd:s >1023, the current implementation will trigger an abort due to access outside of allocated bit mask. Corrections would include: * Match fdset_add() signature in fd_man.c to fd_man.h * Handling of return codes