On 18/05/2016 09:31, Tahhan, Maryam wrote:
[..]
>> +eth_xstats_count_t xstats_count;
>> +/**< Get number of extended statistics. */
>
> Hi Remy
> While reviewing the second patch in this patchset I noticed you aren't
> actually using
> eth_xstats_count_t xstats_count in the
>uint8_t stat_idx,
> @@ -1427,6 +1447,10 @@ struct eth_dev_ops {
> eth_stats_reset_t stats_reset; /**< Reset generic device
> statistics. */
> eth_xstats_get_t xstats_get;/**< Get extended device
> statistics. */
>
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton
> Sent: Friday, May 6, 2016 12:11 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [RFC PATCH v2 1/3] rte: change xstats to use integer
> keys
>
> Signed-off-by: Remy Horton
> ---
Acked-by: Maryam Tahhan
2016-05-09 13:59, David Harton:
> > }
> >
> > -
>
> Not sure how the community feels about white-space only changes.
> Just mentioning in case some folks get excited about it. One here and a few
> below.
It's a trivial cleanup. No problem I think.
On 09/05/2016 14:59, David Harton (dharton) wrote:
[..]
>> }
>>
>> -
>
> Not sure how the community feels about white-space only changes.
> Just mentioning in case some folks get excited about it. One here and a few
> below.
I doubt it'll be showstopper. In any case hoping to get a v3 out
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton
> Sent: Friday, May 06, 2016 7:11 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [RFC PATCH v2 1/3] rte: change xstats to use integer
> keys
>
> Signed-off-by: R
Signed-off-by: Remy Horton
---
lib/librte_ether/rte_ethdev.c | 100 --
lib/librte_ether/rte_ethdev.h | 55 +++
2 files changed, 142 insertions(+), 13 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.c
7 matches
Mail list logo
