[dpdk-dev] [bug] dpdk-vfio: Invalid region/index assumption

2016-07-28 Thread Santosh Shukla
On Thu, Jul 28, 2016 at 03:44:57AM +0530, Alex Williamson wrote: > Hi, > > I took a quick look at the dpdk vfio code and spotted an invalid > assumption that should probably be corrected ASAP. That is: > > lib/librte_eal/linuxapp/eal/eal_vfio.h: > #define VFIO_GET_REGION_ADDR(x) ((uint64_t) x

[dpdk-dev] [bug] dpdk-vfio: Invalid region/index assumption

2016-07-28 Thread Burakov, Anatoly
> Hi, > > 2016-07-27 16:14, Alex Williamson: > > I took a quick look at the dpdk vfio code and spotted an invalid > > assumption that should probably be corrected ASAP. > > It can theoretically be a bug but the value may never change in the kernel, > right? > So when you say ASAP, I feel it can

[dpdk-dev] [bug] dpdk-vfio: Invalid region/index assumption

2016-07-28 Thread Alex Williamson
On Thu, 28 Jul 2016 09:42:13 + "Burakov, Anatoly" wrote: > > Hi, > > > > 2016-07-27 16:14, Alex Williamson: > > > I took a quick look at the dpdk vfio code and spotted an invalid > > > assumption that should probably be corrected ASAP. > > > > It can theoretically be a bug but the

[dpdk-dev] [bug] dpdk-vfio: Invalid region/index assumption

2016-07-28 Thread Thomas Monjalon
Hi, 2016-07-27 16:14, Alex Williamson: > I took a quick look at the dpdk vfio code and spotted an invalid > assumption that should probably be corrected ASAP. It can theoretically be a bug but the value may never change in the kernel, right? So when you say ASAP, I feel it can wait the next DPDK

[dpdk-dev] [bug] dpdk-vfio: Invalid region/index assumption

2016-07-27 Thread Alex Williamson
Hi, I took a quick look at the dpdk vfio code and spotted an invalid assumption that should probably be corrected ASAP. That is: lib/librte_eal/linuxapp/eal/eal_vfio.h: #define VFIO_GET_REGION_ADDR(x) ((uint64_t) x << 40ULL) #define VFIO_GET_REGION_IDX(x) (x >> 40) Region offset to index is an