[dpdk-dev] [dpdk-dev,v5,1/3] mempool: support external handler

2016-06-01 Thread Jan Viktorin
On Tue, 31 May 2016 22:40:59 +0200 Olivier MATZ wrote: > Hi, > > On 05/31/2016 03:47 PM, Hunt, David wrote: > > On 5/31/2016 1:06 PM, Jan Viktorin wrote: > >> On Tue, 31 May 2016 10:09:42 +0100 > >> "Hunt, David" wrote: > >> > >>> The *p pointer is the opaque data for a given mempool

[dpdk-dev] [dpdk-dev,v5,1/3] mempool: support external handler

2016-06-01 Thread Hunt, David
On 5/31/2016 9:40 PM, Olivier MATZ wrote: [...] >> +/** Structure defining a mempool handler. */ > Later in the text, I suggested to rename rte_mempool_handler to > rte_mempool_ops. > I believe that it explains the purpose of this struct better. It > would improve >

[dpdk-dev] [dpdk-dev,v5,1/3] mempool: support external handler

2016-05-31 Thread Olivier MATZ
Hi, On 05/31/2016 03:47 PM, Hunt, David wrote: > On 5/31/2016 1:06 PM, Jan Viktorin wrote: >> On Tue, 31 May 2016 10:09:42 +0100 >> "Hunt, David" wrote: >> >>> The *p pointer is the opaque data for a given mempool handler (ring, >>> array, linked list, etc) >> Again, doc comments... >> >> I

[dpdk-dev] [dpdk-dev,v5,1/3] mempool: support external handler

2016-05-31 Thread Hunt, David
On 5/31/2016 1:06 PM, Jan Viktorin wrote: > On Tue, 31 May 2016 10:09:42 +0100 > "Hunt, David" wrote: > >> Hi Jan, >> > [...] > +typedef void *(*rte_mempool_alloc_t)(struct rte_mempool *mp); + +/** Free the external pool. */ >>> What is the purpose of this callback? >>> What

[dpdk-dev] [dpdk-dev,v5,1/3] mempool: support external handler

2016-05-31 Thread Jan Viktorin
On Tue, 31 May 2016 10:09:42 +0100 "Hunt, David" wrote: > Hi Jan, > [...] > > >> +typedef void *(*rte_mempool_alloc_t)(struct rte_mempool *mp); > >> + > >> +/** Free the external pool. */ > > What is the purpose of this callback? > > What exactly does it allocate? > > Some rte_mempool

[dpdk-dev] [dpdk-dev,v5,1/3] mempool: support external handler

2016-05-31 Thread Hunt, David
Hi Jan, On 5/23/2016 1:35 PM, Jan Viktorin wrote: >> Until now, the objects stored in mempool mempool were internally stored a > s/mempool mempool/mempool/ > > stored _in_ a ring? Fixed. > > @@ -161,7 +161,6 @@ per_lcore_mempool_test(__attribute__((unused)) void *arg) >

[dpdk-dev] [dpdk-dev,v5,1/3] mempool: support external handler

2016-05-24 Thread Hunt, David
On 5/23/2016 1:35 PM, Jan Viktorin wrote: > Hello David, > > please, see my comments inline. > > I didn't see the previous versions of the mempool (well, only very roughly) > so I am > probably missing some points... My point of view is as a user of the handler > API. > I need to understand

[dpdk-dev] [dpdk-dev,v5,1/3] mempool: support external handler

2016-05-23 Thread Jan Viktorin
Hello David, please, see my comments inline. I didn't see the previous versions of the mempool (well, only very roughly) so I am probably missing some points... My point of view is as a user of the handler API. I need to understand the API to implement a custom handler for my purposes. On