[dpdk-dev] lib: include rte_memory.h for __rte_cache_aligned

2014-12-11 Thread Neil Horman
On Thu, Dec 11, 2014 at 01:36:54AM +0100, Thomas Monjalon wrote: > Hi Neil, > > 2014-12-10 19:28, Neil Horman: > > On Wed, Dec 10, 2014 at 07:09:03PM +, Jia Yu wrote: > > > Hi Neil, > > > > > > Moving __rte_cache_aligned right after struct keyword will help. On the > > > other hand,

[dpdk-dev] lib: include rte_memory.h for __rte_cache_aligned

2014-12-11 Thread Thomas Monjalon
2014-12-09 10:22, Neil Horman: > On Tue, Dec 09, 2014 at 09:53:18AM +0100, Olivier MATZ wrote: > > On 12/08/2014 04:04 PM, Neil Horman wrote: > > >On Fri, Nov 07, 2014 at 09:28:09AM -0800, Jia Yu wrote: > > >>Include rte_memory.h for lib files that use __rte_cache_aligned > > >>attribute. > > >> >

[dpdk-dev] lib: include rte_memory.h for __rte_cache_aligned

2014-12-11 Thread Thomas Monjalon
Hi Neil, 2014-12-10 19:28, Neil Horman: > On Wed, Dec 10, 2014 at 07:09:03PM +, Jia Yu wrote: > > Hi Neil, > > > > Moving __rte_cache_aligned right after struct keyword will help. On the > > other hand, enforcing this rule for existing (100+) and future definitions > > will be difficult.

[dpdk-dev] lib: include rte_memory.h for __rte_cache_aligned

2014-12-10 Thread Jia Yu
Hi Neil, Moving __rte_cache_aligned right after struct keyword will help. On the other hand, enforcing this rule for existing (100+) and future definitions will be difficult. It?s clearer and a good practice to include header file explicitly. Thanks, Jia On 12/9/14, 7:22 AM, "Neil Horman"

[dpdk-dev] lib: include rte_memory.h for __rte_cache_aligned

2014-12-09 Thread Neil Horman
On Tue, Dec 09, 2014 at 09:53:18AM +0100, Olivier MATZ wrote: > Hi Neil, > > On 12/08/2014 04:04 PM, Neil Horman wrote: > >On Fri, Nov 07, 2014 at 09:28:09AM -0800, Jia Yu wrote: > >>Include rte_memory.h for lib files that use __rte_cache_aligned > >>attribute. > >> > >>Signed-off-by: Jia Yu >

[dpdk-dev] lib: include rte_memory.h for __rte_cache_aligned

2014-12-09 Thread Olivier MATZ
Hi Neil, On 12/08/2014 04:04 PM, Neil Horman wrote: > On Fri, Nov 07, 2014 at 09:28:09AM -0800, Jia Yu wrote: >> Include rte_memory.h for lib files that use __rte_cache_aligned >> attribute. >> >> Signed-off-by: Jia Yu >> > Why? I presume there was a build break or something. Please repost

[dpdk-dev] lib: include rte_memory.h for __rte_cache_aligned

2014-12-09 Thread Jia Yu
Yes, Olivier?s observation is consistent with ours. Compilation didn?t complain if rte_memory.h is not included. Currently, the lib files indirectly included rte_mbuf.h or rte_mempool.h. These two header files already included rte_memory.h. Therefore without this patch, things still work (as

[dpdk-dev] lib: include rte_memory.h for __rte_cache_aligned

2014-12-08 Thread Neil Horman
On Fri, Nov 07, 2014 at 09:28:09AM -0800, Jia Yu wrote: > Include rte_memory.h for lib files that use __rte_cache_aligned > attribute. > > Signed-off-by: Jia Yu > Why? I presume there was a build break or something. Please repost with a changelog that details what this patch is for. Neil >