; ; Yigit, Ferruh ; Ananyev,
> Konstantin ; dev@dpdk.org; Anoob Joseph
> ; Richardson, Bruce ;
> Mcnamara, John ; do...@seketeli.net; Andrew
> Rybchenko ; acon...@redhat.com; Trahe,
> Fiona
> Subject: Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks
>
> 1
> bl...@debian.org; ktray...@redhat.com; Ray Kinsella ;
> > dev@dpdk.org; Akhil Goyal ; Yigit, Ferruh
> > ; Ananyev, Konstantin
> > ; dev@dpdk.org; Anoob Joseph
> > ; Richardson, Bruce ;
> > Mcnamara, John ; do...@seketeli.net; Andrew
> > Rybchenko ; acon...@red
il Goyal ; Yigit, Ferruh
> ; Ananyev, Konstantin
> ; dev@dpdk.org; Anoob Joseph
> ; Richardson, Bruce ;
> Mcnamara, John ; do...@seketeli.net; Andrew
> Rybchenko ; acon...@redhat.com; Trahe,
> Fiona
> Subject: Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks
>
> 16/03/2020
16/03/2020 13:57, Trahe, Fiona:
> From: Kusztal, ArkadiuszX
> > > > > The patch we're working on will provide two versions of
> > > > > rte_cryptodev_info_get(), both call the same PMD function from the
> > > dev_ops info_get fn ptr.
> > > > > The default version operates s as normal, the 19.11 ve
Goyal
> ; Yigit, Ferruh ; Ananyev,
> Konstantin
> ; dev@dpdk.org; Anoob Joseph
> ;
> Richardson, Bruce ; Mcnamara, John
> ;
> do...@seketeli.net; Andrew Rybchenko ;
> acon...@redhat.com
> Subject: RE: [dpdk-dev] [PATCH v2 4/4] add ABI checks
>
> Hi,
>
> T
Hi,
Two comments from me,
> > > The patch we're working on will provide two versions of
> > > rte_cryptodev_info_get(), both call the same PMD function from the
> dev_ops info_get fn ptr.
> > > The default version operates s as normal, the 19.11 version searches
> > > through the list returned by
On 04/02/2020 09:51, David Marchand wrote:
> On Mon, Feb 3, 2020 at 7:56 PM Ray Kinsella wrote:
>> On 03/02/2020 17:34, Thomas Monjalon wrote:
>>> 03/02/2020 18:09, Thomas Monjalon:
03/02/2020 10:30, Ferruh Yigit:
> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote:
>> 02/02/2020 14:0
On Tue, Feb 04, 2020 at 10:32:01AM +, Akhil Goyal wrote:
>
> >
> > 04/02/2020 11:16, Akhil Goyal:
> > > Hi,
> > > > On 2/3/2020 5:09 PM, Thomas Monjalon wrote:
> > > > > 03/02/2020 10:30, Ferruh Yigit:
> > > > >> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote:
> > > > >>> 02/02/2020 14:05, Th
On Tue, Feb 04, 2020 at 10:16:56AM +, Akhil Goyal wrote:
> Hi,
> > On 2/3/2020 5:09 PM, Thomas Monjalon wrote:
> > > 03/02/2020 10:30, Ferruh Yigit:
> > >> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote:
> > >>> 02/02/2020 14:05, Thomas Monjalon:
> > 31/01/2020 15:16, Trahe, Fiona:
> > >>>
On Tue, Feb 04, 2020 at 09:44:53AM -0500, Aaron Conole wrote:
> Thomas Monjalon writes:
>
> > RED FLAG
> >
> > I don't see a lot of reactions, so I summarize the issue.
> > We need action TODAY!
> >
> > API makes think that rte_cryptodev_info_get() cannot return
> > a value >= 3 (RTE_CRYPTO_AEAD_
; Ananyev,
> Konstantin
> ; dev@dpdk.org; Anoob Joseph
> ; Kusztal,
> ArkadiuszX ; Richardson, Bruce
> ;
> Mcnamara, John ; do...@seketeli.net; Andrew Rybchenko
> ; acon...@redhat.com
> Subject: Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks
>
> 04/02/2020 16:52, Trahe,
04/02/2020 16:52, Trahe, Fiona:
>
> > We are working on a patch, when it is ready we will send it.
> > If it's not ready by end of your today, of course, go ahead with (b) and
> > we will work towards 20.05.
>
> We will not be sending a patch today.
> The patch we're working on will provide two v
> We are working on a patch, when it is ready we will send it.
> If it's not ready by end of your today, of course, go ahead with (b) and
> we will work towards 20.05.
We will not be sending a patch today.
The patch we're working on will provide two versions of
rte_cryptodev_info_get(),
both ca
Thomas Monjalon writes:
> RED FLAG
>
> I don't see a lot of reactions, so I summarize the issue.
> We need action TODAY!
>
> API makes think that rte_cryptodev_info_get() cannot return
> a value >= 3 (RTE_CRYPTO_AEAD_LIST_END in 19.11).
> Current 20.02 returns 3 (RTE_CRYPTO_AEAD_CHACHA20_POLY1305
On 04/02/2020 10:24, Thomas Monjalon wrote:
> RED FLAG
>
> I don't see a lot of reactions, so I summarize the issue.
> We need action TODAY!
>
> API makes think that rte_cryptodev_info_get() cannot return
> a value >= 3 (RTE_CRYPTO_AEAD_LIST_END in 19.11).
> Current 20.02 returns 3 (RTE_CRYPTO_AE
gt; Cc: Ananyev, Konstantin ; dev@dpdk.org; Anoob
> Joseph
> ; Kusztal, ArkadiuszX ;
> Richardson, Bruce
> ; Mcnamara, John ;
> do...@seketeli.net;
> Andrew Rybchenko ; acon...@redhat.com
> Subject: Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks
>
> RED FLAG
>
> I
On Tue, Feb 04, 2020 at 10:32:01AM +, Akhil Goyal wrote:
>
> >
> > 04/02/2020 11:16, Akhil Goyal:
> > > Hi,
> > > > On 2/3/2020 5:09 PM, Thomas Monjalon wrote:
> > > > > 03/02/2020 10:30, Ferruh Yigit:
> > > > >> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote:
> > > > >>> 02/02/2020 14:05, Th
04/02/2020 11:10, Trahe, Fiona:
> And not used for sizing > >
> > > There a c) though right.
> > > We could work around the issue by api versioning rte_cryptodev_info_get()
> > > and friends.
> >
> > It has a lot of friends, but it sounds like the right approach.
> > Is someone looking into this
On 2/4/2020 9:45 AM, Thomas Monjalon wrote:
> 04/02/2020 10:19, Ferruh Yigit:
>> On 2/3/2020 6:40 PM, Thomas Monjalon wrote:
>>> 03/02/2020 18:40, Ferruh Yigit:
On 2/3/2020 5:09 PM, Thomas Monjalon wrote:
> 03/02/2020 10:30, Ferruh Yigit:
>> On 2/2/2020 2:41 PM, Ananyev, Konstantin wro
>
> 04/02/2020 11:16, Akhil Goyal:
> > Hi,
> > > On 2/3/2020 5:09 PM, Thomas Monjalon wrote:
> > > > 03/02/2020 10:30, Ferruh Yigit:
> > > >> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote:
> > > >>> 02/02/2020 14:05, Thomas Monjalon:
> > > 31/01/2020 15:16, Trahe, Fiona:
> > > > On 1/3
04/02/2020 11:16, Akhil Goyal:
> Hi,
> > On 2/3/2020 5:09 PM, Thomas Monjalon wrote:
> > > 03/02/2020 10:30, Ferruh Yigit:
> > >> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote:
> > >>> 02/02/2020 14:05, Thomas Monjalon:
> > 31/01/2020 15:16, Trahe, Fiona:
> > > On 1/30/2020 8:18 PM, Thoma
On 2/3/2020 9:07 PM, Thomas Monjalon wrote:
> 03/02/2020 19:55, Ray Kinsella:
>> On 03/02/2020 17:34, Thomas Monjalon wrote:
>>> 03/02/2020 18:09, Thomas Monjalon:
03/02/2020 10:30, Ferruh Yigit:
> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote:
>> 02/02/2020 14:05, Thomas Monjalon:
>>
RED FLAG
I don't see a lot of reactions, so I summarize the issue.
We need action TODAY!
API makes think that rte_cryptodev_info_get() cannot return
a value >= 3 (RTE_CRYPTO_AEAD_LIST_END in 19.11).
Current 20.02 returns 3 (RTE_CRYPTO_AEAD_CHACHA20_POLY1305).
The ABI compatibility contract is bro
On 04/02/2020 09:56, Ferruh Yigit wrote:
> On 2/4/2020 9:45 AM, Thomas Monjalon wrote:
>> 04/02/2020 10:19, Ferruh Yigit:
>>> On 2/3/2020 6:40 PM, Thomas Monjalon wrote:
03/02/2020 18:40, Ferruh Yigit:
> On 2/3/2020 5:09 PM, Thomas Monjalon wrote:
>> 03/02/2020 10:30, Ferruh Yigit:
>>>
Hi,
> On 2/3/2020 5:09 PM, Thomas Monjalon wrote:
> > 03/02/2020 10:30, Ferruh Yigit:
> >> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote:
> >>> 02/02/2020 14:05, Thomas Monjalon:
> 31/01/2020 15:16, Trahe, Fiona:
> > On 1/30/2020 8:18 PM, Thomas Monjalon wrote:
> >> 30/01/2020 17:09,
And not used for sizing > >
> > There a c) though right.
> > We could work around the issue by api versioning rte_cryptodev_info_get()
> > and friends.
>
> It has a lot of friends, but it sounds like the right approach.
> Is someone looking into this?
[Fiona] Yes. But not clear yet if can be don
On Tue, Feb 04, 2020 at 09:56:31AM +, Ferruh Yigit wrote:
> On 2/4/2020 9:45 AM, Thomas Monjalon wrote:
> > 04/02/2020 10:19, Ferruh Yigit:
> >> On 2/3/2020 6:40 PM, Thomas Monjalon wrote:
> >>> 03/02/2020 18:40, Ferruh Yigit:
> On 2/3/2020 5:09 PM, Thomas Monjalon wrote:
> > 03/02/202
On Mon, Feb 3, 2020 at 7:56 PM Ray Kinsella wrote:
> On 03/02/2020 17:34, Thomas Monjalon wrote:
> > 03/02/2020 18:09, Thomas Monjalon:
> >> 03/02/2020 10:30, Ferruh Yigit:
> >>> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote:
> 02/02/2020 14:05, Thomas Monjalon:
> > 31/01/2020 15:16, Tra
04/02/2020 10:19, Ferruh Yigit:
> On 2/3/2020 6:40 PM, Thomas Monjalon wrote:
> > 03/02/2020 18:40, Ferruh Yigit:
> >> On 2/3/2020 5:09 PM, Thomas Monjalon wrote:
> >>> 03/02/2020 10:30, Ferruh Yigit:
> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote:
> > 02/02/2020 14:05, Thomas Monjalon:
On 2/3/2020 6:40 PM, Thomas Monjalon wrote:
> 03/02/2020 18:40, Ferruh Yigit:
>> On 2/3/2020 5:09 PM, Thomas Monjalon wrote:
>>> 03/02/2020 10:30, Ferruh Yigit:
On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote:
> 02/02/2020 14:05, Thomas Monjalon:
>> 31/01/2020 15:16, Trahe, Fiona:
>
03/02/2020 19:55, Ray Kinsella:
> On 03/02/2020 17:34, Thomas Monjalon wrote:
> > 03/02/2020 18:09, Thomas Monjalon:
> >> 03/02/2020 10:30, Ferruh Yigit:
> >>> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote:
> 02/02/2020 14:05, Thomas Monjalon:
> > 31/01/2020 15:16, Trahe, Fiona:
> >>
On 03/02/2020 17:34, Thomas Monjalon wrote:
> 03/02/2020 18:09, Thomas Monjalon:
>> 03/02/2020 10:30, Ferruh Yigit:
>>> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote:
02/02/2020 14:05, Thomas Monjalon:
> 31/01/2020 15:16, Trahe, Fiona:
>> On 1/30/2020 8:18 PM, Thomas Monjalon wrote
03/02/2020 18:40, Ferruh Yigit:
> On 2/3/2020 5:09 PM, Thomas Monjalon wrote:
> > 03/02/2020 10:30, Ferruh Yigit:
> >> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote:
> >>> 02/02/2020 14:05, Thomas Monjalon:
> 31/01/2020 15:16, Trahe, Fiona:
> > On 1/30/2020 8:18 PM, Thomas Monjalon wrote:
On 2/3/2020 5:09 PM, Thomas Monjalon wrote:
> 03/02/2020 10:30, Ferruh Yigit:
>> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote:
>>> 02/02/2020 14:05, Thomas Monjalon:
31/01/2020 15:16, Trahe, Fiona:
> On 1/30/2020 8:18 PM, Thomas Monjalon wrote:
>> 30/01/2020 17:09, Ferruh Yigit:
03/02/2020 18:09, Thomas Monjalon:
> 03/02/2020 10:30, Ferruh Yigit:
> > On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote:
> > > 02/02/2020 14:05, Thomas Monjalon:
> > >> 31/01/2020 15:16, Trahe, Fiona:
> > >>> On 1/30/2020 8:18 PM, Thomas Monjalon wrote:
> > If library give higher value than ex
03/02/2020 10:30, Ferruh Yigit:
> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote:
> > 02/02/2020 14:05, Thomas Monjalon:
> >> 31/01/2020 15:16, Trahe, Fiona:
> >>> On 1/30/2020 8:18 PM, Thomas Monjalon wrote:
> 30/01/2020 17:09, Ferruh Yigit:
> > On 1/29/2020 8:13 PM, Akhil Goyal wrote:
>
Hello,
Ferruh Yigit a écrit:
[...]
> +1 the change/shuffle of the existing values are problematic, but we don't
> have
> it in this case.
Right.
[...]
> The concern is when there are cases we can waive, we can't directly rely on
> the
> tool and automate it. These indicators good for impro
> >
> > These sorts of changes are the type that we could collectively waive in
> > terms of
> > ABI checking, as they should be ok, but the errors from libabigail should be
> > taken as an indicator that this API could be rewritten (for example by
> > removing
> > the abi entirely, and adding
On 2/3/2020 2:00 PM, Dodji Seketeli wrote:
> Hello,
>
> Ferruh Yigit a écrit:
>
> [...]
>
>> +1 the change/shuffle of the existing values are problematic, but we don't
>> have
>> it in this case.
>
> Right.
>
> [...]
>
>> The concern is when there are cases we can waive, we can't directly r
On 2/3/2020 11:50 AM, Neil Horman wrote:
> On Mon, Feb 03, 2020 at 09:30:06AM +, Ferruh Yigit wrote:
>> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote:
>>>
31/01/2020 15:16, Trahe, Fiona:
> On 1/30/2020 8:18 PM, Thomas Monjalon wrote:
>> 30/01/2020 17:09, Ferruh Yigit:
>>> On 1
On Mon, Feb 03, 2020 at 09:30:06AM +, Ferruh Yigit wrote:
> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote:
> >
> >> 31/01/2020 15:16, Trahe, Fiona:
> >>> On 1/30/2020 8:18 PM, Thomas Monjalon wrote:
> 30/01/2020 17:09, Ferruh Yigit:
> > On 1/29/2020 8:13 PM, Akhil Goyal wrote:
>
On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote:
>
>> 31/01/2020 15:16, Trahe, Fiona:
>>> On 1/30/2020 8:18 PM, Thomas Monjalon wrote:
30/01/2020 17:09, Ferruh Yigit:
> On 1/29/2020 8:13 PM, Akhil Goyal wrote:
>>
>> I believe these enums will be used only in case of ASYM case which
> 31/01/2020 15:16, Trahe, Fiona:
> > On 1/30/2020 8:18 PM, Thomas Monjalon wrote:
> > > 30/01/2020 17:09, Ferruh Yigit:
> > > > On 1/29/2020 8:13 PM, Akhil Goyal wrote:
> > > > >
> > > > > I believe these enums will be used only in case of ASYM case which is
> > > > > experimental.
> > > >
> >
31/01/2020 15:16, Trahe, Fiona:
> On 1/30/2020 8:18 PM, Thomas Monjalon wrote:
> > 30/01/2020 17:09, Ferruh Yigit:
> > > On 1/29/2020 8:13 PM, Akhil Goyal wrote:
> > > >
> > > > I believe these enums will be used only in case of ASYM case which is
> > > > experimental.
> > >
> > > Independent fr
> > > I believe these enums will be used only in case of ASYM case which is
> > > experimental.
> >
> > Independent from being experiment and not, this shouldn't be a problem, I
> > think
> > this is a false positive.
> >
> > The ABI break can happen when a struct has been shared between the
>
>
> On 1/30/2020 8:18 PM, Thomas Monjalon wrote:
> > 30/01/2020 17:09, Ferruh Yigit:
> >> On 1/29/2020 8:13 PM, Akhil Goyal wrote:
> >>>
> >>>
>
> On Wed, Jan 29, 2020 at 7:10 PM Anoob Joseph wrote:
> > The asymmetric crypto library is experimental. Changes to experimental
>
@tuxdriver.com; Mcnamara, John ; Kusztal,
> ArkadiuszX
> Subject: Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks
>
> On 1/30/2020 11:49 PM, Ananyev, Konstantin wrote:
> >
> >
> >> -Original Message-
> >> From: dev On Behalf Of Thomas Monj
rg; David Marchand ; Richardson,
>> Bruce ;
>> nhor...@tuxdriver.com; Mcnamara, John ; Trahe,
>> Fiona ; Kusztal, ArkadiuszX
>> ; Yigit, Ferruh
>> Subject: Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks
>>
>> 30/01/2020 14:06, Trahe, Fiona:
>>> We were
On 1/30/2020 8:18 PM, Thomas Monjalon wrote:
> 30/01/2020 17:09, Ferruh Yigit:
>> On 1/29/2020 8:13 PM, Akhil Goyal wrote:
>>>
>>>
On Wed, Jan 29, 2020 at 7:10 PM Anoob Joseph wrote:
> The asymmetric crypto library is experimental. Changes to experimental
> code
paths is al
ara, John ; Trahe, Fiona
> ; Kusztal, ArkadiuszX
> ; Yigit, Ferruh
> Subject: Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks
>
> 30/01/2020 14:06, Trahe, Fiona:
> > We were unaware the LIST_END change could constitute an ABI breakage, but
> > can see how it affects the arr
30/01/2020 17:09, Ferruh Yigit:
> On 1/29/2020 8:13 PM, Akhil Goyal wrote:
> >
> >
> >>
> >> On Wed, Jan 29, 2020 at 7:10 PM Anoob Joseph wrote:
> >>> The asymmetric crypto library is experimental. Changes to experimental
> >>> code
> >> paths is allowed, right?
> >>
> >> The asymmetric crypto
On 1/30/2020 3:59 PM, Thomas Monjalon wrote:
> 30/01/2020 14:06, Trahe, Fiona:
>> We were unaware the LIST_END change could constitute an ABI breakage, but
>> can see how it affects the array size when picked up.
>> We're exploring options.
>>
>> I agree with Anoob's point that if we don't allow t
On 1/29/2020 8:13 PM, Akhil Goyal wrote:
>
>
>>
>> On Wed, Jan 29, 2020 at 7:10 PM Anoob Joseph wrote:
>>> The asymmetric crypto library is experimental. Changes to experimental code
>> paths is allowed, right?
>>
>> The asymmetric crypto enum is referenced by a function part of the stable
>> A
30/01/2020 14:06, Trahe, Fiona:
> We were unaware the LIST_END change could constitute an ABI breakage, but can
> see how it affects the array size when picked up.
> We're exploring options.
>
> I agree with Anoob's point that if we don't allow the LIST_END to be
> modified, then it means no fea
@nxp.com
> Cc: dev@dpdk.org; David Marchand ; Richardson,
> Bruce
> ; nhor...@tuxdriver.com; Mcnamara, John
>
> Subject: Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks
>
> Hi Thomas,
>
> The asymmetric crypto library is experimental. Changes to experimental code
>
>
> On Wed, Jan 29, 2020 at 7:10 PM Anoob Joseph wrote:
> > The asymmetric crypto library is experimental. Changes to experimental code
> paths is allowed, right?
>
> The asymmetric crypto enum is referenced by a function part of the stable ABI.
> It is possible to waive this enum, if we are s
On Wed, Jan 29, 2020 at 7:10 PM Anoob Joseph wrote:
> The asymmetric crypto library is experimental. Changes to experimental code
> paths is allowed, right?
The asymmetric crypto enum is referenced by a function part of the stable ABI.
It is possible to waive this enum, if we are sure no use out
nks,
Anoob
> -Original Message-
> From: dev On Behalf Of Thomas Monjalon
> Sent: Wednesday, January 29, 2020 11:13 PM
> To: akhil.go...@nxp.com; Anoob Joseph
> Cc: dev@dpdk.org; David Marchand ;
> bruce.richard...@intel.com; nhor...@tuxdriver.com; John McNamara
>
> Subject: Re:
Anoob, Akhil,
Please we need to revert or fix the ABI breakages in cryptodev very soon.
The FIXME section below must be empty.
Thanks
29/01/2020 18:26, David Marchand:
> We currently have issues reported for librte_crypto recent changes for
> which suppression rules have been added too.
[..]
> -
59 matches
Mail list logo
