[dpdk-dev] [PATCH v2] doc: ip_pipeline app user guide
> > From: "Dumitrescu, Cristian" > > > > Added more extensive documentation for ip_pipeline application. > > > > Signed-off-by: Cristian Dumitrescu > > Acked-by: Jasvinder Singh > > Acked-by: Piotr Azarewicz > > Acked-by: John McNamara > > --- > > Acked-by: Cristian Dumitrescu This patch is moving doc for examples/ip_pipeline/ from doc/guides/sample_app_ug/ to a standalone doc. The only app having a standalone doc is testpmd. So this patch is applied after moving it back to doc/guides/sample_app_ug/. Thanks
[dpdk-dev] tx_stop_queue and flow control
Hello, DPDK drivers support tx_stop_queue, but they don't use it for flow control, I.e. Stop upper layer calling the device tx_pkt_burst routine when there is no resource. I wonder if flow control is needed here, if yes, is there plan to add this support? Thanks, Jia
[dpdk-dev] [PATCH v2] doc: ip_pipeline app user guide
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, August 11, 2015 9:37 PM > To: Dumitrescu, Cristian > Cc: dev at dpdk.org; Mcnamara, John > Subject: Re: [dpdk-dev] [PATCH v2] doc: ip_pipeline app user guide > > > > From: "Dumitrescu, Cristian" > > > > > > Added more extensive documentation for ip_pipeline application. > > > > > > Signed-off-by: Cristian Dumitrescu > > > Acked-by: Jasvinder Singh > > > Acked-by: Piotr Azarewicz > > > Acked-by: John McNamara > > > --- > > > > Acked-by: Cristian Dumitrescu > > This patch is moving doc for examples/ip_pipeline/ from > doc/guides/sample_app_ug/ to a standalone doc. > The only app having a standalone doc is testpmd. > > So this patch is applied after moving it back to doc/guides/sample_app_ug/. > Thanks Hi Thomas, The intention was to have this as a separate document, since this application is fairly complex at this point and it is essentially used as an application generator and tester for more APIs and setups than available through the other example apps (similar to testpmd). But if you decide to put it back to the sample apps guide, I am fine with it. Thanks! Regards, Cristian
[dpdk-dev] [PATCH] doc: add missing API headers
> Some libraries were not included in doxygen documentation. > Other ones were included but not listed in the index. > > The malloc library is now included in EAL. > > The libraries compat and jobstats are added but not doxygen compliant. > > Signed-off-by: Thomas Monjalon Applied
[dpdk-dev] [PATCH] doc: add missing API headers
Some libraries were not included in doxygen documentation. Other ones were included but not listed in the index. The malloc library is now included in EAL. The libraries compat and jobstats are added but not doxygen compliant. Signed-off-by: Thomas Monjalon --- doc/api/doxy-api-index.md | 16 ++-- doc/api/doxy-api.conf | 4 +++- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md index 6958f8f..72ac3c4 100644 --- a/doc/api/doxy-api-index.md +++ b/doc/api/doxy-api-index.md @@ -36,7 +36,9 @@ API {#index} There are many libraries, so their headers may be grouped by topics: - **device**: + [dev](@ref rte_dev.h), [ethdev] (@ref rte_ethdev.h), + [ethctrl](@ref rte_eth_ctrl.h), [devargs](@ref rte_devargs.h), [bond] (@ref rte_eth_bond.h), [vhost] (@ref rte_virtio_net.h), @@ -76,12 +78,15 @@ There are many libraries, so their headers may be grouped by topics: - **layers**: [ethernet] (@ref rte_ether.h), + [ARP](@ref rte_arp.h), + [ICMP] (@ref rte_icmp.h), [IP] (@ref rte_ip.h), [SCTP] (@ref rte_sctp.h), [TCP](@ref rte_tcp.h), [UDP](@ref rte_udp.h), [frag/reass] (@ref rte_ip_frag.h), - [LPM route] (@ref rte_lpm.h), + [LPM IPv4 route] (@ref rte_lpm.h), + [LPM IPv6 route] (@ref rte_lpm6.h), [ACL](@ref rte_acl.h) - **QoS**: @@ -92,6 +97,7 @@ There are many libraries, so their headers may be grouped by topics: - **hashes**: [hash] (@ref rte_hash.h), [jhash] (@ref rte_jhash.h), + [thash] (@ref rte_thash.h), [FBK hash] (@ref rte_fbk_hash.h), [CRC hash] (@ref rte_hash_crc.h) @@ -99,8 +105,10 @@ There are many libraries, so their headers may be grouped by topics: [mbuf] (@ref rte_mbuf.h), [ring] (@ref rte_ring.h), [distributor](@ref rte_distributor.h), + [reorder](@ref rte_reorder.h), [tailq] (@ref rte_tailq.h), - [bitmap] (@ref rte_bitmap.h) + [bitmap] (@ref rte_bitmap.h), + [ivshmem](@ref rte_ivshmem.h) - **packet framework**: * [port] (@ref rte_port.h): @@ -122,10 +130,13 @@ There are many libraries, so their headers may be grouped by topics: - **basic**: [approx fraction](@ref rte_approx.h), [random] (@ref rte_random.h), + [config file](@ref rte_cfgfile.h), [key/value args] (@ref rte_kvargs.h), [string] (@ref rte_string_fns.h) - **debug**: + [jobstats] (@ref rte_jobstats.h), + [hexdump](@ref rte_hexdump.h), [debug] (@ref rte_debug.h), [log](@ref rte_log.h), [warnings] (@ref rte_warnings.h), @@ -134,4 +145,5 @@ There are many libraries, so their headers may be grouped by topics: - **misc**: [EAL config] (@ref rte_eal.h), [common] (@ref rte_common.h), + [ABI compat] (@ref rte_compat.h), [version](@ref rte_version.h) diff --git a/doc/api/doxy-api.conf b/doc/api/doxy-api.conf index de32af1..cfb4627 100644 --- a/doc/api/doxy-api.conf +++ b/doc/api/doxy-api.conf @@ -34,16 +34,18 @@ INPUT = doc/api/doxy-api-index.md \ lib/librte_eal/common/include \ lib/librte_eal/common/include/generic \ lib/librte_acl \ + lib/librte_cfgfile \ lib/librte_cmdline \ + lib/librte_compat \ lib/librte_distributor \ lib/librte_ether \ lib/librte_hash \ lib/librte_ip_frag \ + lib/librte_ivshmem \ lib/librte_jobstats \ lib/librte_kni \ lib/librte_kvargs \ lib/librte_lpm \ - lib/librte_malloc \ lib/librte_mbuf \ lib/librte_mempool \ lib/librte_meter \ -- 2.4.2
[dpdk-dev] [PATCH v2] doc: ip_pipeline app user guide
From: "Dumitrescu, Cristian"Added more extensive documentation for ip_pipeline application. Signed-off-by: Cristian Dumitrescu Acked-by: Jasvinder Singh Acked-by: Piotr Azarewicz Acked-by: John McNamara --- doc/guides/index.rst |1 + doc/guides/ip_pipeline_ug/img/ip_pipelines_1.svg | 738 + doc/guides/ip_pipeline_ug/img/ip_pipelines_2.svg | 997 + doc/guides/ip_pipeline_ug/img/ip_pipelines_3.svg | 826 ++ doc/guides/ip_pipeline_ug/index.rst| 38 + doc/guides/ip_pipeline_ug/ip_pipeline_app.rst | 1129 doc/guides/sample_app_ug/index.rst |1 - .../sample_app_ug/internet_proto_ip_pipeline.rst | 135 --- 8 files changed, 3729 insertions(+), 136 deletions(-) create mode 100644 doc/guides/ip_pipeline_ug/img/ip_pipelines_1.svg create mode 100644 doc/guides/ip_pipeline_ug/img/ip_pipelines_2.svg create mode 100644 doc/guides/ip_pipeline_ug/img/ip_pipelines_3.svg create mode 100644 doc/guides/ip_pipeline_ug/index.rst create mode 100644 doc/guides/ip_pipeline_ug/ip_pipeline_app.rst delete mode 100644 doc/guides/sample_app_ug/internet_proto_ip_pipeline.rst diff --git a/doc/guides/index.rst b/doc/guides/index.rst index 439c7e3..a916856 100644 --- a/doc/guides/index.rst +++ b/doc/guides/index.rst @@ -44,6 +44,7 @@ Contents: nics/index sample_app_ug/index testpmd_app_ug/index + ip_pipeline_ug/index faq/index rel_notes/index contributing/index diff --git a/doc/guides/ip_pipeline_ug/img/ip_pipelines_1.svg b/doc/guides/ip_pipeline_ug/img/ip_pipelines_1.svg new file mode 100644 index 000..a114ed8 --- /dev/null +++ b/doc/guides/ip_pipeline_ug/img/ip_pipelines_1.svg @@ -0,0 +1,738 @@ + + + +http://purl.org/dc/elements/1.1/; + xmlns:cc="http://creativecommons.org/ns#; + xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#; + xmlns:svg="http://www.w3.org/2000/svg; + xmlns="http://www.w3.org/2000/svg; + xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd; + xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape; + width="638.18219" + height="273.16391" + id="svg2" + version="1.1" + inkscape:version="0.48.4 r9939" + sodipodi:docname="ipPipelines_1_update.svg"> + + + + + + + + + + + + + + + + + + + + + + + + + + + +image/svg+xml +http://purl.org/dc/dcmitype/StillImage; /> + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +CPU Core 1 +CPU Core 2 +CPU Core 3 + +P1 +P2 +P3 +CPU Core 1 +P1 +P2 +P3 + + diff --git a/doc/guides/ip_pipeline_ug/img/ip_pipelines_2.svg b/doc/guides/ip_pipeline_ug/img/ip_pipelines_2.svg new file mode 100644 index 000..5252b17 --- /dev/null +++ b/doc/guides/ip_pipeline_ug/img/ip_pipelines_2.svg @@ -0,0 +1,997 @@ + + + +http://purl.org/dc/elements/1.1/; + xmlns:cc="http://creativecommons.org/ns#; + xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#; + xmlns:svg="http://www.w3.org/2000/svg; + xmlns="http://www.w3.org/2000/svg; + xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd; + xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape; + width="520.43439" + height="438.61716" + id="svg5382" + version="1.1" + inkscape:version="0.48.4 r9939" + sodipodi:docname="ipPipelines_2_update.svg"> + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +image/svg+xml +http://purl.org/dc/dcmitype/StillImage; /> + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
[dpdk-dev] [PATCH] doc: restructured release notes documentation
2015-08-11 15:28, Thomas Monjalon: > 2015-08-11 13:12, Mcnamara, John: > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > Why not add faq after user guides and before release notes and > > > contributor's guidelines? > > > user guides > > > faq > > > release notes > > > contributing > > > > Hi, > > > > No strong reason. I'll submit a V2. > > No need to submit a v2. > I've done the change and split the patch for easier future references. Applied, thanks
[dpdk-dev] [PATCH v2] doc: ip_pipeline app user guide
> -Original Message- > From: Mcnamara, John > Sent: Tuesday, August 11, 2015 5:47 PM > To: dev at dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH v2] doc: ip_pipeline app user guide > > From: "Dumitrescu, Cristian" > > Added more extensive documentation for ip_pipeline application. > > Signed-off-by: Cristian Dumitrescu > Acked-by: Jasvinder Singh > Acked-by: Piotr Azarewicz > Acked-by: John McNamara > --- Acked-by: Cristian Dumitrescu Thanks, John!
[dpdk-dev] [PATCH 2/2] doc: add mlx4 release notes to DPDK 2.1.0
Signed-off-by: Adrien Mazarguil --- doc/guides/rel_notes/release_2_1.rst | 20 1 file changed, 20 insertions(+) diff --git a/doc/guides/rel_notes/release_2_1.rst b/doc/guides/rel_notes/release_2_1.rst index c39418c..00edd4b 100644 --- a/doc/guides/rel_notes/release_2_1.rst +++ b/doc/guides/rel_notes/release_2_1.rst @@ -38,12 +38,32 @@ New Features * TODO. +* Mellanox ConnectX-3 PMD (mlx4) enhancements. + +* Support Mellanox OFED 3.0. + +* Improved performance for both RX and TX operations. + +* Better link status information. + +* Outer L3/L4 checksum offload support. + +* Inner L3/L4 checksum offload support for VXLAN. Resolved Issues --- * TODO. +* Mellanox ConnectX-3 PMD (mlx4) bugfixes. + +* Multiple VLAN filters support. + +* Compilation on 32 bit platforms. + +* Possible crash in case of mbuf allocation failure. + +* Compilation as a shared library. Known Issues -- 2.1.0
[dpdk-dev] [PATCH 1/2] doc: add missing release notes for mlx4 availability in DPDK 2.0.0
Signed-off-by: Adrien Mazarguil --- doc/guides/rel_notes/release_2_0.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_2_0.rst b/doc/guides/rel_notes/release_2_0.rst index 4341a0c..62737ae 100644 --- a/doc/guides/rel_notes/release_2_0.rst +++ b/doc/guides/rel_notes/release_2_0.rst @@ -123,6 +123,12 @@ New Features * Support for VXLAN packet on Intel? 40GbE Controllers +* Poll Mode Driver for Mellanox ConnectX-3 EN adapters (mlx4) + +.. note:: This PMD is only available for Linux and is disabled by default + due to external dependencies (libibverbs and libmlx4). Please + refer to the NIC drivers guide for more information. + * Packet Distributor Sample Application * Job Stats library and Sample Application. -- 2.1.0
[dpdk-dev] [PATCH 0/2] add mlx4 release notes
Following John McNamara's changes we've noticed that mlx4 release notes were missing from DPDK 2.0.0. This patchset adds them retroactively and also provides mlx4 release notes for DPDK 2.1.0. Adrien Mazarguil (2): doc: add missing release notes for mlx4 availability in DPDK 2.0.0 doc: add mlx4 release notes to DPDK 2.1.0 doc/guides/rel_notes/release_2_0.rst | 6 ++ doc/guides/rel_notes/release_2_1.rst | 20 2 files changed, 26 insertions(+) -- 2.1.0
[dpdk-dev] docs for the igb_uio.c?
Hello: Unable to locate the documentation for the igb_uio.c program in the DPDK-2.0.0 package. Can somebody please steer me to it? Thanks -Navneet
[dpdk-dev] [PATCH] doc: restructured release notes documentation
2015-08-11 13:12, Mcnamara, John: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Why not add faq after user guides and before release notes and > > contributor's guidelines? > > user guides > > faq > > release notes > > contributing > > Hi, > > No strong reason. I'll submit a V2. No need to submit a v2. I've done the change and split the patch for easier future references. Thanks
[dpdk-dev] [PATCH] doc: restructured release notes documentation
2015-08-11 12:57, John McNamara: > --- a/doc/guides/index.rst > +++ b/doc/guides/index.rst > @@ -46,3 +46,4 @@ Contents: > testpmd_app_ug/index > rel_notes/index > guidelines/index > + faq/index Why not add faq after user guides and before release notes and contributor's guidelines? user guides faq release notes contributing
[dpdk-dev] [PATCH] doc: rename guidelines for contributors
> > Clarify target of guidelines by renaming the title and the directory. > > > > Signed-off-by: Thomas Monjalon > > Acked-by: John McNamara Applied
[dpdk-dev] [PATCH] doc: restructured release notes documentation
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, August 11, 2015 2:02 PM > To: Mcnamara, John > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: restructured release notes > documentation >... > Why not add faq after user guides and before release notes and > contributor's guidelines? > user guides > faq > release notes > contributing Hi, No strong reason. I'll submit a V2. John. --
[dpdk-dev] DPDK2.1 (rc3 & rc4) major performance drop.
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Weglicki, MichalX > Sent: Tuesday, August 11, 2015 11:40 AM > To: dev at dpdk.org > Subject: [dpdk-dev] DPDK2.1 (rc3 & rc4) major performance drop. > > Hello, > > Currently I'm integrating OVS head with DPDK 2.1. Based on my tests > performance in all scenarios (confirmed on Phy2Phy and Vhostuser) has > dropped about 10%. Please find example results below: Also: > Michal: > It seems I can fix it on OVS side by passing old hardcoded > size(2048 + RTE_PKTMBUF_HEADROOM) as argument instead of NULL. Hi, In commit 1d493a49490fa the bahaviour of rte_pktmbuf_pool_init() changed: commit 1d493a49490fa90e09689d49280cff0d51d0193e Author: Olivier Matz Date: Wed Apr 22 11:57:18 2015 +0200 mbuf: fix data room size calculation in pool init Previously passing opaque_arg == NULL initialized mbuf_data_room_size = 2048 + RTE_PKTMBUF_HEADROOM. Now it is set as follows: + /* if no structure is provided, assume no mbuf private area */ + user_mbp_priv = opaque_arg; + if (user_mbp_priv == NULL) { + default_mbp_priv.mbuf_priv_size = 0; + if (mp->elt_size > sizeof(struct rte_mbuf)) + roomsz = mp->elt_size - sizeof(struct rte_mbuf); + else + roomsz = 0; + default_mbp_priv.mbuf_data_room_size = roomsz; + user_mbp_priv = _mbp_priv; + } A workaround, for OVS, would be to pass the new opaque_arg struct with the required default set. However, perhaps this should be fixed in DPDK. The updated doc in the same patch says: +DPDK 2.0 to DPDK 2.1 + + +* The second argument of rte_pktmbuf_pool_init(mempool, opaque) is now a +pointer to a struct rte_pktmbuf_pool_private instead of a uint16_t +casted into a pointer. Backward compatibility is preserved when the +argument was NULL which is the majority of use cases, but not if the +opaque pointer was not NULL, as it is not technically feasible. In +this case, the application has to be modified to properly fill a +rte_pktmbuf_pool_private structure and pass it to +rte_pktmbuf_pool_init(). + I think the OVS issue shows that backward compatibility isn't preserved (in the strictest sense). Should this be fixed? Opinions? John. --
[dpdk-dev] [PATCH] doc: restructured release notes documentation
Restructured the Release Notes documentation into a more useful structure that is easier to use and to update between releases. The main changes are: * Each release version has it's own section with New Features, Resolved Issues, Known Issues and API/ABI Changes. * Redundant sections have been removed. * The FAQ section have been moved to a standalone document. * The Known Issues tables have been changed to definition lists. Signed-off-by: John McNamara --- doc/guides/faq/faq.rst | 240 + doc/guides/faq/index.rst| 42 + doc/guides/index.rst|1 + doc/guides/rel_notes/deprecation.rst|7 +- doc/guides/rel_notes/faq.rst| 228 - doc/guides/rel_notes/index.rst | 14 +- doc/guides/rel_notes/known_issues.rst | 1232 ++- doc/guides/rel_notes/new_features.rst | 129 --- doc/guides/rel_notes/rel_description.rst| 145 +-- doc/guides/rel_notes/release_1_8.rst| 64 ++ doc/guides/rel_notes/release_2_0.rst| 133 +++ doc/guides/rel_notes/release_2_1.rst| 69 ++ doc/guides/rel_notes/resolved_issues.rst| 1395 --- doc/guides/rel_notes/supported_features.rst | 396 doc/guides/rel_notes/supported_os.rst | 14 +- doc/guides/rel_notes/updating_apps.rst | 136 --- 16 files changed, 1061 insertions(+), 3184 deletions(-) create mode 100644 doc/guides/faq/faq.rst create mode 100644 doc/guides/faq/index.rst delete mode 100644 doc/guides/rel_notes/faq.rst delete mode 100644 doc/guides/rel_notes/new_features.rst create mode 100644 doc/guides/rel_notes/release_1_8.rst create mode 100644 doc/guides/rel_notes/release_2_0.rst create mode 100644 doc/guides/rel_notes/release_2_1.rst delete mode 100644 doc/guides/rel_notes/resolved_issues.rst delete mode 100644 doc/guides/rel_notes/supported_features.rst delete mode 100644 doc/guides/rel_notes/updating_apps.rst diff --git a/doc/guides/faq/faq.rst b/doc/guides/faq/faq.rst new file mode 100644 index 000..7b2394c --- /dev/null +++ b/doc/guides/faq/faq.rst @@ -0,0 +1,240 @@ +.. BSD LICENSE +Copyright(c) 2010-2014 Intel Corporation. All rights reserved. +All rights reserved. + +Redistribution and use in source and binary forms, with or without +modification, are permitted provided that the following conditions +are met: + +* Redistributions of source code must retain the above copyright +notice, this list of conditions and the following disclaimer. +* Redistributions in binary form must reproduce the above copyright +notice, this list of conditions and the following disclaimer in +the documentation and/or other materials provided with the +distribution. +* Neither the name of Intel Corporation nor the names of its +contributors may be used to endorse or promote products derived +from this software without specific prior written permission. + +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + + +What does "EAL: map_all_hugepages(): open failed: Permission denied Cannot init memory" mean? +- + +This is most likely due to the test application not being run with sudo to promote the user to a superuser. +Alternatively, applications can also be run as regular user. +For more information, please refer to :doc:`DPDK Getting Started Guide `. + + +If I want to change the number of TLB Hugepages allocated, how do I remove the original pages allocated? + + +The number of pages allocated can be seen by executing the following command:: + + grep Huge /proc/meminfo + +Once all the pages are mmapped by an application, they stay that way. +If you start a test application with less than the maximum, then you have free pages. +When you stop and restart the test application, it looks to see if the pages are available in the ``/dev/huge`` directory and mmaps them. +If you look in the directory, you will see ``n`` number of 2M pages files. If
[dpdk-dev] [PATCH] doc: rename guidelines for contributors
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, August 11, 2015 10:53 AM > To: Mcnamara, John > Cc: dev at dpdk.org > Subject: [PATCH] doc: rename guidelines for contributors > > Clarify target of guidelines by renaming the title and the directory. > > Signed-off-by: Thomas Monjalon Acked-by: John McNamara
[dpdk-dev] DPDK2.1 (rc3 & rc4) major performance drop.
Hello, Currently I'm integrating OVS head with DPDK 2.1. Based on my tests performance in all scenarios (confirmed on Phy2Phy and Vhostuser) has dropped about 10%. Please find example results below: PHY2PHY (Bidirectional) DPDK 2.1: Iteration 1: 14,164,987 pps Iteration 2: 13,866,386 pps Iteration 3: 14,093,153 pps DPDK 2.0: Iteration 1: 15,406,646 pps Iteration 2: 15,410,182 pps Iteration 3: 15,404,678 pps VHOSTUser: DPDK 2.1: Iteration 1: 3,328,678 pps Iteration 2: 3,367,130 pps Iteration 3: 3,259,899 pps DPDK 2.0: Iteration 1: 3,786,969 pps Iteration 2: 3,736,117 pps Iteration 3: 3,557,150 pps Based on my test last commit where performance was the same was: 37f9a7270e800df5c603b2c76c73ed3bca3328d9 Bad commit: 1d493a49490fa90e09689d49280cff0d51d0193e You can find diff in attachment. Change is still compatible in OVS because in rte_pktmbuf_pool_init, NULL is passed as second argument. Did anyone noticed such performance drop? Could anyone give me some information why this implementation has changed? Any hints how to get back to previous performance would be very appreciated. Br, Michal. -- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
[dpdk-dev] [PATCH] doc: announce ABI change for old flow director APIs removing
APIs for flow director filters has been replaced by rte_eth_dev_filter_ctrl by previous releases. Enic, ixgbe and i40e are switched to support filter_ctrl APIs, so the old APIs are useless, and ready to be removed now. This patch announces the ABI change for these APIs removing. Signed-off-by: Jingjing Wu --- doc/guides/rel_notes/deprecation.rst | 36 1 file changed, 36 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 5330d3b..b1be38f 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -35,3 +35,39 @@ Deprecation Notices * The following fields have been deprecated in rte_eth_stats: imissed, ibadcrc, ibadlen, imcasts, fdirmatch, fdirmiss, tx_pause_xon, rx_pause_xon, tx_pause_xoff, rx_pause_xoff + +* APIs for flow director filters has been replaced by rte_eth_dev_filter_ctrl. + Following old APIs, and data structures are deprecated and will be removed + with version 2.2. There is no backward compatibility planned from release 2.2. + APIs: +rte_eth_dev_fdir_add_signature_filter +rte_eth_dev_fdir_update_signature_filter +rte_eth_dev_fdir_remove_signature_filter +rte_eth_dev_fdir_get_infos +rte_eth_dev_fdir_add_perfect_filter +rte_eth_dev_fdir_update_perfect_filter +rte_eth_dev_fdir_remove_perfect_filter +rte_eth_dev_fdir_set_masks + Data structures: +struct rte_fdir_filter +struct rte_fdir_masks +struct rte_eth_fdir +fields in struct eth_dev_ops + fdir_add_signature_filter + fdir_update_signature_filter + fdir_remove_signature_filter + fdir_infos_get + fdir_add_perfect_filter + fdir_update_perfect_filter + fdir_remove_perfect_filter + fdir_set_masks +enum rte_l4type +enum rte_iptype +fdir_add_signature_filter_t +fdir_update_signature_filter_t +fdir_remove_signature_filter_t +fdir_infos_get_t +fdir_add_perfect_filter_t +fdir_update_perfect_filter_t +fdir_remove_perfect_filter_t +fdir_set_masks_t -- 2.4.0
[dpdk-dev] [PATCH] doc: ip_pipeline app user guide
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Monday, August 10, 2015 10:45 PM > To: Dumitrescu, Cristian > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: ip_pipeline app user guide > > 2015-08-06 14:48, Cristian Dumitrescu: > > Signed-off-by: Cristian Dumitrescu > ... > > The patch is corrupted. > Checkpatch reports: > ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?) Git > reports: > fatal: corrupt patch at line 191 Hi, I think the problem is that the svg files had lines over 1000 chars that got truncated by git-send-patch or the mailer daemon. We'll resubmit the patchset. John
[dpdk-dev] [PATCH] doc: announce ABI change for old flow director APIs removing
> -Original Message- > From: Wu, Jingjing > Sent: Tuesday, August 11, 2015 10:12 AM > To: dev at dpdk.org > Cc: Wu, Jingjing; Zhang, Helin; Liu, Jijiang > Subject: [PATCH] doc: announce ABI change for old flow director APIs removing > > APIs for flow director filters has been replaced by rte_eth_dev_filter_ctrl by > previous releases. Enic, ixgbe and i40e are switched to support filter_ctrl > APIs, > so the old APIs are useless, and ready to be removed now. > This patch announces the ABI change for these APIs removing. > > Signed-off-by: Jingjing Wu Acked-by: Jijiang Liu
[dpdk-dev] [PATCH] doc: announce ABI change for old flow director APIs removing
> -Original Message- > From: Wu, Jingjing > Sent: Monday, August 10, 2015 7:12 PM > To: dev at dpdk.org > Cc: Wu, Jingjing; Zhang, Helin; Liu, Jijiang > Subject: [PATCH] doc: announce ABI change for old flow director APIs removing > > APIs for flow director filters has been replaced by rte_eth_dev_filter_ctrl by > previous releases. Enic, ixgbe and i40e are switched to support filter_ctrl > APIs, so > the old APIs are useless, and ready to be removed now. > This patch announces the ABI change for these APIs removing. > > Signed-off-by: Jingjing Wu Acked-by: Helin Zhang
[dpdk-dev] [dpdk-announce] release candidate 2.1.0-rc4
A new DPDK release candidate is ready for testing: http://dpdk.org/browse/dpdk/tag/?id=v2.1.0-rc4 It is a small weekly and last release candidate. Only the release notes should be updated before the release 2.1.0. Changelog (main changes since 2.1.0-rc3) - fixes for: * build * ivshmem * bonding Thank you
[dpdk-dev] [PATCH 0/2] docs: add warning note to base dirs readme
> This patch updates the "Source Organisation" section of the Programmers Guide > to add an note that the code in the drivers/net/pmd/base directories should > not be modifed by the user apart from the pmd_osdep.[ch] files. > > It also adds a note to the README files in the drivers/net/pmd/base dirs to > highlight the same thing. > > John McNamara (2): > doc: add explanation about code in the base dirs > drivers: add warning note to base dirs readme Applied, thanks
[dpdk-dev] [PATCH] doc: ip_pipeline app user guide
2015-08-06 14:48, Cristian Dumitrescu: > Signed-off-by: Cristian Dumitrescu > --- > doc/guides/index.rst |1 + > doc/guides/ip_pipeline_ug/img/ip_pipelines_1.svg | 718 + > doc/guides/ip_pipeline_ug/img/ip_pipelines_2.svg | 997 + > doc/guides/ip_pipeline_ug/img/ip_pipelines_3.svg | 826 ++ > doc/guides/ip_pipeline_ug/index.rst| 38 + > doc/guides/ip_pipeline_ug/ip_pipeline_app.rst | 1129 > > doc/guides/sample_app_ug/index.rst |1 - > .../sample_app_ug/internet_proto_ip_pipeline.rst | 135 --- The patch is corrupted. Checkpatch reports: ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?) Git reports: fatal: corrupt patch at line 191
[dpdk-dev] [PATCH v1] doc: prog_guide update for RX interrupt event
> > The patch updates the env_abstraction_layer.rst part in prog_guide. > > It adds the RX interrupt event declaration and revises the others in > > interrupt event section. > > > > Signed-off-by: Cunming Liang > Acked-by: Danny Zhou Applied, thanks
[dpdk-dev] [PATCH 0/2] Warn user if system has more than 64 cores when using VM power manager
2015-08-07 11:06, Gonzalez Monroy, Sergio: > On 06/08/2015 12:07, Pablo de Lara wrote: > > Pablo de Lara (2): > >examples/vm_power_mgr: show warning when using systems with more than > > 64 cores > >doc: add known issue regarding VM power mgr in release notes > > > > doc/guides/rel_notes/known_issues.rst | 24 > > examples/vm_power_manager/channel_manager.c | 11 +-- > > 2 files changed, 29 insertions(+), 6 deletions(-) > > > Acked-by: Sergio Gonzalez Monroy Applied, thanks