[dpdk-dev] [PATCH] doc: add contributors guide

2015-10-16 Thread Thomas Monjalon
Hi John, 2015-10-15 17:51, John McNamara: > Add a document to explain the DPDK patch submission and review process. Thanks > +There are also DPDK mailing lists for: > + > +* users: `general usage questions `_. > +* announce: `release announcements

[dpdk-dev] I have a problem in setting up DPDK 2.1.0 in Fedora OS release 20 (Heisenbug). I cannot r

2015-10-16 Thread 최익성
Dear John Manamara and DPDK experts. Thank you very much for your precious advice and answer. I will try to upgrade the OS. I really appreciate to you for your excellent work and great contributions. Sincerely Yours, Ick-Sung Choi. -Original Message- From: "Mcnamara,

[dpdk-dev] [PATCH 1/4] ixgbe: 512 entries RSS table on x550

2015-10-16 Thread Lu, Wenzhuo
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, October 16, 2015 6:19 AM > To: Lu, Wenzhuo; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH 1/4] ixgbe: 512 entries RSS table on x550 > > Hi Wenzhuo, > > > -Original Message- > > From: dev

[dpdk-dev] [PATCH 4/4] ixgbe: VF RSS reta query and update

2015-10-16 Thread Lu, Wenzhuo
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, October 16, 2015 6:58 AM > To: Lu, Wenzhuo; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH 4/4] ixgbe: VF RSS reta query and update > > > > > -Original Message- > > From: dev [mailto:dev-bounces

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-10-16 Thread Yuanhan Liu
On Thu, Oct 15, 2015 at 04:18:59PM +0300, Michael S. Tsirkin wrote: > On Thu, Oct 15, 2015 at 02:08:39PM +0300, Marcel Apfelbaum wrote: > > Make vhost-user virtio 1.0 compatible by adding it to the > > supported features and keeping the header length > > the same as for mergeable RX buffers. > >

[dpdk-dev] [PATCH] eal: don't reset getopt lib

2015-10-16 Thread Tiwei Bie
On Thu, Oct 15, 2015 at 04:22:53PM +, Don Provan wrote: > Looks perfect. Thanks! Thanks! It's my pleasure. :-) Best wishes, Tiwei Bie > -don > > -Original Message- > From: Tiwei Bie [mailto:btw at mail.ustc.edu.cn] > Sent: Thursday, October 15, 2015 4:46 AM > To: Don Provan ;

[dpdk-dev] DPDK patch backlog

2015-10-16 Thread Zhu, Heqing
+1 -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger Sent: Friday, October 16, 2015 5:44 AM To: Thomas Monjalon Cc: dev at dpdk.org Subject: [dpdk-dev] DPDK patch backlog There are currently 428 patches in New state in DPDK patchwork. Thomas,

[dpdk-dev] [PATCH v3 01/36] e1000/base: update readme and copyright

2015-10-16 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- drivers/net/e1000/base/README | 4 ++-- drivers/net/e1000/base/e1000_80003es2lan.c | 2 +- drivers/net/e1000/base/e1000_80003es2lan.h | 2 +- drivers/net/e1000/base/e1000_82540.c | 2 +- drivers/net/e1000/base/e1000_82541.c | 2 +-

[dpdk-dev] [PATCH v3 02/36] e1000/base: add new devices

2015-10-16 Thread Wenzhuo Lu
Add some new i218 devices. Signed-off-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_api.c | 4 drivers/net/e1000/base/e1000_defines.h | 2 ++ drivers/net/e1000/base/e1000_hw.h | 4 drivers/net/e1000/base/e1000_ich8lan.c | 18 ++ 4 files changed, 24

[dpdk-dev] [PATCH v3 04/36] e1000/base: fix issue with jumbo frame CRC failures in client

2015-10-16 Thread Wenzhuo Lu
This is a patch to change the value of register 776.20[11:2] for jumbo mode from 0x1A to 0x1F. This is to enlarge the gap between read and write pointers in the TX Fifo. And replace the magic number with a macro by the way. Signed-off-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_defines.h |

[dpdk-dev] [PATCH v3 03/36] e1000/base: fix issue with link flap on 82579

2015-10-16 Thread Wenzhuo Lu
Several customers have reported a link flap issue on 82579. The symptoms are random and intermittent link losses when 82579 is connected to specific switches. Issue has been root caused as interoperability problem between the NIC and at least some Broadcom PHYs in the Energy Efficient Ethernet

[dpdk-dev] [PATCH v3 05/36] e1000/base: redundant PHY power down for i210

2015-10-16 Thread Wenzhuo Lu
The wrong bit is being used in PHYREG16 for PHY power down. In addition, the use of PHYREG 16 is unnecessary if bit 11 of PHYREG 0 is used. Signed-off-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_phy.c | 15 --- drivers/net/e1000/base/e1000_phy.h | 1 - 2 files changed, 16

[dpdk-dev] [PATCH v3 06/36] e1000/base: add return value to the functions of setting receive address register

2015-10-16 Thread Wenzhuo Lu
Previously, the rar_set functions were of type void, and when they failed to program an address register they would, at most, put a message into the log and end. The fact that they failed to program an address into a address register, if checked for, should be captured and passed back to the

[dpdk-dev] [PATCH v3 07/36] e1000/base: add defaults for i210 TX/RX PBSIZE

2015-10-16 Thread Wenzhuo Lu
These are the defaults for the packet buffer size registers that need to be explicitly set back if someone changes them and comes back to a normal driver. Signed-off-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_defines.h | 2 ++ 1 file changed, 2 insertions(+) diff --git

[dpdk-dev] [PATCH v3 08/36] e1000/base: remove E1000_WRITE_FLUSH for DH89XXCC_SGMII after commencing HW reset

2015-10-16 Thread Wenzhuo Lu
For DH89XXCC_SGMII, write flush leaves registers of this device trashed (0x). Added check for this device. Also, after both for Port SW Reset and Device Reset case, platform should wait at least 3ms before reading any registers. Since waiting is conditionally executed only for Device Reset

[dpdk-dev] [PATCH v3 09/36] e1000/base: add evaluation of e1000_nvm_read return value

2015-10-16 Thread Wenzhuo Lu
Adding code to a case where e1000_nvn_read is called, but there is no consideration for when the read fails (returns an error code). Also, this patch adds an error message to a base NVM reading function that is missing it for consistency. This patch is not covering all cases of these conditions,

[dpdk-dev] [PATCH v3 10/36] e1000/base: change invariant return to not use variables

2015-10-16 Thread Wenzhuo Lu
Although this change should be optimized out by the compiler, just return a constant directly rather than declare a variable. Signed-off-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_82575.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git

[dpdk-dev] [PATCH v3 13/36] e1000/base: add support for inverted format ETrackId

2015-10-16 Thread Wenzhuo Lu
There are some images which contain ETrackID in inverted format. This patch allows reading this format. Signed-off-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_nvm.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/e1000/base/e1000_nvm.c

[dpdk-dev] [PATCH v3 12/36] e1000/base: add return value handler for ESB2 controller init and reset

2015-10-16 Thread Wenzhuo Lu
Adding code where missing to handle case where calls to e1000_read_kmrn_reg_80003es2lan and e1000_write_kmrn_reg_80003es2lan return an error value. Also, when accessing the E1000_KMRNCTRLSTA_INBAND_PARAM offset to disable far-end loopback on 80003es2lan devices, make the handling of a read or

[dpdk-dev] [PATCH v3 14/36] e1000/base: add EEARBC_I210 for i210

2015-10-16 Thread Wenzhuo Lu
EEARBC has changed on i210. It means EEARBC has a different address on i210 than on other NICs. So, add a new entity named EEARBC_I210 to the register list and make sure the right one is being used on i210. Signed-off-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_i210.c | 17 ++---

[dpdk-dev] [PATCH v3 15/36] e1000/base: apply paranoia to macro arguments

2015-10-16 Thread Wenzhuo Lu
Macro arguments need to be in parens since we can pass in expressions. Signed-off-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_api.h | 16 drivers/net/e1000/base/e1000_hw.h | 2 +- drivers/net/e1000/base/e1000_regs.h | 4 ++-- 3 files changed, 11 insertions(+), 11

[dpdk-dev] [PATCH v3 11/36] e1000/base: add return value handler when check manage mode

2015-10-16 Thread Wenzhuo Lu
Adding code, where missing, to handle the case when hw->nvm.ops.read returns an error value. Signed-off-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_82571.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/e1000/base/e1000_82571.c

[dpdk-dev] [PATCH v3 18/36] e1000/base: fix TIPG value for non 10 half duplex mode

2015-10-16 Thread Wenzhuo Lu
TIPG value is increased when setting speed to 10 half to prevent packet loss. However, it was never decreased again when speed changes. This caused performance issues in the NDIS driver. Fix this to restore TIPG to default value on non 10 half. Signed-off-by: Wenzhuo Lu ---

[dpdk-dev] [PATCH v3 19/36] e1000/base: add return value for resume workaround

2015-10-16 Thread Wenzhuo Lu
Add u32 return value to function e1000_resume_workarounds_pchlan, so that calling function can detect PHY access failure during resuming flow. Signed-off-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_ich8lan.c | 11 ++- drivers/net/e1000/base/e1000_ich8lan.h | 2 +- 2 files changed,

[dpdk-dev] [PATCH v3 20/36] e1000/base: fix link detect flow

2015-10-16 Thread Wenzhuo Lu
In case that auto-negotiate is not enabled, call e1000_setup_copper_link_generic instead of e1000_phy_setup_autoneg. Signed-off-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_ich8lan.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git

[dpdk-dev] [PATCH v3 17/36] e1000/base: prevent ulp flow if cable connected

2015-10-16 Thread Wenzhuo Lu
Enabling ulp on link down when cable is connect caused an infinite loop of linkup/down indications in the NDIS driver. After discussed, correct flow is to enable ULP only when cable is disconnected. Signed-off-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_ich8lan.c | 3 +++ 1 file changed, 3

[dpdk-dev] [PATCH v3 22/36] e1000/base: add bit for disable packetbuffer read

2015-10-16 Thread Wenzhuo Lu
Added bit FEXTNVM7[18], that controls disabling MAC packet buffer read. Signed-off-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_ich8lan.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/e1000/base/e1000_ich8lan.h b/drivers/net/e1000/base/e1000_ich8lan.h index

[dpdk-dev] [PATCH v3 23/36] e1000/base: K1 flow fixes

2015-10-16 Thread Wenzhuo Lu
This patch is for the following updates to the K1 configurations: Tx idle period for entering K1 should be 128 ns. Minimum Tx idle period in K1 should be 256 ns. Signed-off-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_ich8lan.c | 47 +-

[dpdk-dev] [PATCH v3 24/36] e1000/base: remove FIXME comment

2015-10-16 Thread Wenzhuo Lu
The "FIXME" comment is revomed from e1000_acquire_swfw_sync_80003es2lan but forgotten being removed from e1000_acquire_swfw_sync_82575 while the similar changes were made to both. Signed-off-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_82575.c | 2 +- 1 file changed, 1 insertion(+), 1

[dpdk-dev] [PATCH v3 25/36] e1000/base: set correct value of beacon duration

2015-10-16 Thread Wenzhuo Lu
Fix for I217 Packet Loss issue - The Management Engine sets the FEXTNVM4 Beacon Duration incorrectly. This fix ensures that the correct value will always be set. Correct value for this field is 8 usec. Signed-off-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_ich8lan.c | 14 ++ 1

[dpdk-dev] [PATCH v3 26/36] e1000/base: disable extension header parsing for IPv6

2015-10-16 Thread Wenzhuo Lu
All 1G Server products need to have IPv6 extension headers turned off. Signed-off-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_82575.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/e1000/base/e1000_82575.c b/drivers/net/e1000/base/e1000_82575.c

[dpdk-dev] [PATCH v3 27/36] e1000/base: fix for i354 88E1112 PHY using AutoMedia Detect

2015-10-16 Thread Wenzhuo Lu
e1000_check_for_link_media_swap() is supposed to check PHY page 0 for copper and PHY page 1 for "other" (fiber) link. We switched back from page 1 to page 0 too soon, before e1000_check_for_link_82575() is executed and we were never finding link on fiber (other). Note: The precedence of link type

[dpdk-dev] [PATCH v3 28/36] e1000/base: increase timeout of polling bit RSPCIPHY in check_reset_block

2015-10-16 Thread Wenzhuo Lu
Previously, in check_reset_block RSPCIPHY was polled for 100 ms before determining that the ME veto is set. This needed to be increased to 300 ms. Signed-off-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_ich8lan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v3 30/36] e1000/base: use the correct i210 register for EEMNGCTL

2015-10-16 Thread Wenzhuo Lu
The i210 has two EEPROM access registers that are located in non-standard offsets: EEARBC and EEMNGCTL. EEARBC was fixed previously and EEMNGCTL should also be corrected. Signed-off-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_i210.c | 30 ++

[dpdk-dev] [PATCH v3 31/36] e1000/base: move the print to the right position

2015-10-16 Thread Wenzhuo Lu
This info need not to be always printed. Move it into the if. Signed-off-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_phy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/base/e1000_phy.c b/drivers/net/e1000/base/e1000_phy.c index 6bbb379..d43b7ce

[dpdk-dev] [PATCH v3 32/36] e1000/base: synchronization of MAC-PHY interface only on non- ME systems

2015-10-16 Thread Wenzhuo Lu
On power up, the MAC - PHY interface needs to be set to PCIe, even if cable is disconnected. In ME systems, the ME handles this on exit from Sx(Sticky mode) state. In non-ME, the driver handles it. Added a check for non-ME system to the driver code that handles that. Signed-off-by: Wenzhuo Lu

[dpdk-dev] [PATCH v3 33/36] e1000/base: fix to enable both ulp and EEE in Sx state

2015-10-16 Thread Wenzhuo Lu
This patch implements a modified flow that allows both ULP and EEE in Sx(Sticky mode). Signed-off-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_ich8lan.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/e1000/base/e1000_ich8lan.c b/drivers/net/e1000/base/e1000_ich8lan.c

[dpdk-dev] [PATCH v3 34/36] e1000/base: some minor change

2015-10-16 Thread Wenzhuo Lu
Some minor code change. No functionality impact. Signed-off-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_ich8lan.c | 27 --- drivers/net/e1000/base/e1000_ich8lan.h | 1 + 2 files changed, 13 insertions(+), 15 deletions(-) diff --git

[dpdk-dev] [PATCH v3 35/36] e1000: add new devices

2015-10-16 Thread Wenzhuo Lu
Add the new e1000 devices to the DPDK PCI device list. Signed-off-by: Wenzhuo Lu --- lib/librte_eal/common/include/rte_pci_dev_ids.h | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/librte_eal/common/include/rte_pci_dev_ids.h b/lib/librte_eal/common/include/rte_pci_dev_ids.h index

[dpdk-dev] [PATCH v3 36/36] doc: update release notes for e1000 base code update

2015-10-16 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- doc/guides/rel_notes/release_2_2.rst | 22 ++ 1 file changed, 22 insertions(+) diff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.rst index 5687676..36a9d69 100644 --- a/doc/guides/rel_notes/release_2_2.rst +++

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-10-16 Thread Michael S. Tsirkin
On Fri, Oct 16, 2015 at 10:24:38AM +0800, Yuanhan Liu wrote: > On Thu, Oct 15, 2015 at 04:18:59PM +0300, Michael S. Tsirkin wrote: > > On Thu, Oct 15, 2015 at 02:08:39PM +0300, Marcel Apfelbaum wrote: > > > Make vhost-user virtio 1.0 compatible by adding it to the > > > supported features and

[dpdk-dev] Would you check if there is deadlock in rte_distributor_process() librte_distributor?

2015-10-16 Thread 최익성
Dear DPDK experts. Thank you very much for your excellent work and great contributions. I have a question about distributor library source code. /dpdk/lib/librte_distributor/rte_distributor.c In rte_distributor_process(), rte_distributor_process() { mbufs[] - d-backlog - d-bufs } =

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-10-16 Thread Yuanhan Liu
On Fri, Oct 16, 2015 at 09:20:18AM +0300, Michael S. Tsirkin wrote: > On Fri, Oct 16, 2015 at 10:24:38AM +0800, Yuanhan Liu wrote: > > On Thu, Oct 15, 2015 at 04:18:59PM +0300, Michael S. Tsirkin wrote: > > > On Thu, Oct 15, 2015 at 02:08:39PM +0300, Marcel Apfelbaum wrote: > > > > Make vhost-user

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-10-16 Thread Andriy Berestovskyy
Hi guys, Just a minor note: ARM is bi-endian in fact. For instance, there are both endians tool chains available on Linaro. Andriy On Fri, Oct 16, 2015 at 8:20 AM, Michael S. Tsirkin wrote: > On Fri, Oct 16, 2015 at 10:24:38AM +0800, Yuanhan Liu wrote: >> On Thu, Oct 15, 2015 at 04:18:59PM

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-10-16 Thread Yuanhan Liu
On Fri, Oct 16, 2015 at 09:43:09AM +0200, Andriy Berestovskyy wrote: > Hi guys, > Just a minor note: ARM is bi-endian in fact. Thank you for clarifying that my old memory is right :) --yliu > For instance, there are > both endians tool chains available on Linaro. > > Andriy > > > On

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-10-16 Thread Michael S. Tsirkin
On Fri, Oct 16, 2015 at 09:43:09AM +0200, Andriy Berestovskyy wrote: > Hi guys, > Just a minor note: ARM is bi-endian in fact. For instance, there are > both endians tool chains available on Linaro. > > Andriy Yea. BE support is around for legacy stuff. So I'm not sure it's all that important

[dpdk-dev] [RFC PATCH v2] vhost: Add VHOST PMD

2015-10-16 Thread Tetsuya Mukawa
On 2015/09/24 2:47, Loftus, Ciara wrote: >> The patch introduces a new PMD. This PMD is implemented as thin wrapper >> of librte_vhost. It means librte_vhost is also needed to compile the PMD. >> The PMD can have 'iface' parameter like below to specify a path to connect >> to a virtio-net device.

[dpdk-dev] DPDK patch backlog

2015-10-16 Thread Thomas Monjalon
2015-10-15 14:44, Stephen Hemminger: > There are currently 428 patches in New state in DPDK patchwork. > > Thomas, could you start reducing that backlog? Yes > The simplest solution would be to merge some of the big patch series > from Intel for the base drivers, then reviewers can focus on the

[dpdk-dev] Unsafe array accesses in rte_sched.c

2015-10-16 Thread Simon Kågström
Hi! I'm investigating DPDK support for pacing output streams and trying to understand the QoS framework. However, I quickly found some instances of unsafe array accesses. E.g., the rte_sched_port_config_qsize function looks like this: static void rte_sched_port_config_qsize(struct

[dpdk-dev] [PATCH 0/3] vhost: Fix virtio-net on VHOST_USER_RESET_OWNER

2015-10-16 Thread Jerome Jutteau
Hi, I have a bug when Qemu with two vhost interfaces gently stops (SIGINT). When stopping, it sends two RESET_OWNER for each interface: - Before stopping, we have two interfaces identifers: 0 and 1. - The first reset_owner call resets device 1 (and this id device_fh) to zero, the device list

[dpdk-dev] [PATCH 1/3] vhost: avoid device identifier to be reset to 0 in reset_owner

2015-10-16 Thread Jerome Jutteau
virtio-net clean and init device after a VHOST_USER_RESET_OWNER. This reset device identifier to 0 and break ll_root listing logic. This patch keep the old device identifier and re-write it on the cleaned device. Signed-off-by: Jerome Jutteau --- lib/librte_vhost/virtio-net.c | 3 +++ 1 file

[dpdk-dev] [PATCH 2/3] vhost: check that a device exists during reset_owner

2015-10-16 Thread Jerome Jutteau
virtio-net search for it's device in reset_owner. The function don't check the return result of get_config_ll_entry which can be NULL. Signed-off-by: Jerome Jutteau --- lib/librte_vhost/virtio-net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_vhost/virtio-net.c

[dpdk-dev] [PATCH 3/3] vhost: protect user_get_vring_base from unknown devices

2015-10-16 Thread Jerome Jutteau
get_device return is not checked and may cause segfault when device is not found. This patch fix this. Signed-off-by: Jerome Jutteau --- lib/librte_vhost/vhost_user/virtio-net-user.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_vhost/vhost_user/virtio-net-user.c

[dpdk-dev] [PATCH v6 0/9] Dynamic RSS Configuration for Bonding

2015-10-16 Thread Tomasz Kulasek
OVERVIEW 1) Setting .rxmode.mq_mode for bonding device to ETH_MQ_RX_RSS makes bonding device fully RSS-capable, so all slaves are synchronized with its configuration. This mode is intended to provide RSS configuration as known from "dynamic RSS configuration for one port" and made slaves

[dpdk-dev] [PATCH v6 1/9] bonding: rss dynamic configuration

2015-10-16 Thread Tomasz Kulasek
Bonding device implements independent management of RSS settings. It stores its own copies of settings i.e. RETA, RSS hash function and RSS key. It?s required to ensure consistency. 1) RSS hash function set for bonding device is maximal set of RSS hash functions supported by all bonded devices.

[dpdk-dev] [PATCH 0/4] RSS enhancement on Intel x550 NIC

2015-10-16 Thread Nélio Laranjeiro
On Mon, Sep 28, 2015 at 03:52:27PM +0800, Wenzhuo Lu wrote: > This patch set implements the RSS enhancement on x550. > The enhancement includes, the PF RSS redirection table is enlarged > from 128 entries to 512 entries, the VF doesn't share the same > registers with PF and per VF RSS redirection

[dpdk-dev] [PATCH v6 2/9] null: fix segfault when null_pmd added to bonding

2015-10-16 Thread Tomasz Kulasek
This patch initializes eth_dev->link_intr_cbs queue used when null pmd is added to the bonding. v5 changes: - removed unnecessary malloc for eth_driver (rte_null_pmd) Signed-off-by: Tomasz Kulasek --- drivers/net/null/rte_eth_null.c |2 ++ 1 file changed, 2 insertions(+) diff --git

[dpdk-dev] [PATCH v6 3/9] null: extend number of virtual queues

2015-10-16 Thread Tomasz Kulasek
This patch adds a possibility to configure more than one queue on null device. v5 changes: - fixed queues number configuration (using internals->nb_*_queues instead of dev->data->nb_*_queues) Signed-off-by: Tomasz Kulasek --- drivers/net/null/rte_eth_null.c | 28

[dpdk-dev] [PATCH v6 4/9] null: export eth_dev_null_create

2015-10-16 Thread Tomasz Kulasek
v6 changes: - reordered with patch 5/9 - fixed forward dependency to the patch 5/9 Signed-off-by: Tomasz Kulasek --- drivers/net/null/Makefile |2 +- drivers/net/null/rte_eth_null.c |4 ++- drivers/net/null/rte_eth_null.h | 40

[dpdk-dev] [PATCH v6 5/9] null: virtual dynamic rss configuration

2015-10-16 Thread Tomasz Kulasek
This implementation allows to set and read RSS configuration for null device, and is used to validate right values propagation over the slaves, in test units for dynamic RSS configuration for bonding. v6 changes: - reordered with patch 4/9 - recreated due to the changes in patch 4/9 v5

[dpdk-dev] [PATCH v6 6/9] test: dynamic rss configuration

2015-10-16 Thread Tomasz Kulasek
Signed-off-by: Tomasz Kulasek --- app/test/Makefile|8 + app/test/test_link_bonding_rssconf.c | 679 ++ 2 files changed, 687 insertions(+) create mode 100644 app/test/test_link_bonding_rssconf.c diff --git a/app/test/Makefile

[dpdk-dev] [PATCH v6 7/9] bonding: per queue stats

2015-10-16 Thread Tomasz Kulasek
This patch adds fills bonding port's stats with a sum of corresponding values taken from bonded slaves, when stats are requested for bonding port. v5 changes: - removed queue_stats_mapping_set from eth_dev_ops of bonding device Signed-off-by: Tomasz Kulasek ---

[dpdk-dev] [PATCH v6 8/9] doc: fixed spellings and typos

2015-10-16 Thread Tomasz Kulasek
Signed-off-by: Tomasz Kulasek --- .../prog_guide/link_bonding_poll_mode_drv_lib.rst |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst b/doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst index

[dpdk-dev] [PATCH v3 02/20] librte_ether: add fields from rte_pci_driver to rte_eth_dev_data

2015-10-16 Thread Iremonger, Bernard
Hi John, > > Subject: [dpdk-dev] [PATCH v3 02/20] librte_ether: add fields from ... > > > > lro : 1; /**< RX LRO is ON(1) / OFF(0) */ > > + uint32_t dev_flags; /**< Flags controlling handling of device. */ > > + enum rte_kernel_driver kdrv;/**< Kernel driver

[dpdk-dev] [PATCH v3 3/4] doc: add netronome nfp6000 guide

2015-10-16 Thread Alejandro.Lucero
From: "Alejandro.Lucero" Signed-off-by: Alejandro.Lucero Signed-off-by: Rolf.Neugebauer --- doc/guides/nics/index.rst |1 + doc/guides/nics/nfp.rst | 270 + 2 files changed, 271 insertions(+) create mode

[dpdk-dev] [PATCH v3 0/4] support for netronome nfp-6xxx card

2015-10-16 Thread Alejandro.Lucero
From: "Alejandro.Lucero" This patchset adds a new PMD for Netronome NFP-6xxx card along with a new UIO driver, documentation and minor changes to configuration scripts. V3: - Making all patches independent for applying and building - changing commits messages

[dpdk-dev] [PATCH v3 4/4] tools: add support for nfp_uio

2015-10-16 Thread Alejandro.Lucero
From: "Alejandro.Lucero" This patch adds support for using nfp_uio and therefore working with Netronome nfp6000 card. Signed-off-by: Alejandro.Lucero Signed-off-by: Rolf.Neugebauer --- tools/dpdk_nic_bind.py |8 ++-- tools/setup.sh | 122

[dpdk-dev] [PATCH v3 2/4] nfp-uio: new uio driver for netronome nfp6000 card

2015-10-16 Thread Alejandro.Lucero
From: "Alejandro.Lucero" This patch adds a new UIO kernel driver for supporting PCI VFs with Netronome nfp6000 card. Future PCI PF support will be based on changes to this module. Signed-off-by: Alejandro.Lucero Signed-off-by: Rolf.Neugebauer ---

[dpdk-dev] [PATCH v3 1/4] nfp: new poll mode driver for netronome nfp6000 card

2015-10-16 Thread Alejandro.Lucero
From: "Alejandro.Lucero" This patch adds a new PMD for using PCI Virtual Functions with Netronome nfp6000 card. Signed-off-by: Alejandro.Lucero Signed-off-by: Rolf.Neugebauer --- MAINTAINERS |9 + config/common_linuxapp

[dpdk-dev] [PATCH 1/5] eal: refactor plugin list append from eal_parse_args() to a helper function

2015-10-16 Thread Panu Matilainen
Signed-off-by: Panu Matilainen --- lib/librte_eal/linuxapp/eal/eal.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index 33e1067..cc66d9f 100644 ---

[dpdk-dev] [PATCH 2/5] eal: refactor plugin init from eal_parse_args() to a helper function

2015-10-16 Thread Panu Matilainen
Signed-off-by: Panu Matilainen --- lib/librte_eal/linuxapp/eal/eal.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index cc66d9f..d8a53e4 100644 ---

[dpdk-dev] [PATCH 3/5] eal: move plugin loading to eal/common

2015-10-16 Thread Panu Matilainen
There's no good reason to limit plugins to Linux, make it available on FreeBSD too. Signed-off-by: Panu Matilainen --- lib/librte_eal/bsdapp/eal/eal.c| 2 ++ lib/librte_eal/common/eal_common_options.c | 52 + lib/librte_eal/common/eal_options.h|

[dpdk-dev] [PATCH 4/5] eal: add an error code to plugin init for the next step

2015-10-16 Thread Panu Matilainen
Signed-off-by: Panu Matilainen --- lib/librte_eal/bsdapp/eal/eal.c| 3 ++- lib/librte_eal/common/eal_common_options.c | 3 ++- lib/librte_eal/common/eal_options.h| 2 +- lib/librte_eal/linuxapp/eal/eal.c | 3 ++- 4 files changed, 7 insertions(+), 4 deletions(-) diff

[dpdk-dev] [PATCH 5/5] eal: add support for driver directory concept

2015-10-16 Thread Panu Matilainen
Add a new EAL option -D for loading all drivers from a given directory. Additionally a default driver directory can be set in build-time configuration, in which case it will be always be used when EAL is initialized (but can be overridden or disabled with -D). This simplifies usage in shared

[dpdk-dev] [PATCH 1/5] eal: refactor plugin list append from eal_parse_args() to a helper function

2015-10-16 Thread Bruce Richardson
On Fri, Oct 16, 2015 at 02:58:13PM +0300, Panu Matilainen wrote: > Signed-off-by: Panu Matilainen > --- > lib/librte_eal/linuxapp/eal/eal.c | 28 +++- > 1 file changed, 19 insertions(+), 9 deletions(-) > > diff --git a/lib/librte_eal/linuxapp/eal/eal.c >

[dpdk-dev] [PATCH 4/5] eal: add an error code to plugin init for the next step

2015-10-16 Thread Bruce Richardson
On Fri, Oct 16, 2015 at 02:58:16PM +0300, Panu Matilainen wrote: > Signed-off-by: Panu Matilainen > --- > lib/librte_eal/bsdapp/eal/eal.c| 3 ++- > lib/librte_eal/common/eal_common_options.c | 3 ++- > lib/librte_eal/common/eal_options.h| 2 +- >

[dpdk-dev] Why rte_eal_ivshmem_obj_initd() does not add memory pools to rte_mempool_tailq list?

2015-10-16 Thread Burakov, Anatoly
Hi Mauricio > Dear DPDK community, > > Some time ago I was trying to map a memory pool into a guest using > IVSHMEM as described here: > > http://comments.gmane.org/gmane.comp.networking.dpdk.devel/17779 > > After some time I decided to review the code of eal_ivshmem.c, I noticed > that in the

[dpdk-dev] [PATCH v2 0/4] RSS enhancement on Intel x550 NIC

2015-10-16 Thread Wenzhuo Lu
This patch set implements the RSS enhancement on x550. The enhancement includes, the PF RSS redirection table is enlarged from 128 entries to 512 entries, the VF doesn't share the same registers with PF and per VF RSS redirection table is provided. V2: Condense the code. Add release notes.

[dpdk-dev] [PATCH v2 1/4] ixgbe: 512 entries RSS table on x550

2015-10-16 Thread Wenzhuo Lu
Comparing with the older NICs, x550's RSS redirection table is enlarged to 512 entries. As the original code is for the NICs which have a 128 entries RSS table, it means only part of the RSS table is set on x550. So, RSS cannot work as expected on x550, it doesn't redirect the packets evenly.

[dpdk-dev] [PATCH v2 3/4] ixgbe: VF RSS reta/hash query and update

2015-10-16 Thread Wenzhuo Lu
This patch implements the VF RSS reta/hash query and update function on 10G NICs. But the update function is only provided for x550. Because the other NICs don't have the separate registers for VF, we don't want to let a VF NIC change the shared RSS reta/hash registers. It may cause PF and other

[dpdk-dev] [PATCH v2 4/4] doc: release notes update for RSS enhancement

2015-10-16 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- doc/guides/rel_notes/release_2_2.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.rst index 5687676..d9d2a3d 100644 --- a/doc/guides/rel_notes/release_2_2.rst +++

[dpdk-dev] [PATCH 1/5] eal: refactor plugin list append from eal_parse_args() to a helper function

2015-10-16 Thread Panu Matilainen
On 10/16/2015 03:57 PM, Bruce Richardson wrote: > On Fri, Oct 16, 2015 at 02:58:13PM +0300, Panu Matilainen wrote: >> Signed-off-by: Panu Matilainen >> --- >> lib/librte_eal/linuxapp/eal/eal.c | 28 +++- >> 1 file changed, 19 insertions(+), 9 deletions(-) >> >> diff

[dpdk-dev] DPDK patch backlog

2015-10-16 Thread Lu, Wenzhuo
Hi Hemminger, +1 > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zhu, Heqing > Sent: Friday, October 16, 2015 10:47 AM > To: Stephen Hemminger; Thomas Monjalon > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] DPDK patch backlog > > +1 > > -Original

[dpdk-dev] [PATCH 4/5] eal: add an error code to plugin init for the next step

2015-10-16 Thread Panu Matilainen
On 10/16/2015 03:59 PM, Bruce Richardson wrote: > On Fri, Oct 16, 2015 at 02:58:16PM +0300, Panu Matilainen wrote: >> Signed-off-by: Panu Matilainen >> --- >> lib/librte_eal/bsdapp/eal/eal.c| 3 ++- >> lib/librte_eal/common/eal_common_options.c | 3 ++- >>

[dpdk-dev] Why rte_eal_ivshmem_obj_initd() does not add memory pools to rte_mempool_tailq list?

2015-10-16 Thread Mauricio Vásquez
Hi Anatoly, Thank you very much for your answer, it clarifies it for me. I absolutely agree with you that adding mempools support should not be implemented until a solution for mempool cache corruption is found. Mauricio, On 16 October 2015 at 15:00, Burakov, Anatoly wrote: > Hi Mauricio > >

[dpdk-dev] [PATCHv5 1/8] ethdev: add new API to retrieve RX/TX queue information

2015-10-16 Thread Bruce Richardson
On Wed, Oct 14, 2015 at 06:44:38PM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > > Sent: Wednesday, October 14, 2015 5:09 PM > > To: Ananyev, Konstantin > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev]

[dpdk-dev] Question about zero length segments in received mbuf

2015-10-16 Thread Tom Kiely
Hi, I am currently experiencing a serious issue and was hoping someone else might have encountered it. I have a KVM VM using two ixgbe interfaces A and B (configured to use PCI passthrough) and forwarding traffic from interface A via B. At about 4 million pps of 64 byte frames, the rx

[dpdk-dev] RSS API discussion

2015-10-16 Thread Lu, Wenzhuo
Hi N?lio, > Hi Wenzhuo, > > We should discuss about this API for a future release of DPDK because this one > lacks in flexibility. Some other NICs have indirection tables with a > different/configurable size, and the current API does not help to manage it. > > For ConnectX-4 I have made a lot

[dpdk-dev] Unsafe array accesses in rte_sched.c

2015-10-16 Thread Simon Kågström
On 2015-10-16 15:39, Dumitrescu, Cristian wrote: >> port->qsize_add[12] = port->qsize_add[11] + port->qsize[2]; >> port->qsize_add[13] = port->qsize_add[12] + port->qsize[3]; >> port->qsize_add[14] = port->qsize_add[13] + port->qsize[3]; >> port->qsize_add[15] =

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-10-16 Thread Bruce Richardson
On Thu, Oct 15, 2015 at 04:18:59PM +0300, Michael S. Tsirkin wrote: > On Thu, Oct 15, 2015 at 02:08:39PM +0300, Marcel Apfelbaum wrote: > > Make vhost-user virtio 1.0 compatible by adding it to the > > supported features and keeping the header length > > the same as for mergeable RX buffers. > >

[dpdk-dev] Question about zero length segments in received mbuf

2015-10-16 Thread Bruce Richardson
On Fri, Oct 16, 2015 at 02:32:15PM +0100, Tom Kiely wrote: > Hi, > I am currently experiencing a serious issue and was hoping someone else > might have encountered it. > > I have a KVM VM using two ixgbe interfaces A and B (configured to use PCI > passthrough) and forwarding traffic from

[dpdk-dev] DPDK patch backlog

2015-10-16 Thread Neil Horman
On Fri, Oct 16, 2015 at 10:45:23AM +0200, Thomas Monjalon wrote: > 2015-10-15 14:44, Stephen Hemminger: > > There are currently 428 patches in New state in DPDK patchwork. > > > > Thomas, could you start reducing that backlog? > > Yes > > > The simplest solution would be to merge some of the

[dpdk-dev] [PATCH v2 0/4] RSS enhancement on Intel x550 NIC

2015-10-16 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Friday, October 16, 2015 2:06 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2 0/4] RSS enhancement on Intel x550 NIC > > This patch set implements the RSS enhancement on x550. >

[dpdk-dev] RSS API discussion

2015-10-16 Thread Nélio Laranjeiro
On Fri, Oct 16, 2015 at 01:40:00PM +, Lu, Wenzhuo wrote: > Hi N?lio, > > > Hi Wenzhuo, > > > > We should discuss about this API for a future release of DPDK because this > > one > > lacks in flexibility. Some other NICs have indirection tables with a > > different/configurable size, and

[dpdk-dev] Unsafe array accesses in rte_sched.c

2015-10-16 Thread Stephen Hemminger
On Fri, 16 Oct 2015 15:50:55 +0200 Simon K?gstr?m wrote: > On 2015-10-16 15:39, Dumitrescu, Cristian wrote: > >> port->qsize_add[12] = port->qsize_add[11] + port->qsize[2]; > >> port->qsize_add[13] = port->qsize_add[12] + port->qsize[3]; > >> port->qsize_add[14] =

[dpdk-dev] [PATCH 2/2] uio: new driver to support PCI MSI-X

2015-10-16 Thread Stephen Hemminger
On Fri, 16 Oct 2015 19:11:35 +0200 Thomas Monjalon wrote: > To sum it up, > We want to remove the need of the out-of-tree module igb_uio. > 3 possible implementations were discussed so far: > - new UIO driver > - extend uio_pci_generic > - VFIO without IOMMU There is recent progress on VFIO

[dpdk-dev] [PATCH v4 1/7] mk: Add rule for installing headers

2015-10-16 Thread Olivier MATZ
Hi Mario, Thank you for this patch series, and thank you Panu for the good comments on this series. Please see some comments below. On 10/05/2015 10:20 PM, Mario Carrillo wrote: > Add hierarchy-file support to the DPDK headers. > > When invoking "make install-headers" headers will > be

[dpdk-dev] [PATCH v4 2/7] mk: Add rule for installing app files

2015-10-16 Thread Olivier MATZ
Hi Mario, On 10/05/2015 10:20 PM, Mario Carrillo wrote: > Add hierarchy-file support to the DPDK app files, > nic bind file and cpu layout file. > > When invoking "make install-bin" app files will > be installed in: $(DESTDIR)/$(BIN_DIR) > where BIN_DIR=/usr/bin by default. > > You can override

[dpdk-dev] [PATCH v4 5/7] mk: Add rule for installing documentation

2015-10-16 Thread Olivier MATZ
Hi Mario, On 10/05/2015 10:20 PM, Mario Carrillo wrote: > Add hierarchy-file support to the DPDK documentation. > > When invoking "make install-doc" documentation files will > be installed in: $(DESTDIR)/$(DOC_DIR) where > DOC_DIR=$(DESTDIR)/usr/share/doc/dpdk by default. > > You can override

[dpdk-dev] [PATCH v4 6/7] mk: Add rule for installing sdk files

2015-10-16 Thread Olivier MATZ
Hi Panu, On 10/05/2015 10:20 PM, Mario Carrillo wrote: > Add hierarchy-file support to the DPDK makefiles, scripts, > examples, tools, config files and headers. > > When invoking "make install-sdk" makefiles, scripts, > examples, tools, config files will be installed in: > $(DESTDIR)/$(SDK_DIR)

  1   2   >