[dpdk-dev] [PATCH] lib: move rte_ring read barrier to correct location

Hello, > > Hi Juhamatti, > > > > > > > > Hello, > > > > > > > > > > -Original Message- > > > > > > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of > > > > > > > Juhamatti Kuusisaari > > > > > > > Sent: Monday, July 11, 2016 11:21 AM > > > > > > > To: dev at dpdk.org > > > > > >

[dpdk-dev] Compiling DPDK is not working on Red Hat 6.7

It seems that the patch fixed the issue. Kindest regards Raslan Darawsheh -Original Message- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Tuesday, July 12, 2016 3:16 PM To: Raslan Darawsheh Cc: dev at dpdk.org; Christian Ehrhardt Subject: Re: [dpdk-dev] Compiling

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

On 12.07.2016 08:53, Ilya Maximets wrote: > On 12.07.2016 05:43, Yuanhan Liu wrote: >> On Mon, Jul 11, 2016 at 02:47:56PM +0300, Ilya Maximets wrote: >>> On 11.07.2016 14:05, Yuanhan Liu wrote: On Mon, Jul 11, 2016 at 12:50:24PM +0300, Ilya Maximets wrote: > On 11.07.2016 11:38, Yuanhan

[dpdk-dev] [PATCH 1/2] mk: clean up application linker flags

Make some cleaning before fixing the link dependency ordering in the next commit. - Move flags for creating a map file in the variable MAPFLAGS. - Make only one call to linkerprefix macro. - Group linker flags on the same line. Signed-off-by: Thomas Monjalon --- mk/rte.app.mk | 14

[dpdk-dev] Compiling DPDK is not working on Red Hat 6.7

2016-07-13 06:01, Raslan Darawsheh: > It seems that the patch fixed the issue. Thanks, I've sent the patches: http://dpdk.org/ml/archives/dev/2016-July/043917.html > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > 2016-07-12 11:35, Raslan

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

On Wed, Jul 13, 2016 at 10:34:07AM +0300, Ilya Maximets wrote: > On 12.07.2016 08:53, Ilya Maximets wrote: > > On 12.07.2016 05:43, Yuanhan Liu wrote: > >> On Mon, Jul 11, 2016 at 02:47:56PM +0300, Ilya Maximets wrote: > >>> On 11.07.2016 14:05, Yuanhan Liu wrote: > On Mon, Jul 11, 2016 at

[dpdk-dev] [PATCH v6 05/17] eal: introduce init macros

Hello Shreyansh, On Tue, 12 Jul 2016 11:31:10 +0530 Shreyansh Jain wrote: > Introduce a RTE_INIT macro used to mark an init function as a constructor. > Current eal macros have been converted to use this (no functional impact). > DRIVER_REGISTER_PCI is added as a helper for pci drivers. > >

[dpdk-dev] [PATCH] virtio: fix missing curly braces

GCC 6 is complaining and seems to be correct here. virtio_user_ethdev.c:345:2: error: this ?if? clause does not guard... [-Werror=misleading-indentation] if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) == 1) ^~ virtio_user_ethdev.c:348:3: note: ...this statement, but the

[dpdk-dev] [PATCH] virtio: fix missing curly braces

Hi Jan, On 07/13/2016 11:24 AM, Jan Viktorin wrote: > GCC 6 is complaining and seems to be correct here. > > virtio_user_ethdev.c:345:2: error: > this ?if? clause does not guard... [-Werror=misleading-indentation] >if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) == 1) >^~ > >

[dpdk-dev] Valgrind and DPDK

Hi All, Has some one successfully ran DPDK 16.04 with Valgrind (latest SVN copy)? I?m still getting issues even with running it without the RDRAND CPU flag. Thanks, Eelco

[dpdk-dev] [PATCH] net/i40e: revert VLAN filtering fix

This reverts commit 4761f57d58c6f52543738dbe299f846d62d75895. Introducing VLAN table by adding VLAN adminq command will cause NIC's throughput drop obviously. It's a hardware issue. With this revert, VLAN filtering can only work when promiscuous mode is disabled. Reverts: 4761f57d58c6 ("net/i40e:

[dpdk-dev] DPDK on Xen maintenance

On Di, 2016-07-12 at 11:34 +0200, Thomas Monjalon wrote: > Hi all, > > We are facing some issues with Xen dom0. > Some were fixed in RC2: > https://urldefense.proofpoint.com/v2/url?u=http-3A__dpdk.org_ml > _archives_dev_2016- > 2DJuly_043760.html=CwICAg=IL_XqQWOjubgfqINi2jTzg=eGq7Pg5OSP440n

[dpdk-dev] [PATCH] mempool: fix empty structure definition

This commit addresses the following warning reported by clang, which happens by default, as long as CONFIG_RTE_LIBRTE_MEMPOOL_DEBUG is disabled: warning: empty struct has size 0 in C, size 1 in C++ C and C++ must use the same size for objects to avoid corruption during run time. Fixes:

[dpdk-dev] [PATCH] lib: move rte_ring read barrier to correct location

Hi Juhamatti, > > Hello, > > > > Hi Juhamatti, > > > > > > > > > > > Hello, > > > > > > > > > > > > -Original Message- > > > > > > > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of > > > > > > > > Juhamatti Kuusisaari > > > > > > > > Sent: Monday, July 11, 2016 11:21 AM > > >

[dpdk-dev] [PATCH v4 00/10] Fix build errors related to exported headers

DPDK uses GNU C language extensions in most of its code base. This is fine for internal source files whose compilation flags are controlled by DPDK, however user applications that use exported "public" headers may experience compilation failures when enabling strict error/standard checks (-std and

[dpdk-dev] [PATCH v4 01/10] lib: work around braced-groups within expressions

Exported header files used by applications should allow the strictest compiler flags. Language extensions used in many places must be explicitly marked or removed to avoid warnings and compilation failures. This commit prevents the following errors: error: ISO C forbids braced-groups within

[dpdk-dev] [PATCH v4 02/10] lib: work around large enum values

Exported header files used by applications should allow the strictest compiler flags. Language extensions used in many places must be explicitly marked or removed to avoid warnings and compilation failures. This commit prevents the following errors: error: ISO C restricts enumerator values to

[dpdk-dev] [PATCH v4 03/10] lib: use C99 syntax for zero-size arrays

Exported header files used by applications should allow the strictest compiler flags. Language extensions used in many places must be explicitly marked or removed to avoid warnings and compilation failures. The extension keyword is used whenever the C99 syntax cannot do it. This commit prevents

[dpdk-dev] [PATCH v4 04/10] lib: work around nonstandard bit-fields

Exported header files used by applications should allow the strictest compiler flags. Language extensions used in many places must be explicitly marked or removed to avoid warnings and compilation failures. This commit prevents the following errors: error: type of bit-field `[...]' is a GCC

[dpdk-dev] [PATCH v4 05/10] lib: work around unnamed structs/unions

Exported header files used by applications should allow the strictest compiler flags. Language extensions used in many places must be explicitly marked to avoid warnings and compilation failures. Unnamed structs/unions are allowed since C11, however many compiler versions do not use this mode by

[dpdk-dev] [PATCH v4 06/10] lib: add missing include dependencies

Exported header files for use by applications should be self sufficient and allow out of order inclusion. Moreover, they must include all the system headers they need for types and macros. This commit prevents the following errors: error: `RTE_MAX_LCORE' undeclared here (not in a function)

[dpdk-dev] [PATCH v4 07/10] lib: work around forward reference to enum types

Exported header files used by applications should allow the strictest compiler flags. Language extensions used in many places must be explicitly marked or removed to avoid warnings and compilation failures. This commit prevents the following errors: error: ISO C forbids forward references to

[dpdk-dev] [PATCH v4 08/10] lib: remove named variadic macros in exported headers

Exported header files used by applications should allow the strictest compiler flags. Language extensions used in many places must be explicitly marked or removed to avoid warnings and compilation failures. Since there is no way to force named variadic macros as extensions, use a a standard

[dpdk-dev] [PATCH v4 09/10] lib: hide static functions never defined

Arch-specific functions not defined for all architectures (missing on x86 in this case) and not used anywhere should not expose a prototype. This commit prevents the following error: error: `rte_mov48' declared `static' but never defined Signed-off-by: Adrien Mazarguil ---

[dpdk-dev] [PATCH v4 10/10] scripts: check compilation of exported header files

This script checks that header files in a given directory do not miss dependencies when included on their own, do not conflict and accept being compiled with the strictest possible flags. Signed-off-by: Adrien Mazarguil --- MAINTAINERS | 1 + scripts/check-includes.sh | 286

[dpdk-dev] [PATCH] mempool: fix empty structure definition

On 07/13/2016 02:30 PM, Adrien Mazarguil wrote: > This commit addresses the following warning reported by clang, which > happens by default, as long as CONFIG_RTE_LIBRTE_MEMPOOL_DEBUG is disabled: > > warning: empty struct has size 0 in C, size 1 in C++ > > C and C++ must use the same size for

[dpdk-dev] [PATCH] net/mlx5: work around compilation issue

From: Olga Shern RHEL 7.1's GCC for POWER8 reports the following error in one rte_memcpy() macro call by mlx5: error: array subscript is above array bounds [-Werror=array-bounds] It appears to be a GCC bug which can be worked around by making parentheses more explicit.

[dpdk-dev] [PATCH] net/i40e: revert VLAN filtering fix

Hi, > -Original Message- > From: Wu, Jingjing > Sent: Wednesday, July 13, 2016 6:28 PM > To: Richardson, Bruce > Cc: dev at dpdk.org; Wu, Jingjing ; Shaw, Jeffrey B > ; Zhang, Helin ; Chen, > Jing D ; Ananyev, Konstantin > > Subject: [PATCH] net/i40e: revert VLAN filtering fix > > This

[dpdk-dev] [PATCH v2 0/2] doc: live migration procedure with vhost_user

This patchset describes the procedure to Live migrate a VM with Virtio PMD's with the vhost_user sample application (vhost-switch) running on the host. This patchset depends on the following patch: http://dpdk.org/dev/patchwork/patch/14625 Changes in v2: removed l2fwd information minor changes

[dpdk-dev] [PATCH v2 1/2] doc: live migration of VM with vhost_user on host

This patch describes the procedure to be be followed to perform Live Migration of a VM with Virtio PMD running on a host which is running the vhost_user sample application (vhost-switch). It includes sample host and VM scripts used in the procedure. Signed-off-by: Bernard Iremonger ---

[dpdk-dev] [PATCH v2 2/2] doc: add vhost_user live migration image

This patch adds an image of the Live Migration of a VM using vhost_user on the host, test configuration. Signed-off-by: Bernard Iremonger --- doc/guides/howto/img/lm_vhost_user.svg| 644 ++ doc/guides/howto/lm_virtio_vhost_user.rst | 4 + 2 files changed, 648

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

On Wednesday, July 13, 2016, Yuanhan Liu wrote: > On Wed, Jul 13, 2016 at 10:34:07AM +0300, Ilya Maximets wrote: > > This scenario fixed somehow, I agree. But this patch still needed to > protect > > vhost from untrusted VM, from malicious or buggy virtio application. > > Maybe we could change

[dpdk-dev] [PATCH v1 1/1] examples/l2fwd-crypto: improve random key generator

On 07/11/2016 03:17 PM, Thomas Monjalon wrote: > 2016-06-08 07:46, Azarewicz, PiotrX T: >>> 2016-05-25 15:34, Piotr Azarewicz: This patch improve generate_random_key() function by replacing rand() function with reading from /dev/urandom. CID 120136 : Calling risky function

[dpdk-dev] [PATCH v1 1/1] examples/l2fwd-crypto: improve random key generator

On 05/25/2016 02:34 PM, Piotr Azarewicz wrote: > This patch improve generate_random_key() function by replacing rand() > function with reading from /dev/urandom. > > CID 120136 : Calling risky function (DC.WEAK_CRYPTO) > dont_call: rand should not be used for security related applications, as >

[dpdk-dev] [PATCH 1/3] pdump: fix error handlings

The changes include 1)If mkdir fails for user passed socket paths log error and return. 2)At some places return value was set to errno and that non-negative number was returned, but the intention was to return negative value. So now rte_errno was set to errno and returning the actual negative

[dpdk-dev] [PATCH 3/3] doc: fix default socket path names

Fixed default socket path name "/var/run" to "/var/run/.dpdk" and "$HOME" to "~/.dpdk". Fixes: 278f945402c5 ("pdump: add new library for packet capture") Signed-off-by: Reshma Pattan --- doc/guides/prog_guide/pdump_lib.rst | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[dpdk-dev] [PATCH 0/3] add new command line options and error handling in pdump

This patch set contains 1)Error handling fixes in pdump library. 2)Support of server and client socket path command line options in pdump tool. 3)Default socket path name fixes in pdump library doc. Reshma Pattan (3): pdump: fix error handlings app/pdump: add new command line options for

[dpdk-dev] [PATCH 2/3] app/pdump: add new command line options for socket paths

Since users of the pdump library and tool can chose to have their own server and client paths, it is must for the pdump tool to use the same server socket path that was used by primary application while initializing packet capture framework by rte_pdump_init() or rte_pdump_set_socket_dir() APIs.

[dpdk-dev] [PATCH] net/enic: fix calculation of truncated packets

The calculation of truncated packets didn't take into account packet errors due to the adapter not having buffers, causing both the ipackets, and imissed counts to be wrong if such errors occurred. In order to properly calculate the number of packets truncated, we need to subtract the count of

[dpdk-dev] [PATCH v6 05/17] eal: introduce init macros

On Wed, 13 Jul 2016 11:20:43 +0200 Jan Viktorin wrote: > Hello Shreyansh, > > On Tue, 12 Jul 2016 11:31:10 +0530 > Shreyansh Jain wrote: > > > Introduce a RTE_INIT macro used to mark an init function as a constructor. > > Current eal macros have been converted to use this (no functional

[dpdk-dev] [PATCH] virtio: fix missing curly braces

On Wed, 13 Jul 2016 11:27:18 +0200 Maxime Coquelin wrote: > Hi Jan, > > On 07/13/2016 11:24 AM, Jan Viktorin wrote: > > GCC 6 is complaining and seems to be correct here. > > > > virtio_user_ethdev.c:345:2: error: > > this ?if? clause does not guard... [-Werror=misleading-indentation] > >

[dpdk-dev] [PATCH] virtio: fix missing curly braces

On Wed, 13 Jul 2016 11:27:18 +0200 Maxime Coquelin wrote: > Hi Jan, > > On 07/13/2016 11:24 AM, Jan Viktorin wrote: > > GCC 6 is complaining and seems to be correct here. > > > > virtio_user_ethdev.c:345:2: error: > > this ?if? clause does not guard... [-Werror=misleading-indentation] > >

[dpdk-dev] [dpdk-users] Intel X710 dropping 802.1ad packets?

I sent this to dpdk-users, but maybe dpdk-dev is a better target list? Thanks, Sean >Hello, > >I am seeing a problem with receiving 802.1ad packets on an intel X710 >card, running the 16.04 dpdk release. All the 802.1ad packets are silently >dropped. The port is in promiscuous mode. As far as

[dpdk-dev] [PATCH] doc: fix mailing list address typo.

The correct mailing list dev at dpdk.org, not dev at dpkg.org. Signed-off-by: Jeff Shaw --- doc/guides/contributing/patches.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst index 06af91d..16a21a5

[dpdk-dev] [RFC] Generic flow director/filtering/classification API

On Mon, Jul 11, 2016 at 10:42:36AM +, Chandran, Sugesh wrote: > Hi Adrien, > > Thank you for your response, > Please see my comments inline. Hi Sugesh, Sorry for the delay, please see my answers inline as well. [...] > > > > Flow director > > > > - > > > > > > > > Flow director

[dpdk-dev] [PATCH] virtio: fix missing curly braces

On 07/13/2016 07:42 PM, Jan Viktorin wrote: > On Wed, 13 Jul 2016 11:27:18 +0200 > Maxime Coquelin wrote: > >> Hi Jan, >> >> On 07/13/2016 11:24 AM, Jan Viktorin wrote: >>> GCC 6 is complaining and seems to be correct here. >>> >>> virtio_user_ethdev.c:345:2: error: >>> this ?if? clause

[dpdk-dev] 16.07-rc2 issue with rte_rtm_init(void) constructor

Folks, I have issues with linking application to 16.07-rc2. Looks like reason is constructor function in include file, so our unit test apps are failing to link as they are not linked with dpdk libs. (and they should not be as they are not calling any dpdk function). static inline void

[dpdk-dev] [PATCH] net/enic: fix segfault after receiving error interrupt

When enic's interrupt handler is called indicating an error, it scans through the receive queues (RQs) on the adapter looking for errors. But since the inclusion of rx scatter, some of the RQs may not be in use, and you shouldn't check them for errors. Fixes: 856d7ba7ed22 ("net/enic: support