[dpdk-dev] spinlock: Move constructor function out of header file

2016-07-15 Thread Thomas Monjalon
2016-07-14 18:10, Damjan Marion: > Dear Jan, > > Thank you for your comments. A bit too much overhead to submit simple patch > so let?s forget about it. I will just add it as it is to our private > collection of patches. These are changes trivial to fix when applying. I strongly prefer that you

[dpdk-dev] net/virtio-user: Fix missing brackets in if condition

2016-07-15 Thread Yuanhan Liu
On Thu, Jul 14, 2016 at 06:31:11PM +0200, viktorin at rehivetech.com wrote: > On Tue, 12 Jul 2016 11:30:25 +0200 > Maxime Coquelin wrote: > > > The error is reported using test build script: > > I recommend to note that the error is reported only by GCC 6+. Agreed! --yliu > > > > >

[dpdk-dev] [PATCH] EAL:fix memory barrier implementation on IBM POWER

2016-07-15 Thread Chao Zhu
On weak memory order architecture like POWER, rte_smp_wmb/rte_smp_rmb need to use CPU instructions, not compiler barrier. This patch fixes this. Also, to improve performance on PPC64, use light weight sync instruction instead of sync instruction. Signed-off-by: Chao Zhu ---

[dpdk-dev] [PATCH v2 0/6] enable lpm, acl and other missing libraries in ppc64le

2016-07-15 Thread Chao Zhu
Gowrishankar, When I tried the patches, I got some compilation error: In file included from /root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.c:34:0: /root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h: In function 'transition4': /root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h:198:2:

[dpdk-dev] [PATCH] lib: change rte_ring dequeue to guarantee ordering before tail update

2016-07-15 Thread Juhamatti Kuusisaari
Consumer queue dequeuing must be guaranteed to be done fully before the tail is updated. This is not guaranteed with a read barrier, changed to a write barrier just before tail update which in practice guarantees correct order of reads and writes. Signed-off-by: Juhamatti Kuusisaari ---

[dpdk-dev] [PATCH] lib: move rte_ring read barrier to correct location

2016-07-15 Thread Kuusisaari, Juhamatti
Hi Konstantin, > Hi Juhamatti, > > > > > Hi Konstantin, > > > > > > > > > It is quite safe to move the barrier before DEQUEUE because > > > > > > > after the DEQUEUE there is nothing really that we would want > > > > > > > to protect > > > with a > > > > > read barrier. > > > > > > > > > > > >

[dpdk-dev] capture packets on VM

2016-07-15 Thread Raja Jayapal
Hi All, I have installed dpdk on VM and would like to know how to capture the packets on dpdk ports. I am sending traffic from host? and want to know how to confirm whether the packets are flowing via dpdk ports. I tried with tcpdump and wireshark but could not capture the packets inside VM.

[dpdk-dev] [PATCH v2] vhost: fix segfault on bad descriptor address

2016-07-15 Thread Yuanhan Liu
On Thu, Jul 14, 2016 at 11:18:39AM +0300, Ilya Maximets wrote: > In current implementation vhost will crash with segmentation fault > if malicious or buggy virtio application breaks addresses of descriptors. > > Before commit 0823c1cb0a73 this crash was reproducible even with > normal DPDK

[dpdk-dev] [PATCH] lib: move rte_ring read barrier to correct location

2016-07-15 Thread Jerin Jacob
On Thu, Jul 14, 2016 at 12:56:11PM +, Ananyev, Konstantin wrote: > > > > The CPU also > > knows already the value that will be written to cons.tail and that value > > does not depend on the previous read either. The CPU does not > > know we are planning to do a spinlock there, so it might

[dpdk-dev] [PATCH v2] vhost: fix segfault on bad descriptor address

2016-07-15 Thread Ilya Maximets
On 15.07.2016 09:17, Yuanhan Liu wrote: > On Thu, Jul 14, 2016 at 11:18:39AM +0300, Ilya Maximets wrote: >> In current implementation vhost will crash with segmentation fault >> if malicious or buggy virtio application breaks addresses of descriptors. >> >> Before commit 0823c1cb0a73 this crash

[dpdk-dev] [PATCH] spinlock:move constructor function out of header

2016-07-15 Thread Thomas Monjalon
2016-07-14 22:45, Wiles, Keith: > > On Jul 14, 2016, at 2:59 PM, Thomas Monjalon > > wrote: > > > > Thanks Keith for continuing work. > > > > 2016-07-14 14:31, Keith Wiles: > >> lib/librte_eal/bsdapp/eal/Makefile | 1 + > >> lib/librte_eal/common/arch/arm/rte_spinlock.c |

[dpdk-dev] spinlock: Move constructor function out of header file

2016-07-15 Thread Thomas Monjalon
2016-07-14 22:20, Damjan Marion: > > > On 15 Jul 2016, at 00:06, Thomas Monjalon > > wrote: > > > > 2016-07-14 18:10, Damjan Marion: > >> Dear Jan, > >> > >> Thank you for your comments. A bit too much overhead to submit simple patch > >> so let?s forget about it. I will just add it as it is

[dpdk-dev] [PATCH v2] vhost: fix segfault on bad descriptor address

2016-07-15 Thread Yuanhan Liu
On Fri, Jul 15, 2016 at 10:23:12AM +0300, Ilya Maximets wrote: > On 15.07.2016 09:17, Yuanhan Liu wrote: > > On Thu, Jul 14, 2016 at 11:18:39AM +0300, Ilya Maximets wrote: > >> In current implementation vhost will crash with segmentation fault > >> if malicious or buggy virtio application breaks

[dpdk-dev] [RFC] remove vhost-cuse

2016-07-15 Thread Yuanhan Liu
You see that no body cares it :) So I will make a patch to mark vhost-cuse as deprecated shortly. Thomas, works to you? --yliu On Mon, Jul 11, 2016 at 11:59:55AM +0800, Yuanhan Liu wrote: > It's something echoed around in my mind for a long while, and here I'm > gonna make it public: a

[dpdk-dev] [RFC] remove vhost-cuse

2016-07-15 Thread Thomas Monjalon
2016-07-15 16:42, Yuanhan Liu: > You see that no body cares it :) > > So I will make a patch to mark vhost-cuse as deprecated shortly. > Thomas, works to you? Perfect. Thanks Yuanhan > On Mon, Jul 11, 2016 at 11:59:55AM +0800, Yuanhan Liu wrote: > > It's something echoed around in my mind for

[dpdk-dev] [PATCH] app/testpmd: fix redundant time update

2016-07-15 Thread Reshma Pattan
Inside flush_fwd_rx_queues removed redundant prev_tsc update with cur_tsc, as prev_tsc value is always updated with rte_rdtsc() in for loop. Coverity issue: 127797 Fixes: f487715f36f5 ("app/testpmd: add timeout in Rx queue flushing") Signed-off-by: Reshma Pattan --- app/test-pmd/testpmd.c | 1

[dpdk-dev] [RFC] Generic flow director/filtering/classification API

2016-07-15 Thread Chandran, Sugesh
Thank you Adrien, Please find below for some more comments/inputs Let me know your thoughts on this. Regards _Sugesh > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com] > Sent: Wednesday, July 13, 2016 9:03 PM > To: Chandran, Sugesh > Cc: dev at

[dpdk-dev] [PATCH] doc: fix consumer/producer mixup in Ring lib doc

2016-07-15 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Shreyansh Jain > Sent: Tuesday, July 12, 2016 10:45 AM > To: olivier.matz at 6wind.com > Cc: dev at dpdk.org; thomas.monjalon at 6wind.com > Subject: [dpdk-dev] [PATCH] doc: fix consumer/producer mixup in Ring

[dpdk-dev] [PATCH v6 12/17] pci: add a helper for device name

2016-07-15 Thread Shreyansh jain
On Thursday 14 July 2016 10:25 PM, Jan Viktorin wrote: > On Tue, 12 Jul 2016 11:31:17 +0530 > Shreyansh Jain wrote: > >> eal is a better place than crypto / ethdev for naming resources. > > s/for naming/to name/ OK. > > What is meant by "resources" here? This has historic context (from

[dpdk-dev] [PATCH v6 13/17] pci: add a helper to update a device

2016-07-15 Thread Shreyansh jain
On Thursday 14 July 2016 10:31 PM, Jan Viktorin wrote: > On Tue, 12 Jul 2016 11:31:18 +0530 > Shreyansh Jain wrote: > >> This helper updates a pci device object with latest information it can >> find. >> It will be used mainly for hotplug code. >> >> Signed-off-by: David Marchand >>

[dpdk-dev] [PATCH v6 15/17] eal: add hotplug operations for pci and vdev

2016-07-15 Thread Shreyansh jain
On Thursday 14 July 2016 10:20 PM, Jan Viktorin wrote: > On Tue, 12 Jul 2016 11:31:20 +0530 > Shreyansh Jain wrote: > >> Hotplug which deals with resources should come from the layer that already >> handles them, i.e. EAL. >> >> For both attach and detach operations, 'name' is used to select the

[dpdk-dev] spinlock: Move constructor function out of header file

2016-07-15 Thread Damjan Marion (damarion)
> On 15 Jul 2016, at 10:31, Thomas Monjalon > wrote: > > 2016-07-14 22:20, Damjan Marion: >> >>> On 15 Jul 2016, at 00:06, Thomas Monjalon >>> wrote: >>> >>> 2016-07-14 18:10, Damjan Marion: Dear Jan, Thank you for your comments. A bit too much overhead to submit simple

[dpdk-dev] [PATCH v6 12/17] pci: add a helper for device name

2016-07-15 Thread Thomas Monjalon
2016-07-15 15:09, Shreyansh jain: > On Thursday 14 July 2016 10:25 PM, Jan Viktorin wrote: > > What is meant by "resources" here? > > This has historic context (from earlier version of this patch). > But I could relate the word 'resources' to EAL representation of devices - > whether PCI or

[dpdk-dev] [PATCH v6 12/17] pci: add a helper for device name

2016-07-15 Thread Jan Viktorin
On Fri, 15 Jul 2016 15:09:58 +0530 Shreyansh jain wrote: > On Thursday 14 July 2016 10:25 PM, Jan Viktorin wrote: > > On Tue, 12 Jul 2016 11:31:17 +0530 > > Shreyansh Jain wrote: > > > >> eal is a better place than crypto / ethdev for naming resources. > > > > s/for naming/to name/ > >

[dpdk-dev] [PATCH] app/testpmd: fix redundant time update

2016-07-15 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Reshma Pattan > Sent: Friday, July 15, 2016 10:19 AM > To: dev at dpdk.org > Cc: Pattan, Reshma > Subject: [dpdk-dev] [PATCH] app/testpmd: fix redundant time update > > Inside flush_fwd_rx_queues removed

[dpdk-dev] [PATCH] examples/distributor: fix Rx thread logic for zero packets

2016-07-15 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Reshma Pattan > Sent: Thursday, July 14, 2016 4:49 PM > To: dev at dpdk.org > Cc: Pattan, Reshma > Subject: [dpdk-dev] [PATCH] examples/distributor: fix Rx thread logic for zero > packets > > From: Reshma

[dpdk-dev] [RFC] Generic flow director/filtering/classification API

2016-07-15 Thread Chilikin, Andrey
Hi Sugesh, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Chandran, Sugesh > Sent: Friday, July 15, 2016 10:23 AM > To: 'Adrien Mazarguil' > > > > To PMD maintainers: please comment if you know devices that > > > > support tagging matching packets with

[dpdk-dev] spinlock: Move constructor function out of header file

2016-07-15 Thread Thomas Monjalon
2016-07-15 09:54, Damjan Marion: > So we don?t have much pending beside 2 patches for i40e which > Jeff submitted yesterday and they will i guess need to wait for 16.11. Yes these i40e patches will probably have to wait 16.11. > Only one which I have on my mind is: > >

[dpdk-dev] [PATCH 1/2] bnx2x: disable fast path interrupts

2016-07-15 Thread Chas Williams
On Thu, 2016-07-14 at 10:03 -0700, Rasesh Mody wrote: > Disable fastpath interrupts and remove unneeded delay in > bnx2x_interrupt_action(). This patch fixes and prevents performance > degradation for BNX2X PMD. > > Fixes: 540a2110 ("bnx2x: driver core") > > Signed-off-by: Rasesh Mody >? > diff

[dpdk-dev] [PATCH] lib: move rte_ring read barrier to correct location

2016-07-15 Thread Ananyev, Konstantin
Hi Jerin, > > > > > > > The CPU also > > > knows already the value that will be written to cons.tail and that > > > value does not depend on the previous read either. The CPU does not know > > > we are planning to do a spinlock there, so it might do things > out-of-order without proper

[dpdk-dev] [PATCH v6 16/17] ethdev: convert to eal hotplug

2016-07-15 Thread Shreyansh jain
On Thursday 14 July 2016 10:21 PM, Jan Viktorin wrote: > On Tue, 12 Jul 2016 11:31:21 +0530 > Shreyansh Jain wrote: > >> Remove bus logic from ethdev hotplug by using eal for this. >> >> Current api is preserved: >> - the last port that has been created is tracked to return it to the >>

[dpdk-dev] [PATCH] net/fm10k: fix FTAG mode on multi-queue

2016-07-15 Thread Xiao Wang
In multi-queue + FTAG use case, we need to turn tx_ftag_en on for all the Tx queues. Fixes: 7958b1310d5e ("fm10k: enable FTAG based forwarding") Reported-by: Ricky Li Signed-off-by: Xiao Wang --- drivers/net/fm10k/fm10k_ethdev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

[dpdk-dev] [PATCH] mk: fix default rule of test subdirectory

2016-07-15 Thread Pattan, Reshma
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, July 12, 2016 11:22 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] mk: fix default rule of test subdirectory > > When using "make -C app/test" (with RTE_SDK/RTE_TARGET

[dpdk-dev] [PATCH v6 05/17] eal: introduce init macros

2016-07-15 Thread Shreyansh jain
On Thursday 14 July 2016 09:27 PM, Jan Viktorin wrote: > On Thu, 14 Jul 2016 10:57:55 +0530 > Shreyansh jain wrote: > >> Hi Jan, >> >> On Wednesday 13 July 2016 11:04 PM, Jan Viktorin wrote: >>> On Wed, 13 Jul 2016 11:20:43 +0200 >>> Jan Viktorin wrote: >>> Hello Shreyansh, On

[dpdk-dev] [PATCH v3 1/2] doc: live migration of VM with Virtio and VF

2016-07-15 Thread Mcnamara, John
> -Original Message- > From: Iremonger, Bernard > Sent: Thursday, July 7, 2016 11:43 AM > To: Mcnamara, John ; dev at dpdk.org > Cc: Liu, Yong ; Xu, Qian Q ; > Iremonger, Bernard > Subject: [PATCH v3 1/2] doc: live migration of VM with Virtio and VF > > This patch describes the procedure

[dpdk-dev] [PATCH 2/2] doc: add vhost_user live migration image

2016-07-15 Thread Mcnamara, John
> -Original Message- > From: Iremonger, Bernard > Sent: Monday, July 11, 2016 4:05 PM > To: Mcnamara, John ; dev at dpdk.org > Cc: Liu, Yong ; Xu, Qian Q ; > yuanhan.liu at linux.intel.com; Iremonger, Bernard > > Subject: [PATCH 2/2] doc: add vhost_user live migration image > > This

[dpdk-dev] dpdk daily build error on dpdk16.07-rc2

2016-07-15 Thread Liu, Yu Y
Hi Jan, Any update on ena related error? Thanks, Yu Liu From: Gu, YongjieX Sent: Thursday, July 14, 2016 5:23 PM To: thomas.monjalon at 6wind.com; Richardson, Bruce ; Yigit, Ferruh ; Gonzalez Monroy, Sergio ; Jan Medala ; dev at dpdk.org Cc: Cao, Waterman ; Liu, Yu Y ; Chen, WeichunX ; Xu,

[dpdk-dev] [PATCH v3 0/2] vhost: fix segfault on bad descriptor address

2016-07-15 Thread Ilya Maximets
Version 3: * Patch splitted in two. * Applied workaround from Rich Lane and added comment about performance issue with some compilers and 'unlikely' macro. Version 2: * Rebased on top of current master. * host's address now checked in meargeable case,

[dpdk-dev] [PATCH v3 1/2] vhost: fix using of bad return value on mergeable enqueue

2016-07-15 Thread Ilya Maximets
Return value on error changed from '-1' to '0' because it returns unsigned value and it means number of used descriptors. Also fixed updating of 'last_used_idx' by using actual number of used descriptors. Fixes: 623bc47054d0 ("vhost: do sanity check for ring descriptor length") Signed-off-by:

[dpdk-dev] [PATCH v3 2/2] vhost: do sanity check for ring descriptor address

2016-07-15 Thread Ilya Maximets
In current implementation vhost will crash with segmentation fault if malicious or buggy virtio application breaks addresses of descriptors. Before commit 0823c1cb0a73 ("vhost: workaround stale vring base") this crash was reproducible even with normal DPDK application that tries to change number

[dpdk-dev] dpdk daily build error on dpdk16.07-rc2

2016-07-15 Thread Jan Mędala
Hello Yu Liu, I've sent second version of patch to test on icc16 compiler, Yongjie is helping me to test issues on icc. Jan

[dpdk-dev] [PATCH v6 16/17] ethdev: convert to eal hotplug

2016-07-15 Thread Jan Viktorin
On Fri, 15 Jul 2016 16:06:25 +0530 Shreyansh jain wrote: > On Thursday 14 July 2016 10:21 PM, Jan Viktorin wrote: > > On Tue, 12 Jul 2016 11:31:21 +0530 > > Shreyansh Jain wrote: > > > >> Remove bus logic from ethdev hotplug by using eal for this. > >> > >> Current api is preserved: > >> -

[dpdk-dev] [PATCH v3 1/2] doc: live migration of VM with Virtio and VF

2016-07-15 Thread Iremonger, Bernard
Hi John, > > Subject: [PATCH v3 1/2] doc: live migration of VM with Virtio and VF > > > > This patch describes the procedure to be be followed to perform Live > > Migration of a VM with Virtio and VF PMD's using the bonding PMD. > > > > It includes sample host and VM scripts used in the

[dpdk-dev] [PATCH v6 12/17] pci: add a helper for device name

2016-07-15 Thread Jan Viktorin
On Fri, 15 Jul 2016 11:56:38 +0200 Thomas Monjalon wrote: > 2016-07-15 15:09, Shreyansh jain: > > On Thursday 14 July 2016 10:25 PM, Jan Viktorin wrote: > > > What is meant by "resources" here? > > > > This has historic context (from earlier version of this patch). > > But I could relate

[dpdk-dev] [PATCH v3 0/2] vhost: fix segfault on bad descriptor address

2016-07-15 Thread Yuanhan Liu
On Fri, Jul 15, 2016 at 02:15:03PM +0300, Ilya Maximets wrote: > Version 3: > * Patch splitted in two. > * Applied workaround from Rich Lane and added comment about > performance issue with some compilers and 'unlikely' macro. Thanks a lot for the patches. Acked-by: Yuanhan

[dpdk-dev] [PATCH] lib: change rte_ring dequeue to guarantee ordering before tail update

2016-07-15 Thread Ananyev, Konstantin
> > Consumer queue dequeuing must be guaranteed to be done fully before the tail > is updated. This is not guaranteed with a read barrier, > changed to a write barrier just before tail update which in practice > guarantees correct order of reads and writes. > > Signed-off-by: Juhamatti

[dpdk-dev] [PATCH] doc: deprecate vhost-cuse

2016-07-15 Thread Yuanhan Liu
Vhost-cuse was invented before vhost-user exist. The both are actually doing the same thing: a vhost-net implementation in user space. But they are not exactly the same thing. Firstly, vhost-cuse is harder for use; no one seems to care it, either. Furthermore, since v2.1, a large majority of

[dpdk-dev] [RFC] remove vhost-cuse

2016-07-15 Thread Yuanhan Liu
On Fri, Jul 15, 2016 at 11:14:52AM +0200, Thomas Monjalon wrote: > 2016-07-15 16:42, Yuanhan Liu: > > You see that no body cares it :) > > > > So I will make a patch to mark vhost-cuse as deprecated shortly. > > Thomas, works to you? > > Perfect. Thanks Yuanhan Great! deprecate note has been

[dpdk-dev] [PATCH v6 05/17] eal: introduce init macros

2016-07-15 Thread Thomas Monjalon
Hi guys, 2016-07-15 16:18, Shreyansh jain: > On Thursday 14 July 2016 09:27 PM, Jan Viktorin wrote: > > Please. The time is almost gone. 18/7/2016 is the release (according > > to the roadmap)... I have to fix it in my patchset, otherwise it > > does not build (after moving the .name from

[dpdk-dev] capture packets on VM

2016-07-15 Thread Matt Laswell
Hey Raja, When you bind the ports to the DPDK poll mode drivers, the kernel no longer has visibility into them. This makes some sense intuitively - it would be very bad for both the kernel and a user mode application to both attempt to control the ports. This is why tools like tcpdump and

[dpdk-dev] [PATCH v2] vfio: fix pci_vfio_map_resource

2016-07-15 Thread Burakov, Anatoly
> The offset of the 2nd mmap() when mapping the region after msix_bar > needs to take region address into consideration as mmap() takes address > that is resource-relative instead of bar-relative. This is exposed when > binding vmxnet3 to vfio-pci. > > Fixes: 90a1633b2347 ("eal/linux: allow to

[dpdk-dev] [PATCH v6 12/17] pci: add a helper for device name

2016-07-15 Thread Shreyansh Jain
On Friday 15 July 2016 03:09 PM, Shreyansh jain wrote: > On Thursday 14 July 2016 10:25 PM, Jan Viktorin wrote: >> On Tue, 12 Jul 2016 11:31:17 +0530 >> Shreyansh Jain wrote: >> >>> eal is a better place than crypto / ethdev for naming resources. >> >> s/for naming/to name/ > > OK. > >> >> What

[dpdk-dev] [PATCH v1 00/15] rte_driver/device infrastructure

2016-07-15 Thread Thomas Monjalon
2016-07-08 21:09, Jan Viktorin: > Hello, > > based on the discussions with Shreyansh, I propose a patchset with > the important EAL changes. It is incomplete and I suppose to extend > and change certain things in the foreseeable future. > > Important notes: > > * pmd_type is removed > *

[dpdk-dev] [PATCH] scripts: print failed directory when testing build

2016-07-15 Thread Thomas Monjalon
The script test-build.sh can be used to test building several targets with different configurations. The directory name reflects the target and the customized configuration. When there is a failure, it is convenient to print this build directory to quickly know which case is failing without

[dpdk-dev] capture packets on VM

2016-07-15 Thread Pattan, Reshma
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Raja Jayapal > Sent: Friday, July 15, 2016 6:55 AM > To: dev at dpdk.org > Subject: [dpdk-dev] capture packets on VM > > Hi All, > > I have installed dpdk on VM and would like to know how to capture the

[dpdk-dev] [PATCH 2/2] app/test: filter out unavailable tests

2016-07-15 Thread David Marchand
On Wed, Jul 13, 2016 at 11:24 PM, Thomas Monjalon wrote: > Some tests can fail to run because they are not compiled. > It has been more visible recently when the PCI test became disabled > in the default configuration because of dependency on libarchive: > PCI autotest:Fail [Not found] >

[dpdk-dev] [PATCH 2/2] app/test: filter out unavailable tests

2016-07-15 Thread Thomas Monjalon
2016-07-15 16:23, David Marchand: > On Wed, Jul 13, 2016 at 11:24 PM, Thomas Monjalon > wrote: > > Some tests can fail to run because they are not compiled. > > It has been more visible recently when the PCI test became disabled > > in the default configuration because of dependency on

[dpdk-dev] spinlock: Move constructor function out of header file

2016-07-15 Thread Thomas Monjalon
I will apply it with trivial changes suggested by Jan and the small needed changes that I describe below: 2016-07-14 20:03, Jan Viktorin: > On Thu, 14 Jul 2016 15:27:29 +0200 > damarion at cisco.com wrote: > > --- /dev/null > > +++ b/lib/librte_eal/common/arch/x86/rte_spinlock.c [...] > >

[dpdk-dev] [RFC] Generic flow director/filtering/classification API

2016-07-15 Thread Adrien Mazarguil
On Fri, Jul 15, 2016 at 09:23:26AM +, Chandran, Sugesh wrote: > Thank you Adrien, > Please find below for some more comments/inputs > > Let me know your thoughts on this. Thanks, stripping again non relevant parts. [...] > > > > > [Sugesh] Is it a limitation to use only 32 bit ID? Is it

[dpdk-dev] spinlock: Move constructor function out of header file

2016-07-15 Thread Thomas Monjalon
2016-07-15 16:37, Thomas Monjalon: > I will apply it with trivial changes suggested by Jan and > the small needed changes that I describe below: > > 2016-07-14 20:03, Jan Viktorin: > > On Thu, 14 Jul 2016 15:27:29 +0200 > > damarion at cisco.com wrote: > > > --- /dev/null > > > +++

[dpdk-dev] [PATCH] mempool: fix empty structure definition

2016-07-15 Thread Thomas Monjalon
> > This commit addresses the following warning reported by clang, which > > happens by default, as long as CONFIG_RTE_LIBRTE_MEMPOOL_DEBUG is disabled: > > > > warning: empty struct has size 0 in C, size 1 in C++ > > > > C and C++ must use the same size for objects to avoid corruption during

[dpdk-dev] [PATCH] scripts: print failed directory when testing build

2016-07-15 Thread Thomas Monjalon
2016-07-15 15:55, Thomas Monjalon: > The script test-build.sh can be used to test building several > targets with different configurations. The directory name reflects > the target and the customized configuration. > When there is a failure, it is convenient to print this build > directory to

[dpdk-dev] [PATCH] scripts: remove old build option

2016-07-15 Thread Thomas Monjalon
2016-07-12 17:56, Thomas Monjalon: > The config option CONFIG_RTE_PCI_CONFIG does not exist anymore. > > Fixes: 7d619406f31d ("pci: remove deprecated specific config") > > Signed-off-by: Thomas Monjalon Applied

[dpdk-dev] [PATCH] scripts: fix libnuma dependency in build test

2016-07-15 Thread Thomas Monjalon
2016-07-12 17:55, Thomas Monjalon: > The option CONFIG_RTE_LIBRTE_VHOST_NUMA depends on availability of > libnuma in the system. > The configuration option DPDK_DEP_NUMA can be set if available for > the DPDK_TARGET being built. > > Fixes: cd31ca579c0d ("scripts: add build tests") > >

[dpdk-dev] [PATCH 2/2] mk: fix dependency on toolchain libraries

2016-07-15 Thread Thomas Monjalon
2016-07-13 09:42, Thomas Monjalon: > The -l options specifying libraries to link with are in LDLIBS. > But it can happen to have some libraries in other variables. > In case of a low level dependency specified in some environments > via EXTRA_LDFLAGS, there can be an unresolved issue due to a >

[dpdk-dev] [PATCH] mk: fix default rule of test subdirectory

2016-07-15 Thread Thomas Monjalon
> > When using "make -C app/test" (with RTE_SDK/RTE_TARGET adjusted) without > > specifying the rule (all), the build is not done. > > Indeed the default rule is not "all" anymore since there are some rules > > added for > > external resources link. > > > > It is fixed by adding a reference to

[dpdk-dev] [PATCH 2/2] app/test: filter out unavailable tests

2016-07-15 Thread Thomas Monjalon
> > Some tests can fail to run because they are not compiled. > > It has been more visible recently when the PCI test became disabled > > in the default configuration because of dependency on libarchive: > > PCI autotest:Fail [Not found] > > > > The autotest script catch them and do not

[dpdk-dev] [PATCH v2] vfio: fix pci_vfio_map_resource

2016-07-15 Thread Thomas Monjalon
2016-07-14 17:15, Yong Wang: > - void *second_addr = RTE_PTR_ADD(bar_addr, > memreg[1].offset); > + void *second_addr = RTE_PTR_ADD(bar_addr, > + > memreg[1].offset - reg.offset);

[dpdk-dev] [PATCH v1 00/15] rte_driver/device infrastructure

2016-07-15 Thread Jan Viktorin
On Fri, 15 Jul 2016 15:19:14 +0200 Thomas Monjalon wrote: > 2016-07-08 21:09, Jan Viktorin: > > Hello, > > > > based on the discussions with Shreyansh, I propose a patchset with > > the important EAL changes. It is incomplete and I suppose to extend > > and change certain things in the

[dpdk-dev] [PATCH v2] i40: fix the VXLAN TSO issue

2016-07-15 Thread Bruce Richardson
Since we are now heading to RC3 for 16.07 and there are quite a number of open comments on this patch unresolved, it's going to be deferred till 16.11, when it can have more review and discussion. /Bruce On Thu, Jul 07, 2016 at 12:24:43PM +, Ananyev, Konstantin wrote: > > > > -Original

[dpdk-dev] [PATCH 02/10] bnx2x: Remove unused preprocessor symbols and code

2016-07-15 Thread Bruce Richardson
On Tue, Jul 12, 2016 at 09:38:06AM -0400, Chas Williams wrote: > ELINK_INCLUDE_EMUL and ELINK_INCLUDE_FPGA are never defined. Remove them > along with enumeration constants dependent on their inclusion. > > Fixes: 540a211084a7 ("bnx2x: driver core") > > Signed-off-by: Chas Williams <3chas3 at

[dpdk-dev] [PATCH 1/2] bnx2x: disable fast path interrupts

2016-07-15 Thread Rasesh Mody
> From: Chas Williams [mailto:3chas3 at gmail.com] > Sent: Friday, July 15, 2016 3:35 AM > > On Thu, 2016-07-14 at 10:03 -0700, Rasesh Mody wrote: > > Disable fastpath interrupts and remove unneeded delay in > > bnx2x_interrupt_action(). This patch fixes and prevents performance > > degradation

[dpdk-dev] [PATCH v2] vfio: fix pci_vfio_map_resource

2016-07-15 Thread Thomas Monjalon
2016-07-15 17:32, Thomas Monjalon: > 2016-07-14 17:15, Yong Wang: > > - void *second_addr = RTE_PTR_ADD(bar_addr, > > memreg[1].offset); > > + void *second_addr = RTE_PTR_ADD(bar_addr, > > +

[dpdk-dev] [PATCH v2] vfio: fix pci_vfio_map_resource

2016-07-15 Thread Thomas Monjalon
2016-07-15 18:42, Thomas Monjalon: > 2016-07-15 17:32, Thomas Monjalon: > > 2016-07-14 17:15, Yong Wang: > > > - void *second_addr = RTE_PTR_ADD(bar_addr, > > > memreg[1].offset); > > > + void *second_addr = RTE_PTR_ADD(bar_addr, > > > +

[dpdk-dev] [PATCH 02/10] bnx2x: Remove unused preprocessor symbols and code

2016-07-15 Thread Chas Williams
On Fri, 2016-07-15 at 16:56 +0100, Bruce Richardson wrote: > On Tue, Jul 12, 2016 at 09:38:06AM -0400, Chas Williams wrote: > > ELINK_INCLUDE_EMUL and ELINK_INCLUDE_FPGA are never defined.??Remove them > > along with enumeration constants dependent on their inclusion. > >? > > Fixes: 540a211084a7

[dpdk-dev] virtio PMD issue

2016-07-15 Thread Harish Patil
Hi Huawie/Yuanhan, I encounter segfault issue in virtio PMD driver when I run any DPDK application in the VM. The virtio devices should not have been probed in the first place since they are not attached to igb_uio driver (and managed by kernel driver). Network devices using DPDK-compatible

[dpdk-dev] [PATCH] net/enic: remove print of internal driver version

2016-07-15 Thread John Daley
The enic PMD code has diverged from code that was once shared with the enic kernel mode driver for performance reasons. It is confusing and misleading to print the internal version number. Remove it. Fixes: fefed3d1e62c ("enic: new driver") Signed-off-by: John Daley --- drivers/net/enic/enic.h

[dpdk-dev] [PATCH v3 0/2] vhost: fix segfault on bad descriptor address

2016-07-15 Thread Thomas Monjalon
2016-07-15 20:14, Yuanhan Liu: > On Fri, Jul 15, 2016 at 02:15:03PM +0300, Ilya Maximets wrote: > > Version 3: > > * Patch splitted in two. > > * Applied workaround from Rich Lane and added comment about > > performance issue with some compilers and 'unlikely' macro. > > Thanks a

[dpdk-dev] [PATCH v2] vhost_user: avoid crash when exeeding file descriptors

2016-07-15 Thread Thomas Monjalon
2016-07-12 16:37, Yuanhan Liu: > On Wed, Jul 06, 2016 at 02:24:58PM +0200, Christian Ehrhardt wrote: > > *update in v2* > > - refreshing for DPDK 16.07 > > - Close fd on vserver->listenfd as suggested in discussion > > > > Original From: > > From: Patrik Andersson > > > > Protect against DPDK

[dpdk-dev] virtio PMD issue

2016-07-15 Thread Vincent Li
it is fixed in 16.07-rc2 that I checked Vincent On Fri, Jul 15, 2016 at 11:48 AM, Harish Patil wrote: > Hi Huawie/Yuanhan, > I encounter segfault issue in virtio PMD driver when I run any DPDK > application in the VM. The virtio devices should not have been probed in > the first place since

[dpdk-dev] virtio PMD issue

2016-07-15 Thread Harish Patil
> >it is fixed in 16.07-rc2 that I checked Great, thanks. > >Vincent > >On Fri, Jul 15, 2016 at 11:48 AM, Harish Patil >wrote: >> Hi Huawie/Yuanhan, >> I encounter segfault issue in virtio PMD driver when I run any DPDK >> application in the VM. The virtio devices should not have been probed in

[dpdk-dev] [PATCH] net/virtio-user: Fix missing brackets in if condition

2016-07-15 Thread Thomas Monjalon
2016-07-12 20:11, Yuanhan Liu: > On Tue, Jul 12, 2016 at 11:30:25AM +0200, Maxime Coquelin wrote: > > The error is reported using test build script: > > > > $ scripts/test-build.sh x86_64-native-linuxapp-gcc > > ... > > drivers/net/virtio/virtio_user_ethdev.c: In function > >

[dpdk-dev] [PATCH 0/2] Add ptype and xsum handling in i40e rx vpmd

2016-07-15 Thread Thomas Monjalon
2016-07-14 09:59, Jeff Shaw: > Our testing suggests minimal (in some cases zero) impact to core-bound > forwarding throughput as measured by testpmd. Throughput increase is > observed in l3fwd as now the vpmd can be used with hw_ip_checksum > enabled and without needing '--parse-ptype'. > > The

[dpdk-dev] [PATCH] net/i40e: revert VLAN filtering fix

2016-07-15 Thread Thomas Monjalon
> > This reverts commit 4761f57d58c6f52543738dbe299f846d62d75895. > > Introducing VLAN table by adding VLAN adminq command will cause NIC's > > throughput drop obviously. It's a hardware issue. > > With this revert, VLAN filtering can only work when promiscuous mode is > > disabled. > > > >

[dpdk-dev] [PATCH] net/fm10k: fix FTAG mode on multi-queue

2016-07-15 Thread Thomas Monjalon
2016-07-15 18:38, Xiao Wang: > In multi-queue + FTAG use case, we need to turn tx_ftag_en on for all > the Tx queues. > > Fixes: 7958b1310d5e ("fm10k: enable FTAG based forwarding") > > Reported-by: Ricky Li > Signed-off-by: Xiao Wang Applied, thanks

[dpdk-dev] [PATCH v4 00/10] Fix build errors related to exported headers

2016-07-15 Thread Bruce Richardson
On Wed, Jul 13, 2016 at 03:02:37PM +0200, Adrien Mazarguil wrote: > DPDK uses GNU C language extensions in most of its code base. This is fine > for internal source files whose compilation flags are controlled by DPDK, > however user applications that use exported "public" headers may experience >