[dpdk-dev] [PATCH] net/i40e: fix vsi removing from tailq when release

2016-07-25 Thread Jingjing Wu
VSI structure need to be removed from TAILQ list when releasing. But for the child VSI it will be removed again after the structure is freed. It will cause core dump when the DPDK i40e using as PF host driver. This patch fixes it to only remove child VSI from TAILQ before send adminq command to

[dpdk-dev] [dpdk-users] RSS Hash not working for XL710/X710 NICs for some RX mbuf sizes

2016-07-25 Thread Xing, Beilei
Hi, > -Original Message- > From: Take Ceara [mailto:dumitru.ceara at gmail.com] > Sent: Friday, July 22, 2016 8:32 PM > To: Xing, Beilei > Cc: Zhang, Helin ; Wu, Jingjing intel.com>; > dev at dpdk.org > Subject: Re: [dpdk-dev] [dpdk-users] RSS Hash not working for XL710/X710 NICs > for

[dpdk-dev] [PATCH v2] net/i40e: fix vsi removing from tailq when release

2016-07-25 Thread Jingjing Wu
VSI structure need to be removed from TAILQ list when releasing. But for the child VSI it will be removed again after the structure is freed. It will cause core dump when the DPDK i40e using as PF host driver. This patch fixes it to only remove child VSI from TAILQ before send adminq command to

[dpdk-dev] [PATCH] doc: add known issue about promiscuous mode for I40e VF

2016-07-25 Thread Jeff Guo
When use i40e linux kernel driver as host driver and DPDK handler the i40e VF, the promiscuous mode doesn't work in i40e VF. It is not supported by DPDK i40e VF driver right now. --- doc/guides/rel_notes/known_issues.rst | 22 ++ 1 file changed, 22 insertions(+) diff --git

[dpdk-dev] Updating http://dpdk.org/doc/nics

2016-07-25 Thread Thomas Monjalon
2016-07-24 14:29, Ajit Khaparde: > I don't see the Broadcom NICs listed in the list of supported NICs. > Can you add an entry for the Broadcom NICs supported by the bnxt PMD driver? Yes I'm used to update this page before each release. But I may also suggest to send a patch yourself to web at

[dpdk-dev] [PATCH 2/2] doc: improve wording of new features section

2016-07-25 Thread Bruce Richardson
On Fri, Jul 22, 2016 at 06:19:11PM +0200, Thomas Monjalon wrote: > 2016-07-22 17:06, Bruce Richardson: > > Improve the wording of some text in the "new features" section of > > the release notes. > > I think these patches conflict with this one: > http://dpdk.org/dev/patchwork/patch/14898/

[dpdk-dev] [dpdk-users] RSS Hash not working for XL710/X710 NICs for some RX mbuf sizes

2016-07-25 Thread Take Ceara
Hi Beilei, On Mon, Jul 25, 2016 at 5:24 AM, Xing, Beilei wrote: > Hi, > >> -Original Message- >> From: Take Ceara [mailto:dumitru.ceara at gmail.com] >> Sent: Friday, July 22, 2016 8:32 PM >> To: Xing, Beilei >> Cc: Zhang, Helin ; Wu, Jingjing > intel.com>; >> dev at dpdk.org >>

[dpdk-dev] [PATCH] mk: fix link with glibc < 2.17

2016-07-25 Thread Thomas Monjalon
There is a dependency on librt with old glibc. The -lrt option was added everywhere it is needed but was also added in some applications makefiles as the first link option. The problem is this option is really useful only if added after the objects or libraries using it (except if using

[dpdk-dev] [PATCH] mk: fix static link with glibc < 2.17

2016-07-25 Thread Azarewicz, PiotrX T
> The problem is that -lrt appears before -lrte_eal. > The question is: where does it come from? > It is even before _LDLIBS-y += -L$(RTE_SDK_BIN)/lib... mystery root cause: commit c7cda4d8b4ea9cb0f209dda36882d225354b1db9 and my workaround is: /app/test/Makefile ifeq

[dpdk-dev] [PATCH] timer: fix break list when timer_cb reset running timer

2016-07-25 Thread Sanford, Robert
On 7/23/16 4:49 AM, "Thomas Monjalon" wrote: >2016-07-23 0:14 GMT+02:00 Sanford, Robert : >> Acked-by: Robert Sanford >> >> I tested the three timer patches with app/test timer_autotest and >> timer_racecond_autotest, and additional private tests. > >Thanks Robert. >Are you confident enough to

[dpdk-dev] [PATCH] mk: fix static link with glibc < 2.17

2016-07-25 Thread Thomas Monjalon
2016-07-25 11:13, Azarewicz, PiotrX T: > > The problem is that -lrt appears before -lrte_eal. > > The question is: where does it come from? > > It is even before _LDLIBS-y += -L$(RTE_SDK_BIN)/lib... mystery > > root cause: > commitc7cda4d8b4ea9cb0f209dda36882d225354b1db9 The error is

[dpdk-dev] [PATCH v2] net/i40e: fix vsi removing from tailq when release

2016-07-25 Thread Zhang, Helin
> -Original Message- > From: Wu, Jingjing > Sent: Monday, July 25, 2016 1:36 PM > To: Zhang, Helin > Cc: dev at dpdk.org; Wu, Jingjing ; Xing, Beilei > ; Peng, Yuan > Subject: [PATCH v2] net/i40e: fix vsi removing from tailq when release > > VSI structure need to be removed from TAILQ

[dpdk-dev] [PATCH 1/2] mk: get correct clang version

2016-07-25 Thread Ferruh Yigit
-dumpversion is for gcc compatibility and doesn't return actual clang version. -dumpversion only returns 4.2.1 for a long time. Fixes: 2ef6eea891e5 ("mk: add clang toolchain") Signed-off-by: Ferruh Yigit --- mk/toolchain/clang/rte.toolchain-compat.mk | 6 -- 1 file changed, 4

[dpdk-dev] [PATCH 2/2] mk: fix FreeBSD clang compile error

2016-07-25 Thread Ferruh Yigit
clang version < 3.5 doesn't support -z linker option, and some FreeBSD box still has clang versions < 3.5 as default version. compile error: clang: error: unknown argument: '-z' Fixes: fd591c4c4e35 ("mk: check shared library dependencies") Signed-off-by: Ferruh Yigit --- mk/rte.lib.mk

[dpdk-dev] net/pcap: set rte_errno on TX error

2016-07-25 Thread Zoltan Kiss
This returns the error code provided by pcap_sendpacket() Signed-off-by: Zoltan Kiss diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index 7e213eb..0899bac 100644 --- a/drivers/net/pcap/rte_eth_pcap.c +++ b/drivers/net/pcap/rte_eth_pcap.c @@ -41,6 +41,7 @@

[dpdk-dev] net/pcap: set rte_errno on TX error

2016-07-25 Thread Ferruh Yigit
On 7/25/2016 2:10 PM, Zoltan Kiss wrote: > This returns the error code provided by pcap_sendpacket() Although this is good idea, this adds undocumented side effect to rte_eth_tx_burst(). I am not able to find any information in rte_eth_tx_burst() that it can alter rte_errno. Since rte_errno is

[dpdk-dev] net/pcap: set rte_errno on TX error

2016-07-25 Thread Thomas Monjalon
2016-07-25 14:33, Ferruh Yigit: > On 7/25/2016 2:10 PM, Zoltan Kiss wrote: > > This returns the error code provided by pcap_sendpacket() > > Although this is good idea, this adds undocumented side effect to > rte_eth_tx_burst(). > > I am not able to find any information in rte_eth_tx_burst()

[dpdk-dev] [PATCH] vhost: fix off-by-one error on nr_desc check

2016-07-25 Thread Maxime Coquelin
nr_desc is not an index but the number of descriptors, so can be equal to the virtqueue size. Fixes: a436f53ebfeb ("vhost: avoid dead loop chain") Cc: Yuanhan Liu Signed-off-by: Maxime Coquelin --- Hi Yuanhan, I faced the bug while testing my indirect descriptor patch, it happens as soon as

[dpdk-dev] [PATCH] maintainers: add an entry for the stable branches

2016-07-25 Thread Thomas Monjalon
This git tree will be used to backport some fixes from the master branch to maintain some "stable releases". The minor version number z will be incremented for these releases: YY.MM.z Signed-off-by: Thomas Monjalon --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git

[dpdk-dev] [PATCH] timer: fix break list when timer_cb reset running timer

2016-07-25 Thread Thomas Monjalon
Hiroyuki, Robert, I would like to apply these patches quickly. Please could you provide some "Fixes:" line to know the origin of the bugs? Thanks

[dpdk-dev] [PATCH] maintainers: add an entry for the stable branches

2016-07-25 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Monday, July 25, 2016 3:38 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] maintainers: add an entry for the stable > branches > > This git tree will be used to backport some

[dpdk-dev] [PATCH] ring: fix sc dequeue performance issue

2016-07-25 Thread Thomas Monjalon
2016-07-24 22:57, Ananyev, Konstantin: > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > > Use of rte_smb_wmb() instead of rte_smb_rmb() in sc dequeue function > > creates the additional overhead of waiting for all the STOREs to be > > completed to local buffer from ring buffer

[dpdk-dev] [PATCH v2] net/i40e: fix vsi removing from tailq when release

2016-07-25 Thread Thomas Monjalon
> > VSI structure need to be removed from TAILQ list when releasing. > > But for the child VSI it will be removed again after the structure is > > freed. It will > > cause core dump when the DPDK i40e using as PF host driver. > > > > This patch fixes it to only remove child VSI from TAILQ before

[dpdk-dev] [PATCH] maintainers: add staging tree for network drivers

2016-07-25 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index d099131..844227b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -34,6 +34,13 @@ Stable Branches --- T: git://dpdk.org/dpdk-stable +Staging

[dpdk-dev] [PATCH 1/2] mk: get correct clang version

2016-07-25 Thread Bruce Richardson
On Mon, Jul 25, 2016 at 01:55:48PM +0100, Ferruh Yigit wrote: > -dumpversion is for gcc compatibility and doesn't return actual clang > version. -dumpversion only returns 4.2.1 for a long time. > > Fixes: 2ef6eea891e5 ("mk: add clang toolchain") > > Signed-off-by: Ferruh Yigit Confirm this set

[dpdk-dev] [PATCH] timer: fix break list when timer_cb reset running timer

2016-07-25 Thread Thomas Monjalon
2016-07-26 00:14, Hiroyuki Mikita: > Fixes: a4b7a5a45cf5 ("timer: fix race condition") > > 2016-07-25 23:43 GMT+09:00 Thomas Monjalon : > > Hiroyuki, Robert, > > I would like to apply these patches quickly. > > Please could you provide some "Fixes:" line to know the origin > > of the bugs? > >

[dpdk-dev] [PATCH] maintainers: add staging tree for network drivers

2016-07-25 Thread Thomas Monjalon
2016-07-25 16:19, Bruce Richardson: > +Staging Trees > +- > + > +Networking Drivers > +T: git://dpdk.org/dpdk-next-net > +M: Bruce Richardson I thought we could write the next- tree information below the existing title: Networking Drivers --

[dpdk-dev] [PATCH] vhost: fix off-by-one error on nr_desc check

2016-07-25 Thread Maxime Coquelin
On 07/25/2016 05:24 PM, Yuanhan Liu wrote: > On Mon, Jul 25, 2016 at 04:09:58PM +0200, Maxime Coquelin wrote: >> nr_desc is not an index but the number of descriptors, >> so can be equal to the virtqueue size. >> >> Fixes: a436f53ebfeb ("vhost: avoid dead loop chain") >> >> Cc: Yuanhan Liu >>

[dpdk-dev] [PATCH] vhost: fix off-by-one error on nr_desc check

2016-07-25 Thread Thomas Monjalon
2016-07-25 23:24, Yuanhan Liu: > On Mon, Jul 25, 2016 at 04:09:58PM +0200, Maxime Coquelin wrote: > > nr_desc is not an index but the number of descriptors, > > so can be equal to the virtqueue size. > > > > Fixes: a436f53ebfeb ("vhost: avoid dead loop chain") > > > > Cc: Yuanhan Liu > >

[dpdk-dev] [PATCH 1/2] mk: get correct clang version

2016-07-25 Thread Thomas Monjalon
2016-07-25 16:21, Bruce Richardson: > On Mon, Jul 25, 2016 at 01:55:48PM +0100, Ferruh Yigit wrote: > > -dumpversion is for gcc compatibility and doesn't return actual clang > > version. -dumpversion only returns 4.2.1 for a long time. > > > > Fixes: 2ef6eea891e5 ("mk: add clang toolchain") > >

[dpdk-dev] [PATCH] timer: fix incorrect pending-list manipulation

2016-07-25 Thread Thomas Monjalon
2016-07-26 00:16, Hiroyuki Mikita: > Fixes: 9b15ba895b9f ("timer: use a skip list") > > >>This commit fixes incorrect pending-list manipulation > >>when getting list of expired timers in rte_timer_manage(). > >> > >>When timer_get_prev_entries() sets pending_head on prev, > >>the pending-list is

[dpdk-dev] [PATCH] timer: remove unnecessary timer add call

2016-07-25 Thread Thomas Monjalon
2016-07-26 00:15, Hiroyuki Mikita: > Fixes: a4b7a5a45cf5 ("timer: fix race condition") > > > >>When timer_set_running_state() fails in rte_timer_manage(), > >>the failed timer is put back on pending-list. > >>In this case, another core tries to reset or stop the timer. > >>It does not need to be

[dpdk-dev] [PATCH] timer: fix break list when timer_cb reset running timer

2016-07-25 Thread Thomas Monjalon
> >When timer_cb resets another running timer on the same lcore, > >the list of expired timers is chained to the pending-list. > >This commit prevents a running timer from being reset > >by not its own timer_cb. > > > >Signed-off-by: Hiroyuki Mikita > > Acked-by: Robert Sanford > > I tested

[dpdk-dev] [PATCH] mk: fix link with glibc < 2.17

2016-07-25 Thread Thomas Monjalon
2016-07-25 12:57, Thomas Monjalon: > There is a dependency on librt with old glibc. > The -lrt option was added everywhere it is needed but was also > added in some applications makefiles as the first link option. > The problem is this option is really useful only if added after > the objects or

[dpdk-dev] [PATCH] maintainers: add an entry for the stable branches

2016-07-25 Thread Thomas Monjalon
2016-07-25 23:05, Yuanhan Liu: > On Mon, Jul 25, 2016 at 04:38:03PM +0200, Thomas Monjalon wrote: > > This git tree will be used to backport some fixes from the > > master branch to maintain some "stable releases". > > The minor version number z will be incremented for these releases: > >

[dpdk-dev] [PATCH] maintainers: add staging tree for network drivers

2016-07-25 Thread Bruce Richardson
On Mon, Jul 25, 2016 at 05:28:40PM +0200, Thomas Monjalon wrote: > 2016-07-25 16:19, Bruce Richardson: > > +Staging Trees > > +- > > + > > +Networking Drivers > > +T: git://dpdk.org/dpdk-next-net > > +M: Bruce Richardson > > I thought we could write the next- tree information below

[dpdk-dev] [PATCH 2/2] mempool: fix unsafe tailq element removal

2016-07-25 Thread Olivier Matz
Hi Sergio, On 07/22/2016 06:01 PM, Sergio Gonzalez Monroy wrote: > Potentially user provided function could remove/free tailq elements. > Doing so within a TAILQ_FOREACH loop is not safe. > > Use _SAFE versions of _FOREACH macros. > > Signed-off-by: Sergio Gonzalez Monroy > --- >

[dpdk-dev] [RFC] Generic flow director/filtering/classification API

2016-07-25 Thread John Fastabend
On 16-07-25 04:32 AM, Rahul Lakkireddy wrote: > Hi Adrien, > > On Thursday, July 07/21/16, 2016 at 19:07:38 +0200, Adrien Mazarguil wrote: >> Hi Rahul, >> >> Please see below. >> >> On Thu, Jul 21, 2016 at 01:43:37PM +0530, Rahul Lakkireddy wrote: >>> Hi Adrien, >>> >>> The proposal looks very

[dpdk-dev] [RFC] mk: add config items to disable tools and tests

2016-07-25 Thread Ferruh Yigit
It is not possible to prevent compiling some tests and tools. These enabled when a library or specific exec env enabled. This compilation can be overkill for someone who is compiling DPDK just as library. Adding two new config options, to completely enable/disable tools and test. Both enable

[dpdk-dev] [PATCH v2] mempool: fix unsafe removal from list by callback

2016-07-25 Thread Thomas Monjalon
If a mempool is removed from the list by a callback function during rte_mempool_walk(), the TAILQ_FOREACH loop will fail unexpectedly. It is fixed by using the safe version of the loop macro. Reported-by: Sergio Gonzalez Monroy Signed-off-by: Thomas Monjalon ---

[dpdk-dev] [PATCH v2] mempool: fix unsafe removal from list by callback

2016-07-25 Thread Olivier Matz
Hello Thomas, On 07/25/2016 09:54 PM, Thomas Monjalon wrote: > If a mempool is removed from the list by a callback function > during rte_mempool_walk(), the TAILQ_FOREACH loop will fail unexpectedly. > It is fixed by using the safe version of the loop macro. > > Reported-by: Sergio Gonzalez

[dpdk-dev] [PATCH v2] mempool: fix unsafe removal from list by callback

2016-07-25 Thread Thomas Monjalon
> > If a mempool is removed from the list by a callback function > > during rte_mempool_walk(), the TAILQ_FOREACH loop will fail unexpectedly. > > It is fixed by using the safe version of the loop macro. > > > > Reported-by: Sergio Gonzalez Monroy > > Signed-off-by: Thomas Monjalon > >

[dpdk-dev] [dpdk-announce] release candidate 16.07-rc5

2016-07-25 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: http://dpdk.org/browse/dpdk/tag/?id=v16.07-rc5 There are some fixes which require a small new release candidate. We must avoid touching the code from now. Please let's complete the documentation and check that everything is OK before

[dpdk-dev] [PATCH] doc: add a deprecation about the modification of the return type of promiscuous configure ops in i40e eth_dev_ops

2016-07-25 Thread Jeff Guo
Since an issue has broken out the problem that even the i40e linux kernel driver do not support the promiscuous mode in i40e VF when use i40e linux kernel driver as host driver, the testpmd app still show the mode configure status to be enabled. In order to reflect the real status of the i40e

[dpdk-dev] [PATCH v2] doc: add known issue about promiscuous mode for I40e VF

2016-07-25 Thread Jeff Guo
When use i40e linux kernel driver as host driver and DPDK handler the i40e VF, the promiscuous mode doesn't work in i40e VF. It is not supported by DPDK i40e VF driver right now. Signed-off-by: Jeff Guo --- v1->v2: - add singned-off and modify some format doc/guides/rel_notes/known_issues.rst