[dpdk-dev] [PATCH v2] net/virtio: fix xstats name issue

2016-09-07 Thread Yang, Zhiyong
hi, yuanhan: Thanks a lot for your clear comments in detail. Patch v3 will be sent later. -zhiyong- > -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Tuesday, September 6, 2016 8:28 PM > To: Yang, Zhiyong > Cc: dev at dpdk.org; Xie, Huawei >

[dpdk-dev] [RFC] net/ixgbe: start rxtx after all nic config done.

2016-09-07 Thread Wu, Jingjing
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of wang wei > Sent: Tuesday, September 6, 2016 8:05 PM > To: thomas.monjalon at 6wind.com > Cc: dev at dpdk.org > Subject: [dpdk-dev] [RFC] net/ixgbe: start rxtx after all nic config done. > > if start rxtx

[dpdk-dev] [PATCH v2] add mtu set in virtio

2016-09-07 Thread Dey, Souvik
Hi Maxime, In that case let this fix be there till the time the new implementation comes in. We can re-visit the changes again in the new implementation and then decide to keep this or remove it. Hope this serves all the purposes. -- Regards, Souvik -Original Message- From:

[dpdk-dev] [PATCH 5/6] vhost: add a flag to enable Tx zero copy

2016-09-07 Thread Xu, Qian Q
Thx for the clarification. As to the naming, although it's a little confusing, if people are fine with it, I'm fine. -Original Message- From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] Sent: Tuesday, September 6, 2016 6:02 PM To: Xu, Qian Q Cc: dev at dpdk.org; Maxime Coquelin

[dpdk-dev] [PATCH v3] virtio: enable indirect descriptors feature

2016-09-07 Thread Yuanhan Liu
On Tue, Sep 06, 2016 at 04:09:39PM +, Pierre Pfister (ppfister) wrote: > >From be1210e77f0f9072ccb8e6970552596b6780a44c Mon Sep 17 00:00:00 2001 > From: Pierre Pfister > Date: Fri, 2 Sep 2016 16:24:57 +0200 > Subject: [PATCH] virtio: enable indirect descriptors feature > > Virtio indirect

[dpdk-dev] [PATCH v3]virtio:add mtu set in virtio

2016-09-07 Thread souvikdey33
Signed-off-by: Souvik Dey Fixes: 1fb8e8896ca8 ("Signed-off-by: Souvik Dey ") Reviewed-by: Stephen Hemminger Virtio interfaces should also support setting of mtu, as in case of cloud it is expected to have the consistent mtu across the infrastructure that the dhcp server sends and not hardcoded

[dpdk-dev] [PATCH v2] add mtu set in virtio

2016-09-07 Thread Yuanhan Liu
On Tue, Aug 30, 2016 at 09:57:39AM +0200, Maxime Coquelin wrote: > Hi Souvik, > > On 08/30/2016 01:02 AM, souvikdey33 wrote: > >Signed-off-by: Souvik Dey > > > >Fixes: 1fb8e8896ca8 ("Signed-off-by: Souvik Dey ") > >Reviewed-by: Stephen Hemminger > > > >Virtio interfaces should also support

[dpdk-dev] [PATCH v3]virtio:add mtu set in virtio

2016-09-07 Thread Yuanhan Liu
Firstly, thanks for the patch! And I got few more style issues for you :) The first goes to the subject (commit summary): - the prefix is "net/virtio", but not "virtio" - a space is needed after ':' On Tue, Sep 06, 2016 at 11:21:56PM -0400, souvikdey33 wrote: > Signed-off-by: Souvik Dey SoB

[dpdk-dev] [PATCH v3]virtio:add mtu set in virtio

2016-09-07 Thread Yuanhan Liu
On Tue, Sep 06, 2016 at 11:21:56PM -0400, souvikdey33 wrote: > +static int > +virtio_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) > +{ > + struct virtio_hw *hw = dev->data->dev_private; > + if (mtu < VIRTIO_MIN_RX_BUFSIZE || mtu > VIRTIO_MAX_RX_PKTLEN) { > + PMD_INIT_LOG(ERR,

[dpdk-dev] [PATCH v3]virtio:add mtu set in virtio

2016-09-07 Thread Dey, Souvik
Hi Liu, The first version of the patch was reviewed by Stephen and after he agreed I have incorporated all those changes in v2 and v3 had only the style error fixes. That is why I have put the line Reviewed by . Still I might have some errors in filing the patch as I am new to this. Do you

[dpdk-dev] [PATCH v3]virtio:add mtu set in virtio

2016-09-07 Thread Dey, Souvik
Ok will change it. Do I need to submit a new v4 for that ? can I put your name also in the reviewed by list? -Original Message- From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] Sent: Tuesday, September 6, 2016 11:43 PM To: Dey, Souvik Cc: dev at dpdk.org; stephen at

[dpdk-dev] [PATCH v3]virtio:add mtu set in virtio

2016-09-07 Thread Yuanhan Liu
On Wed, Sep 07, 2016 at 03:47:27AM +, Dey, Souvik wrote: > Ok will change it. Do I need to submit a new v4 for that ? Yes. > can I put your name also in the reviewed by list? Nope, you should not add that. I just offered some comments. And yes, I reviewed your patch, but that doesn't mean

[dpdk-dev] [PATCH v3]virtio:add mtu set in virtio

2016-09-07 Thread Dey, Souvik
Ok thanks understood. I will submit v4 for this. -Original Message- From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] Sent: Tuesday, September 6, 2016 11:54 PM To: Dey, Souvik Cc: dev at dpdk.org; stephen at networkplumber.org Subject: Re: [dpdk-dev] [PATCH v3]virtio:add mtu set in

[dpdk-dev] [PATCH v4]net/virtio: add mtu set in virtio

2016-09-07 Thread souvikdey33
Virtio interfaces should also support setting of mtu, as in case of cloud it is expected to have the consistent mtu across the infrastructure that the dhcp server sends and not hardcoded to 1500(default). Changes in v4: Incorporated review comments. Changes in v3: Corrected few style errors as

[dpdk-dev] [PATCH v4]net/virtio: add mtu set in virtio

2016-09-07 Thread Dey, Souvik
Hi Liu, Submitted the version 4 of the patch as you suggested , and have removed the Reviewed by line. I have still kept the function definition as to follow the same suit as we have done for other eth_dev_ops. -- Regards, Souvik -Original Message- From: Dey, Souvik Sent:

[dpdk-dev] [RFC] net/ixgbe: start rxtx after all nic config done.

2016-09-07 Thread wei wang
2016-09-07 9:33 GMT+08:00 Wu, Jingjing : > > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of wang wei >> Sent: Tuesday, September 6, 2016 8:05 PM >> To: thomas.monjalon at 6wind.com >> Cc: dev at dpdk.org >> Subject: [dpdk-dev] [RFC] net/ixgbe: start rxtx

[dpdk-dev] [PATCH 2/2] virtio: support IOMMU platform

2016-09-07 Thread Jason Wang
On 2016?09?06? 15:46, Yuanhan Liu wrote: > Oops, seems I failed to send it out (I happened to know it when > I was checking the patchwork status: I didn't find my comment). > > I also happened to find out that I failed to receive quite many > emails, including some patches. Seems something went

[dpdk-dev] [PATCH v4 2/6] vhost: rewrite enqueue

2016-09-07 Thread Yuanhan Liu
Hmmm, yet another email didn't send out successfully. Resend. BTW, please work out v5 on top of the latest next-virtio tree. Thanks. --yliu On Mon, Sep 05, 2016 at 02:39:25PM +0800, Yuanhan Liu wrote: On Mon, Aug 29, 2016 at 11:36:00PM -0400, Zhihong Wang wrote: > This patch

[dpdk-dev] [PATCH v4 2/6] vhost: rewrite enqueue

2016-09-07 Thread Wang, Zhihong
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Wednesday, September 7, 2016 1:33 PM > To: Wang, Zhihong > Cc: dev at dpdk.org; maxime.coquelin at redhat.com; > thomas.monjalon at 6wind.com > Subject: Re: [PATCH v4 2/6] vhost: rewrite enqueue >

[dpdk-dev] [PATCH v3] net/virtio: fix xstats name issue

2016-09-07 Thread Zhiyong Yang
We have a stats named "size_1024_1517_packets", while the code actually counts the range "[1024, 1518]", which is obviously wrong. The code is as follows in the function virtio_update_packet_stats. else if (s < 1519) stats->size_bins[6]++; We could either fix it by correcting the

[dpdk-dev] [PATCH] meter: fix excess token bucket update in srtcm implementation

2016-09-07 Thread Nikhil Jagtap
As per srTCM RFC 2697, we should be updating the E bucket only after the C bucket overflows. This patch fixes the current DPDK implementation, where we are updating both the buckets simultaneously at the same rate (CIR) which results in token accumulation rate of (2*CIR). Signed-off-by: Nikhil

[dpdk-dev] meter: excess token bucket update in srtcm

2016-09-07 Thread Nikhil Jagtap
Hi Cristian, Thanks for the confirmation. I have submitted a patch for the same. http://dpdk.org/ml/archives/dev/2016-September/046226.html Regards, Nikhil On 6 September 2016 at 15:26, Dumitrescu, Cristian < cristian.dumitrescu at intel.com> wrote: > Hi Nikhil, > > It also looks to me that

[dpdk-dev] [PATCH 0/8] net/mlx5: various fixes

2016-09-07 Thread Nelio Laranjeiro
- Flow director - Rx Capabilities - Inline Adrien Mazarguil (1): net/mlx5: fix Rx VLAN offload capability report Nelio Laranjeiro (3): net/mlx5: force inline for completion function net/mlx5: re-factorize functions net/mlx5: fix inline logic Raslan Darawsheh (1): net/mlx5: fix

[dpdk-dev] [PATCH 1/8] net/mlx5: fix inconsistent return value in Flow Director

2016-09-07 Thread Nelio Laranjeiro
From: Yaacov Hazan The return value in DPDK is negative errno on failure. Since internal functions in mlx driver return positive values need to negate this value when it returned to dpdk layer. Fixes: 76f5c99 ("mlx5: support flow director") Signed-off-by: Yaacov Hazan

[dpdk-dev] [PATCH 2/8] net/mlx5: fix Rx VLAN offload capability report

2016-09-07 Thread Nelio Laranjeiro
From: Adrien Mazarguil This capability is implemented but not reported. Fixes: f3db9489188a ("mlx5: support Rx VLAN stripping") Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH 3/8] net/mlx5: fix removing VLAN filter

2016-09-07 Thread Nelio Laranjeiro
From: Raslan Darawsheh memmove was moving bytes as the number of elements next to i, while it should move the number of elements multiplied by the size of each element. Fixes: e9086978 ("mlx5: support VLAN filtering") Signed-off-by: Raslan Darawsheh ---

[dpdk-dev] [PATCH 4/8] net/mlx5: refactor allocation of flow director queues

2016-09-07 Thread Nelio Laranjeiro
From: Yaacov Hazan This is done to prepare support for drop queues, which are not related to existing RX queues and need to be managed separately. Signed-off-by: Yaacov Hazan Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.h | 1 +

[dpdk-dev] [PATCH 5/8] net/mlx5: fix support for flow director drop mode

2016-09-07 Thread Nelio Laranjeiro
From: Yaacov Hazan Packet rejection was routed to a polled queue. This patch route them to a dummy queue which is not polled. Fixes: 76f5c99e6840 ("mlx5: support flow director") Signed-off-by: Yaacov Hazan Signed-off-by: Adrien Mazarguil Signed-off-by: Nelio Laranjeiro

[dpdk-dev] [PATCH 8/8] net/mlx5: fix inline logic

2016-09-07 Thread Nelio Laranjeiro
To improve performance the NIC expects for large packets to have a pointer to a cache aligned address, old inline code could break this assumption which hurts performance. Fixes: 2a66cf378954 ("net/mlx5: support inline send") Signed-off-by: Nelio Laranjeiro Signed-off-by: Vasily Philipov ---

[dpdk-dev] [PATCH 6/8] net/mlx5: force inline for completion function

2016-09-07 Thread Nelio Laranjeiro
This function was supposed to be inlined, but was not because several functions calls it. This function should always be inline avoid external function calls and to optimize code in data-path. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxtx.c | 5 - 1 file changed, 4

[dpdk-dev] [PATCH 7/8] net/mlx5: re-factorize functions

2016-09-07 Thread Nelio Laranjeiro
Rework logic of wqe_write() and wqe_write_vlan() which are pretty similar to keep a single one. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxtx.c | 98 ++-- 1 file changed, 22 insertions(+), 76 deletions(-) diff --git

[dpdk-dev] [PATCH 0/6] net/mlx5: performance improvement

2016-09-07 Thread Nelio Laranjeiro
- Rework structure elements to reduce their size. - Removes a second useless loop in Tx burst function. This series should be applied on top of "net/mlx5: various fixes". Nelio Laranjeiro (6): net/mlx5: rework hardware structures net/mlx5: reduce Tx and Rx structure size net/mlx5: reduce

[dpdk-dev] [PATCH 2/6] net/mlx5: reduce Tx and Rx structure size

2016-09-07 Thread Nelio Laranjeiro
PMD uses only power of two number of descriptors, storing the number of elements in log2 helps to reduce the size of the container to store it. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_ethdev.c | 4 ++-- drivers/net/mlx5/mlx5_rxq.c| 10

[dpdk-dev] [PATCH 1/6] net/mlx5: rework hardware structures

2016-09-07 Thread Nelio Laranjeiro
Rework Work Queue Element (aka WQE) structures to fit PMD needs. A WQE is an aggregation of 16 bytes elements known as "data segments" (aka dseg). Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_prm.h | 70 ++ drivers/net/mlx5/mlx5_rxtx.c | 165

[dpdk-dev] [PATCH 3/6] net/mlx5: reduce Tx and Rx structure size

2016-09-07 Thread Nelio Laranjeiro
PMD uses only power of two number of Completion Queue Elements, storing the number of elements in log2 helps to reduce the size of the container to store it. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxq.c | 2 +- drivers/net/mlx5/mlx5_rxtx.c | 8

[dpdk-dev] [PATCH 4/6] net/mlx5: reduce Tx structure size

2016-09-07 Thread Nelio Laranjeiro
Blue Flame is a buffer allocated with a power of two value, its size is returned by Verbs in log2. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxtx.c | 2 +- drivers/net/mlx5/mlx5_rxtx.h | 2 +- drivers/net/mlx5/mlx5_txq.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)

[dpdk-dev] [PATCH 5/6] net/mlx5: reduce Tx and Rx structure size

2016-09-07 Thread Nelio Laranjeiro
PMD uses only power of two number of Work Queue Elements, storing the number of elements in log2 helps to reduce the size of the container to store it. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxtx.c | 23 --- drivers/net/mlx5/mlx5_rxtx.h | 2 +-

[dpdk-dev] [PATCH 6/6] net/mlx5: remove gather loop on segments

2016-09-07 Thread Nelio Laranjeiro
Tx function was handling a double loop to send segmented packets, it can be done in a single one. Signed-off-by: Nelio Laranjeiro Signed-off-by: Vasily Philipov --- drivers/net/mlx5/mlx5_rxtx.c | 312 ++- 1 file changed, 158 insertions(+), 154

[dpdk-dev] [dpdk-stable] [PATCH v3] net/virtio: fix xstats name issue

2016-09-07 Thread Yuanhan Liu
On Wed, Sep 07, 2016 at 02:11:00PM +0800, Zhiyong Yang wrote: > We have a stats named "size_1024_1517_packets", while the code > actually counts the range "[1024, 1518]", which is obviously wrong. > The code is as follows in the function virtio_update_packet_stats. > > else if (s < 1519) >

[dpdk-dev] [PATCH v2] add mtu set in virtio

2016-09-07 Thread Maxime Coquelin
On 09/07/2016 04:11 AM, Dey, Souvik wrote: > Hi Maxime, > In that case let this fix be there till the time the new implementation > comes in. We can re-visit the changes again in the new implementation and > then decide to keep this or remove it. Hope this serves all the purposes. Sure,

[dpdk-dev] [PATCH] dpdk_procinfo: check for primary process

2016-09-07 Thread Panu Matilainen
On 09/06/2016 08:12 PM, Maryam Tahhan wrote: > Add a check to see if the primary process is running and exit gracefully if it > is not. > > Suggested-by: Patrick Kutch > Signed-off-by: Maryam Tahhan > --- > app/proc_info/main.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git

[dpdk-dev] [PATCH v2] add mtu set in virtio

2016-09-07 Thread Maxime Coquelin
On 09/07/2016 05:25 AM, Yuanhan Liu wrote: > On Tue, Aug 30, 2016 at 09:57:39AM +0200, Maxime Coquelin wrote: >> Hi Souvik, >> >> On 08/30/2016 01:02 AM, souvikdey33 wrote: >>> Signed-off-by: Souvik Dey >>> >>> Fixes: 1fb8e8896ca8 ("Signed-off-by: Souvik Dey ") >>> Reviewed-by: Stephen

[dpdk-dev] [RFC PATCH v2 0/5] add API's for VF management

2016-09-07 Thread Pattan, Reshma
Hi, Ping for comments on this patch series. Thanks, Reshma > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bernard Iremonger > Sent: Friday, August 26, 2016 10:10 AM > To: Shah, Rahul R ; Lu, Wenzhuo > ; dev at dpdk.org > Cc: Iremonger, Bernard > Subject:

[dpdk-dev] [PATCH v6 1/9] lpm: add altivec intrinsics for dpdk lpm on ppc_64

2016-09-07 Thread Bruce Richardson
On Tue, Aug 16, 2016 at 03:57:51PM +0530, Gowrishankar Muthukrishnan wrote: > This patch adds ppc64le port for LPM library in DPDK. > > Signed-off-by: Gowrishankar Muthukrishnan linux.vnet.ibm.com> > --- > app/test/test_xmmt_ops.h | 16 +++ >

[dpdk-dev] [PATCH v2 1/2] drivers/i40e: Add new PCTYPEs for device x722

2016-09-07 Thread Jeff Guo
There are 6 new PCTYPEs enabled in the device x722. The 6 new PCTYPEs As bellow: NonF Unicast IPv4, UDP NonF Multicast IPv4, UDP NonF IPv4, TCP, SYN, no ACK NonF Unicast IPv6, UDP NonF Multicast IPv6, UDP Signed-off-by: Jeff Guo --- drivers/net/i40e/i40e_ethdev.c | 188

[dpdk-dev] [PATCH v2 2/2] drivers/i40e: Add FD PCTYPE translation for device x722

2016-09-07 Thread Jeff Guo
In device x722, before the FD filter is programmed, the PCTYPE in the FD programming descriptor need to use GLQF_FD_PCTYPE table to translate into Second PCTYPE, that will let new PCTYPE compatible with original PCTYPE in FD filter. Signed-off-by: Jeff Guo --- drivers/net/i40e/i40e_ethdev.c |

[dpdk-dev] [PATCH v2 1/1] dpdk_procinfo: check for primary process

2016-09-07 Thread Maryam Tahhan
Add a check to see if the primary process is running and exit gracefully if it is not. v2: * Updated to tone down message and remove unnecessary brackets. Suggested-by: Patrick Kutch Signed-off-by: Maryam Tahhan --- app/proc_info/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[dpdk-dev] [PATCH] dpdk_procinfo: check for primary process

2016-09-07 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen > Sent: Wednesday, September 7, 2016 9:43 AM > To: Tahhan, Maryam ; dev at dpdk.org > Cc: Kutch, Patrick G > Subject: Re: [dpdk-dev] [PATCH] dpdk_procinfo: check for primary process > ... > >

[dpdk-dev] [PATCH 1/1] testpmd_ug: update userguide with xstats commands

2016-09-07 Thread Maryam Tahhan
Update the testpmd user guide with instructions for retrieving extended NIC statistics. Signed-off-by: Maryam Tahhan --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst

[dpdk-dev] [PATCH] Revert "bonding: use existing enslaved device queues"

2016-09-07 Thread Ilya Maximets
This reverts commit 5b7bb2bda5519b7800f814df64d4e015282140e5. It is necessary to reconfigure all queues every time because configuration can be changed. For example, if we're reconfiguring bonding device with new memory pool, already configured queues will still use the old one. And if the old

[dpdk-dev] [PATCH v9 00/25] Introducing rte_driver/rte_device generalization

2016-09-07 Thread Shreyansh Jain
Based on master (e22856313) Background: === It includes two different patch-sets floated on ML earlier: * Original patch series is from David Marchand [1], [2]. `- This focused mainly on PCI (PDEV) part `- v7 of this was posted by me [8] in August/2016 * Patch series [4] from Jan

[dpdk-dev] [PATCH v9 01/25] eal: define macro container_of

2016-09-07 Thread Shreyansh Jain
Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/include/rte_common.h | 21 + 1 file changed, 21 insertions(+) diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/include/rte_common.h index 332f2a4..c5d94f3

[dpdk-dev] [PATCH v9 02/25] eal: remove duplicate function declaration

2016-09-07 Thread Shreyansh Jain
rte_eal_dev_init is declared in both eal_private.h and rte_dev.h since its introduction. This function has been exported in ABI, so remove it from eal_private.h Fixes: e57f20e05177 ("eal: make vdev init path generic for both virtual and pci devices") Signed-off-by: David Marchand Signed-off-by:

[dpdk-dev] [PATCH v9 03/25] pci: no need for dynamic tailq init

2016-09-07 Thread Shreyansh Jain
These lists can be initialized once and for all at build time. With this, those lists are only manipulated in a common place (and we could even make them private). A nice side effect is that pci drivers can now register in constructors. Signed-off-by: David Marchand Reviewed-by: Jan Viktorin

[dpdk-dev] [PATCH v9 04/25] crypto: no need for a crypto pmd type

2016-09-07 Thread Shreyansh Jain
This information is not used and just adds noise. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 8 +++- lib/librte_cryptodev/rte_cryptodev.h | 2 -- lib/librte_cryptodev/rte_cryptodev_pmd.h | 3 +-- 3 files changed, 4

[dpdk-dev] [PATCH v9 05/25] drivers: align pci driver definitions

2016-09-07 Thread Shreyansh Jain
Pure coding style, but it might make it easier later if we want to move fields in rte_cryptodev_driver and eth_driver structures. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- drivers/crypto/qat/rte_qat_cryptodev.c | 2 +- drivers/net/ena/ena_ethdev.c | 2 +-

[dpdk-dev] [PATCH v9 06/25] eal: introduce init macros

2016-09-07 Thread Shreyansh Jain
Introduce a RTE_INIT macro used to mark an init function as a constructor. Current eal macros have been converted to use this (no functional impact). DRIVER_REGISTER_PCI is added as a helper for pci drivers. Suggested-by: Jan Viktorin Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain

[dpdk-dev] [PATCH v9 07/25] driver: init/uninit common wrappers for PCI drivers

2016-09-07 Thread Shreyansh Jain
crypto and ethdev drivers aligned to PCI probe/remove. Existing handlers for init/uninit can be easily reused for this. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 16 lib/librte_cryptodev/rte_cryptodev_pmd.h

[dpdk-dev] [PATCH v9 08/25] drivers: convert all pdev drivers as pci drivers

2016-09-07 Thread Shreyansh Jain
Simplify crypto and ethdev pci drivers init by using newly introduced init macros and helpers. Those drivers then don't need to register as "rte_driver"s anymore. Exceptions: - virtio and mlx* use RTE_INIT directly as they have custom initialization steps. - VDEV devices are not modified - they

[dpdk-dev] [PATCH v9 09/25] driver: Remove driver register callbacks for crypto/net

2016-09-07 Thread Shreyansh Jain
Now that all pdev are pci drivers, we don't need to register crypto and ethdev drivers through a dedicated channel. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 22 --- lib/librte_cryptodev/rte_cryptodev_pmd.h

[dpdk-dev] [PATCH v9 10/25] eal/pci: Helpers for device name parsing/update

2016-09-07 Thread Shreyansh Jain
- Move rte_eth_dev_create_unique_device_name() from ether/rte_ethdev.c to common/include/rte_pci.h as rte_eal_pci_device_name(). Being a common method, can be used across crypto/net PCI PMDs. - Remove crypto specific routine and fallback to common name function. - Introduce a eal private

[dpdk-dev] [PATCH v9 11/25] ethdev: do not scan all pci devices on attach

2016-09-07 Thread Shreyansh Jain
No need to scan all devices, we only need to update the device being attached. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_pci.c | 11 --- lib/librte_ether/rte_ethdev.c | 3 --- 2 files changed, 8 insertions(+), 6

[dpdk-dev] [PATCH v9 12/25] eal: add hotplug operations for pci and vdev

2016-09-07 Thread Shreyansh Jain
Hotplug invocations, which deals with devices, should come from the layer that already handles them, i.e. EAL. For both attach and detach operations, 'name' is used to select the bus that will handle the request. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain ---

[dpdk-dev] [PATCH v9 13/25] ethdev: convert to eal hotplug

2016-09-07 Thread Shreyansh Jain
Remove bus logic from ethdev hotplug by using eal for this. Current api is preserved: - the last port that has been created is tracked to return it to the application when attaching, - the internal device name is reused when detaching. We can not get rid of ethdev hotplug yet since we still

[dpdk-dev] [PATCH v9 14/25] ethdev: get rid of device type

2016-09-07 Thread Shreyansh Jain
Now that hotplug has been moved to eal, there is no reason to keep the device type in this layer. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- app/test/virtual_pmd.c| 2 +- drivers/net/af_packet/rte_eth_af_packet.c | 2 +-

[dpdk-dev] [PATCH v9 15/25] eal: extract vdev infra

2016-09-07 Thread Shreyansh Jain
Move all PMD_VDEV-specific code into a separate module and header file to not polute the generic code anymore. There is now a list of virtual devices available. The rte_vdev_driver integrates the original rte_driver inside (C inheritance). The rte_driver will be however change in the future to

[dpdk-dev] [PATCH v9 16/25] eal: Remove PDEV/VDEV unused code

2016-09-07 Thread Shreyansh Jain
- Remove checks for VDEV from rte_eal_vdev_(init/uninint) as all devices are inherently virtual here. - PDEVs perform PCI specific inits - rte_eal_dev_init() need not call rte_driver->init(); Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain ---

[dpdk-dev] [PATCH v9 18/25] eal: move init/uninit to rte_vdev_driver

2016-09-07 Thread Shreyansh Jain
These functions are virtual-device specific and they are never called for any PCI driver (after introducing DRIVER_REGISTER_PCI, there is no way to do it). All affected drivers are updated. The prototypes are renamed to rte_vdev_init_t and rte_vdev_uninit_t. Signed-off-by: Jan Viktorin

[dpdk-dev] [PATCH v9 19/25] eal: remove PMD_DRIVER_REGISTER and unused pmd_types

2016-09-07 Thread Shreyansh Jain
- All devices register themselfs by calling a kind of DRIVER_REGISTER_XXX. The PMD_REGISTER_DRIVER is not used anymore. - PMD_VDEV type is also not being used - can be removed from all VDEVs. Note: PMD_REGISTER_DRIVER usage by PMDINFO tool and its documentation has not yet been removed.

[dpdk-dev] [PATCH v9 20/25] eal: rte_pci.h includes rte_dev.h

2016-09-07 Thread Shreyansh Jain
Further refactoring and generalization of PCI infrastructure will require access to the rte_dev.h contents. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/include/rte_pci.h | 1 + 1 file changed, 1 insertion(+) diff --git

[dpdk-dev] [PATCH v9 17/25] drivers: convert PMD_VDEV drivers to use rte_vdev_driver

2016-09-07 Thread Shreyansh Jain
All PMD_VDEV drivers can now use rte_vdev_driver instead of the rte_driver (which is embedded in the rte_vdev_driver). Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain --- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 14 -- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 14

[dpdk-dev] [PATCH v9 21/25] eal: rename and move rte_pci_resource

2016-09-07 Thread Shreyansh Jain
There is no need to have a custom memory resource representation for each infrastructure (PCI, ...) as it would always have the same members. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain --- drivers/net/szedata2/rte_eth_szedata2.c | 4 ++-- lib/librte_eal/common/include/rte_dev.h

[dpdk-dev] [PATCH v9 22/25] eal/pci: inherit rte_driver by rte_pci_driver

2016-09-07 Thread Shreyansh Jain
Remove the 'name' member from rte_pci_driver and move to generic rte_driver. Most of the PMD drivers were initially using DRIVER_REGISTER_PCI(..) as well as assigning a name to eth_driver.pci_drv.name member. In this patch, only the original DRIVER_REGISTER_PCI(..) name has been populated into

[dpdk-dev] [PATCH v9 23/25] eal: call rte_eal_driver_register

2016-09-07 Thread Shreyansh Jain
To register both vdev and pci drivers into the list of all rte_driver, we have to call rte_eal_driver_register explicitly. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_pci.c | 2 ++ lib/librte_eal/common/eal_common_vdev.c | 2 ++ 2 files

[dpdk-dev] [PATCH v9 24/25] eal: introduce rte_device

2016-09-07 Thread Shreyansh Jain
Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_dev.c | 13 + lib/librte_eal/common/include/rte_dev.h | 31 +++ 2 files changed, 44 insertions(+) diff --git a/lib/librte_eal/common/eal_common_dev.c

[dpdk-dev] [PATCH v9 25/25] eal/pci: Create rte_device list and fallback on its members

2016-09-07 Thread Shreyansh Jain
Now that rte_device is available, drivers can start using its members (numa, name) as well as link themselves into another rte_device list. As of now no one is using this list, but can be used for moving over all devices (pdev/vdev/Xdev) and perform bulk actions (like cleanup). Signed-off-by:

[dpdk-dev] DPDK patchwork upgrade

2016-09-07 Thread Thomas Monjalon
Hi all, Patchwork is upgraded from a pre-0.9 version to 1.1.1: http://dpdk.org/dev/patchwork This new version brings 2 new columns: - A/R/T for Acked-by/Reviewed-by/Tested-by counters. Unfortunately it does not yet parse the cover letter of a series. - S/W/F for

[dpdk-dev] QoS: The difference of traffic class between subport and pipe in QoS

2016-09-07 Thread Dumitrescu, Cristian
Traffic class is really the type of traffic, e.g. voice, real-time video (like RTP), best effort (TCP-based video, file downloads, etc). Each traffic type has different requirements in terms on latency/delay, jitter/delay variation, loss rate, bandwidth, etc. The levels of our scheduling

[dpdk-dev] [PATCH 5/6] vhost: add a flag to enable Tx zero copy

2016-09-07 Thread Thomas Monjalon
2016-09-06 17:55, Yuanhan Liu: > On Tue, Sep 06, 2016 at 09:00:14AM +, Xu, Qian Q wrote: > > Just curious about the naming: vhost USER TX Zero copy. In fact, it's Vhost > > RX zero-copy > > For virtio, it's Virtio TX zero-copy. So, I wonder why we call it as Vhost > > TX ZERO-COPY, > > Any

[dpdk-dev] DPDK patchwork upgrade

2016-09-07 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Wednesday, September 07, 2016 8:02 AM > To: dev at dpdk.org > Cc: Stephen Finucane > Subject: [dpdk-dev] DPDK patchwork upgrade > > Hi all, > > Patchwork is upgraded from a pre-0.9

[dpdk-dev] DPDK patchwork upgrade

2016-09-07 Thread Thomas Monjalon
2016-09-07 16:40, De Lara Guarch, Pablo: > I am looking at it, and I see two issues: > - There are some patches that have been acked, but I don't see that in > patchwork > (e.g. http://dpdk.org/dev/patchwork/patch/15381/) Yes the new columns are empty. I guess they will be filled starting from

[dpdk-dev] [PATCH 0/2] Add HMAC_MD5 to Intel QuickAssist Technology driver

2016-09-07 Thread De Lara Guarch, Pablo
Hi Arek, > -Original Message- > From: Trahe, Fiona > Sent: Wednesday, August 10, 2016 10:38 AM > To: Kusztal, ArkadiuszX; dev at dpdk.org > Cc: Jain, Deepak K; De Lara Guarch, Pablo; Griffin, John; Trahe, Fiona > Subject: RE: [PATCH 0/2] Add HMAC_MD5 to Intel QuickAssist Technology >

[dpdk-dev] DPDK patchwork upgrade

2016-09-07 Thread Stephen Finucane
> Hi all, > > Patchwork is upgraded from a pre-0.9 version to 1.1.1: > http://dpdk.org/dev/patchwork > > This new version brings 2 new columns: > > - A/R/T for Acked-by/Reviewed-by/Tested-by counters. > Unfortunately it does not yet parse the cover letter of a series. It's coming:

[dpdk-dev] [PATCH 0/2] add aes-sha224-hmac support to Intel QAT driver

2016-09-07 Thread De Lara Guarch, Pablo
Hi Deepak, > -Original Message- > From: Jain, Deepak K > Sent: Thursday, August 18, 2016 6:18 AM > To: De Lara Guarch, Pablo; Trahe, Fiona; Griffin, John > Cc: dev at dpdk.org; Jain, Deepak K > Subject: [PATCH 0/2] add aes-sha224-hmac support to Intel QAT driver > > This patchset adds

[dpdk-dev] [PATCH 0/2] add aes-sha384-hmac support to Intel QAT driver

2016-09-07 Thread De Lara Guarch, Pablo
Hi Deepak, > -Original Message- > From: Jain, Deepak K > Sent: Thursday, August 18, 2016 6:26 AM > To: De Lara Guarch, Pablo; Trahe, Fiona; Griffin, John > Cc: dev at dpdk.org; Jain, Deepak K > Subject: [PATCH 0/2] add aes-sha384-hmac support to Intel QAT driver > > This patchset adds

[dpdk-dev] [PATCH 0/2] add NULL crypto support in Intel QAT driver

2016-09-07 Thread De Lara Guarch, Pablo
Hi Deepak, > -Original Message- > From: Jain, Deepak K > Sent: Thursday, August 18, 2016 6:34 AM > To: De Lara Guarch, Pablo; Trahe, Fiona; Griffin, John > Cc: dev at dpdk.org; Jain, Deepak K > Subject: [PATCH 0/2] add NULL crypto support in Intel QAT driver > > This patchset adds

[dpdk-dev] [PATCH] crypto/qat: add Intel QuickAssist C62x device

2016-09-07 Thread De Lara Guarch, Pablo
Hi Deepak, > -Original Message- > From: Jain, Deepak K > Sent: Tuesday, August 23, 2016 7:54 AM > To: De Lara Guarch, Pablo; Trahe, Fiona; Griffin, John > Cc: dev at dpdk.org; Jain, Deepak K > Subject: [PATCH] crypto/qat: add Intel QuickAssist C62x device > > Signed-off-by: Deepak Kumar

[dpdk-dev] [PATCH 0/4] add kasumi in Intel(R) QuickAssist driver

2016-09-07 Thread De Lara Guarch, Pablo
Hi Deepak, > -Original Message- > From: Jain, Deepak K > Sent: Tuesday, August 23, 2016 2:36 PM > To: De Lara Guarch, Pablo; Trahe, Fiona; Griffin, John > Cc: dev at dpdk.org; Jain, Deepak K > Subject: [PATCH 0/4] add kasumi in Intel(R) QuickAssist driver > > This patchset contains

[dpdk-dev] [PATCH] crypto/qat: add Intel(R) QuickAssist C3xxx device

2016-09-07 Thread De Lara Guarch, Pablo
Hi Deepak, > -Original Message- > From: Jain, Deepak K > Sent: Friday, August 26, 2016 5:28 AM > To: Trahe, Fiona; Griffin, John; De Lara Guarch, Pablo > Cc: dev at dpdk.org; Jain, Deepak K > Subject: [PATCH] crypto/qat: add Intel(R) QuickAssist C3xxx device > > Signed-off-by: Deepak

[dpdk-dev] [PATCH 3/3] examples/ipsec-secgw: add AES-GCM support

2016-09-07 Thread De Lara Guarch, Pablo
Hi Sergio, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Sergio Gonzalez > Monroy > Sent: Tuesday, August 23, 2016 10:00 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 3/3] examples/ipsec-secgw: add AES-GCM > support > > Add support for AES-GCM

[dpdk-dev] [PATCH v6 1/2] examples/ipsec-secgw: add configuration file support

2016-09-07 Thread De Lara Guarch, Pablo
Hi Fan, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Fan Zhang > Sent: Tuesday, August 23, 2016 7:47 AM > To: dev at dpdk.org > Cc: Gonzalez Monroy, Sergio > Subject: [dpdk-dev] [PATCH v6 1/2] examples/ipsec-secgw: add configuration > file support > >

[dpdk-dev] [PATCH v2 0/2] Add 3DES support to Quickassist PMD

2016-09-07 Thread De Lara Guarch, Pablo
Hi Fiona, > -Original Message- > From: Trahe, Fiona > Sent: Friday, August 26, 2016 8:49 AM > To: dev at dpdk.org > Cc: De Lara Guarch, Pablo; Griffin, John; Jain, Deepak K; Kusztal, ArkadiuszX; > Trahe, Fiona > Subject: [PATCH v2 0/2] Add 3DES support to Quickassist PMD > > From: Fiona

[dpdk-dev] [PATCH v9 00/25] Introducing rte_driver/rte_device generalization

2016-09-07 Thread Stephen Hemminger
On Wed, 7 Sep 2016 19:37:52 +0530 Shreyansh Jain wrote: > Based on master (e22856313) > > Background: > === > > It includes two different patch-sets floated on ML earlier: > * Original patch series is from David Marchand [1], [2]. > `- This focused mainly on PCI (PDEV) part > `-

[dpdk-dev] [PATCH 0/4] New crypto software based device

2016-09-07 Thread De Lara Guarch, Pablo
Hi Piotr, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Piotr Azarewicz > Sent: Friday, August 26, 2016 12:22 AM > To: Doherty, Declan; dev at dpdk.org > Cc: Kerlin, MarcinX > Subject: [dpdk-dev] [PATCH 0/4] New crypto software based device > > From:

[dpdk-dev] [PATCH 0/2] add aes-sha224-hmac support to Intel QAT driver

2016-09-07 Thread Jain, Deepak K
HI Pablo, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, September 7, 2016 7:00 PM > To: Jain, Deepak K ; Trahe, Fiona > ; Griffin, John > Cc: dev at dpdk.org > Subject: RE: [PATCH 0/2] add aes-sha224-hmac support to Intel QAT driver > > Hi Deepak, > > >

[dpdk-dev] [PATCH 0/2] add NULL crypto support in Intel QAT driver

2016-09-07 Thread Jain, Deepak K
HI Pablo, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, September 7, 2016 7:05 PM > To: Jain, Deepak K ; Trahe, Fiona > ; Griffin, John > Cc: dev at dpdk.org > Subject: RE: [PATCH 0/2] add NULL crypto support in Intel QAT driver > > Hi Deepak, > > >

[dpdk-dev] [PATCH 0/4] add kasumi in Intel(R) QuickAssist driver

2016-09-07 Thread Jain, Deepak K
Hi Pablo, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, September 7, 2016 7:07 PM > To: Jain, Deepak K ; Trahe, Fiona > ; Griffin, John > Cc: dev at dpdk.org > Subject: RE: [PATCH 0/4] add kasumi in Intel(R) QuickAssist driver > > Hi Deepak, > > > -Original

[dpdk-dev] [PATCH 0/2] add aes-sha384-hmac support to Intel QAT driver

2016-09-07 Thread Jain, Deepak K
HI Pablo, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, September 7, 2016 7:02 PM > To: Jain, Deepak K ; Trahe, Fiona > ; Griffin, John > Cc: dev at dpdk.org > Subject: RE: [PATCH 0/2] add aes-sha384-hmac support to Intel QAT driver > > Hi Deepak, > > >

[dpdk-dev] [PATCH] crypto/qat: add Intel QuickAssist C62x device

2016-09-07 Thread Jain, Deepak K
HI Pablo, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, September 7, 2016 7:07 PM > To: Jain, Deepak K ; Trahe, Fiona > ; Griffin, John > Cc: dev at dpdk.org > Subject: RE: [PATCH] crypto/qat: add Intel QuickAssist C62x device > > Hi Deepak, > > > -Original

[dpdk-dev] [PATCH] crypto/qat: add Intel(R) QuickAssist C3xxx device

2016-09-07 Thread Jain, Deepak K
HI Pablo, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, September 7, 2016 7:08 PM > To: Jain, Deepak K ; Trahe, Fiona > ; Griffin, John > Cc: dev at dpdk.org > Subject: RE: [PATCH] crypto/qat: add Intel(R) QuickAssist C3xxx device > > Hi Deepak, > > >

  1   2   >