[dpdk-dev] [PATCH] kni: unregister an unregisterd net_device could cause a kernel crash

Signed-off-by: zhouyangchao --- lib/librte_eal/linuxapp/kni/kni_misc.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c b/lib/librte_eal/linuxapp/kni/kni_misc.c index 67e9b7d..17b6d7a 100644 ---

[dpdk-dev] [PATCH] kni: unregister an unregisterd net_device could cause a kernel crash

Signed-off-by: zhouyangchao --- lib/librte_eal/linuxapp/kni/kni_misc.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c b/lib/librte_eal/linuxapp/kni/kni_misc.c index 67e9b7d..ad4e603 100644 ---

[dpdk-dev] [PATCH] mempool: fix check flags

fix check flags in case of single producer and single consumer Fixes: 449c49b9 ("mempool: support handler operations") Signed-off-by: Hiroyuki Mikita --- lib/librte_mempool/rte_mempool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_mempool/rte_mempool.c

[dpdk-dev] [PATCH] mempool: fix check flags

Sorry, I did not notice the same kind of patch. I close this patch. Hiroyuki 2016-09-08 23:46 GMT+09:00 Olivier Matz : > Hi Hiroki, Ferruh, > > On 09/08/2016 04:44 PM, Ferruh Yigit wrote: >> On 9/8/2016 3:28 PM, Hiroyuki Mikita wrote: >>> fix check flags in case of single producer and single

[dpdk-dev] sysfs permission problem when running dpdk app in lxc

I found many other guys face the same issue as mine, but no replies to their question. Anyway, there are three major option groups including apparmor, seccome, and cgroup. It seems that some security options of lxc prevent my DPDK app from opening sysfs file in RW mode. I changed lxc.aa_profile to

[dpdk-dev] [PATCH v2] add mtu set in virtio

Are we good to get this in for 16.11 and then revisit this when the VHOST improvements comes in. This will atleast take care of the gap between 16.11 and VHOST improvements coming in. -- Regards, Souvik -Original Message- From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] Sent:

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

On 9/8/2016 8:18 PM, Yuanhan Liu wrote: > On Thu, Sep 08, 2016 at 04:53:22PM +0800, Tan, Jianfeng wrote: >> >> On 9/6/2016 4:20 PM, Yuanhan Liu wrote: >>> On Tue, Sep 06, 2016 at 03:54:30PM +0800, Tan, Jianfeng wrote: Hi Yuanhan, On 9/6/2016 2:42 PM, Yuanhan Liu wrote: >

[dpdk-dev] [PATCH v9 01/25] eal: define macro container_of

Hi Ferruh, On Thursday 08 September 2016 07:46 PM, Ferruh Yigit wrote: > On 9/7/2016 3:07 PM, Shreyansh Jain wrote: >> Signed-off-by: Jan Viktorin >> Signed-off-by: Shreyansh Jain >> --- >> lib/librte_eal/common/include/rte_common.h | 21 + >> 1 file changed, 21

[dpdk-dev] VLAN of SRIOV VF with DPDK

Hi, I have having an unique issue to get the VLAN tags upto the VM instance running ixgbevf pmd. Currently my setup looks like this : Host running 7.1 RHEL , linux 3.10.0-229.el7.x86_64 with 10G 82599ES NIC cards with firmware : 0x8838 and ixgbe driver version 4.0.1-k-rh7.1

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

On 9/9/2016 12:19 PM, Yuanhan Liu wrote: >> >> >> Never mind, above fix on the vhost side will not take effect on >> existing >> vpp-vhost implementations. >> >> Actually, I was talking about the DPDK vhost implementation :) >> >> >> This patch is talking about vpp's

[dpdk-dev] [PATCH 1/6] ethdev: add Tx preparation

On Thu, Sep 08, 2016 at 04:09:05PM +, Kulasek, TomaszX wrote: > Hi Jerin, Hi TomaszX, > > > -Original Message- > > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > > Sent: Thursday, September 8, 2016 09:29 > > To: Kulasek, TomaszX > > Cc: dev at dpdk.org > > Subject:

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

On Fri, Sep 09, 2016 at 01:50:16PM +0800, Tan, Jianfeng wrote: > On 9/9/2016 12:19 PM, Yuanhan Liu wrote: > > >> > >> > >> Never mind, above fix on the vhost side will not take effect on > >> existing > >> vpp-vhost implementations. > >> > >> Actually, I was talking about the

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

On 9/9/2016 2:03 PM, Yuanhan Liu wrote: >> GET_PROTOCOL_FEATURES >> is not supported yet. I see those features in PROTOCOL_FEATURES is for live >> migration (right?). > Not exactly. PROTOCOL_FEATURES was firstly introduced while MQ was > enabled. Thus it's no wonder MQ is the first protocol

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

On Fri, Sep 09, 2016 at 02:24:20PM +0800, Tan, Jianfeng wrote: > > > On 9/9/2016 2:03 PM, Yuanhan Liu wrote: > >>GET_PROTOCOL_FEATURES > >>is not supported yet. I see those features in PROTOCOL_FEATURES is for live > >>migration (right?). > >Not exactly. PROTOCOL_FEATURES was firstly introduced

[dpdk-dev] [PATCH v4]net/virtio: add mtu set in virtio

On Wed, Sep 07, 2016 at 04:21:30AM +, Dey, Souvik wrote: > Hi Liu, > Submitted the version 4 of the patch as you suggested , Your patch is looking much better. But not really, you ignored few of my comments. > and have removed the Reviewed by line. > I have still kept the function

[dpdk-dev] [PATCH] net/kni: add KNI PMD

2016-09-08 19:11, Ferruh Yigit: > On 9/8/2016 10:38 AM, Thomas Monjalon wrote: > > 2016-09-08 10:25, Bruce Richardson: > >> On Thu, Sep 08, 2016 at 09:44:55AM +0200, Thomas Monjalon wrote: > >>> 2016-09-06 11:33, Ferruh Yigit: > Add KNI PMD which wraps librte_kni for ease of use. > >

[dpdk-dev] [PATCH v2 0/8] Misc enhancements in testpmd

This patchset introduces several enhancements or minor fixes in testpmd. It is targetted for v16.11, and applies on top of software ptype v2 patchset [1]. These patches are useful to validate the virtio offload patchset [2] (to be rebased). [1]

[dpdk-dev] [PATCH v2 2/8] app/testpmd: use new function to dump offload flags

Use the functions introduced in the previous commit to dump the offload flags. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 27 +++ app/test-pmd/rxonly.c | 15 ++- 2 files changed, 5 insertions(+), 37 deletions(-) diff --git

[dpdk-dev] [PATCH v2 3/8] app/testpmd: dump rx flags in csum engine

Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 7cc51df..a484b18 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c @@

[dpdk-dev] [PATCH v2 1/8] mbuf: add function to dump ol flag list

The functions rte_get_rx_ol_flag_name() and rte_get_tx_ol_flag_name() can dump one flag, or set of flag that are part of the same mask (ex: PKT_TX_UDP_CKSUM, part of PKT_TX_L4_MASK). But they are not designed to dump the list of flags contained in mbuf->ol_flags. This commit introduce new

[dpdk-dev] [PATCH v2 4/8] app/testpmd: add option to enable lro

Introduce a new argument '--enable-lro' to ask testpmd to enable the LRO feature on enabled ports, like it's done for '--enable-rx-cksum' for instance. Signed-off-by: Olivier Matz --- app/test-pmd/parameters.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test-pmd/parameters.c

[dpdk-dev] [PATCH v2 8/8] app/testpmd: hide segsize when unrelevant in csum engine

When TSO is not asked, hide the segment size. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 9938150..4b36d74 100644 --- a/app/test-pmd/csumonly.c +++

[dpdk-dev] [PATCH v2 5/8] app/testpmd: do not change ip addrs in csum engine

The csum forward engine was updated to change the IP addresses in the packet data in commit 51f694dd40f5 ("app/testpmd: rework checksum forward engine") This was done to ensure that the checksum is correctly reprocessed when using hardware checksum offload. But the functions

[dpdk-dev] [PATCH v2 7/8] app/testpmd: don't use tso if packet is too small

Asking for TSO (TCP Segmentation Offload) on packets that are already smaller than (headers + MSS) does not work, for instance on ixgbe. Fix the csumonly engine to only set the TSO flag when a segmentation offload is really required, i.e. when packet is large enough. Signed-off-by: Olivier Matz

[dpdk-dev] [PATCH v2 6/8] app/testpmd: display rx port in csum engine

This information is useful when debugging, especially with bidirectional traffic. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index ee98724..35edf1d 100644 ---

[dpdk-dev] [PATCH] ethdev: clarify API comment for imissed stats

The "imissed" stats represent RX packets dropped by the HW, so we should not talk about mbufs as the hardware is not aware of this structure. Buffer seems to be a better word. Fixes: 4eadb8ba11b7 ("ethdev: do not deprecate imissed counter") Signed-off-by: Olivier Matz ---

[dpdk-dev] [PATCH] testpmd: fix crash when mempool allocation fails

Avoid access to mempool pointer if it is NULL. Fixes: b19a0c75a0d4 ("app/testpmd: remove anonymous mempool code") Coverity issue: 127553 Signed-off-by: Olivier Matz --- app/test-pmd/testpmd.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test-pmd/testpmd.c

[dpdk-dev] [PATCH v2] net/vhost: add pmd xstats

This feature adds vhost pmd extended statistics from per queue perspective for the application such as OVS etc. The statistics counters are based on RFC 2819 and RFC 2863 as follows: rx/tx_good_packets rx/tx_total_bytes rx/tx_dropped_pkts rx/tx_broadcast_packets rx/tx_multicast_packets

[dpdk-dev] [dpdk-stable] [PATCH] testpmd: fix crash when mempool allocation fails

On Fri, Sep 09, 2016 at 10:16:25AM +0200, Olivier Matz wrote: > Avoid access to mempool pointer if it is NULL. > > Fixes: b19a0c75a0d4 ("app/testpmd: remove anonymous mempool code") > Coverity issue: 127553 > > Signed-off-by: Olivier Matz > --- > app/test-pmd/testpmd.c | 4 > 1 file

[dpdk-dev] [PATCH v2] net/vhost: add pmd xstats

Hi Zhiyong, > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zhiyong Yang > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/vhost: add pmd xstats > > +struct vhost_xstats { > + uint64_t stat[16]; > +}; Perhaps we could create an enum to access the stat array? enum

[dpdk-dev] [dpdk-stable] [PATCH] testpmd: fix crash when mempool allocation fails

Hi Yuanhan, On 09/09/2016 10:25 AM, Yuanhan Liu wrote: > On Fri, Sep 09, 2016 at 10:16:25AM +0200, Olivier Matz wrote: >> Avoid access to mempool pointer if it is NULL. >> >> Fixes: b19a0c75a0d4 ("app/testpmd: remove anonymous mempool code") >> Coverity issue: 127553 >> >> Signed-off-by: Olivier

[dpdk-dev] [PATCH v3 00/15] Introduce SoC device/driver framework for EAL

Introduction: = This patch set is direct derivative of Jan's original series [1],[2]. - As this deviates substantially from original series, if need be I can post it as a separate patch rather than v2. Please suggest. - Also, there are comments on original v1 ([4]) which are

[dpdk-dev] [PATCH v3 01/15] eal/soc: introduce very essential SoC infra definitions

Define initial structures and functions for the SoC infrastructure. This patch supports only a very minimal functions for now. More features will be added in the following commits. Includes rte_device/rte_driver inheritance of rte_soc_device/rte_soc_driver. Signed-off-by: Jan Viktorin

[dpdk-dev] [PATCH v3 02/15] eal/soc: add rte_eal_soc_register/unregister logic

Registeration of a SoC driver through a helper DRIVER_REGISTER_SOC (on the lines of DRIVER_REGISTER_PCI). soc_driver_list stores all the registered drivers. Test case has been introduced to verify the registration and deregistration. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain

[dpdk-dev] [PATCH v3 03/15] eal/soc: Implement SoC device list and dump

SoC devices would be linked in a separate list (from PCI). This is used for probe function. A helper for dumping the device list is added. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 2 ++

[dpdk-dev] [PATCH v3 04/15] eal: introduce --no-soc option

This option has the same meaning for the SoC infra as the --no-pci for the PCI infra. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_eal/common/eal_common_options.c | 5 + lib/librte_eal/common/eal_internal_cfg.h | 1 +

[dpdk-dev] [PATCH v3 05/15] eal/soc: init SoC infra from EAL

Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_eal/bsdapp/eal/Makefile| 1 + lib/librte_eal/bsdapp/eal/eal.c | 4 +++ lib/librte_eal/bsdapp/eal/eal_soc.c | 46 lib/librte_eal/common/eal_private.h

[dpdk-dev] [PATCH v3 06/15] eal/soc: implement probing of drivers

Each SoC PMD registers a set of callback for scanning its own bus/infra and matching devices to drivers when probe is called. This patch introduces the infra for calls to SoC scan on rte_eal_soc_init() and match on rte_eal_soc_probe(). Patch also adds test case for scan and probe. Signed-off-by:

[dpdk-dev] [PATCH v3 07/15] eal/soc: extend and utilize devargs

It is assumed that SoC Devices provided on command line are prefixed with "soc:". This patch adds parse and attach support for such devices. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_eal/common/eal_common_dev.c | 27

[dpdk-dev] [PATCH v3 08/15] eal/soc: add drv_flags

The flags are copied from the PCI ones. They should be refactorized into a general set of flags in the future. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_eal/common/include/rte_soc.h | 10 ++ 1 file changed, 10 insertions(+)

[dpdk-dev] [PATCH v3 10/15] ether: utilize container_of for pci_drv

It is not necessary to place the rte_pci_driver at the beginning of the rte_eth_dev struct anymore as we use the container_of macro to get the parent pointer. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_ether/rte_ethdev.c | 4 ++--

[dpdk-dev] [PATCH v3 09/15] eal/soc: add intr_handle

Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_eal/common/include/rte_soc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_eal/common/include/rte_soc.h b/lib/librte_eal/common/include/rte_soc.h index 93d3a2f..aa4c678

[dpdk-dev] [PATCH v3 11/15] ether: verify we copy info from a PCI device

Now that different types of ethdev exist, check for presence of PCI dev while copying out the info. Similar would be done for SoC. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_ether/rte_ethdev.c | 2 ++ 1 file changed, 2 insertions(+)

[dpdk-dev] [PATCH v3 12/15] ether: extract function eth_dev_get_intr_handle

We abstract access to the intr_handle here as we want to get it either from the pci_dev or soc_dev. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_ether/rte_ethdev.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-)

[dpdk-dev] [PATCH v3 13/15] ether: extract function eth_dev_get_driver_name

Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_ether/rte_ethdev.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 104ea4a..4fa65ca

[dpdk-dev] [PATCH v3 14/15] ether: Support rte_soc_driver/device for etherdev

- eth_driver/rte_eth_dev embeds rte_soc_driver/device for relating SoC PMDs to ethernet devices. - Add probe and remove functions linked to eth_dev_init/uninit Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- lib/librte_ether/rte_ethdev.c | 129

[dpdk-dev] [PATCH v3 15/15] eal/crypto: Support rte_soc_driver/device for cryptodev

- rte_cryptodev_driver/rte_cryptodev_dev embeds rte_soc_driver/device for linking SoC PMDs to crypto devices. - Add probe and remove functions linked Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 122 -

[dpdk-dev] [RFC PATCH v2 0/5] add API's for VF management

Hi Thomas and Ferruh, Can you take a look and provide comments on ixgbe driver and ethdev changes. Thanks, Reshma > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bernard Iremonger > Sent: Friday, August 26, 2016 10:10 AM > To: Shah, Rahul R ; Lu, Wenzhuo

[dpdk-dev] [PATCH v2] net/vhost: add pmd xstats

Hi, Harry: Your idea looks very good. Thanks --Zhiyong > -Original Message- > From: Van Haaren, Harry > Sent: Friday, September 9, 2016 4:41 PM > To: Yang, Zhiyong ; dev at dpdk.org > Cc: yuanhan.liu at linux.intel.com; thomas.monjalon at 6wind.com; > "mailto:pmatilai"@redhat.com; Yang,

[dpdk-dev] [PATCH v9 01/25] eal: define macro container_of

On Fri, Sep 09, 2016 at 09:49:06AM +0530, Shreyansh Jain wrote: > Hi Ferruh, > > On Thursday 08 September 2016 07:46 PM, Ferruh Yigit wrote: > >On 9/7/2016 3:07 PM, Shreyansh Jain wrote: > >>Signed-off-by: Jan Viktorin > >>Signed-off-by: Shreyansh Jain > >>--- > >>

[dpdk-dev] [RFC][PATCH V2 1/3] examples/vhost: Add vswitch (generic switch) framework

Hi Pankaj, Thanks for the massive and great work. On 9/5/2016 6:54 PM, Pankaj Chauhan wrote: > Introduce support for a generic framework for handling of switching between > physical and vhost devices. The vswitch framework introduces the following > concept: > > 1. vswitch_dev: Vswitch device is

[dpdk-dev] [RFC] igb_uio: deprecate iomem and ioport mapping

Hello Jianfeng, On Thu, Sep 1, 2016 at 4:16 AM, Jianfeng Tan wrote: > Previously in igb_uio, iomem is mapped, and both ioport and io mem > are recorded into uio framework, which is duplicated and makes the > code too complex. > > For iomem, DPDK user space code never opens or reads files under >

[dpdk-dev] [RFC] igb_uio: deprecate iomem and ioport mapping

Hi David, Thank you for reviewing this. On 9/9/2016 5:06 PM, David Marchand wrote: > Hello Jianfeng, > > On Thu, Sep 1, 2016 at 4:16 AM, Jianfeng Tan > wrote: >> Previously in igb_uio, iomem is mapped, and both ioport and io mem >> are recorded into uio framework, which is duplicated and makes

[dpdk-dev] [PATCH v2] testpmd: fix crash when mempool allocation fails

Avoid access to mempool pointer if it is NULL. Fixes: b19a0c75a0d4 ("app/testpmd: remove anonymous mempool code") Coverity issue: 127553 Signed-off-by: Olivier Matz --- app/test-pmd/testpmd.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test-pmd/testpmd.c

[dpdk-dev] [PATCH v2] testpmd: fix crash when mempool allocation fails

Sorry, I just resent the same one... On 09/09/2016 11:40 AM, Olivier Matz wrote: > Avoid access to mempool pointer if it is NULL. > > Fixes: b19a0c75a0d4 ("app/testpmd: remove anonymous mempool code") > Coverity issue: 127553 > > Signed-off-by: Olivier Matz > --- > app/test-pmd/testpmd.c | 4

[dpdk-dev] [PATCH v3] testpmd: fix crash when mempool allocation fails

Avoid access to mempool pointer if it is NULL. Fixes: b19a0c75a0d4 ("app/testpmd: remove anonymous mempool code") Coverity issue: 127553 Signed-off-by: Olivier Matz --- app/test-pmd/testpmd.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test-pmd/testpmd.c

[dpdk-dev] [PATCH v9 01/25] eal: define macro container_of

Hi Adrien, On Friday 09 September 2016 02:25 PM, Adrien Mazarguil wrote: > This warning is a known issue in the Verbs header that will be addressed > eventually. It occurs even without Shreyansh's patch (more likely when > CONFIG_RTE_LIBRTE_MLX4_DEBUG and/or CONFIG_RTE_LIBRTE_MLX5_DEBUG are >

[dpdk-dev] [PATCH v5 0/6] vhost: optimize enqueue

This patch set optimizes the vhost enqueue function. It implements the vhost logic from scratch into a single function designed for high performance and good maintainability, and improves CPU efficiency significantly by optimizing cache access, which means: * Higher maximum throughput can be

[dpdk-dev] [PATCH v5 1/6] vhost: fix windows vm hang

This patch fixes a Windows VM compatibility issue in DPDK 16.07 vhost code which causes the guest to hang once any packets are enqueued when mrg_rxbuf is turned on by setting the right id and len in the used ring. As defined in virtio spec 0.95 and 1.0, in each used ring element, id means index

[dpdk-dev] [PATCH v5 2/6] vhost: rewrite enqueue

This patch implements the vhost logic from scratch into a single function designed for high performance and better maintainability. This is the baseline version of the new code, more optimization will be added in the following patches in this patch set. Signed-off-by: Zhihong Wang --- Changes

[dpdk-dev] [PATCH v5 3/6] vhost: remove useless volatile

This patch removes useless volatile attribute to allow compiler optimization. Signed-off-by: Zhihong Wang --- lib/librte_vhost/vhost.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index c2dfc3c..9707dfc 100644 ---

[dpdk-dev] [PATCH v5 4/6] vhost: add desc prefetch

This patch adds descriptor prefetch to hide cache access latency. Signed-off-by: Zhihong Wang --- lib/librte_vhost/virtio_net.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 6f63968..b38f18f 100644 ---

[dpdk-dev] [PATCH v5 5/6] vhost: batch update used ring

This patch enables batch update of the used ring for better efficiency. Signed-off-by: Zhihong Wang --- Changes in v4: 1. Free shadow used ring in the right place. 2. Add failure check for shadow used ring malloc. lib/librte_vhost/vhost.c | 20 -- lib/librte_vhost/vhost.h

[dpdk-dev] [PATCH v5 6/6] vhost: optimize cache access

This patch reorders the code to delay virtio header write to optimize cache access efficiency for cases where the mrg_rxbuf feature is turned on. It reduces CPU pipeline stall cycles significantly. Signed-off-by: Zhihong Wang --- Changes in v3: 1. Remove unnecessary memset which causes

[dpdk-dev] [PATCH] scripts: reverse order of checked commits

The list of git commits to check was in the reversed order. Also add a comment in the help of checkpatches.sh about list input. Signed-off-by: Thomas Monjalon --- scripts/check-git-log.sh | 10 +- scripts/checkpatches.sh | 7 +-- 2 files changed, 10 insertions(+), 7 deletions(-)

[dpdk-dev] [PATCH v3 3/4] bonding: take queue spinlock in rx/tx burst functions

Hi Bernard, This is an old patch, sorry for commenting after this long. On 6/12/2016 6:11 PM, Bernard Iremonger wrote: > Use rte_spinlock_trylock() in the rx/tx burst functions to > take the queue spinlock. > > Signed-off-by: Bernard Iremonger > Acked-by: Konstantin Ananyev > --- ... >

[dpdk-dev] [PATCH v9 00/25] Introducing rte_driver/rte_device generalization

Hi Stephen, On Thursday 08 September 2016 10:19 PM, Stephen Hemminger wrote: [...] >> > I think yes. There are separate lists for all device types which helps >> > keep the EAL code free of type checks. But, functionally it doesn't make >> > that big a different between a common or specific list.

[dpdk-dev] [PATCH] kni: unregister an unregisterd net_device could cause a kernel crash

2016-09-08 18:15, Ferruh Yigit: > On 9/8/2016 5:44 PM, Stephen Hemminger wrote: > > ... > > > But then again the whole KNI driver fails completely when > > running kernel style check. > > > > Yes, it generates lots of warnings. > I can fix them (excluding ethtool/*), that wouldn't take much

[dpdk-dev] [PATCH v3] ntnic: add PMD driver

This is the Napatech NTNIC Poll Mode Driver (PMD) for DPDK. This patch adds support for Napatech NICs to DPDK. This is the initial implementation. Signed-off-by: Finn Christensen --- v3: * Removed the need for binary libraries on build v2: * Added information how to build the PMD without

[dpdk-dev] [RFC PATCH v2 0/5] add API's for VF management

2016-09-09 08:49, Pattan, Reshma: > Hi Thomas and Ferruh, > > Can you take a look and provide comments on ixgbe driver and ethdev changes. We could try. But honestly we have a lot of work to do for DPDK, except reviews. So I would appreciate to see more reviewers on ethdev stuff. Volunteers

[dpdk-dev] [PATCH] scripts: reverse order of checked commits

On Fri, Sep 9, 2016 at 1:11 PM, Thomas Monjalon wrote: > The list of git commits to check was in the reversed order. > Also add a comment in the help of checkpatches.sh about list input. > > Signed-off-by: Thomas Monjalon Thanks Thomas. Tested-by: David Marchand -- David Marchand

[dpdk-dev] [PATCH] kni: fix crash for KNI interface remove

2016-08-31 14:06, Ferruh Yigit: > Removing KNI interface that has no PCI driver for ethtool support cause > kernel crash. > > Fixes: 109febfe58f9 ("net/igb: move PCI device IDs from EAL") > Fixes: 221fba3b987c ("net/ixgbe: move PCI device IDs from EAL") > > Signed-off-by: Ferruh Yigit Applied,

[dpdk-dev] [PATCH v3] ntnic: add PMD driver

On Fri, Sep 09, 2016 at 12:48:38PM +, Finn Christensen wrote: > This is the Napatech NTNIC Poll Mode Driver (PMD) for DPDK. > > This patch adds support for Napatech NICs to DPDK. This is the > initial implementation. > > Signed-off-by: Finn Christensen > --- > v3: > * Removed the need for

[dpdk-dev] [PATCH v2] kni: support RHEL 6.8

2016-08-31 15:49, Ferruh Yigit: > Add support for RHEL6.8 which uses an old version of kernel with some > new features backported. > > Signed-off-by: Ferruh Yigit Applied, thanks

[dpdk-dev] [RFC PATCH v2 1/5] librte_ether: add internal callback functions

On Fri, Aug 26, 2016 at 10:10:16AM +0100, Bernard Iremonger wrote: > add _rte_eth_dev_callback_process_vf function. > add _rte_eth_dev_callback_process_generic function > > Adding a callback to the user application on VF to PF mailbox message, > allows passing information to the application

[dpdk-dev] [PATCH v4]net/virtio: add mtu set in virtio

Hi Liu, Yes agreed your comment. I will definitely remove the declaration as it is not really required. So the latest patch will look like this . Yes I did rush a bit to submit the patch last will correct my suite. So sending the patch in a reply if we have more comments we can take a look

[dpdk-dev] [RFC PATCH v2 3/5] librte_ether: add API's for VF management

On Fri, Aug 26, 2016 at 10:10:18AM +0100, Bernard Iremonger wrote: > Add new API functions to configure and manage VF's on a NIC. > > add rte_eth_dev_vf_ping function. > add rte_eth_dev_set_vf_vlan_anti_spoof function. > add rte_eth_dev_set_vf_mac_anti_spoof function. > > Signed-off-by:

[dpdk-dev] [PATCH v2] kni: Bug fix in module_init and module_exit

2016-09-06 09:02, Ferruh Yigit: > On 9/2/2016 11:23 AM, Vincent Guo wrote: > > Fix pernet calls when HAVE_SIMPLIFIED_PERNET_OPERATIONS is not set. > > > > Fixes: e6734d21b4e1 ("kni: fix build with kernel 2.6.32") > > > > Signed-off-by: Vincent Guo > > Only patch subject should start with

[dpdk-dev] [PATCH] kni: unregister an unregisterd net_device could cause a kernel crash

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Friday, September 9, 2016 1:40 PM > To: Yigit, Ferruh > Cc: Stephen Hemminger ; zhouyangchao > ; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] kni: unregister an unregisterd

[dpdk-dev] [PATCH v4]net/virtio: add mtu set in virtio

> >Hi Liu, > >Yes agreed your comment. I will definitely remove the declaration as it is not >really >required. > So the latest patch will look like this . Yes I did rush a bit to submit the > patch last will >correct my suite. So sending the patch in a reply if we have more comments we >can

[dpdk-dev] [PATCH v4]net/virtio: add mtu set in virtio

Hi Mark, Yes I thought I did that change. Sorry once again.. making too many mistakes. Changed it . Thanks. The MTU here is L3 MTU. Setting this will help in reducing the fragmented/multi-segmented packets and also in case we want to reduce the MTU below 1500, to support VXLAN or GRE tunnel

[dpdk-dev] [PATCH v4]net/virtio: add mtu set in virtio

> >Hi Mark, > >Yes I thought I did that change. Sorry once again.. making too many mistakes. >Changed it . >Thanks. >The MTU here is L3 MTU. Setting this will help in reducing the >fragmented/multi-segmented >packets and also in case we want to reduce the MTU below 1500, to support >VXLAN or

[dpdk-dev] [PATCH v2 0/2] Add HMAC_MD5 to Intel QuickAssist Technology driver

This patchset add capability to use HMAC_MD5 hash algorithm to Intel QuickAssist Technology driver and test cases to cryptodev test files. This patchset depends on the following patches/patchsets: "crypto/qat: make the session struct variable in size"

[dpdk-dev] [PATCH v2 1/2] crypto/qat: add MD5 HMAC capability to Intel QAT driver

From: Arkadiusz Kusztal Added posibility to compute MD5 HMAC digest with Intel QuickAssist Technology Driver Signed-off-by: Arek Kusztal Signed-off-by: Deepak Kumar Jain Acked-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst| 1 +

[dpdk-dev] [PATCH v2 2/2] app/test: add test cases for MD5 HMAC for Intel QAT driver

From: Arkadiusz Kusztal Added MD5 HMAC hash algorithm to test file for Intel QuickAssist Technology Driver Signed-off-by: Arek Kusztal Acked-by: Fiona Trahe --- app/test/test_cryptodev.c | 185

[dpdk-dev] [PATCH v7 0/9] enable lpm, acl and other missing libraries in ppc64le

> > v7 changes: > > - removed enforcing cache alignment for table hash structs and > > instead check only for multiples of 64 bytes. > > > > Acked-by: Cristian Dumitrescu Applied, thanks We now have some AltiVec code in DPDK!

[dpdk-dev] [PATCH v9 00/25] Introducing rte_driver/rte_device generalization

On 07/09/16 15:07, Shreyansh Jain wrote: > Based on master (e22856313) > > Background: > === > > It includes two different patch-sets floated on ML earlier: > * Original patch series is from David Marchand [1], [2]. > `- This focused mainly on PCI (PDEV) part > `- v7 of this was

[dpdk-dev] [PATCH 1/1] doc: clarify usage of testpmd mac fwd mode

Explain default testpmd behavior in mac fwd mode to remove amiguity/confusion regarding user's ability to specify Ethernet addresses. Signed-off-by: Mark Kavanagh --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git

[dpdk-dev] [PATCH v4]net/virtio: add mtu set in virtio

Hi Mark/Liu, Thanks to both of you for being so patient with a series of silly errors. I have tried to make it better this time. Also there were some un-used variable in the function which I have removed. Please check the new patch with all your comments incorporated. Also along

[dpdk-dev] FM10420 (RRC) - Problems with PMD matching on virtual functions in ACL table

Hello All. I have an FM10420 card with dual 100G ports, I am running a DPDK application that binds two virtual function ports to it. I tried to set rules to the IES to match on the ports logical id (for the VF's), the rules are configured well but are not working (not matching). If i dont use

[dpdk-dev] meter: excess token bucket update in srtcm

Thanks, Nikhil, will review and get back to you in the next couple of weeks. Regards, Cristian From: Nikhil Jagtap [mailto:nikhil.jag...@gmail.com] Sent: Wednesday, September 7, 2016 7:22 AM To: Dumitrescu, Cristian Cc: Ramia, Kannan Babu ; dev at dpdk.org Subject: Re: [dpdk-dev] meter: excess

[dpdk-dev] [PATCH v2 1/3] lib/librte_port: enable file descriptor port support

> -Original Message- > From: Richardson, Bruce > Sent: Monday, September 5, 2016 11:12 AM > To: Singh, Jasvinder > Cc: dev at dpdk.org; Dumitrescu, Cristian > Subject: Re: [dpdk-dev] [PATCH v2 1/3] lib/librte_port: enable file descriptor > port support > > On Sun, Sep 04, 2016 at

[dpdk-dev] [PATCH v2] kni: fix build with kernel 4.8

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ferruh Yigit > Sent: Thursday, September 08, 2016 11:32 AM > To: dev at dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v2] kni: fix build with kernel 4.8 > > Linux kernel v4.8 removes macro