For storage virtualization use cases, vhost-scsi becomes a more popular
solution to support VMs. However a user space vhost-scsi-user solution
does not exist currently. SPDK(Storage Performance Development Kit,
https://github.com/spdk/spdk) will provide a user space vhost-scsi target
to support
Hi Mark/Liu,
Is there any further comments to the below patch ? Should I submit it
as v5 of the patch ?
--
Regards,
Souvik
-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Dey, Souvik
Sent: Monday, September 12, 2016 11:12 AM
To: Kavanagh, Mark B ;
I've been having trouble getting virtio (in legacy mode) working with the
multi-process model. The latest issue is as follows:
- The primary process calls vtpci_init() with a struct
rte_pci_device that's only valid in that process
- For legacy mode vtpci_init() calls rte_eal_pci_ioport() with
On Thu, Sep 15, 2016 at 08:28:18AM +0800, Changpeng Liu wrote:
> Since we changed the vhost library as a common framework to add other
As I said in my earlier email, I don't see how common it becomes after
your refactoring. __Another__ for example, I just saw a bunch of
duplicated code below that
On Wed, Sep 14, 2016 at 12:25:21AM +, Dey, Souvik wrote:
> Hi Mark/Liu,
> Is there any further comments to the below patch ? Should I submit it
> as v5 of the patch ?
I think I'm okay with the patch now. But I got one more ask for you :)
In commit log, you stated:
Virtio
On Tue, Sep 13, 2016 at 05:10:09PM +0200, Thomas Monjalon wrote:
> 2016-09-13 14:47, Ciara Loftus:
> > In some cases when using the vHost PMD, certain vHost library functions
> > may still need to be accessed. One such example is the
> > rte_vhost_get_queue_num function which returns the number of
> -Original Message-
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Wednesday, September 14, 2016 11:29 AM
> To: Liu, Changpeng
> Cc: dev at dpdk.org; Harris, James R
> Subject: Re: [PATCH v2 2/2] vhost: add vhost-scsi support to vhost library
>
> On Thu, Sep 15,
Hi,
> -Original Message-
> From: Wang, Xiao W
> Sent: Tuesday, September 06, 2016 9:27 AM
> To: dev at dpdk.org
> Cc: Chen, Jing D ; olivier.matz at 6wind.com; Wang,
> Xiao W
>
> Subject: [PATCH v2 0/5] implement new Rx checksum flag
>
> v2:
> * Removed hw_ip_checksum check in
On Wed, Sep 14, 2016 at 04:46:21AM +, Liu, Changpeng wrote:
> > Few more generic comments:
> >
> > - you touched way more code than necessary.
> >
> > - you should split your patches into some small patches: one patch just
> > does one tiny logic. Doing one bunch of stuff in one patch is
On Fri, Sep 09, 2016 at 04:15:27PM +0800, Zhiyong Yang wrote:
> +struct vhost_xstats {
> + uint64_t stat[16];
> +};
> +
> struct vhost_queue {
> int vid;
> rte_atomic32_t allow_queuing;
> @@ -85,7 +89,8 @@ struct vhost_queue {
> uint64_t missed_pkts;
> uint64_t
2016-09-14 12:43, Yuanhan Liu:
> On Tue, Sep 13, 2016 at 05:10:09PM +0200, Thomas Monjalon wrote:
> > 2016-09-13 14:47, Ciara Loftus:
> > > In some cases when using the vHost PMD, certain vHost library functions
> > > may still need to be accessed. One such example is the
> > >
On Wed, Sep 14, 2016 at 09:10:48AM +0200, Thomas Monjalon wrote:
> 2016-09-14 12:43, Yuanhan Liu:
> > On Tue, Sep 13, 2016 at 05:10:09PM +0200, Thomas Monjalon wrote:
> > > 2016-09-13 14:47, Ciara Loftus:
> > > > In some cases when using the vHost PMD, certain vHost library functions
> > > > may
Hi, yuanhan:
Thanks so much for your detailed comments.
> -Original Message-
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Wednesday, September 14, 2016 2:20 PM
> To: Yang, Zhiyong
> Cc: dev at dpdk.org; thomas.monjalon at 6wind.com; pmatilai at redhat.com
>
Fill RSS hash result in mbuf.
To be applied on top of
"[PATCH 0/6] net/mlx5: performance improvement"
Nelio Laranjeiro (1):
net/mlx5: return RSS hash result in mbuf
drivers/net/mlx5/mlx5_rxq.c | 1 +
drivers/net/mlx5/mlx5_rxtx.c | 6 +-
drivers/net/mlx5/mlx5_rxtx.h | 2 ++
3 files
Signed-off-by: Nelio Laranjeiro
---
drivers/net/mlx5/mlx5_rxq.c | 1 +
drivers/net/mlx5/mlx5_rxtx.c | 6 +-
drivers/net/mlx5/mlx5_rxtx.h | 2 ++
3 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index f6f4315..65c264b
> > + desc_current =
> > + vq->avail->ring[(vq->last_used_idx)
> &
> > + (vq->size - 1)];
> > + desc_chain_head = desc_current;
> > + desc =
> -Original Message-
> From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com]
> Sent: Tuesday, September 13, 2016 12:27 AM
> To: Wang, Zhihong ; dev at dpdk.org
> Cc: yuanhan.liu at linux.intel.com; thomas.monjalon at 6wind.com
> Subject: Re: [PATCH v5 2/6] vhost: rewrite enqueue
>
Hi, Yuanhan:
Sorry to misunderstand your comment.
> -Original Message-
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Wednesday, September 14, 2016 2:20 PM
> To: Yang, Zhiyong
> Cc: dev at dpdk.org; thomas.monjalon at 6wind.com; pmatilai at redhat.com
>
2016-09-14 15:21, Yuanhan Liu:
> On Wed, Sep 14, 2016 at 09:10:48AM +0200, Thomas Monjalon wrote:
> > 2016-09-14 12:43, Yuanhan Liu:
> > > On Tue, Sep 13, 2016 at 05:10:09PM +0200, Thomas Monjalon wrote:
> > > > 2016-09-13 14:47, Ciara Loftus:
> > > > > In some cases when using the vHost PMD,
> -Original Message-
> From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com]
> Sent: Monday, September 12, 2016 11:46 PM
> To: Wang, Zhihong ; dev at dpdk.org
> Cc: yuanhan.liu at linux.intel.com; thomas.monjalon at 6wind.com
> Subject: Re: [PATCH v5 5/6] vhost: batch update used
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Akhil Goyal
> Sent: Monday, September 12, 2016 1:17 PM
> To: Azarewicz, PiotrX T ; Doherty, Declan
> ; dev at dpdk.org
> Cc: Kerlin, MarcinX ; Mrozowicz, SlawomirX
> ; Kobylinski, MichalX
> ; Kulasek, TomaszX
>
From: Deepak Kumar JAIN
Signed-off-by: Deepak Kumar Jain
Acked-by: Fiona Trahe
---
Changes in v2:
Added new feature information in release_16_11.rst file.
doc/guides/cryptodevs/qat.rst | 76 +++---
Hi Nelio,
On 9/7/2016 8:02 AM, Nelio Laranjeiro wrote:
> To improve performance the NIC expects for large packets to have a pointer
> to a cache aligned address, old inline code could break this assumption
> which hurts performance.
>
> Fixes: 2a66cf378954 ("net/mlx5: support inline send")
>
>
RTE_DEVEL_BUILD is set to := y in mk/rte.vars.mk, which makes it
impossible to override via an environment variable, and forces users
to pass it inline in the make call.
Use ?= instead to have it pick up the environment variable as well.
Cc:
Signed-off-by: Luca Boccassi
---
mk/rte.vars.mk | 2
On Wed, Sep 14, 2016 at 12:50 PM, Luca Boccassi
wrote:
> RTE_DEVEL_BUILD is set to := y in mk/rte.vars.mk, which makes it
> impossible to override via an environment variable, and forces users
> to pass it inline in the make call.
> Use ?= instead to have it pick up the environment variable as
On Tue, Aug 30, 2016 at 7:25 PM, Luca Boccassi wrote:
> Some targets in mk/internal/rte.compile-pre.mk are calling CC or
> HOSTCC without passing CPPFLAGS, EXTRA_CPPFLAGS or HOST_CPPFLAGS,
> HOST_EXTRA_CPPFLAGS.
> On Debian/Ubuntu builds this means that preprocessor flags set by the
>
On Wed, Sep 14, 2016 at 11:43:35AM +0100, Ferruh Yigit wrote:
> Hi Nelio,
>
> On 9/7/2016 8:02 AM, Nelio Laranjeiro wrote:
> > To improve performance the NIC expects for large packets to have a pointer
> > to a cache aligned address, old inline code could break this assumption
> > which hurts
On Tue, Sep 13, 2016 at 02:05:49PM +, ZELEZNIAK, ALEX wrote:
> Idea here is not to allow VM to control policies assigned to it for security
> and other reasons. PF is controlled by host and dictates what VM can and
> can't do in regards of setting VF parameters.
I think the proposed scheme,
- Flow director
- Rx Capabilities
- Inline
Changes in V2:
- Fix a compilation error.
Adrien Mazarguil (1):
net/mlx5: fix Rx VLAN offload capability report
Nelio Laranjeiro (3):
net/mlx5: force inline for completion function
net/mlx5: re-factorize functions
net/mlx5: fix inline
From: Yaacov Hazan
The return value in DPDK is negative errno on failure.
Since internal functions in mlx driver return positive
values need to negate this value when it returned to
dpdk layer.
Fixes: 76f5c99 ("mlx5: support flow director")
Signed-off-by: Yaacov Hazan
From: Adrien Mazarguil
This capability is implemented but not reported.
Fixes: f3db9489188a ("mlx5: support Rx VLAN stripping")
Signed-off-by: Adrien Mazarguil
---
drivers/net/mlx5/mlx5_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
From: Raslan Darawsheh
memmove was moving bytes as the number of elements next to i, while it
should move the number of elements multiplied by the size of each element.
Fixes: e9086978 ("mlx5: support VLAN filtering")
Signed-off-by: Raslan Darawsheh
---
From: Yaacov Hazan
This is done to prepare support for drop queues, which are not related to
existing RX queues and need to be managed separately.
Signed-off-by: Yaacov Hazan
Signed-off-by: Adrien Mazarguil
---
drivers/net/mlx5/mlx5.h | 1 +
From: Yaacov Hazan
Packet rejection was routed to a polled queue. This patch route them to a
dummy queue which is not polled.
Fixes: 76f5c99e6840 ("mlx5: support flow director")
Signed-off-by: Yaacov Hazan
Signed-off-by: Adrien Mazarguil
Signed-off-by: Nelio Laranjeiro
This function was supposed to be inlined, but was not because several
functions calls it. This function should always be inline avoid
external function calls and to optimize code in data-path.
Signed-off-by: Nelio Laranjeiro
---
drivers/net/mlx5/mlx5_rxtx.c | 5 -
1 file changed, 4
Rework logic of wqe_write() and wqe_write_vlan() which are pretty similar
to keep a single one.
Signed-off-by: Nelio Laranjeiro
---
drivers/net/mlx5/mlx5_rxtx.c | 98 ++--
1 file changed, 22 insertions(+), 76 deletions(-)
diff --git
To improve performance the NIC expects for large packets to have a pointer
to a cache aligned address, old inline code could break this assumption
which hurts performance.
Fixes: 2a66cf378954 ("net/mlx5: support inline send")
Signed-off-by: Nelio Laranjeiro
Signed-off-by: Vasily Philipov
---
On Wed, 2016-08-31 at 09:50 +0200, Christian Ehrhardt wrote:
> *Updates in v2*
> - rebased to latest upstream
> - moved tools to their own guide section
> - fixed some wording and indents
> - properly marked fixed-width text elements
> - fixed some rst issues in devbind doc
>
> Hi,
> this is
>
>>
>>Hi Mark/Liu,
>>? Thanks to both of you for being so patient with a series
>>of silly errors. I have tried to make it better this time. Also there
>>were some un-used variable in the function which I have removed. Please
>>check the new patch with all your comments incorporated.
- Rework structure elements to reduce their size.
- Removes a second useless loop in Tx burst function.
This series should be applied on top of "net/mlx5: various fixes".
Changes in v2:
- rework serie to apply it on top of "net/mlx5: various fixes".
Nelio Laranjeiro (6):
net/mlx5: rework
Rework Work Queue Element (aka WQE) structures to fit PMD needs.
A WQE is an aggregation of 16 bytes elements known as "data segments"
(aka dseg).
Signed-off-by: Nelio Laranjeiro
---
drivers/net/mlx5/mlx5_prm.h | 70 ++
drivers/net/mlx5/mlx5_rxtx.c | 167
PMD uses only power of two number of descriptors, storing the number of
elements in log2 helps to reduce the size of the container to store it.
Signed-off-by: Nelio Laranjeiro
Signed-off-by: Adrien Mazarguil
---
drivers/net/mlx5/mlx5_ethdev.c | 4 ++--
drivers/net/mlx5/mlx5_rxq.c| 10
PMD uses only power of two number of Completion Queue Elements, storing the
number of elements in log2 helps to reduce the size of the container to
store it.
Signed-off-by: Nelio Laranjeiro
---
drivers/net/mlx5/mlx5_rxq.c | 2 +-
drivers/net/mlx5/mlx5_rxtx.c | 8
Blue Flame is a buffer allocated with a power of two value, its size is
returned by Verbs in log2.
Signed-off-by: Nelio Laranjeiro
---
drivers/net/mlx5/mlx5_rxtx.c | 2 +-
drivers/net/mlx5/mlx5_rxtx.h | 2 +-
drivers/net/mlx5/mlx5_txq.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
PMD uses only power of two number of Work Queue Elements, storing the
number of elements in log2 helps to reduce the size of the container to
store it.
Signed-off-by: Nelio Laranjeiro
---
drivers/net/mlx5/mlx5_rxtx.c | 23 ---
drivers/net/mlx5/mlx5_rxtx.h | 2 +-
Tx function was handling a double loop to send segmented packets, it can be
done in a single one.
Signed-off-by: Nelio Laranjeiro
Signed-off-by: Vasily Philipov
---
drivers/net/mlx5/mlx5_rxtx.c | 312 ++-
1 file changed, 158 insertions(+), 154
On Wed, Sep 14, 2016 at 01:53:47PM +0200, Nelio Laranjeiro wrote:
> - Flow director
> - Rx Capabilities
> - Inline
>
> Changes in V2:
>
> - Fix a compilation error.
>
> Adrien Mazarguil (1):
> net/mlx5: fix Rx VLAN offload capability report
>
> Nelio Laranjeiro (3):
> net/mlx5: force
On 7/7/2016 1:19 PM, Olivier Matz wrote:
> Update desc_to_olflags_v() to set PKT_RX_IP_CKSUM_BAD and
> PKT_RX_L4_CKSUM_BAD in the ol_fags of the mbuf.
>
> The Rx vector function can now be used with hw_ip_checksum
> enabled.
>
> Tested with:
>
> cd dpdk.org/
> make config
Hi Harish,
On 7/12/2016 6:39 AM, Harish Patil wrote:
>>
>> Correctly hint the cache line size. Remove unused macros associated
>> with the cache line size.
>>
>> Fixes: 540a211084a7 ("bnx2x: driver core")
>>
>> Signed-off-by: Chas Williams <3chas3 at gmail.com>
>> ---
>>
On 9/1/2016 3:47 PM, Jeff Shaw wrote:
> On Fri, Jul 15, 2016 at 10:26:23PM +0200, Thomas Monjalon wrote:
>> 2016-07-14 09:59, Jeff Shaw:
>>> Our testing suggests minimal (in some cases zero) impact to core-bound
>>> forwarding throughput as measured by testpmd. Throughput increase is
>>> observed
Howdy,
Just noticed a line of code that struck me as odd and so I am writing just
in case it is a bug:
http://dpdk.org/browse/dpdk/tree/drivers/net/mlx5/mlx5_rxtx.c#n1014
Specifically the check "(mpw.length != length)" in mlx_tx_burst_mpw() looks
like a descriptor-format optimization for the
On 7/14/2016 6:27 PM, Vladyslav Buslov wrote:
> Added prefetch of first packet payload cacheline in i40e_rx_scan_hw_ring
> Added prefetch of second mbuf cacheline in i40e_rx_alloc_bufs
>
> Signed-off-by: Vladyslav Buslov
> ---
> drivers/net/i40e/i40e_rxtx.c | 7 +--
> 1 file changed, 5
On 7/20/2016 6:11 PM, Zoltan Kiss wrote:
> Using weak symbols have a few issues with static linking:
>
> - normally the linker searches the .o files already linked, if your weak
> one is there, it won't check if there is a strong version
> - unless the symbol is directly referred, but it's not
On 7/27/2016 2:11 PM, Ali Volkan ATLI wrote:
> Signed-off-by: Ali Volkan ATLI
> ---
Fixes: 0f6b7c7f7a37 ("igb: use DD bit to count RX available descriptors")
function names not desired in patch subject, what about something like
following:
net/e1000: fix number of available Rx descriptors
On 8/2/2016 8:34 PM, Rich Lane wrote:
> When using VMDQ+RSS, the queue ids used by the application are not
> contiguous (see i40e_pf_config_rss). Most of the driver already handled
> this, but there were a few cases where it assumed all configured queues
> had been setup.
>
> Fixes: 4861cde46116
On 8/4/2016 7:24 PM, Eric Kinzie wrote:
> This series contains a fix to the validation of interfaces added to a
> bond group and an enhancement to allow reception of tagged frames on
> slave interfaces that are virtual functions.
>
> Eric Kinzie (2):
> net/bonding: validate speed after link up
On 8/9/2016 3:07 AM, Wei Zhao1 wrote:
> rx_good_bytes and rx_good_packets statistic is inconsistent when port
> stopped,ipackets statistic is minus the discard packets but rx_bytes
> statistic not,but i40e has no statistic of discard bytes.So we check
> "dev_started" flag, if the port is started
Hi Luke,
On Wed, Sep 14, 2016 at 03:24:07PM +0200, Luke Gorrie wrote:
> Howdy,
>
> Just noticed a line of code that struck me as odd and so I am writing just
> in case it is a bug:
>
> http://dpdk.org/browse/dpdk/tree/drivers/net/mlx5/mlx5_rxtx.c#n1014
>
> Specifically the check "(mpw.length
Hi Liu,
Comments embedded.
Rgds,
John.
On 05/09/16 04:23, Yuanhan Liu wrote:
> On Thu, Sep 01, 2016 at 11:21:38AM +0100, John Griffin wrote:
>> Remove the dependency on dev->driver->pci_drv.name when
>> creating the memzone for the qat hardware queues.
>> The pci_drv.name may grow too large for
On 8/8/2016 12:17 PM, Ferruh Yigit wrote:
> On 8/6/2016 7:16 AM, Rami Rosen wrote:
>> This patch fixes a typo in doc/guides/nics/intel_vf.rst.
>>
>> Signed-off-by: Rami Rosen
>
> Acked-by: Ferruh Yigit
>
Fixes: fc1f2750a3ec ("doc: programmers guide")
Add support for RHEL 7.3, which uses kernel 3.10,
but backported features from newer kernels.
Signed-off-by: Pablo de Lara
---
lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
Hi Adrien,
On 14 September 2016 at 16:30, Adrien Mazarguil
wrote:
> Your interpretation is correct (this is intentional and not a bug).
>
Thanks very much for clarifying.
This is interesting to me because I am also working on a ConnectX-4 (Lx)
driver based on the newly released driver
Hi Mark/Liu,
I know this might be a redundant question, but should I put your names
in the Reviewed-by section in v5 ?
--
Regards,
Souvik
-Original Message-
From: Kavanagh, Mark B [mailto:mark.b.kavan...@intel.com]
Sent: Wednesday, September 14, 2016 8:16 AM
To: Dey, Souvik ;
Hello,
Can you please review the change and let me know if any comments. I would like
to push this patch to 16.11 release. Thanks. Please note this fix is tested as
well.
Regards
Suyash Karmarkar
_
From: Karmarkar Suyash
Sent: Monday, August 29, 2016
64 matches
Mail list logo