[dpdk-dev] [PATCH v7] net/virtio: add set_mtu in virtio

2016-10-05 Thread Dey, Souvik
Hi All, Is there any further comments or modifications required for this patch, or what next steps do you guys suggest here ? -- Regards, Souvik -Original Message- From: Dey, Souvik Sent: Saturday, October 1, 2016 10:09 AM To: mark.b.kavanagh at intel.com; yuanhan.liu at

[dpdk-dev] [PATCH v5 0/4] Cuckoo hash enhancements

2016-10-05 Thread Pablo de Lara
This patchset improves lookup performance on the current hash library by changing the existing lookup bulk pipeline, with an improved pipeline, based on a loop-and-jump model, instead of the current 4-stage 2-entry pipeline. Also, x86 vectorized intrinsics are used to improve performance when

[dpdk-dev] [PATCH v5 1/4] hash: reorder hash structure

2016-10-05 Thread Pablo de Lara
In order to optimize lookup performance, hash structure is reordered, so all fields used for lookup will be in the first cache line. Signed-off-by: Pablo de Lara Acked-by: Bruce Richardson Acked-by: Sameh Gobriel --- lib/librte_hash/rte_cuckoo_hash.h | 36 +---

[dpdk-dev] [PATCH v5 2/4] hash: reorganize bucket structure

2016-10-05 Thread Pablo de Lara
From: Byron Marohn Move current signatures of all entries together in the bucket and same with all alternative signatures, instead of having current and alternative signatures together per entry in the bucket. This will be benefitial in the next commits, where a

[dpdk-dev] [PATCH v5 3/4] hash: add vectorized comparison

2016-10-05 Thread Pablo de Lara
From: Byron Marohn In lookup bulk function, the signatures of all entries are compared against the signature of the key that is being looked up. Now that all the signatures are together, they can be compared with vector instructions (SSE, AVX2), achieving higher lookup

[dpdk-dev] [PATCH v5 4/4] hash: modify lookup bulk pipeline

2016-10-05 Thread Pablo de Lara
From: Byron Marohn This patch replaces the pipelined rte_hash lookup mechanism with a loop-and-jump model, which performs significantly better, especially for smaller table sizes and smaller table occupancies. Signed-off-by: Byron Marohn Signed-off-by: Saikrishna

[dpdk-dev] [PATCH v6 0/4] new crypto software based device

2016-10-05 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Slawomir Mrozowicz > Sent: Tuesday, October 04, 2016 8:11 AM > To: dev at dpdk.org > Cc: Mrozowicz, SlawomirX > Subject: [dpdk-dev] [PATCH v6 0/4] new crypto software based device > > This code provides the

[dpdk-dev] [PATCH v6 0/4] new crypto software based device

2016-10-05 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Tuesday, October 04, 2016 4:37 PM > To: Mrozowicz, SlawomirX; dev at dpdk.org > Cc: Mrozowicz, SlawomirX > Subject: Re: [dpdk-dev] [PATCH v6 0/4] new crypto software based

[dpdk-dev] [PATCH] examples/ipsec-secgw: Update checksum while decrementing ttl

2016-10-05 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Sergio Gonzalez > Monroy > Sent: Monday, September 26, 2016 6:28 AM > To: akhil.goyal at nxp.com; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: Update checksum > while decrementing

[dpdk-dev] [PATCH v3 0/9] IPsec Enhancements

2016-10-05 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Thursday, September 29, 2016 5:28 PM > To: Gonzalez Monroy, Sergio; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 0/9] IPsec Enhancements > > > > > -Original

[dpdk-dev] [PATCH v2] app/test: remove hard-coding of crypto num qps

2016-10-05 Thread De Lara Guarch, Pablo
Hi, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Fiona Trahe > Sent: Thursday, September 29, 2016 10:18 AM > To: dev at dpdk.org > Cc: De Lara Guarch, Pablo; Trahe, Fiona; Akhil Goyal > Subject: [dpdk-dev] [PATCH v2] app/test: remove hard-coding of crypto

[dpdk-dev] [PATCH 1/2] i40e: Add packet_type metadata in the i40e vPMD

2016-10-05 Thread Chen, Jing D
Hi, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jeff Shaw > Sent: Thursday, July 14, 2016 9:59 AM > To: dev at dpdk.org; Zhang, Helin ; Wu, Jingjing > ; damarion at cisco.com > Subject: [dpdk-dev] [PATCH 1/2] i40e: Add packet_type metadata in the i40e >

[dpdk-dev] [PATCH] cryptodev: fix compilation error in SUSE 11 SP2

2016-10-05 Thread De Lara Guarch, Pablo
Hi Adrien, > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com] > Sent: Friday, September 30, 2016 1:34 AM > To: De Lara Guarch, Pablo > Cc: dev at dpdk.org; Doherty, Declan > Subject: Re: [PATCH] cryptodev: fix compilation error in SUSE 11 SP2 > > On Thu,

[dpdk-dev] [PATCH v2] cryptodev: fix compilation error in SUSE 11 SP2

2016-10-05 Thread Pablo de Lara
This commit fixes following build error, which happens in SUSE 11 SP2, with gcc 4.5.1: In file included from lib/librte_cryptodev/rte_cryptodev.c:70:0: lib/librte_cryptodev/rte_cryptodev.h:772:7: error: flexible array member in otherwise empty struct Fixes: 347a1e037fd3 ("lib: use C99 syntax for

[dpdk-dev] [PATCH v2 4/8] app/testpmd: add option to enable lro

2016-10-05 Thread De Lara Guarch, Pablo
Hi Olivier, > -Original Message- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Friday, September 09, 2016 12:56 AM > To: dev at dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH v2 4/8] app/testpmd: add option to enable lro > > Introduce a new argument '--enable-lro' to

[dpdk-dev] [PATCH] examples/ipsec-secgw: Update checksum while decrementing ttl

2016-10-05 Thread Akhil Goyal
On 10/5/2016 6:04 AM, De Lara Guarch, Pablo wrote: > > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Sergio Gonzalez >> Monroy >> Sent: Monday, September 26, 2016 6:28 AM >> To: akhil.goyal at nxp.com; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH]

[dpdk-dev] [PATCH] test_cryptodev_perf: IV and digest should be stored at a DMAeble address

2016-10-05 Thread Akhil Goyal
On 9/26/2016 10:03 PM, akhil.goyal at nxp.com wrote: > From: Akhil Goyal > > For physical crypto devices, IV and digest are processed by the crypto > device which need the contents to be written on some DMA able address. > > So in order to do that, IV and digest are accomodated in the packet. > >

[dpdk-dev] [PATCH v2 1/8] mbuf: add function to dump ol flag list

2016-10-05 Thread De Lara Guarch, Pablo
Hi Olivier, > -Original Message- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Friday, September 09, 2016 12:55 AM > To: dev at dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH v2 1/8] mbuf: add function to dump ol flag list > > The functions rte_get_rx_ol_flag_name()

[dpdk-dev] qos: traffic shaping at queue level

2016-10-05 Thread Nikhil Jagtap
Hi Cristian, Thanks for the info. A few more comments/questions inline. On 3 October 2016 at 23:42, Dumitrescu, Cristian < cristian.dumitrescu at intel.com> wrote: > > > > > *From:* Nikhil Jagtap [mailto:nikhil.jagtap at gmail.com] > *Sent:* Friday, September 30, 2016 7:12 AM > *To:* dev at

[dpdk-dev] [RFC] libeventdev: event driven programming model framework for DPDK

2016-10-05 Thread Jerin Jacob
On Tue, Oct 04, 2016 at 09:49:52PM +, Vangati, Narender wrote: > Hi Jerin, Hi Narender, Thanks for the comments.I agree with proposed changes; I will address these comments in v2. /Jerin > > > > Here are some comments on the libeventdev RFC. > > These are collated thoughts after

[dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2016-10-05 Thread David Marchand
Hello, On Tue, Oct 4, 2016 at 6:59 PM, Jean Tourrilhes wrote: > On Tue, Oct 04, 2016 at 02:11:39PM +0100, Sergio Gonzalez Monroy wrote: >> The case you are trying to fix is, as an example, when your secondary app is >> using LPM but your primary is not. >> So basically with this patch, you are

[dpdk-dev] [PATCH v7] net/virtio: add set_mtu in virtio

2016-10-05 Thread Kavanagh, Mark B
>Hi All, > Is there any further comments or modifications required for this patch, > or what next >steps do you guys suggest here ? Hi Souvik, Some minor comments inline. Thanks, Mark > >-- >Regards, >Souvik > >-Original Message- >From: Dey, Souvik >Sent: Saturday, October 1,

[dpdk-dev] [PATCH v2] doc: arm64: document DPDK application profiling methods

2016-10-05 Thread Jerin Jacob
Signed-off-by: Jerin Jacob --- v2: -Addressed ARM64 specific review comments(Suggested by Thomas) http://dpdk.org/dev/patchwork/patch/16362/ --- doc/guides/prog_guide/profile_app.rst | 58 +++ 1 file changed, 58 insertions(+) diff --git

[dpdk-dev] [PATCH v2] cryptodev: fix compilation error in SUSE 11 SP2

2016-10-05 Thread Adrien Mazarguil
On Wed, Oct 05, 2016 at 03:45:51AM +0100, Pablo de Lara wrote: > This commit fixes following build error, which happens in SUSE 11 SP2, > with gcc 4.5.1: > > In file included from lib/librte_cryptodev/rte_cryptodev.c:70:0: > lib/librte_cryptodev/rte_cryptodev.h:772:7: > error: flexible array

[dpdk-dev] [PATCH 1/2] kni: remove unused ethtool files

2016-10-05 Thread Remy Horton
On 30/09/2016 11:10, Ferruh Yigit wrote: > Signed-off-by: Ferruh Yigit > --- > lib/librte_eal/linuxapp/kni/Makefile |2 - > lib/librte_eal/linuxapp/kni/ethtool/igb/igb_ptp.c | 944 - > lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.c | 1482 >

[dpdk-dev] [PATCH 2/2] kni: remove unnecessary ethtool files

2016-10-05 Thread Remy Horton
On 30/09/2016 11:10, Ferruh Yigit wrote: > Signed-off-by: Ferruh Yigit > --- > lib/librte_eal/linuxapp/kni/Makefile | 3 - > .../linuxapp/kni/ethtool/igb/igb_debugfs.c | 28 -- > .../linuxapp/kni/ethtool/igb/igb_hwmon.c | 260 --- >

[dpdk-dev] [PATCH] eal: fix c++ compilation issue with rte_delay_us()

2016-10-05 Thread Thomas Monjalon
2016-10-03 18:27, Konstantin Ananyev: > When compiling with C++, it treats > void (*rte_delay_us)(unsigned int us); > as definition of the global variable. > So further linking with librte_eal fails. > > Fixes: b4d63fb62240 ("eal: customize delay function") Applied, thanks I don't understand

[dpdk-dev] [PATCH v2]:rte_timer:timer lag issue correction

2016-10-05 Thread Pattan, Reshma
Hi Suyash, > -Original Message- > From: Karmarkar Suyash [mailto:skarmarkar at sonusnet.com] > Sent: Tuesday, October 4, 2016 11:36 PM > To: Sanford, Robert ; dev at dpdk.org; > thomas.monjalon at 6wind.com; Pattan, Reshma > Subject: RE: [PATCH v2]:rte_timer:timer lag issue correction >

[dpdk-dev] [RFC 0/7] changing mbuf pool handler

2016-10-05 Thread Hunt, David
Hi Olivier, On 3/10/2016 4:49 PM, Olivier Matz wrote: > Hi Hemant, > > Thank you for your feedback. > > On 09/22/2016 01:52 PM, Hemant Agrawal wrote: >> Hi Olivier >> >> On 9/19/2016 7:12 PM, Olivier Matz wrote: >>> Hello, >>> >>> Following discussion from [1] ("usages issue with external

[dpdk-dev] [PATCH v2 1/3] mem: fix hugepage mapping error messages

2016-10-05 Thread Thomas Monjalon
2016-10-04 20:07, Sergio Gonzalez Monroy: > On 04/10/2016 18:17, Jean Tourrilhes wrote: > > Running secondary is tricky due to the need to map the memory region > > at the right place in VM, which is whatever primary has chosen. If the > > base address for primary happens to by already mapped in

[dpdk-dev] [PATCH v2] app/testpmd: fix DCB config issue

2016-10-05 Thread Iremonger, Bernard
> -Original Message- > From: Lu, Wenzhuo > Sent: Monday, September 26, 2016 2:11 AM > To: dev at dpdk.org > Cc: De Lara Guarch, Pablo ; Iremonger, > Bernard ; Lu, Wenzhuo > > Subject: [PATCH v2] app/testpmd: fix DCB config issue > > An issue is found that DCB cannot be configured on

[dpdk-dev] [PATCH v2]:rte_timer:timer lag issue correction

2016-10-05 Thread Thomas Monjalon
> > For Periodic timers ,if the lag gets introduced, the current code > > added additional delay when the next peridoc timer was initialized > > by not taking into account the delay added, with this fix the code > > would start the next occurrence of timer keeping in account the > > lag

[dpdk-dev] [PATCH v5 0/4] Cuckoo hash enhancements

2016-10-05 Thread Thomas Monjalon
2016-10-05 00:25, Pablo de Lara: > This patchset improves lookup performance on the current hash library > by changing the existing lookup bulk pipeline, with an improved pipeline, > based on a loop-and-jump model, instead of the current 4-stage 2-entry > pipeline. > Also, x86 vectorized

[dpdk-dev] [PATCH] eal: fix c++ compilation issue with rte_delay_us()

2016-10-05 Thread Ananyev, Konstantin
Hi Thomas, > > 2016-10-03 18:27, Konstantin Ananyev: > > When compiling with C++, it treats > > void (*rte_delay_us)(unsigned int us); > > as definition of the global variable. > > So further linking with librte_eal fails. > > > > Fixes: b4d63fb62240 ("eal: customize delay function") > >

[dpdk-dev] [PATCH 00/19] KNI checkpatch cleanup

2016-10-05 Thread Pattan, Reshma
Hi Ferruh, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ferruh Yigit > Sent: Thursday, September 15, 2016 4:46 PM > To: dev at dpdk.org > Cc: Stephen Hemminger ; Ferruh Yigit > > Subject: [dpdk-dev] [PATCH 00/19] KNI checkpatch cleanup > > KNI

[dpdk-dev] [RFC 0/7] changing mbuf pool handler

2016-10-05 Thread Hemant Agrawal
Hi Olivier, > -Original Message- > From: Hunt, David [mailto:david.hunt at intel.com] > Hi Olivier, > > > On 3/10/2016 4:49 PM, Olivier Matz wrote: > > Hi Hemant, > > > > Thank you for your feedback. > > > > On 09/22/2016 01:52 PM, Hemant Agrawal wrote: > >> Hi Olivier > >> > >> On

[dpdk-dev] [PATCH] examples/l3fwd: em path hash offload to machine

2016-10-05 Thread Jerin Jacob
On Tue, Aug 23, 2016 at 08:24:39PM +0530, Hemant Agrawal wrote: Maybe you can change the subject line to: examples/l3fwd: em: use hw accelerated crc hash function for arm64 instead of: examples/l3fwd: em path hash offload to machine > if machine level CRC extension are available, offload the >

[dpdk-dev] [PATCH v2 09/12] virtio: add Rx checksum offload support

2016-10-05 Thread Olivier Matz
Hi Maxime, On 10/03/2016 02:51 PM, Maxime Coquelin wrote: >> --- a/drivers/net/virtio/virtio_rxtx.c >> +++ b/drivers/net/virtio/virtio_rxtx.c >> @@ -50,6 +50,7 @@ >> #include >> #include >> #include >> +#include >> >> #include "virtio_logs.h" >> #include "virtio_ethdev.h" >> @@ -627,6

[dpdk-dev] [PATCH v11 00/24] Introducing rte_driver/rte_device generalization

2016-10-05 Thread Shreyansh Jain
Hi Thomas, On Tuesday 04 October 2016 01:12 PM, Thomas Monjalon wrote: > 2016-10-04 12:21, Shreyansh Jain: >> Hi Thomas, >> >> On Monday 03 October 2016 07:58 PM, Thomas Monjalon wrote: >>> Applied, thanks everybody for the great (re)work! >> >> Thanks! >> [...] [...] >> >> It can be merged with

[dpdk-dev] [PATCH] log: do not drop debug logs at compile time

2016-10-05 Thread Olivier Matz
Hi David, On 10/04/2016 10:26 AM, David Marchand wrote: > On Fri, Sep 16, 2016 at 9:43 AM, Olivier Matz > wrote: >> Today, all logs whose level is lower than INFO are dropped at >> compile-time. This prevents from enabling debug logs at runtime using >> --log-level=8. >> >> The rationale was to

[dpdk-dev] [PATCH] log: do not drop debug logs at compile time

2016-10-05 Thread Olivier Matz
Hi David, On 10/04/2016 10:28 AM, David Marchand wrote: > On Mon, Oct 3, 2016 at 6:27 PM, Wiles, Keith wrote: >>> On Oct 3, 2016, at 10:37 AM, Olivier Matz wrote: >>> What makes you feel it's easier to add a log level instead of adding a >>> new RTE_LOG_DP() function? >> >> It seems to me the

[dpdk-dev] [PATCH v2 1/2] mbuf: add rte_pktmbuff_reset_headroom function

2016-10-05 Thread Olivier Matz
Hi Maxime, On 10/04/2016 02:05 PM, Maxime Coquelin wrote: > Some application use rte_mbuf_raw_alloc() function to improve > performance by not resetting mbuf's fields to their default state. > > This can be however problematic for mbuf consumers that need some > headroom, meaning that data_off

[dpdk-dev] [PATCH] ip_frag: fix missing dependency on librte_hash

2016-10-05 Thread Panu Matilainen
Not sure what exactly changed and where, but I've started getting build failures on Fedora rawhide i386: lib/librte_ip_frag/ip_frag_internal.c:36:23: fatal error: rte_jhash.h: No such file or directory #include ^ Looking at librte_ip_frag, it clearly

[dpdk-dev] Proposal: enable redirection of DPDK logs from the user app

2016-10-05 Thread Olivier Matz
Hi Francesco, On 10/04/2016 02:28 PM, Montorsi, Francesco wrote: > Hi Olivier, > >> It seems the mailing list stripped your patch sent as attachment. >> Can you please resend it again in the body of the mail? > You're right sorry. It's attached at the end of this mail. > >> I think we can

[dpdk-dev] [PATCH] mbuf: fix leak and errno on pool creation error

2016-10-05 Thread Thomas Monjalon
2016-09-19 14:34, Olivier Matz: > On error, the mempool object has to be freed, and rte_errno should be a > positive value. > > Fixes: 152ca517900b ("mbuf: use default mempool handler from config") > > Signed-off-by: Olivier Matz Applied, thanks

[dpdk-dev] [PATCH] app/test: add mempool walk

2016-10-05 Thread Olivier Matz
Hi Thomas, On 10/03/2016 10:58 PM, Thomas Monjalon wrote: > The mempool function rte_mempool_walk was not tested. > It will print the name of all mempools. > > Signed-off-by: Thomas Monjalon Acked-by: Olivier Matz

[dpdk-dev] [PATCH 1/2] net/bonding: validate speed after link up

2016-10-05 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Eric Kinzie > Sent: Thursday, August 4, 2016 7:25 PM > To: dev at dpdk.org > Cc: Jan Blunck > Subject: [dpdk-dev] [PATCH 1/2] net/bonding: validate speed after link up > > It's possible for the bonding driver

[dpdk-dev] [PATCH 2/2] net/bonding: enable slave VLAN filter

2016-10-05 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Eric Kinzie > Sent: Thursday, August 4, 2016 7:25 PM > To: dev at dpdk.org > Cc: Jan Blunck > Subject: [dpdk-dev] [PATCH 2/2] net/bonding: enable slave VLAN filter > > SR-IOV virtual functions cannot rely on

[dpdk-dev] [RFC 0/7] changing mbuf pool handler

2016-10-05 Thread Hunt, David
On 5/10/2016 12:49 PM, Hemant Agrawal wrote: > Hi Olivier, > >> -Original Message- >> From: Hunt, David [mailto:david.hunt at intel.com] >> Hi Olivier, >> >> >> On 3/10/2016 4:49 PM, Olivier Matz wrote: >>> Hi Hemant, >>> >>> Thank you for your feedback. >>> >>> On 09/22/2016 01:52 PM,

[dpdk-dev] Proposal: enable redirection of DPDK logs from the user app

2016-10-05 Thread Montorsi, Francesco
Hi Olivier, > On 10/04/2016 02:28 PM, Montorsi, Francesco wrote: > > Yes, but to be honest, that seems a troublesome solution for something > > as easy as logging a string; e.g. by using fopencookie() approach, you > > don't have the concept of "log message", you just provide a function > > that

[dpdk-dev] [PATCH v2 09/12] virtio: add Rx checksum offload support

2016-10-05 Thread Maxime Coquelin
Hi Olivier, On 10/05/2016 01:56 PM, Olivier Matz wrote: > Hi Maxime, > > On 10/03/2016 02:51 PM, Maxime Coquelin wrote: >>> --- a/drivers/net/virtio/virtio_rxtx.c >>> +++ b/drivers/net/virtio/virtio_rxtx.c >>> @@ -50,6 +50,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> >>>

[dpdk-dev] [PATCH v2 09/12] virtio: add Rx checksum offload support

2016-10-05 Thread Olivier Matz
On 10/05/2016 03:27 PM, Maxime Coquelin wrote: >> @@ -903,7 +905,8 @@ virtio_recv_pkts(void *rx_queue, struct rte_mbuf >> **rx_pkts, uint16_t nb_pkts) >> rte_vlan_strip(rxm); >> >> /* Update offload features */ >> - if (virtio_rx_offload(rxm,

[dpdk-dev] [PATCH 2/2] kni: remove unnecessary ethtool files

2016-10-05 Thread Thomas Monjalon
2016-10-05 09:58, Remy Horton: > > On 30/09/2016 11:10, Ferruh Yigit wrote: > > Signed-off-by: Ferruh Yigit > > --- > > lib/librte_eal/linuxapp/kni/Makefile | 3 - > > .../linuxapp/kni/ethtool/igb/igb_debugfs.c | 28 -- > > .../linuxapp/kni/ethtool/igb/igb_hwmon.c

[dpdk-dev] [PATCH] ip_frag: fix missing dependency on librte_hash

2016-10-05 Thread Thomas Monjalon
2016-10-05 15:14, Panu Matilainen: > Not sure what exactly changed and where, but I've started getting > build failures on Fedora rawhide i386: > lib/librte_ip_frag/ip_frag_internal.c:36:23: fatal error: > rte_jhash.h: No such file or directory > #include >

[dpdk-dev] Proposal: enable redirection of DPDK logs from the user app

2016-10-05 Thread Olivier Matz
Hi Francesco, On 10/05/2016 03:26 PM, Montorsi, Francesco wrote: > Hi Olivier, > >> On 10/04/2016 02:28 PM, Montorsi, Francesco wrote: >>> Yes, but to be honest, that seems a troublesome solution for something >>> as easy as logging a string; e.g. by using fopencookie() approach, you >>> don't

[dpdk-dev] [PATCH v7] net/virtio: add set_mtu in virtio

2016-10-05 Thread Dey, Souvik
Yes Mark, I have modified the patch with the below comments. drivers/net/virtio/virtio_ethdev.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 423c597..1dbfea6 100644 ---

[dpdk-dev] [PATCH v2 4/8] app/testpmd: add option to enable lro

2016-10-05 Thread Olivier Matz
Hi Pablo, On 10/05/2016 08:26 AM, De Lara Guarch, Pablo wrote: > Hi Olivier, > >> -Original Message- >> From: Olivier Matz [mailto:olivier.matz at 6wind.com] >> Sent: Friday, September 09, 2016 12:56 AM >> To: dev at dpdk.org; De Lara Guarch, Pablo >> Subject: [PATCH v2 4/8] app/testpmd:

[dpdk-dev] [PATCH v2 1/8] mbuf: add function to dump ol flag list

2016-10-05 Thread Olivier Matz
Hi Pablo, On 10/05/2016 08:45 AM, De Lara Guarch, Pablo wrote: > Hi Olivier, > >> -Original Message- >> diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c >> index fb2b962..56f37e6 100644 >> --- a/lib/librte_mbuf/rte_mbuf.c >> +++ b/lib/librte_mbuf/rte_mbuf.c >> @@

[dpdk-dev] [PATCH v4 1/2] librte_ether: add internal callback functions

2016-10-05 Thread Thomas Monjalon
2016-10-04 15:52, Bernard Iremonger: > add _rte_eth_dev_callback_process_vf function. > add _rte_eth_dev_callback_process_generic function > > Adding a callback to the user application on VF to PF mailbox message, > allows passing information to the application controlling the PF > when a VF

[dpdk-dev] [PATCH v2 04/22] qede/base: update base driver

2016-10-05 Thread Thomas Monjalon
2016-09-30 18:40, Mody, Rasesh: > > From: Ferruh Yigit [mailto:ferruh.yigit at intel.com] > > Thank you for the update, base driver patch update now reduced from > > "14653 insertions(+), 8536 deletions(-)" to > > "10857 insertions(+), 4853 deletions(-)" > > > > But this is still to big for

[dpdk-dev] [PATCH v2 1/3] mem: fix hugepage mapping error messages

2016-10-05 Thread Jean Tourrilhes
On Wed, Oct 05, 2016 at 11:51:48AM +0200, Thomas Monjalon wrote: > > Applied, thanks > A rebase was necessary because of this patch: http://dpdk.org/commit/c00ae961 > Please check everything is OK. Tested today's master. Working as expected. Thanks ! Jean

[dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2016-10-05 Thread Jean Tourrilhes
On Wed, Oct 05, 2016 at 09:58:01AM +0200, David Marchand wrote: > Hello, Hi there, > I thought you had unaligned binaries. > You are compiling only one binary ? Primary is compiled using the DPDK build process. Secondary is build using the Snort build process.

[dpdk-dev] [PATCH v4 1/2] librte_ether: add internal callback functions

2016-10-05 Thread Iremonger, Bernard
Hi Thomas, > Subject: Re: [dpdk-dev] [PATCH v4 1/2] librte_ether: add internal callback > functions > > 2016-10-04 15:52, Bernard Iremonger: > > add _rte_eth_dev_callback_process_vf function. > > add _rte_eth_dev_callback_process_generic function > > > > Adding a callback to the user

[dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2016-10-05 Thread Thomas Monjalon
2016-10-05 09:49, Jean Tourrilhes: > On Wed, Oct 05, 2016 at 09:58:01AM +0200, David Marchand wrote: > > I thought you had unaligned binaries. > > You are compiling only one binary ? > > Primary is compiled using the DPDK build process. > Secondary is build using the Snort build

[dpdk-dev] [PATCH v4 1/2] librte_ether: add internal callback functions

2016-10-05 Thread Thomas Monjalon
2016-10-05 17:04, Iremonger, Bernard: > > > --- a/lib/librte_ether/rte_ethdev.c > > > +++ b/lib/librte_ether/rte_ethdev.c > > > @@ -2510,6 +2510,20 @@ void > > > _rte_eth_dev_callback_process(struct rte_eth_dev *dev, > > > enum rte_eth_event_type event) > > > { > > > + return

[dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2016-10-05 Thread Jean Tourrilhes
On Wed, Oct 05, 2016 at 07:09:14PM +0200, Thomas Monjalon wrote: > > Probably that you would have some aligned builds if Snort was using > a pkg-config approach to link DPDK. I seriously doubt it, but maybe there is some deep linker magic that would pick the appropriate set of

[dpdk-dev] [PATCH v2] eal: don't fail secondary if primary is missing tailqs

2016-10-05 Thread Jean Tourrilhes
If the primary and secondary process were build using different build systems, the list of constructors included by the linker in each binary might be different. Tailqs are registered via constructors, so the linker magic will directly impact which tailqs are registered with the primary and the

[dpdk-dev] [PATCH v2 1/2] i40e: Add packet_type metadata in the i40e vPMD

2016-10-05 Thread Jeff Shaw
From: Damjan Marion The ptype is decoded from the rx descriptor and stored in the packet type field in the mbuf using the same function as the non-vector driver. Signed-off-by: Damjan Marion Signed-off-by: Jeff Shaw Acked-by: Qi Zhang --- Changes in v2: - Add missing

[dpdk-dev] [PATCH v2 2/2] i40e: Enable bad checksum flags in i40e vPMD

2016-10-05 Thread Jeff Shaw
From: Damjan Marion Decode the checksum flags from the rx descriptor, setting the appropriate bit in the mbuf ol_flags field when the flag indicates a bad checksum. Signed-off-by: Damjan Marion Signed-off-by: Jeff Shaw --- drivers/net/i40e/i40e_rxtx_vec.c | 48

[dpdk-dev] Proposal: enable redirection of DPDK logs from the user app

2016-10-05 Thread Matthew Hall
On Wed, Oct 05, 2016 at 01:26:30PM +, Montorsi, Francesco wrote: > Correct, but in my experience DPDK never creates such a long line of log > message... > > Francesco This comment is fatally flawed. Many of us write our applications using these functions. I have things which hex-dump

[dpdk-dev] [PATCH v2 1/2] i40e: Add packet_type metadata in the i40e vPMD

2016-10-05 Thread Chen, Jing D
Hi, > -Original Message- > From: Shaw, Jeffrey B > Sent: Wednesday, October 5, 2016 5:13 PM > To: dev at dpdk.org > Cc: Zhang, Helin ; Wu, Jingjing > ; damarion at cisco.com; Zhang, Qi Z > ; Chen, Jing D > Subject: [PATCH v2 1/2] i40e: Add packet_type metadata in the i40e vPMD > >

[dpdk-dev] [PATCH v2 2/2] i40e: Enable bad checksum flags in i40e vPMD

2016-10-05 Thread Chen, Jing D
Hi, > -Original Message- > From: Shaw, Jeffrey B > Sent: Wednesday, October 5, 2016 5:13 PM > To: dev at dpdk.org > Cc: Zhang, Helin ; Wu, Jingjing > ; damarion at cisco.com; Zhang, Qi Z > ; Chen, Jing D > Subject: [PATCH v2 2/2] i40e: Enable bad checksum flags in i40e vPMD > > From:

[dpdk-dev] [PATCH v2 2/2] i40e: Enable bad checksum flags in i40e vPMD

2016-10-05 Thread Jeff Shaw
On Wed, Oct 05, 2016 at 04:57:28PM -0700, Chen, Jing D wrote: > Hi, > > > -Original Message- > > From: Shaw, Jeffrey B > > Sent: Wednesday, October 5, 2016 5:13 PM > > To: dev at dpdk.org > > Cc: Zhang, Helin ; Wu, Jingjing > > ; damarion at cisco.com; Zhang, Qi Z > > ; Chen, Jing D > >

[dpdk-dev] [PATCH 1/2] bnx2x: fix maximum PF queues

2016-10-05 Thread Rasesh Mody
Fix the max number of PF rx/tx queues. Set the value based on BNX2X_MAX_RSS_COUNT() rather than hard coding it to 128. Fixes: 540a211 ("bnx2x: driver core") Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[dpdk-dev] [PATCH 2/2] bnx2x: fix to use SOCKET_ID_ANY for slowpath memory

2016-10-05 Thread Rasesh Mody
When the DMA allocation routine is invoked in the context of a non-EAL thread, the API rte_lcore_id() returns -1 and indexing on that in rte_lcore_to_socket_id() leads to segfault. The fix is to use SOCKET_ID_ANY as the socket_id for all slowpath memory allocation. Fixes: 540a211 ("bnx2x: driver