[dpdk-dev] [PATCH] net/ixgbe: fix link never come up problem with x552

2016-11-09 Thread Wei Zhao
From: zhao wei The links never coming up with DPDK16.11 when bring up x552 NIC, device id is 15ac.This is caused by delete some code which casing removes X550em SFP iXFI setup for the drivers in function ixgbe_setup_mac_link_sfp_x550em().Fix methord is recover the deleted

[dpdk-dev] [PATCH] net/ixgbe: fix link never come up problem with x552

2016-11-09 Thread Wei Zhao
From: zhao wei The links never coming up with DPDK16.11 when bring up x552 NIC, device id is 15ac.This is caused by delete some code which casing removes X550em SFP iXFI setup for the drivers in function ixgbe_setup_mac_link_sfp_x550em().Fix methord is recover the deleted

[dpdk-dev] [PATCH] net/ixgbe: fix link never come up problem with x552

2016-11-09 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wei Zhao > Sent: Wednesday, November 9, 2016 3:00 PM > To: dev at dpdk.org > Cc: Zhao1, Wei > Subject: [dpdk-dev] [PATCH] net/ixgbe: fix link never come up problem with > x552 > > From: zhao wei > >

[dpdk-dev] [PATCH] examples/l3fwd: force CRC stripping for i40evf

2016-11-09 Thread Björn Töpel
Commit 1bbcc5d21129 ("i40evf: report error for unsupported CRC stripping config") broke l3fwd, since it was forcing that CRC was kept. Now, if i40evf is running, CRC stripping will be enabled. Signed-off-by: Bj?rn T?pel --- examples/l3fwd/main.c | 9 - 1 file changed, 8 insertions(+), 1

[dpdk-dev] [PATCH] examples/l3fwd: force CRC stripping for i40evf

2016-11-09 Thread Yao, Lei A
Tested-by: Lei Yao - Apply patch to v16.11-rc3 - Compile: Pass - Host OS: VMware ESXi 6.0 - VM OS: Fedora 20 - GCC: 4.8.3 Tested with this patch, l3fwd sample can work with i40e VF with Fedora VM using VMware as the host. -Original Message- From: Topel, Bjorn Sent: Wednesday, November

[dpdk-dev] [PATCH] examples/l3fwd: force CRC stripping for i40evf

2016-11-09 Thread Thomas Monjalon
2016-11-09 09:23, Bj?rn T?pel: > Commit 1bbcc5d21129 ("i40evf: report error for unsupported CRC > stripping config") broke l3fwd, since it was forcing that CRC was > kept. Now, if i40evf is running, CRC stripping will be enabled. [...] > + rte_eth_dev_info_get(portid, _info); > +

[dpdk-dev] [PATCH] examples/l3fwd: force CRC stripping for i40evf

2016-11-09 Thread Björn Töpel
> Thanks for raising the issue. It is completely defeating the generic > ethdev API. We must not have different behaviours depending of the > driver. Why it cannot be fixed in the driver? I should probably refer to the thread, where the concern was raised:

[dpdk-dev] [PATCH] examples/l3fwd: force CRC stripping for i40evf

2016-11-09 Thread Ananyev, Konstantin
Hi, > > Commit 1bbcc5d21129 ("i40evf: report error for unsupported CRC > stripping config") broke l3fwd, since it was forcing that CRC was > kept. Now, if i40evf is running, CRC stripping will be enabled. > > Signed-off-by: Bj?rn T?pel > --- > examples/l3fwd/main.c | 9 - > 1 file

[dpdk-dev] [PATCH] examples/l3fwd: force CRC stripping for i40evf

2016-11-09 Thread Björn Töpel
Adding Helin to the conversation. > That's a common problem across Intel VF devices. Bothe igb and ixgbe > overcomes that problem just by forcing ' rxmode.hw_strip_crc = 1;' at > PMD itself: [...] > Wonder, can't i40e VF do the same? Right, however, and this (silent failure) approach was

[dpdk-dev] [PATCH v7 00/21] Introduce SoC device/driver framework for EAL

2016-11-09 Thread Thomas Monjalon
Hi Shreyansh, I realize that we had a lot of off-list discussions on this topic and there was no public explanation of the status of this series. 2016-10-28 17:56, Shreyansh Jain: [...] > As of now EAL is primarly focused on PCI initialization/probing. Right. DPDK was PCI centric. We must give

[dpdk-dev] [PATCH] examples/l3fwd: force CRC stripping for i40evf

2016-11-09 Thread Thomas Monjalon
2016-11-09 11:05, Bj?rn T?pel: > > BTW, all other examples would experience same problem too, right? > > Correct, so the broader question would be "what is the correct behavior > for an example application, when a port configuration isn't supported by > the hardware?". > > My stand, FWIW, is

[dpdk-dev] [RFC v2] Generic flow director/filtering/classification API

2016-11-09 Thread Adrien Mazarguil
Hi Helin and PMD maintainers, On Tue, Nov 08, 2016 at 01:31:05AM +, Zhang, Helin wrote: > Hi Adrien > > Any update on the v1 APIs? We are struggling on that, as we need that for our > development. > May I bring another idea to remove the blocking? > Can we send out the APIs with PMD changes

[dpdk-dev] [PATCH] examples/l3fwd: force CRC stripping for i40evf

2016-11-09 Thread Ananyev, Konstantin
> > Adding Helin to the conversation. > > > That's a common problem across Intel VF devices. Bothe igb and ixgbe > > overcomes that problem just by forcing ' rxmode.hw_strip_crc = 1;' at > > PMD itself: > > [...] > > > Wonder, can't i40e VF do the same? > > Right, however, and this (silent

[dpdk-dev] [PATCH] examples/l3fwd: force CRC stripping for i40evf

2016-11-09 Thread Björn Töpel
>> Correct, so the broader question would be "what is the correct >> behavior for an example application, when a port configuration >> isn't supported by the hardware?". >> >> My stand, FWIW, is that igb and ixgbe should have the same >> semantics as i40e currently has, i.e. return an error to the

[dpdk-dev] mbuf changes

2016-11-09 Thread Alejandro Lucero
On Wed, Oct 26, 2016 at 10:28 AM, Alejandro Lucero < alejandro.lucero at netronome.com> wrote: > > > On Tue, Oct 25, 2016 at 2:05 PM, Bruce Richardson < > bruce.richardson at intel.com> wrote: > >> On Tue, Oct 25, 2016 at 05:24:28PM +0530, Shreyansh Jain wrote: >> > On Monday 24 October 2016

[dpdk-dev] [PATCH] examples/l3fwd: force CRC stripping for i40evf

2016-11-09 Thread Ananyev, Konstantin
> -Original Message- > From: Topel, Bjorn > Sent: Wednesday, November 9, 2016 11:28 AM > To: Ananyev, Konstantin ; dev at dpdk.org; > Zhang, Helin > Cc: Xu, Qian Q ; Yao, Lei A ; > Wu, Jingjing ; > thomas.monjalon at 6wind.com > Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: force

[dpdk-dev] [PATCH] virtio: tx with can_push when VERSION_1 is set

2016-11-09 Thread Pierre Pfister (ppfister)
Hello Maxime, Sorry for the late reply. > Le 8 nov. 2016 ? 10:44, Maxime Coquelin a > ?crit : > > Hi Pierre, > > On 11/08/2016 10:31 AM, Pierre Pfister (ppfister) wrote: >> Current virtio driver advertises VERSION_1 support, >> but does not handle device's VERSION_1 support when >> sending

[dpdk-dev] disable hugepages

2016-11-09 Thread Keren Hochman
Hi, how can I create mempool without hugepages?My application is running on a pcap file so no huge pages is needed ? Thanks.

[dpdk-dev] [PATCH] app/test: fix crash of lpm test

2016-11-09 Thread Olivier Matz
The test recently added accesses to lpm->tbl8[ip >> 8] with is much larger than the size of the table, causing a crash of the test application. Fix this typo by replacing tbl8 by tbl24. Fixes: 231fa88ed522 ("app/test: verify LPM tbl8 recycle") Signed-off-by: Olivier Matz --- Hi Wei, I don't

[dpdk-dev] [PATCH] examples/l3fwd: force CRC stripping for i40evf

2016-11-09 Thread Björn Töpel
Bj?rn/Konstantin wrote: >> Finally, why doesn't l3fwd have the CRC stripped? > > I don?t know any good reason for that for l3fwd or any other sample > app. I think it is just a 'historical' reason. Ok! Then I'd suggest changing the l3fwd default to actually *strip* CRC instead of not doing it.

[dpdk-dev] [PATCH v7 00/21] Introduce SoC device/driver framework for EAL

2016-11-09 Thread Shreyansh Jain
Hello Thomas, On Wednesday 09 November 2016 03:47 PM, Thomas Monjalon wrote: > Hi Shreyansh, > > I realize that we had a lot of off-list discussions on this topic > and there was no public explanation of the status of this series. Thanks for your email. (and all the suggestions you have given

[dpdk-dev] disable hugepages

2016-11-09 Thread Christian Ehrhardt
On Wed, Nov 9, 2016 at 1:55 PM, Keren Hochman wrote: > how can I create mempool without hugepages?My application is running on a > pcap file so no huge pages is needed ? > Not sure if that is what you really want (Debug use only), but in general no-huge is available as EAL arg >From

[dpdk-dev] disable hugepages

2016-11-09 Thread Keren Hochman
I need this option only for testing. How can I use rte_mempool_create if I use --no-huge? Thank you, Keren On Wed, Nov 9, 2016 at 3:40 PM, Christian Ehrhardt < christian.ehrhardt at canonical.com> wrote: > > On Wed, Nov 9, 2016 at 1:55 PM, Keren Hochman < > keren.hochman at lightcyber.com>

[dpdk-dev] [PATCH] virtio: tx with can_push when VERSION_1 is set

2016-11-09 Thread Maxime Coquelin
Hi Pierre, On 11/09/2016 01:42 PM, Pierre Pfister (ppfister) wrote: > Hello Maxime, > > Sorry for the late reply. > > >> Le 8 nov. 2016 ? 10:44, Maxime Coquelin a >> ?crit : >> >> Hi Pierre, >> >> On 11/08/2016 10:31 AM, Pierre Pfister (ppfister) wrote: >>> Current virtio driver advertises

[dpdk-dev] disable hugepages

2016-11-09 Thread Olivier Matz
Hi Keren, On 11/09/2016 03:40 PM, Keren Hochman wrote: > On Wed, Nov 9, 2016 at 3:40 PM, Christian Ehrhardt < > christian.ehrhardt at canonical.com> wrote: > >> >> On Wed, Nov 9, 2016 at 1:55 PM, Keren Hochman < >> keren.hochman at lightcyber.com> wrote: >> >>> how can I create mempool without

[dpdk-dev] [PATCH] virtio: tx with can_push when VERSION_1 is set

2016-11-09 Thread Maxime Coquelin
Hi Pierre, On 11/09/2016 01:42 PM, Pierre Pfister (ppfister) wrote: > Hello Maxime, > > Sorry for the late reply. > > >> Le 8 nov. 2016 ? 10:44, Maxime Coquelin a >> ?crit : >> >> Hi Pierre, >> >> On 11/08/2016 10:31 AM, Pierre Pfister (ppfister) wrote: >>> Current virtio driver advertises

[dpdk-dev] [PATCH] net: introduce big and little endian types

2016-11-09 Thread Nelio Laranjeiro
This commit introduces new rte_{le,be}{16,32,64}_t types and updates rte_{le,be,cpu}_to_{le,be,cpu}_*() and network header structures accordingly. Specific big/little endian types avoid uncertainty and conversion mistakes. No ABI change since these are simply typedefs to the original types.

[dpdk-dev] [PATCH] improve git diff

2016-11-09 Thread Thomas Monjalon
Sometimes git does not print the name of the function being changed after @@. It happens especially after a goto label which is not indented. Giving a hint about the languages of files .c, .h and .py will improve hunk headers of "git diff" rendering. Signed-off-by: Thomas Monjalon ---

[dpdk-dev] [PATCH] doc: postpone ABI changes for mbuf

2016-11-09 Thread Olivier Matz
Mbuf modifications are not ready for 16.11, postpone them to 17.02. Signed-off-by: Olivier Matz --- doc/guides/rel_notes/deprecation.rst | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index

[dpdk-dev] [PATCH] maintainers: claim responsability for xen

2016-11-09 Thread Thomas Monjalon
2016-11-07 07:38, Jianfeng Tan: > As some users are still using xen as the hypervisor, I suggest to > continue support for xen in DPDK. And from 16.11, I will be the > maintainer of all xen-related files. > > Signed-off-by: Jianfeng Tan Applied Please Jianfeng, could you start your new role by

[dpdk-dev] [PATCH] doc: postpone ABI changes for mbuf

2016-11-09 Thread Thomas Monjalon
2016-11-09 17:12, Olivier Matz: > Mbuf modifications are not ready for 16.11, postpone them to 17.02. > > Signed-off-by: Olivier Matz Applied, thanks

[dpdk-dev] [PATCH] doc: postpone ABI changes for Tx prepare

2016-11-09 Thread Thomas Monjalon
The changes for the feature "Tx prepare" should be made in version 17.02. Signed-off-by: Thomas Monjalon --- doc/guides/rel_notes/deprecation.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst