[dpdk-dev] [PATCH] EAL: Take reserved hugepages into account

2014-04-16 Thread Stephen Hemminger
On Wed, 16 Apr 2014 11:11:12 + "Burakov, Anatoly" wrote: > Some applications reserve hugepages for later use, but DPDK doesn't take > reserved pages into account when calculating number of available number of > hugepages. This patch adds reading from "resv_hugepages" file in addition to >

[dpdk-dev] [PATCH 03/15] pmd: Add PMD_REGISTER_DRIVER macro

2014-04-16 Thread Olivier MATZ
Hi Neil, On 04/16/2014 03:08 PM, Neil Horman wrote: > On Wed, Apr 16, 2014 at 01:52:49PM +0200, Thomas Monjalon wrote: >> 2014-04-15 14:05, Neil Horman: >>> Rather than have each driver have to remember to add a constructor to it to >>> make sure its gets registered properly, wrap that process up

[dpdk-dev] unsubcribe

2014-04-16 Thread 海涛岳
unsubcribe

[dpdk-dev] build break on BSD

2014-04-16 Thread Neil Horman
Hey- I was just trying to do a build on bsd for dpdk and hit this: == Build lib/librte_eal/bsdapp/eal CC eal.o /root/git/dpdk/lib/librte_eal/bsdapp/eal/eal.c: In function ?eal_parse_args?: /root/git/dpdk/lib/librte_eal/bsdapp/eal/eal.c:654:5: error: implicit declaration of function ?eal_dev_

[dpdk-dev] [PATCH 03/15] pmd: Add PMD_REGISTER_DRIVER macro

2014-04-16 Thread Thomas Monjalon
2014-04-15 14:05, Neil Horman: > Rather than have each driver have to remember to add a constructor to it to > make sure its gets registered properly, wrap that process up in a macro to > make registration a one line affair. This also sets the stage for us to > make registration of vdev pmds and p

[dpdk-dev] [PATCH 02/15] make: include whole archive on static link

2014-04-16 Thread Thomas Monjalon
2014-04-16 07:02, Neil Horman: > On Wed, Apr 16, 2014 at 11:26:48AM +0200, Thomas Monjalon wrote: > > 2014-04-15 14:05, Neil Horman: > > > This happens automatically on dyanmic linking, but when linking an > > > archive > > > we need to to include the whole archive to make sure we call all the > >

[dpdk-dev] [PATCH 01/15] makefiles: Fixed -share command line option error

2014-04-16 Thread Thomas Monjalon
2014-04-16 07:00, Neil Horman: > On Wed, Apr 16, 2014 at 11:22:35AM +0200, Thomas Monjalon wrote: > > Hi, > > > > 2014-04-15 14:05, Neil Horman: > > > The shared libraries built with the current makefile set produce static > > > libraries rather than actual shared objects. This is due to several

[dpdk-dev] [PATCH 03/15] pmd: Add PMD_REGISTER_DRIVER macro

2014-04-16 Thread Neil Horman
On Wed, Apr 16, 2014 at 06:11:32PM +0200, Olivier MATZ wrote: > Hi Neil, > > On 04/16/2014 03:08 PM, Neil Horman wrote: > >On Wed, Apr 16, 2014 at 01:52:49PM +0200, Thomas Monjalon wrote: > >>2014-04-15 14:05, Neil Horman: > >>>Rather than have each driver have to remember to add a constructor to

[dpdk-dev] [PATCH 03/15] pmd: Add PMD_REGISTER_DRIVER macro

2014-04-16 Thread John W. Linville
On Wed, Apr 16, 2014 at 06:11:32PM +0200, Olivier MATZ wrote: > Hi Neil, > > On 04/16/2014 03:08 PM, Neil Horman wrote: > >On Wed, Apr 16, 2014 at 01:52:49PM +0200, Thomas Monjalon wrote: > >>2014-04-15 14:05, Neil Horman: > >>>Rather than have each driver have to remember to add a constructor to

[dpdk-dev] [PATCH 02/15] make: include whole archive on static link

2014-04-16 Thread Thomas Monjalon
2014-04-15 14:05, Neil Horman: > This happens automatically on dyanmic linking, but when linking an archive > we need to to include the whole archive to make sure we call all the > constructors. Not doing this causes them to be discarded due to the fact > theres no symbolic reference connecting the

[dpdk-dev] [PATCH 01/15] makefiles: Fixed -share command line option error

2014-04-16 Thread Thomas Monjalon
Hi, 2014-04-15 14:05, Neil Horman: > The shared libraries built with the current makefile set produce static > libraries rather than actual shared objects. This is due to several missing > options that are required to correctly build shared objects using ld, as > well as a mis-specified -share op

[dpdk-dev] [PATCH] EAL: Take reserved hugepages into account

2014-04-16 Thread Burakov, Anatoly
Some applications reserve hugepages for later use, but DPDK doesn't take reserved pages into account when calculating number of available number of hugepages. This patch adds reading from "resv_hugepages" file in addition to "free_hugepages". --- lib/librte_eal/linuxapp/eal/eal_hugepage_info.c

[dpdk-dev] [PATCH v5] eal_common_cpuflags: Fix %rbx corruption, and simplify the code

2014-04-16 Thread De Lara Guarch, Pablo
Hi Neil, >Oh wow, yes, the if conditionals definately should be checked for each >iteration of the for loop. Good eye. >Still though, seems like a bug in gcc to check the state of the loop index on >exit, when its never used to index the array at that value. Seems a bit like >this bug: >http:

[dpdk-dev] [PATCH v5] eal_common_cpuflags: Fix %rbx corruption, and simplify the code

2014-04-16 Thread Thomas Monjalon
Hi Pablo, 2014-04-16 08:58, De Lara Guarch, Pablo: > There are two missing brackets in the loop: Good catch! Do you plan to send a patch to fix this? Thank you -- Thomas

[dpdk-dev] [PATCH 1/2] mem: add write memory barrier before changing heap state

2014-04-16 Thread didier.pallard
On 04/15/2014 04:08 PM, Richardson, Bruce wrote: >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of David Marchand >> Sent: Tuesday, April 15, 2014 2:51 PM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH 1/2] mem: add write memory barrier before >> changin

[dpdk-dev] [PATCH 05/15 v2] ring: Convert to use of PMD_REGISTER_DRIVER and fix linking

2014-04-16 Thread Neil Horman
convert the ring driver to use the PMD_REGISTER_DRIVER macro and fix up the Makefile so that its linkage is only done if we are building static libraries. This means that the test applications now have no reference to the ring library when building DSO's and must specify its use on the command line

[dpdk-dev] [PATCH 01/15 v2] makefiles: Fixed -share command line option error

2014-04-16 Thread Neil Horman
The shared libraries built with the current makefile set produce static libraries rather than actual shared objects. This is due to several missing options that are required to correctly build shared objects using ld, as well as a mis-specified -share option (which should be -shared). Switching to

[dpdk-dev] [PATCH 02/15] make: include whole archive on static link

2014-04-16 Thread Neil Horman
On Wed, Apr 16, 2014 at 09:02:04AM -0400, Neil Horman wrote: > On Wed, Apr 16, 2014 at 01:40:19PM +0200, Thomas Monjalon wrote: > > 2014-04-16 07:02, Neil Horman: > > > On Wed, Apr 16, 2014 at 11:26:48AM +0200, Thomas Monjalon wrote: > > > > 2014-04-15 14:05, Neil Horman: > > > > > This happens aut

[dpdk-dev] [PATCH 03/15] pmd: Add PMD_REGISTER_DRIVER macro

2014-04-16 Thread Neil Horman
On Wed, Apr 16, 2014 at 01:52:49PM +0200, Thomas Monjalon wrote: > 2014-04-15 14:05, Neil Horman: > > Rather than have each driver have to remember to add a constructor to it to > > make sure its gets registered properly, wrap that process up in a macro to > > make registration a one line affair.

[dpdk-dev] [PATCH 02/15] make: include whole archive on static link

2014-04-16 Thread Neil Horman
On Wed, Apr 16, 2014 at 01:40:19PM +0200, Thomas Monjalon wrote: > 2014-04-16 07:02, Neil Horman: > > On Wed, Apr 16, 2014 at 11:26:48AM +0200, Thomas Monjalon wrote: > > > 2014-04-15 14:05, Neil Horman: > > > > This happens automatically on dyanmic linking, but when linking an > > > > archive > >

[dpdk-dev] [PATCH 03/15] pmd: Add PMD_REGISTER_DRIVER macro

2014-04-16 Thread John W. Linville
On Wed, Apr 16, 2014 at 01:52:49PM +0200, Thomas Monjalon wrote: > 2014-04-15 14:05, Neil Horman: > > Rather than have each driver have to remember to add a constructor to it to > > make sure its gets registered properly, wrap that process up in a macro to > > make registration a one line affair.

[dpdk-dev] [PATCH v5] eal_common_cpuflags: Fix %rbx corruption, and simplify the code

2014-04-16 Thread De Lara Guarch, Pablo
Hi Neil, >> What was the value of RTE_COMPILE_TIME_CPUFLAGS when you built your library? >> If you added defines for flag support that are not tested for yet in the >> cpu_feature_table, that would be the error you would see I think >RTE_COMPILE_TIME_CPUFLAGS= >>RTE_CPUFLAG_SSE,RTE_CPUFLA

[dpdk-dev] [PATCH v5] eal_common_cpuflags: Fix %rbx corruption, and simplify the code

2014-04-16 Thread Neil Horman
On Wed, Apr 16, 2014 at 11:09:46AM +, De Lara Guarch, Pablo wrote: > Hi Neil, > > >Oh wow, yes, the if conditionals definately should be checked for each > >iteration of the for loop. Good eye. > > >Still though, seems like a bug in gcc to check the state of the loop index > >on exit, when

[dpdk-dev] [PATCH v5] eal_common_cpuflags: Fix %rbx corruption, and simplify the code

2014-04-16 Thread De Lara Guarch, Pablo
Hi Neil, > What was the value of RTE_COMPILE_TIME_CPUFLAGS when you built your library? > If you added defines for flag support that are not tested for yet in the > cpu_feature_table, that would be the error you would see I think RTE_COMPILE_TIME_CPUFLAGS= RTE_CPUFLAG_SSE,RTE_CPUFLAG_SSE2,RTE

[dpdk-dev] [PATCH] eal_lcore: check /sys/devices/system/node/nodeY/cpuX as a, fallback for socket id detecting

2014-04-16 Thread Wang Sheng-Hui
3 ways to get the NUMA info: 1) check the existence of symlink /sys/devices/system/cpu/cpuX/nodeY 2) check the existence of symlink /sys/devices/system/node/nodeY/cpuX 3) get the value from /sys/devices/system/cpu/cpuX/topology/physical_package_id Signed-of

[dpdk-dev] [PATCH 02/15] make: include whole archive on static link

2014-04-16 Thread Neil Horman
On Wed, Apr 16, 2014 at 11:26:48AM +0200, Thomas Monjalon wrote: > 2014-04-15 14:05, Neil Horman: > > This happens automatically on dyanmic linking, but when linking an archive > > we need to to include the whole archive to make sure we call all the > > constructors. Not doing this causes them to b

[dpdk-dev] [PATCH 01/15] makefiles: Fixed -share command line option error

2014-04-16 Thread Neil Horman
On Wed, Apr 16, 2014 at 11:22:35AM +0200, Thomas Monjalon wrote: > Hi, > > 2014-04-15 14:05, Neil Horman: > > The shared libraries built with the current makefile set produce static > > libraries rather than actual shared objects. This is due to several missing > > options that are required to co

[dpdk-dev] [PATCH] eal: check error conditinos for every loop iteration

2014-04-16 Thread Neil Horman
The return code for rte_cpu_get_flag_enabled is only checked on the termination of the for loop that it is called inside, but should be checked for every iteration it makes through the for loop. This is caused by some silly missing brackets. Simply add them in Signed-off-by: Neil Horman Reporte

[dpdk-dev] [PATCH v5] eal_common_cpuflags: Fix %rbx corruption, and simplify the code

2014-04-16 Thread Neil Horman
On Wed, Apr 16, 2014 at 08:58:31AM +, De Lara Guarch, Pablo wrote: > Hi Neil, > > > > >> What was the value of RTE_COMPILE_TIME_CPUFLAGS when you built your > >> library? If you added defines for flag support that are not tested for > >> yet in the cpu_feature_table, that would be the err