[dpdk-dev] mk: fix app linking for combined libs

2014-12-16 Thread Hiroshi Shimamoto
> Subject: Re: [dpdk-dev] mk: fix app linking for combined libs > > 2014-12-08 09:53, Neil Horman: > > On Thu, Oct 23, 2014 at 04:36:44PM +0100, Sergio Gonzalez Monroy wrote: > > > Building combined shared libraries results in applications being linked > > > against separeted/individual and combin

[dpdk-dev] Segmentation fault in rte_eal_hugepage_attach

2014-12-16 Thread Rick LaMont
My DPDK application works fine when it's the primary process but crashes whenever --proc-type=secondary. The segmentation fault occurs in this call to mmap() within rte_eal_hugepage_attach(): /* * fdzero is mmapped to get a contiguous block of virtual * addresses of the a

[dpdk-dev] ethdev: fix out of date comment

2014-12-16 Thread Stephen Hemminger
max_frame_size was replaced with mtu by earlier commit Signed-off-by: Stephen Hemminger --- a/lib/librte_ether/rte_ethdev.h 2014-12-08 09:24:51.725600463 -0800 +++ b/lib/librte_ether/rte_ethdev.h 2014-12-16 20:41:41.445416856 -0800 @@ -1669,8 +1669,7 @@ struct eth_driver; * * - *de

[dpdk-dev] [PATCH 7/7] vmxnet3: support jumbo frames

2014-12-16 Thread Stephen Hemminger
From: Stephen Hemminger Add support for linking multi-segment buffers together to handle Jumbo packets Signed-off-by: Stephen Hemminger Signed-off-by: Bill Hong --- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 1 + lib/librte_pmd_vmxnet3/vmxnet3_ring.h | 2 + lib/librte_pmd_vmxnet3/vmxnet3_r

[dpdk-dev] [PATCH 6/7] vmxnet3: support RSS and refactor offload

2014-12-16 Thread Stephen Hemminger
From: Stephen Hemminger Refactor the logic to compute receive offload flags to a simpler function. Andd add support for putting RSS flow hash into packet. Signed-off-by: Stephen Hemminger Signed-off-by: Bill Hong --- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 69 -

[dpdk-dev] [PATCH 5/7] vmxnet3: get rid of DEBUG ifdefs

2014-12-16 Thread Stephen Hemminger
From: Stephen Hemminger By defining macro as a stub it is possible to get rid of #ifdef's in the actual code. Signed-off-by: Stephen Hemminger --- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h | 6 -- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 9 + 2 files changed, 5 insertions(+), 10 del

[dpdk-dev] [PATCH 4/7] vmxnet3: fix link state handling

2014-12-16 Thread Stephen Hemminger
From: Stephen Hemminger This patch is a bugfx. The Intel version of VMXNET3 driver does not handle link state properly. The VMXNET3 API returns 1 if connected and 0 if disconnected. Also need to return correct value to indicate state change. Signed-off-by: Stephen Hemminger --- lib/librte_pmd

[dpdk-dev] [PATCH 3/7] vmxnet3: add support for mulit-segment transmit

2014-12-16 Thread Stephen Hemminger
From: Stephen Hemminger Change sending loop to support multi-segment mbufs. The VMXNET3 api has start-of-packet and end-packet flags, so it is not hard to send multi-segment mbuf's. Also, update descriptor in 32 bit value rather than toggling bitfields which is slower and error prone. Based on c

[dpdk-dev] [PATCH 2/7] vmxnet3: remove mtu check

2014-12-16 Thread Stephen Hemminger
From: Stephen Hemminger Remove check for packets sending packets greater than MTU. No other driver does this, it should be handled at higher layer. Signed-off-by: Stephen Hemminger --- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 2 -- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h | 1 - lib/librte_p

[dpdk-dev] [PATCH 1/7] vmxnet3: add support for VLAN filtering

2014-12-16 Thread Stephen Hemminger
From: Stephen Hemminger VMXNET3 supports configuring filter table in host. Signed-off-by: Stephen Hemminger --- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 107 +--- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h | 2 +- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 25 --

[dpdk-dev] [PATCH 0/7] vmxnet3: driver enhancements

2014-12-16 Thread Stephen Hemminger
This set of patches updates the vmxnet3 in the DPDK to match the features in the driver I wrote. The most important critical feature is support for multi-segment jumbo frames. Stephen Hemminger (7): vmxnet3: add support for VLAN filtering vmxnet3: remove mtu check vmxnet3: add support for mu

[dpdk-dev] [PATCH v2] mk: link combined shared lib using CC

2014-12-16 Thread Thomas Monjalon
2014-10-28 15:48, Sergio Gonzalez Monroy: > If we set EXTRA_CFLAGS=-O0, build fails with following error: > > /usr/bin/ld: test: hidden symbol `mknod' in > /usr/lib64/libc_nonshared.a(mknod.oS) is referenced by DSO > > Fix: link combined shared lib using CC if LINK_USING_CC is enabled. > > Sign

[dpdk-dev] Fwd: FOSDEM conference - call for participation

2014-12-16 Thread Stephen Hemminger
On Fri, 31 Oct 2014 15:53:19 -0700 (PDT) Thomas Monjalon wrote: > Hi, > > Talks related to DPDK can be proposed for FOSDEM 2015: > https://fosdem.org/2015/ > This conference will take place in Belgium on 31 January & 1 February. > Did DPDK make it in the schedule or not?

[dpdk-dev] [PATCH] lib/librte_table: Fix table array lookup

2014-12-16 Thread Dumitrescu, Cristian
Hi Mark, NACK >If the original intent for this table type was to accept >any 32-bit value, then by applying the table index bitmask >as a modulo index for distribution across table entries, >then this patch would be invalid and should be rejected. I think you got it exactly right, this was the i

[dpdk-dev] [PATCH] lib/librte_table: Fix table array lookup

2014-12-16 Thread Thomas Monjalon
Cristian, this patch is about packet framework. Could you review it please? 2014-12-12 17:06, Mark Wunderlich: > The existing lookup function was returning an unmodified > pkts_mask bitmask into lookup_hit_mask. This effectively > assumes that all packets would index correctly into one > of the a

[dpdk-dev] [PATCH] replaced O(n^2) sort in sort_by_physaddr() with qsort() from standard library

2014-12-16 Thread Ananyev, Konstantin
Hi Jay, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jay Rolette > Sent: Thursday, December 11, 2014 4:06 PM > To: Dev > Subject: [dpdk-dev] [PATCH] replaced O(n^2) sort in sort_by_physaddr() with > qsort() from standard library > > Signed-off-by: Jay R

[dpdk-dev] [PATCH v2] bond: static analysis issues fix

2014-12-16 Thread Thomas Monjalon
2014-12-15 17:13, Declan Doherty: > -v2: > Incorporates Pawel's comments regarding assertion's check on activate_slave > array indexing Changelog should be below three dashes to be excluded from git history. > Fixes for link bonding library identified by static analysis tool > > - Overflow asse

[dpdk-dev] [PATCH] ring: Fix return type in enqueue and dequeue burst functions

2014-12-16 Thread Olivier MATZ
Hi Pablo, On 12/15/2014 02:41 PM, Pablo de Lara wrote: > Enqueue and dequeue burst functions always return a positive > value (including 0), so return type should be unsigned, > instead of int. > > Fixed also API doc for one of the functions. > > Signed-off-by: Pablo de Lara Acked-by: Olivier Ma

[dpdk-dev] [PATCH v3] librte_pmd_null: Add null PMD

2014-12-16 Thread Tetsuya Mukawa
(2014/12/16 17:47), Thomas Monjalon wrote: > 2014-12-16 17:44, Tetsuya Mukawa: >> I've updated the null PMD to apply it to latest DPDK. >> Also I've sent a port hotplug patch for null PMD. > As explained in http://dpdk.org/dev#send, do not hesitate to > use --annotate to add this kind of changelog

[dpdk-dev] [PATCH v3] librte_pmd_null: Add null PMD

2014-12-16 Thread Tetsuya Mukawa
I've updated the null PMD to apply it to latest DPDK. Also I've sent a port hotplug patch for null PMD. Thanks, Tetsuya (2014/12/16 17:39), Tetsuya Mukawa wrote: > 'null PMD' is a driver of the virtual device particulary designed to measure > performance of DPDK PMDs. When an application call rx,

[dpdk-dev] [PATCH] librte_pmd_null: Suport port hotplug function

2014-12-16 Thread Tetsuya Mukawa
The patch is for adding port hotplug funcion to null PMD. Signed-off-by: Tetsuya Mukawa --- lib/librte_pmd_null/rte_eth_null.c | 32 1 file changed, 32 insertions(+) diff --git a/lib/librte_pmd_null/rte_eth_null.c b/lib/librte_pmd_null/rte_eth_null.c index 7ecd

[dpdk-dev] [PATCH v3] librte_pmd_null: Add null PMD

2014-12-16 Thread Tetsuya Mukawa
'null PMD' is a driver of the virtual device particulary designed to measure performance of DPDK PMDs. When an application call rx, null PMD just allocates mbufs and returns those. Also tx, the PMD just frees mbufs. The PMD has following options. - size: specify packe size allocated by RX. Default

[dpdk-dev] [PATCH] examples/vhost: Fix vlan offload issue

2014-12-16 Thread Thomas Monjalon
2014-12-12 12:15, Ouyang Changchun: > The following commit break vm2vm hard mode test cases: > commit db4014f2b65cb31bf209cadd5bcec778ca137fe2 > Author: Huawei Xie > Date: Thu Nov 13 06:34:07 2014 +0800 > examples/vhost: use factorized default Rx/Tx configuration > > Investigation show that

[dpdk-dev] DPDK RSS support for ixgbevf PMD

2014-12-16 Thread Vlad Zolotarov
On 12/15/14 22:33, Thomas Monjalon wrote: > 2014-12-15 21:11, Vladislav Zolotarov: >> Hi, >> I'm running an ixgbevf PMD on an AWS guests with extended networking >> (SR-IOV functions of 82599 Intel's NIC) and noticed that even in the >> current git tree there is no support for a multi-queue in thi

[dpdk-dev] [PATCH] Minor fixes in rte_common.h file.

2014-12-16 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ravi Kerur > Sent: Tuesday, December 16, 2014 4:47 PM > To: Neil Horman > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] Minor fixes in rte_common.h file. > > On Sat, Dec 13, 2014 at 2:39 AM, Neil Horma

[dpdk-dev] Building 1.7.1 or 1.8.0-rc4 on latest CentOS 6.6 fails

2014-12-16 Thread Barak Enat
Hi When building 1.7.1 or 1.8.0-rc4 on recent CentOS 6 (6.6) I got this error: In file included from /home/makerpm/rpmbuild/BUILD/dpdk-1.8.0/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:41, from /home/makerpm/rpmbuild/BUILD/dpdk-1.8.0/lib/librte_eal/linuxapp/kni/eth

[dpdk-dev] [PATCH] l3fwd-acl: fix possible memory leak.

2014-12-16 Thread Konstantin Ananyev
At error app_acl_init() can return without freeing dynamically allocated memory. Not really a big problem, as if app_acl_init() fails, then application would terminate immediately anyway. Though it is a good coding practise to make a function to cleanup after itself. Signed-off-by: Konstantin Anan

[dpdk-dev] mk: fix app linking for combined libs

2014-12-16 Thread Thomas Monjalon
2014-12-08 09:53, Neil Horman: > On Thu, Oct 23, 2014 at 04:36:44PM +0100, Sergio Gonzalez Monroy wrote: > > Building combined shared libraries results in applications being linked > > against separeted/individual and combined libs altogether. > > > > Link only against combined lib when the config

[dpdk-dev] [PATCH v2] testpmd: limit port mask bits to RTE_MAX_ETHPORTS

2014-12-16 Thread Neil Horman
On Tue, Dec 16, 2014 at 02:39:44PM +, Bruce Richardson wrote: > The port mask parsing in testpmd allowed up to 64 bits to be processed, > even if RTE_MAX_ETHPORTS is set to a max of 32. Fix this by only > processing up to min(RTE_MAX_ETHPORTS,64) bits of the mask. > > Signed-off-by: Bruce Rich

[dpdk-dev] [PATCH v2] mk: fix build with shared pcap pmd

2014-12-16 Thread Neil Horman
On Tue, Dec 16, 2014 at 03:39:56PM +0100, Thomas Monjalon wrote: > 2014-12-16 08:58, Neil Horman: > > On Tue, Dec 16, 2014 at 12:04:44AM +0100, Thomas Monjalon wrote: > > > Some applications doesn't have the pcap link flag > > > when shared libraries are enabled. > > > Indeed in such case, pcap PMD

[dpdk-dev] [PATCH] Minor fixes in rte_common.h file.

2014-12-16 Thread Neil Horman
On Tue, Dec 16, 2014 at 08:46:51AM -0800, Ravi Kerur wrote: > On Sat, Dec 13, 2014 at 2:39 AM, Neil Horman wrote: > > > > On Fri, Dec 12, 2014 at 03:04:34PM -0800, r k wrote: > > > Subject: [PATCH] Minor fixes in rte_common.h file. > > > > > > Fix rte_is_power_of_2 since 0 is not. > > > Avoid bran

[dpdk-dev] [PATCH 3/3] eal: for safety, use snprintf instead of sprintf

2014-12-16 Thread Bruce Richardson
When printing the version string to a local variable, use snprintf for safety over sprintf. This is general good practice even if the values to print are all hard-coded. Signed-off-by: Bruce Richardson --- lib/librte_eal/common/include/rte_version.h | 4 ++-- 1 file changed, 2 insertions(+), 2 d

[dpdk-dev] [PATCH 2/3] ixgbe: prevent array overflow access in vector driver

2014-12-16 Thread Bruce Richardson
Switch the order of the conditions in a while loop, so we check the range of "i" against the max, before using it to index into the array. Signed-off-by: Bruce Richardson --- lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_pmd_

[dpdk-dev] [PATCH 1/3] af_packet: ensure *internals is not null when dereferencing

2014-12-16 Thread Bruce Richardson
The cleanup code on error checks for *internals being NULL only after using the pointer to perform other cleanup. Fix this by moving the clean-up based on the pointer inside the check for NULL. Signed-off-by: Bruce Richardson --- lib/librte_pmd_af_packet/rte_eth_af_packet.c | 15 ---

[dpdk-dev] [PATCH 0/3] (More) Fixes for issues highlighted by static analysis

2014-12-16 Thread Bruce Richardson
A further three small patches fixing more issues highlighted by static analysis scans. Bruce Richardson (3): af_packet: ensure *internals is not null when dereferencing ixgbe: prevent array overflow access in vector driver eal: for safety, use snprintf instead of sprintf lib/librte_eal/co

[dpdk-dev] [PATCH v3] i40e: workaround for X710 performance issues

2014-12-16 Thread Helin Zhang
On X710, performance number is far from the expectation on recent firmware versions. The fix for this issue may not be integrated in the following firmware version. So the workaround in software driver is needed. It needs to modify the initial values of 3 internal only registers. Note that the work

[dpdk-dev] [PATCH] kni: fix build on RHEL6.5

2014-12-16 Thread Thomas Monjalon
2014-12-11 13:27, Jincheng Miao: > RHEL6.5 kernel is based on 2.6.32. But there are two changing > from 2.6.35: > 1. socket struct is changed > It wrappered previous wait_queue_head_t of socket to > struct socket_wq. So for the kernel older than 2.6.35, we should > directly use socket->wait instead

[dpdk-dev] [PATCH 10/17] librte_acl: add AVX2 as new rte_acl_classify() method

2014-12-16 Thread Ananyev, Konstantin
> -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Monday, December 15, 2014 8:21 PM > To: Ananyev, Konstantin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 10/17] librte_acl: add AVX2 as new > rte_acl_classify() method > > On Mon, Dec 15, 2014 a

[dpdk-dev] two tso related questions

2014-12-16 Thread Alex Markuze
On Tue, Dec 16, 2014 at 2:24 PM, Helmut Sim wrote: > > Thanks Alex, > > So i probably miss something... > what you are saying is correct for IP segmentation where the segmentation > is at the IP level, and all segments are identified according to the > Identification field in the IP header. > > Ho

[dpdk-dev] [PATCH v2] mk: fix build with shared pcap pmd

2014-12-16 Thread Thomas Monjalon
2014-12-16 08:58, Neil Horman: > On Tue, Dec 16, 2014 at 12:04:44AM +0100, Thomas Monjalon wrote: > > Some applications doesn't have the pcap link flag > > when shared libraries are enabled. > > Indeed in such case, pcap PMD must not be linked but pcap library should. > > > > Actually -lpcap is al

[dpdk-dev] [PATCH 5/5] cfgfile: prevent error when reading an empty file

2014-12-16 Thread Bruce Richardson
If the file to be read by the cfgfile is empty, i.e. no configuration data, but possibly comments present, the cfgfile should not mark the last processed section (curr_section) as having N entries, since there is no last processed section. Signed-off-by: Bruce Richardson --- lib/librte_cfgfile/r

[dpdk-dev] [PATCH 4/5] examples: fix check for null before de-reference

2014-12-16 Thread Bruce Richardson
The check for NULL is in the wrong position in the "if" error leg. The pointer should be checked for NULL before checking what the value of what the pointer points to is. Signed-off-by: Bruce Richardson --- examples/vm_power_manager/channel_manager.c | 2 +- examples/vm_power_manager/vm_power_cl

[dpdk-dev] [PATCH 3/5] examples: set correct limit for length of unix socket path

2014-12-16 Thread Bruce Richardson
The length of the path to a unix socket is not PATH_MAX but instead is UNIX_PATH_MAX which is generally just over 100 bytes in size. It's not actually defined in sys/un.h on linux - despite the man page referencing it, so calculate the size in the case where it's not defined. Signed-off-by: Bruce

[dpdk-dev] [PATCH 2/5] test: check for mbuf alloc failure

2014-12-16 Thread Bruce Richardson
If mbuf allocation failed for whatever reason, we would get a NULL pointer exception in test_table_acl.c:test_pipeline_single_filter test case. We fix this by causing an early break out of the application loop. If we quit the test immediately we would leak any existing allocated mbufs, but by break

[dpdk-dev] [PATCH 1/5] test: after NULL check, don't free the NULL pointer

2014-12-16 Thread Bruce Richardson
In the kvargs test cases, we were checking for errors by checking if the returned pointer value was NULL. In the error handling, we then tried to free back the NULL pointer, which would cause a crash. Signed-off-by: Bruce Richardson --- app/test/test_kvargs.c | 3 --- 1 file changed, 3 deletions

[dpdk-dev] [PATCH 0/5] Fixes for issues highlighted by static analysis scan

2014-12-16 Thread Bruce Richardson
This patch set fixes 5 issues found during a static analysis scan of the latest DPDK code. These fixes are for possible NULL pointer references and array overflow/underflow. Bruce Richardson (5): test: after NULL check, don't free the NULL pointer test: check for mbuf alloc failure examples

[dpdk-dev] Symmetric RSS Hashing in DPDK

2014-12-16 Thread Kamraan Nasim
Hello, My DPDK application requires bidirectional TCP flows to have the same RSS hash however default RSS hashing is *asymmetric*. There are posts such as: http://dpdk.info/ml/archives/dev/2014-February/001460.html which point to a symmetric RSS key(0x6d5a). I have tried using it but it is still

[dpdk-dev] [PATCH v3 8/8] doc: updating the list of sample apps in rel notes

2014-12-16 Thread Siobhan Butler
Added new and existing names of sample apps to list of sample apps in release notes. Signed-off-by: Siobhan Butler --- doc/guides/rel_notes/rel_description.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/rel_description.rst b/doc/guides/rel_notes/rel_descripti

[dpdk-dev] [PATCH v3 7/8] doc: updated resolved issues with old known issues

2014-12-16 Thread Siobhan Butler
Removed resolved issues from known issues section. Added new resolved issues to resolved issues section. Signed-off-by: Siobhan Butler --- doc/guides/rel_notes/known_issues.rst| 225 --- doc/guides/rel_notes/resolved_issues.rst | 173 +++- 2 fi

[dpdk-dev] [PATCH v3 6/8] doc: removed reference to Intel DPDK in Rel Notes

2014-12-16 Thread Siobhan Butler
Removed multiple references to Intel(R) DPDK where no longer relevant. Signed-off-by: Siobhan Butler --- doc/guides/rel_notes/faq.rst| 14 +++--- doc/guides/rel_notes/known_issues.rst | 38 +++ doc/guides/rel_notes/rel_description.rst| 36 ++- do

[dpdk-dev] [PATCH v3 5/8] doc: remove appendix a from release notes

2014-12-16 Thread Siobhan Butler
Removing Appendix A from Release Notes as Intel Licensing information is no longer relevant in this document. Signed-off-by: Siobhan Butler --- doc/guides/rel_notes/appendices.rst | 324 doc/guides/rel_notes/index.rst | 44 - 2 files changed, 368 de

[dpdk-dev] [PATCH v3 4/8] doc: moved known issue 6.29 to resolved issues in rel notes

2014-12-16 Thread Siobhan Butler
Signed-off-by: Siobhan Butler --- doc/guides/rel_notes/resolved_issues.rst | 30 ++ 1 file changed, 30 insertions(+) diff --git a/doc/guides/rel_notes/resolved_issues.rst b/doc/guides/rel_notes/resolved_issues.rst index f9ddb7f..5e88005 100644 --- a/doc/guides/rel_no

[dpdk-dev] [PATCH 3/8] doc: added to known issue 6.10 and removed fixed issue 6.29 from rel_notes

2014-12-16 Thread Siobhan Butler
Signed-off-by: Siobhan Butler --- doc/guides/rel_notes/known_issues.rst | 38 +++ 1 file changed, 7 insertions(+), 31 deletions(-) diff --git a/doc/guides/rel_notes/known_issues.rst b/doc/guides/rel_notes/known_issues.rst index 8ef654a..1f45834 100644 --- a/doc/g

[dpdk-dev] [PATCH v3 2/8] doc: added new features to release notes

2014-12-16 Thread Siobhan Butler
Signed-off-by: Siobhan Butler --- doc/guides/rel_notes/new_features.rst | 24 1 file changed, 24 insertions(+) diff --git a/doc/guides/rel_notes/new_features.rst b/doc/guides/rel_notes/new_features.rst index a93aa3c..00895ce 100644 --- a/doc/guides/rel_notes/new_feature

[dpdk-dev] [PATCH v3 1/8] doc: moved 1.7 new features to supported features for 1.8 in Rel_Notes

2014-12-16 Thread Siobhan Butler
Signed-off-by: Siobhan Butler --- doc/guides/rel_notes/new_features.rst | 17 - doc/guides/rel_notes/supported_features.rst | 22 ++ 2 files changed, 22 insertions(+), 17 deletions(-) diff --git a/doc/guides/rel_notes/new_features.rst b/doc/guides/rel_n

[dpdk-dev] [PATCH v3 0/8] doc: patch set to update release notes

2014-12-16 Thread Siobhan Butler
New Features section: - Removed 1.7 New Features - Added 1.8.0 New Features Supported Features section: - Added 1.7 features to Supported Features Known Issues: - Added devices to Known issue "Not all varients of supported NIC types have been used in testing" - Removed known issue

[dpdk-dev] [PATCH] testpmd: limit port mask bits to RTE_MAX_ETHPORTS

2014-12-16 Thread Thomas Monjalon
2014-12-16 13:27, Bruce Richardson: > The port mask parsing in testpmd allowed up to 64 bits to be processed, > even if RTE_MAX_ETHPORTS is set to a max of 32. Fix this by only > processing up to min(RTE_MAX_ETHPORTS,64) bits of the mask. [...] > - for (i = 0; i < 64; i++) { > + for (i = 0;

[dpdk-dev] [PATCH v2] testpmd: limit port mask bits to RTE_MAX_ETHPORTS

2014-12-16 Thread Bruce Richardson
The port mask parsing in testpmd allowed up to 64 bits to be processed, even if RTE_MAX_ETHPORTS is set to a max of 32. Fix this by only processing up to min(RTE_MAX_ETHPORTS,64) bits of the mask. Signed-off-by: Bruce Richardson --- V2: changed to use RTE_MIN in comparison, instead of double "<".

[dpdk-dev] two tso related questions

2014-12-16 Thread Helmut Sim
Thanks Alex, So i probably miss something... what you are saying is correct for IP segmentation where the segmentation is at the IP level, and all segments are identified according to the Identification field in the IP header. However in TCP segmentation the segments are at the TCP level (isn't i

[dpdk-dev] [PATCH] testpmd: limit port mask bits to RTE_MAX_ETHPORTS

2014-12-16 Thread Bruce Richardson
On Tue, Dec 16, 2014 at 02:40:09PM +0100, Thomas Monjalon wrote: > 2014-12-16 13:27, Bruce Richardson: > > The port mask parsing in testpmd allowed up to 64 bits to be processed, > > even if RTE_MAX_ETHPORTS is set to a max of 32. Fix this by only > > processing up to min(RTE_MAX_ETHPORTS,64) bits

[dpdk-dev] [PATCH] testpmd: limit port mask bits to RTE_MAX_ETHPORTS

2014-12-16 Thread Bruce Richardson
The port mask parsing in testpmd allowed up to 64 bits to be processed, even if RTE_MAX_ETHPORTS is set to a max of 32. Fix this by only processing up to min(RTE_MAX_ETHPORTS,64) bits of the mask. Signed-off-by: Bruce Richardson --- app/test-pmd/config.c | 2 +- 1 file changed, 1 insertion(+), 1

[dpdk-dev] [PATCH] replaced O(n^2) sort in sort_by_physaddr() with qsort() from standard library

2014-12-16 Thread Jay Rolette
Actually, I just relooked at the email I sent and it looks correct (properly indented, etc.). Any suggestions for what might be going on? On Tue, Dec 16, 2014 at 1:18 PM, Jay Rolette wrote: > > Thanks Konstantin. Yes, I'll resend. Not sure why gmail is removing > whitespace when I sent in Plain T

[dpdk-dev] [PATCH] replaced O(n^2) sort in sort_by_physaddr() with qsort() from standard library

2014-12-16 Thread Jay Rolette
Thanks Konstantin. Yes, I'll resend. Not sure why gmail is removing whitespace when I sent in Plain Text mode. Ultimately I'll need to figure out how to properly configure git to send these directly instead of handling them more manually. The examples I saw assumed you were using a gmail.com email

[dpdk-dev] [PATCH] linux_gsg: quick_start.rst fixed as per setup.sh menu options *corrected as per latest setup.sh menu options

2014-12-16 Thread Reshma Pattan
Signed-off-by: Reshma Pattan --- doc/guides/linux_gsg/quick_start.rst | 64 ++--- 1 files changed, 35 insertions(+), 29 deletions(-) diff --git a/doc/guides/linux_gsg/quick_start.rst b/doc/guides/linux_gsg/quick_start.rst index 089dddb..a99b8fa 100644 --- a/

[dpdk-dev] [PATCH v2] bond: vlan flags misinterpreted in xmit_slave_hash function

2014-12-16 Thread Declan Doherty
This patch contains a fix for link bonding handling of vlan tagged packets in mode 3 and 5. Currently xmit_slave_hash function misinterprets the PKT_RX_VLAN_PKT flag to mean that there is a vlan tag within the packet when in actually means that there is a valid entry in the vlan_tci field in the

[dpdk-dev] [PATCH] bond: vlan flags misinterpreted in xmit_slave_hash function

2014-12-16 Thread Thomas Monjalon
Hi Declan, 2014-12-16 11:15, Declan Doherty: > - Split transmit hashing function into separate functions to reduce branching > and to make code clearer. > - Add IPv4 IHL parameters to rte_ip.h > - Fixed VLAN tag support in hashing functions and add support for TCP > in layer 4 header hashing.

[dpdk-dev] [PATCH] Minor fixes in rte_common.h file.

2014-12-16 Thread Ravi Kerur
On Tue, Dec 16, 2014 at 9:23 AM, Ananyev, Konstantin < konstantin.ananyev at intel.com> wrote: > > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ravi Kerur > > Sent: Tuesday, December 16, 2014 4:47 PM > > To: Neil Horman > > Cc: dev at dpdk.org > > Sub

[dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support

2014-12-16 Thread Tetsuya Mukawa
(2014/12/11 6:37), Huawei Xie wrote: > vhost-user support > > > Signed-off-by: Huawei Xie > --- > lib/librte_vhost/Makefile | 5 +- > lib/librte_vhost/vhost-net.h | 4 + > lib/librte_vhost/vhost_cuse/virtio-net-cdev.c | 9 + > lib/librte_vhost/vhost_user

[dpdk-dev] [PATCH] bond: vlan flags misinterpreted in xmit_slave_hash function

2014-12-16 Thread Wodkowski, PawelX
> -Original Message- > From: Doherty, Declan > Sent: Tuesday, December 16, 2014 12:16 PM > To: dev at dpdk.org > Cc: Wodkowski, PawelX; Doherty, Declan > Subject: [PATCH] bond: vlan flags misinterpreted in xmit_slave_hash function > > - Split transmit hashing function into separate functio

[dpdk-dev] [PATCH RFC v2 10/12] lib/librte_vhost: vhost-user memory region map

2014-12-16 Thread Tetsuya Mukawa
(2014/12/11 6:37), Huawei Xie wrote: > deals with vhost user memory map/unmap alignment > > Signed-off-by: Huawei Xie > --- > lib/librte_vhost/rte_virtio_net.h | 2 + > lib/librte_vhost/vhost-net.h | 2 - > lib/librte_vhost/vhost_user/vhost-net-user.h | 3 +- >

[dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT

2014-12-16 Thread Thomas Monjalon
2014-12-16 10:00, Sujith Sankar: > On 16/12/14 1:21 pm, "Qiu, Michael" wrote: > >On 12/16/2014 12:13 PM, Sujith Sankar (ssujith) wrote: > >> On 16/12/14 4:54 am, "Thomas Monjalon" > >> wrote: > >>> 2014-12-12 13:48, Sujith Sankar: > This patch corrects the usage of the flag VFIO_PRESENT in

[dpdk-dev] [PATCH] bond: vlan flags misinterpreted in xmit_slave_hash function

2014-12-16 Thread Declan Doherty
- Split transmit hashing function into separate functions to reduce branching and to make code clearer. - Add IPv4 IHL parameters to rte_ip.h - Fixed VLAN tag support in hashing functions and add support for TCP in layer 4 header hashing. - Fixed incorrect flag set in test application packet ge

[dpdk-dev] two tso related questions

2014-12-16 Thread Alex Markuze
On Mon, Dec 15, 2014 at 10:20 PM, Helmut Sim wrote: > > Hi, > > While working on TSO based solution I faced the following two questions: > > 1. > is there a maximum pkt_len to be used with TSO?, e.g. let's say if seg_sz > is 1400 can the entire segmented pkt be 256K (higer than 64K) ?, then the >

[dpdk-dev] [PATCH] testpmd: remove duplicated function parse_item_list

2014-12-16 Thread Bruce Richardson
There were two static functions called "parse_item_list" in testpmd app. Since one was a superset of the functionality of the other, we can collapse the two calls down into a single one, shared between the two C files. Signed-off-by: Bruce Richardson --- app/test-pmd/cmdline.c| 2 +- app/te

[dpdk-dev] [PATCH v3] i40e: workaround for X710 performance issues

2014-12-16 Thread Zhang, Helin
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, December 16, 2014 4:37 PM > To: Zhang, Helin > Cc: dev at dpdk.org; Rowden, Aaron F; Chen, Jing D > Subject: Re: [dpdk-dev] [PATCH v3] i40e: workaround for X710 performance > issues > > Hi

[dpdk-dev] [PATCH] doc: remove intel legal info from freebsd-gsg

2014-12-16 Thread Siobhan Butler
Removed redundant legal blurb from FreeBSD GSG Signed-off-by: Siobhan Butler --- doc/guides/freebsd_gsg/index.rst | 38 -- 1 file changed, 38 deletions(-) diff --git a/doc/guides/freebsd_gsg/index.rst b/doc/guides/freebsd_gsg/index.rst index f84c2f8..1b4cd3b

[dpdk-dev] [PATCH 2/2] Makefile changes for moved files.

2014-12-16 Thread Ravi Kerur
Use RTE_EXEC_ENV_BSDAPP in common files for code specific to BSD and !RTE_EXEC_ENV_BSDAPP for Linux. Signed-off-by: Ravi Kerur --- lib/librte_eal/bsdapp/eal/Makefile| 6 ++-- lib/librte_eal/common/eal_common_alarm.c | 40 lib/librte_eal/common/eal_commo

[dpdk-dev] [PATCH 1/2] Move EAL source files into common directory.

2014-12-16 Thread Ravi Kerur
Move eal_alarm.c eal_interrupts.c and eal_debug.c from linuxapp and bsdapp directories into common directory. Use RTE_EXEC_ENV_BSDAPP to differentiate between BSD and Linux. Signed-off-by: Ravi Kerur --- lib/librte_eal/bsdapp/eal/eal_alarm.c | 60 -- lib/librte_eal/bsdapp/eal/eal_debug

[dpdk-dev] [PATCH 0/2] [RFC] Moving EAL source files into common dir.

2014-12-16 Thread Ravi Kerur
This patch is RFC for moving EAL source files into common directory. Currently eal_alarm.c, eal_interrupts.c and eal_debug.c are moved. Please let me know if this approach makes sense. Ravi Kerur (2): Move EAL source files into common directory. Makefile changes for moved files. lib/librte_e

[dpdk-dev] [PATCH v2] doc: remove redundant intel references-freebsd gsg

2014-12-16 Thread Siobhan Butler
Updated the FreeBSD GSG to remove redundant Intel references. Signed-off-by: Siobhan Butler --- doc/guides/freebsd_gsg/build_dpdk.rst | 78 +-- doc/guides/freebsd_gsg/build_sample_apps.rst | 40 +++--- doc/guides/freebsd_gsg/install_from_ports.rst | 28 ++

[dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT

2014-12-16 Thread Sujith Sankar (ssujith)
On 16/12/14 4:06 pm, "Burakov, Anatoly" wrote: >> -Original Message- >> From: Sujith Sankar (ssujith) [mailto:ssujith at cisco.com] >> Sent: Tuesday, December 16, 2014 10:34 AM >> To: Burakov, Anatoly; Thomas Monjalon >> Cc: dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] enic: corre

[dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT

2014-12-16 Thread Burakov, Anatoly
> -Original Message- > From: Sujith Sankar (ssujith) [mailto:ssujith at cisco.com] > Sent: Tuesday, December 16, 2014 10:34 AM > To: Burakov, Anatoly; Thomas Monjalon > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT > > > > On 16/12/14 3:5

[dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT

2014-12-16 Thread Sujith Sankar (ssujith)
On 16/12/14 3:52 pm, "Burakov, Anatoly" wrote: >> On 16/12/14 4:54 am, "Thomas Monjalon" >> wrote: >> >> >2014-12-12 13:48, Sujith Sankar: >> >> This patch corrects the usage of the flag VFIO_PRESENT in enic >>driver. >> > >> >Please, could you explain why the flag VFIO_PRESENT was not well u

[dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT

2014-12-16 Thread Burakov, Anatoly
> On 16/12/14 4:54 am, "Thomas Monjalon" > wrote: > > >2014-12-12 13:48, Sujith Sankar: > >> This patch corrects the usage of the flag VFIO_PRESENT in enic driver. > > > >Please, could you explain why the flag VFIO_PRESENT was not well used? > > Without including eal_vfio.h, VFIO_PRESENT is not

[dpdk-dev] [PATCH v2] add one option memory-only for secondary processes

2014-12-16 Thread Bruce Richardson
On Tue, Dec 16, 2014 at 09:26:48AM +, Chi, Xiaobo (NSN - CN/Hangzhou) wrote: > Hi, Bruce, > How about this patch, can it be merged to master branch? Thanks. > > Brgs, > Chi Xiaobo > At this point, I think we are well past code-freeze for new features for 1.8, but this looks a good candidate

[dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT

2014-12-16 Thread Sujith Sankar (ssujith)
On 16/12/14 1:21 pm, "Qiu, Michael" wrote: >On 12/16/2014 12:13 PM, Sujith Sankar (ssujith) wrote: >> On 16/12/14 4:54 am, "Thomas Monjalon" >>wrote: >> >>> 2014-12-12 13:48, Sujith Sankar: This patch corrects the usage of the flag VFIO_PRESENT in enic driver. >>> Please, could you explain

[dpdk-dev] [PATCH v3] librte_pmd_null: Add null PMD

2014-12-16 Thread Thomas Monjalon
2014-12-16 17:44, Tetsuya Mukawa: > I've updated the null PMD to apply it to latest DPDK. > Also I've sent a port hotplug patch for null PMD. As explained in http://dpdk.org/dev#send, do not hesitate to use --annotate to add this kind of changelog when sending patch. Example: http://dpdk.o

[dpdk-dev] [PATCH v3] i40e: workaround for X710 performance issues

2014-12-16 Thread Thomas Monjalon
Hi Helin, First, thank you and Jing for the excellent review process. 2014-12-16 16:23, Helin Zhang: > On X710, performance number is far from the expectation on recent > firmware versions. The fix for this issue may not be integrated in > the following firmware version. So the workaround in soft

[dpdk-dev] [PATCH v2] add one option memory-only for secondary processes

2014-12-16 Thread Chi, Xiaobo (NSN - CN/Hangzhou)
Hi, Bruce, How about this patch, can it be merged to master branch? Thanks. Brgs, Chi Xiaobo -Original Message- From: Chi, Xiaobo (NSN - CN/Hangzhou) Sent: Monday, December 15, 2014 5:58 PM To: 'ext Hiroshi Shimamoto'; dev at dpdk.org Subject: RE: [dpdk-dev] [PATCH v2] add one option me

[dpdk-dev] [PATCH] testpmd: limit port mask bits to RTE_MAX_ETHPORTS

2014-12-16 Thread Neil Horman
On Tue, Dec 16, 2014 at 01:50:06PM +, Bruce Richardson wrote: > On Tue, Dec 16, 2014 at 02:40:09PM +0100, Thomas Monjalon wrote: > > 2014-12-16 13:27, Bruce Richardson: > > > The port mask parsing in testpmd allowed up to 64 bits to be processed, > > > even if RTE_MAX_ETHPORTS is set to a max o

[dpdk-dev] [PATCH v3] i40e: workaround for X710 performance issues

2014-12-16 Thread Chen, Jing D
> -Original Message- > From: Zhang, Helin > Sent: Tuesday, December 16, 2014 4:23 PM > To: dev at dpdk.org > Cc: Chen, Jing D; Wu, Jingjing; Liu, Jijiang; Cao, Waterman; Lu, Patrick; > Rowden, Aaron F; Zhang, Helin > Subject: [PATCH v3] i40e: workaround for X710 performance issues > > On

[dpdk-dev] [PATCH v2] mk: fix build with shared pcap pmd

2014-12-16 Thread Neil Horman
On Tue, Dec 16, 2014 at 12:04:44AM +0100, Thomas Monjalon wrote: > Some applications doesn't have the pcap link flag > when shared libraries are enabled. > Indeed in such case, pcap PMD must not be linked but pcap library should. > > Actually -lpcap is always needed if pcap PMD is used, > and -lrt

[dpdk-dev] [PATCH 17/17] libte_acl: fix compilation issues with RTE_LIBRTE_ACL_STANDALONE=y.

2014-12-16 Thread Neil Horman
On Sun, Dec 14, 2014 at 06:10:59PM +, Konstantin Ananyev wrote: > Signed-off-by: Konstantin Ananyev > --- > lib/librte_acl/rte_acl_osdep_alone.h | 47 > ++-- > 1 file changed, 45 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_acl/rte_acl_osdep_alon

[dpdk-dev] [PATCH v2] bond: static analysis issues fix

2014-12-16 Thread Wodkowski, PawelX
> -Original Message- > From: Doherty, Declan > Sent: Monday, December 15, 2014 6:14 PM > To: dev at dpdk.org > Cc: Wodkowski, PawelX; Doherty, Declan > Subject: [PATCH v2] bond: static analysis issues fix > > -v2: > Incorporates Pawel's comments regarding assertion's check on activate_slav

[dpdk-dev] [PATCH] Minor fixes in rte_common.h file.

2014-12-16 Thread Ravi Kerur
On Sat, Dec 13, 2014 at 2:39 AM, Neil Horman wrote: > > On Fri, Dec 12, 2014 at 03:04:34PM -0800, r k wrote: > > Subject: [PATCH] Minor fixes in rte_common.h file. > > > > Fix rte_is_power_of_2 since 0 is not. > > Avoid branching instructions in RTE_MAX and RTE_MIN. > > > > Signed-off-by: Ravi Ker

[dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT

2014-12-16 Thread Qiu, Michael
On 12/16/2014 12:13 PM, Sujith Sankar (ssujith) wrote: > On 16/12/14 4:54 am, "Thomas Monjalon" wrote: > >> 2014-12-12 13:48, Sujith Sankar: >>> This patch corrects the usage of the flag VFIO_PRESENT in enic driver. >> Please, could you explain why the flag VFIO_PRESENT was not well used? > Withou

[dpdk-dev] [RFC PATCH 1/7] eal: add linear thread id as pthread-local variable

2014-12-16 Thread Qiu, Michael
On 12/11/2014 10:05 AM, Cunming Liang wrote: > Signed-off-by: Cunming Liang > --- > lib/librte_eal/common/include/rte_eal.h | 5 ++ > lib/librte_eal/common/include/rte_lcore.h | 12 > lib/librte_eal/linuxapp/eal/eal_thread.c | 115 > -- > 3 files changed, 1

[dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT

2014-12-16 Thread Sujith Sankar (ssujith)
On 16/12/14 4:54 am, "Thomas Monjalon" wrote: >2014-12-12 13:48, Sujith Sankar: >> This patch corrects the usage of the flag VFIO_PRESENT in enic driver. > >Please, could you explain why the flag VFIO_PRESENT was not well used? Without including eal_vfio.h, VFIO_PRESENT is not available in enic

[dpdk-dev] [PATCH v2] i40e: workaround for X710 performance issues

2014-12-16 Thread Zhang, Helin
> -Original Message- > From: Chen, Jing D > Sent: Tuesday, December 16, 2014 10:29 AM > To: Zhang, Helin; dev at dpdk.org > Cc: Rowden, Aaron F > Subject: RE: [dpdk-dev] [PATCH v2] i40e: workaround for X710 performance > issues > > Hi Helin, > > > -Original Message- > > From: de

[dpdk-dev] [PATCH v2] i40e: workaround for X710 performance issues

2014-12-16 Thread Chen, Jing D
Hi Helin, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Helin Zhang > Sent: Monday, December 15, 2014 3:56 PM > To: dev at dpdk.org > Cc: Rowden, Aaron F > Subject: [dpdk-dev] [PATCH v2] i40e: workaround for X710 performance > issues > > As the fixes of be

  1   2   >