[dpdk-dev] [Dpdk-ovs] problem in binding interfaces of virtio-pci on the VM

2015-02-27 Thread Srinivasreddy R
hi , Thanks for your reply . Are you sure that esn3 is the device you are expecting to use to talk to the host? I am sure ens3 is the device i talk to the host . later on i removed ens3 and accessed my VM with "vncviewer" . when i bind interfaces on the VM with igb_uio . How the communication be

[dpdk-dev] [PATCH v4 18/18] mbuf: remove old packet type bit masks

2015-02-27 Thread Helin Zhang
As unified packet types are used instead, those old bit masks and the relevant macros for packet type indication need to be removed. Signed-off-by: Helin Zhang --- lib/librte_mbuf/rte_mbuf.c | 6 -- lib/librte_mbuf/rte_mbuf.h | 14 -- 2 files changed, 4 insertions(+), 16 deletio

[dpdk-dev] [PATCH v4 17/18] examples/l3fwd: support of unified packet type

2015-02-27 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. Signed-off-by: Helin Zhang --- examples/l3fwd/main.c | 71 +-- 1 file changed, 40 insertions(+), 31 deletions(-) v2 changes: * Used

[dpdk-dev] [PATCH v4 16/18] examples/l3fwd-power: support of unified packet type

2015-02-27 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. Signed-off-by: Helin Zhang --- examples/l3fwd-power/main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) v2 changes: * Used redefined packet types and enlarged packet_

[dpdk-dev] [PATCH v4 15/18] examples/l3fwd-acl: support of unified packet type

2015-02-27 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. Signed-off-by: Helin Zhang --- examples/l3fwd-acl/main.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) v2 changes: * Used redefined packet types and en

[dpdk-dev] [PATCH v4 14/18] examples/ip_reassembly: support of unified packet type

2015-02-27 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. Signed-off-by: Helin Zhang --- examples/ip_reassembly/main.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) v2 changes: * Used redefined packet types and enlarged pac

[dpdk-dev] [PATCH v4 13/18] examples/ip_fragmentation: support of unified packet type

2015-02-27 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. Signed-off-by: Helin Zhang --- examples/ip_fragmentation/main.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) v2 changes: * Used redefined packet types and enlarged

[dpdk-dev] [PATCH v4 12/18] app/test: Remove useless code

2015-02-27 Thread Helin Zhang
Severl useless code lines are added accidenly, which blocks packet type unification. They should be deleted at all. Signed-off-by: Helin Zhang --- app/test/packet_burst_generator.c | 10 -- 1 file changed, 10 deletions(-) v4 changes: * Removed several useless code lines which block pack

[dpdk-dev] [PATCH v4 11/18] app/testpmd: support of unified packet type

2015-02-27 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. Signed-off-by: Helin Zhang Signed-off-by: Jijiang Liu --- app/test-pmd/csumonly.c | 10 +-- app/test-pmd/rxonly.c | 178 ++-- 2 files

[dpdk-dev] [PATCH v4 10/18] app/test-pipeline: support of unified packet type

2015-02-27 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. Signed-off-by: Helin Zhang --- app/test-pipeline/pipeline_hash.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) v2 changes: * Used redefined packet types and enlarged

[dpdk-dev] [PATCH v4 09/18] fm10k: support of unified packet type

2015-02-27 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. Signed-off-by: Helin Zhang --- lib/librte_pmd_fm10k/fm10k_rxtx.c | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) v4 changes: * Supported unifi

[dpdk-dev] [PATCH v4 08/18] vmxnet3: support of unified packet type

2015-02-27 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. Signed-off-by: Helin Zhang Acked-by: Yong Wang --- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) v2 changes: * Used redefined pac

[dpdk-dev] [PATCH v4 07/18] enic: support of unified packet type

2015-02-27 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. Signed-off-by: Helin Zhang --- lib/librte_pmd_enic/enic_main.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) v2 changes: * Used redefined packet types and en

[dpdk-dev] [PATCH v4 06/18] i40e: support of unified packet type

2015-02-27 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e_rxtx.c | 786 ++-- 1 file changed, 512 insertions(+), 274 deletions(-) v2 changes: * Use

[dpdk-dev] [PATCH v4 05/18] ixgbe: support of unified packet type

2015-02-27 Thread Helin Zhang
To unify packet type among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. Note that around 2.5% performance drop (64B) was observed of doing 4 ports (1 port per 82599 card) IO forwarding on the same SNB core. Signed-off-by: Helin Zhang --- lib/librte_pmd_i

[dpdk-dev] [PATCH v4 04/18] e1000: support of unified packet type

2015-02-27 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. Signed-off-by: Helin Zhang --- lib/librte_pmd_e1000/igb_rxtx.c | 98 ++--- 1 file changed, 83 insertions(+), 15 deletions(-) v2 changes: * Used

[dpdk-dev] [PATCH v4 03/18] mbuf: add definitions of unified packet types

2015-02-27 Thread Helin Zhang
As there are only 6 bit flags in ol_flags for indicating packet types, which is not enough to describe all the possible packet types hardware can recognize. For example, i40e hardware can recognize more than 150 packet types. Unified packet type is composed of L2 type, L3 type, L4 type, tunnel type

[dpdk-dev] [PATCH v4 02/18] ixgbe: support of unified packet type for vector

2015-02-27 Thread Helin Zhang
To unify the packet type, bit masks of packet type for ol_flags are replaced. In addition, more packet types (UDP, TCP and SCTP) are supported in vectorized ixgbe PMD. Note that around 2% performance drop (64B) was observed of doing 4 ports (1 port per 82599 card) IO forwarding on the same SNB core

[dpdk-dev] [PATCH v4 01/18] mbuf: redefinition of packet_type in rte_mbuf

2015-02-27 Thread Helin Zhang
In order to unify the packet type, the field of 'packet_type' in 'struct rte_mbuf' needs to be extended from 16 to 32 bits. Accordingly, some fields in 'struct rte_mbuf' are re-organized to support this change for Vector PMD. As 'struct rte_kni_mbuf' for KNI should be right mapped to 'struct rte_mb

[dpdk-dev] [PATCH v4 00/18] unified packet type

2015-02-27 Thread Helin Zhang
Currently only 6 bits which are stored in ol_flags are used to indicate the packet types. This is not enough, as some NIC hardware can recognize quite a lot of packet types, e.g i40e hardware can recognize more than 150 packet types. Hiding those packet types hides hardware offload capabilities whi

[dpdk-dev] [PATCH v3 0/3] Mellanox ConnectX-3 PMD

2015-02-27 Thread Adrien Mazarguil
On Thu, Feb 26, 2015 at 03:49:07PM +0200, Gleb Natapov wrote: > On Thu, Feb 26, 2015 at 02:36:27PM +0100, Thomas Monjalon wrote: > > 2015-02-26 13:51, Gleb Natapov: > > > Did git pull today. After enabling mlnx pmd compilation fails with: > > > > > > dpdk/lib/librte_pmd_mlx4/mlx4.c: In function ?m

[dpdk-dev] [PATCH] mlx4: avoid init errors when kernel modules are not loaded

2015-02-27 Thread Adrien Mazarguil
Mimic UIO/VFIO drivers behavior by not causing errors when a device cannot be initialized due to missing or mismatching kernel modules. Display helpful messages instead, such as: [...] EAL: PCI device :83:00.0 on NUMA socket 1 EAL: probe driver: 15b3:1007 librte_pmd_mlx4 PMD: librte_pmd_

[dpdk-dev] [PATCH] rte_mbuf: scattered pktmbufs freeing optimization

2015-02-27 Thread Vadim Suraev
Hi, Olivier, Hi Konstantin, >Indeed, this function looks useful, and I also have a work in progress >on this topic, but currently it is not well tested. I'm sorry, I didn't know. I'll not interfere with my patch)) >About the inlining, I have no objection now, although Stephen may be >right. I thi

[dpdk-dev] Why only rx queue "0" can receive network packet by i40e NIC

2015-02-27 Thread lhffjzh
Hi, BTW, I try on both 1.7.1 and 1.8.0. Thanks and Regards, Haifeng -Original Message- From: dev-bounces at dpdk.org [mailto:dev-boun...@dpdk.org] On Behalf Of lhffjzh Sent: Friday, February 27, 2015 4:47 PM To: 'Sujith Sankar (ssujith)'; 'Wiles, Keith'; 'Thomas Monjalon' Cc: dev at dpd

[dpdk-dev] [PATCH] eal: Fix build issue of hotplug with icc

2015-02-27 Thread Mcnamara, John
> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Friday, February 27, 2015 5:21 AM > To: dev at dpdk.org > Cc: Mcnamara, John; Tetsuya Mukawa > Subject: [PATCH] eal: Fix build issue of hotplug with icc > > This patch fixes following errors with icc. > > e

[dpdk-dev] [PATCH] librte_pmd_null: Fix build issue with icc

2015-02-27 Thread Mcnamara, John
> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Friday, February 27, 2015 5:20 AM > To: dev at dpdk.org > Cc: Mcnamara, John; Tetsuya Mukawa > Subject: [PATCH] librte_pmd_null: Fix build issue with icc > > This patch fixes following errors with icc. Conf

[dpdk-dev] [PATCH] librte_pmd_null: Fix build issue with gcc-4.7

2015-02-27 Thread Mcnamara, John
> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Friday, February 27, 2015 5:18 AM > To: dev at dpdk.org > Cc: Mcnamara, John; stephen at networkplumber.org; Tetsuya Mukawa > Subject: [PATCH] librte_pmd_null: Fix build issue with gcc-4.7 > > This patch fixe

[dpdk-dev] Why only rx queue "0" can receive network packet by i40e NIC

2015-02-27 Thread lhffjzh
Hi All, We use 4 cores loop 4 rx queues on one i40e port, but only rx queue "0" can receive network packet, do anyone kindly know why? BTW, all of network packet has same destination ip address but has more than 200 different source ip address. In addition, by our test, all of rx queues can recei

[dpdk-dev] [Dpdk-ovs] problem in binding interfaces of virtio-pci on the VM

2015-02-27 Thread Srinivasreddy R
hi , please fine the oputput On the VM . /tools/dpdk_nic_bind.py --status Network devices using DPDK-compatible driver == == Network devices using kernel driver === :00:03.0 '82540EM Gigabit Ethernet Controller' if=en

[dpdk-dev] [PATCH] maintainers: claim responsibility for docs

2015-02-27 Thread Siobhan Butler
Signed-off-by: Siobhan Butler --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 07fdf5e..6e4326b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -34,6 +34,7 @@ M: maintainers at dpdk.org Documentation (with overlaps) - +M: Siobhan But

[dpdk-dev] [PATCH] headers: typeof -> __typeof__ to unbreak C++11 code

2015-02-27 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Simon Kagstrom > Sent: Wednesday, February 25, 2015 1:29 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] headers: typeof -> __typeof__ to unbreak C++11 > code > > When compiling C++11-code or above (--

[dpdk-dev] [PATCH] testpmd: Fix segmentation fault when portmask is specified

2015-02-27 Thread Tetsuya Mukawa
If testpmd is invoked with portmask option like below, segmentation fault will be occured. This patch fixes the issue. Reported-by: De Lara Guarch, Pablo Signed-off-by: Tetsuya Mukawa --- app/test-pmd/testpmd.c | 37 +++-- 1 file changed, 23 insertions(+), 14 del

[dpdk-dev] [PATCH v4 03/18] mbuf: add definitions of unified packet types

2015-02-27 Thread Olivier MATZ
Hi Helin, On 02/27/2015 02:11 PM, Helin Zhang wrote: > As there are only 6 bit flags in ol_flags for indicating packet > types, which is not enough to describe all the possible packet > types hardware can recognize. For example, i40e hardware can > recognize more than 150 packet types. Unified pac

[dpdk-dev] [PATCH v4 12/18] app/test: Remove useless code

2015-02-27 Thread Gajdzica, MaciejX T
> Severl useless code lines are added accidenly, which blocks packet type > unification. They should be deleted at all. > > Signed-off-by: Helin Zhang > --- > app/test/packet_burst_generator.c | 10 -- > 1 file changed, 10 deletions(-) > > v4 changes: > * Removed several useless code li

[dpdk-dev] [PATCH v6 2/8] eal/linux: add rx queue interrupt FDs to intr handle struct

2015-02-27 Thread Thomas Monjalon
2015-02-27 11:28, Liang, Cunming: > From: David Marchand [mailto:david.marchand at 6wind.com] > Sent: Friday, February 27, 2015 6:33 PM > > On Fri, Feb 27, 2015 at 5:56 AM, Cunming Liang wrote: > > > --- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h > > > +++ b/lib/librte_eal/linu

[dpdk-dev] [PATCH 3/3] pcap: add byte and error counters into statistics

2015-02-27 Thread Tero Aho
Added input/ouput byte counters into pcap interface statistics, also calls pcap_stats to add dropped packets into input errors. Signed-off-by: Tero Aho --- lib/librte_pmd_pcap/rte_eth_pcap.c | 37 + 1 file changed, 29 insertions(+), 8 deletions(-) diff --git

[dpdk-dev] [PATCH 2/3] pcap: add support for jumbo frames

2015-02-27 Thread Tero Aho
Extend eth_pcap_rx and eth_pcap_tx to support jumbo frames. On receive side read large packets into multiple mbufs and on the transmit side do the opposite. Signed-off-by: Tero Aho --- lib/librte_pmd_pcap/rte_eth_pcap.c | 88 -- 1 file changed, 75 insertions(+

[dpdk-dev] [PATCH 1/3] pcap: utilize underlying real interface properties

2015-02-27 Thread Tero Aho
These changes set pcap interface mac address to the real underlying interface address instead of the default one. Also real interface link status, speed and duplex are reported when eth_link_update is called for the pcap interface. Signed-off-by: Tero Aho --- lib/librte_pmd_pcap/rte_eth_pcap.c |

[dpdk-dev] [PATCH 0/3] pcap pmd improvements

2015-02-27 Thread Tero Aho
We have found it convenient to use pcap interfaces in early development when speed does not matter. However, pcap interfaces use fixed values for some properties like link status which makes it hard to simulate certain conditions. Here's series of small improvements we have originally used on top

[dpdk-dev] [PATCH v6 2/8] eal/linux: add rx queue interrupt FDs to intr handle struct

2015-02-27 Thread Thomas Monjalon
2015-02-27 11:28, Liang, Cunming: > From: David Marchand [mailto:david.marchand at 6wind.com] > Sent: Friday, February 27, 2015 6:33 PM > On Fri, Feb 27, 2015 at 5:56 AM, Cunming Liang intel.com> wrote: > > --- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_i

[dpdk-dev] [PATCH v6 3/8] eal/bsd: dummy for new intr definition

2015-02-27 Thread Thomas Monjalon
2015-02-27 11:21, Liang, Cunming: > From: David Marchand [mailto:david.marchand at 6wind.com] > > On Fri, Feb 27, 2015 at 5:56 AM, Cunming Liang wrote: > > > @@ -49,6 +51,8 @@ enum rte_intr_handle_type { > > > > > > struct rte_intr_handle { > > > > > > int fd;

[dpdk-dev] [PATCH v15] testpmd: Add port hotplug support

2015-02-27 Thread Tetsuya Mukawa
On 2015/02/27 3:49, De Lara Guarch, Pablo wrote: > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tetsuya Mukawa >> Sent: Wednesday, February 25, 2015 7:32 PM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH v15] testpmd: Add port hotplug support >> >>

[dpdk-dev] [PATCH v6 4/8] eal/linux: add per rx queue interrupt handling based on VFIO

2015-02-27 Thread Thomas Monjalon
Hi Cunming, First, sorry to have to say that, but it is not easy to read discussions where quote marks are not used. I re-insert them for clarity. Comments below. 2015-02-27 12:22, Liang, Cunming: > From: David Marchand [mailto:david.marchand at 6wind.com] > Sent: Friday, February 27, 2015 6:34

[dpdk-dev] [PATCH v2] ABI: Add abi checking utility

2015-02-27 Thread Thomas Monjalon
Hi Neil, 2015-02-27 08:48, Neil Horman: > On Mon, Feb 02, 2015 at 01:18:26PM -0500, Neil Horman wrote: > > There was a request for an abi validation utiltyfor the ongoing ABI > > stability > > work. As it turns out there is a abi compliance checker in development that > > seems to be under activ

[dpdk-dev] [PATCH 00/36] Update IXGBE base codes

2015-02-27 Thread Liu, Jijiang
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ouyang Changchun > Sent: Thursday, February 12, 2015 8:01 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 00/36] Update IXGBE base codes > > This patch set update IXGBE base codes to the version of cid-1

[dpdk-dev] [PATCH 0/3] pcap pmd improvements

2015-02-27 Thread Thomas Monjalon
2015-02-27 15:42, Tero Aho: > We have found it convenient to use pcap interfaces in early development > when speed does not matter. However, pcap interfaces use fixed values > for some properties like link status which makes it hard to simulate > certain conditions. > > Here's series of small impr

[dpdk-dev] [PATCH v2 0/4] Fix issues reported by static analysis tool

2015-02-27 Thread Olivier MATZ
Hi Pawel, On 02/25/2015 01:41 PM, Pawel Wodkowski wrote: > Static analysis report some issues against current DPDK version. Most of > them need only cosmetic code changes (changing type of variable). > > One issue related with ring pmd fix real memory leak problem. > > PATCH v2 changes: > - rem

[dpdk-dev] [PATCH] rte_mbuf: scattered pktmbufs freeing optimization

2015-02-27 Thread Olivier MATZ
Hi Vadim, Hi Konstantin, On 02/27/2015 01:18 PM, Vadim Suraev wrote: > Hi, Konstantin, > >> Seems really useful. Indeed, this function looks useful, and I also have a work in progress on this topic, but currently it is not well tested. As we are on the mbuf subject, for 2.1, I would like to dis

[dpdk-dev] [PATCH] eal: Fix build issue of hotplug with icc

2015-02-27 Thread Tetsuya Mukawa
This patch fixes following errors with icc. error #188: enumerated type mixed with another type return -1; Reported-by: Mcnamara, John Signed-off-by: Tetsuya Mukawa --- lib/librte_ether/rte_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte

[dpdk-dev] [PATCH] librte_pmd_null: Fix build issue with icc

2015-02-27 Thread Tetsuya Mukawa
This patch fixes following errors with icc. rte_eth_null.c(47): error #83: type qualifier specified more than once Reported-by: Mcnamara, John Signed-off-by: Tetsuya Mukawa --- lib/librte_pmd_null/rte_eth_null.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/libr

[dpdk-dev] [PATCH] rte_mbuf: scattered pktmbufs freeing optimization

2015-02-27 Thread Vadim Suraev
Hi, Konstantin, >Seems really useful. >One thought - why to introduce the limitation that all mbufs have to be from the same mempool? >I think you can reorder it a bit, so it can handle situation when chained mbufs belong to different mempools. I had a doubt, my concern was how practical is that

[dpdk-dev] [PATCH] librte_pmd_null: Fix build issue with gcc-4.7

2015-02-27 Thread Tetsuya Mukawa
This patch fixes following errors with gcc-4.7. lib/librte_pmd_null/rte_eth_null.c:302:28: error: array subscript is above array bounds Reported-by: Mcnamara, John Reported-by: Stephen Hemminger Signed-off-by: Tetsuya Mukawa --- lib/librte_pmd_null/rte_eth_null.c | 12 +++- 1 fi

[dpdk-dev] [PATCH] rte_mbuf: scattered pktmbufs freeing optimization

2015-02-27 Thread Ananyev, Konstantin
> From: Vadim Suraev [mailto:vadim.suraev at gmail.com] > Sent: Friday, February 27, 2015 12:19 PM > To: Ananyev, Konstantin > Cc: dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH] rte_mbuf: scattered pktmbufs freeing > optimization > > Hi, Konstantin, > >Seems really useful. > >One thought - wh

[dpdk-dev] [PATCH v6 8/8] l3fwd-power: enable one-shot rx interrupt and polling/interrupt mode switch

2015-02-27 Thread Cunming Liang
From: "Zhou, Danny" Demonstrate how to handle per rx queue interrupt in a NAPI-like implementation in usersapce. PDK polling thread mainly works in polling mode and switch to interrupt mode only if there is no any packet received in recent polls. Usersapce interrupt notification generally takes a

[dpdk-dev] [PATCH v6 7/8] igb: enable rx queue interrupts for PF

2015-02-27 Thread Cunming Liang
From: "Zhou, Danny" The patch does below for igb PF: - Setup NIC to generate MSI-X interrupts - Set the IVAR register to map interrupt causes to vectors - Implement interrupt enable/disable functions Signed-off-by: Danny Zhou Signed-off-by: Cunming Liang --- v6 changes - fill queue-vector map

[dpdk-dev] [PATCH v6 6/8] ixgbe: enable rx queue interrupts for both PF and VF

2015-02-27 Thread Cunming Liang
From: "Zhou, Danny" The patch does below things for ixgbe PF and VF: - Setup NIC to generate MSI-X interrupts - Set the IVAR register to map interrupt causes to vectors - Implement interrupt enable/disable functions Signed-off-by: Danny Zhou Signed-off-by: Yong Liu Signed-off-by: Cunming Liang

[dpdk-dev] [PATCH v6 5/8] ethdev: add rx interrupt enable/disable functions

2015-02-27 Thread Cunming Liang
Add three dev_ops functions to enable and disable rx queue interrupts; and to retrieve the vector num which the specified queue assosiated with. Signed-off-by: Danny Zhou Signed-off-by: Cunming Liang --- v6 changes - add rx_intr_vec_get to retrieve the vector num of the queue. v5 changes - R

[dpdk-dev] [PATCH v6 4/8] eal/linux: add per rx queue interrupt handling based on VFIO

2015-02-27 Thread Cunming Liang
This patch does below: - Create multiple VFIO eventfd for rx queues. - Handle per rx queue interrupt. - Eliminate unnecessary suspended DPDK polling thread wakeup mechanism for rx interrupt by allowing polling thread epoll_wait rx queue interrupt notification. Signed-off-by: Danny Zhou S

[dpdk-dev] [PATCH v6 3/8] eal/bsd: dummy for new intr definition

2015-02-27 Thread Cunming Liang
To make bsd compiling happy with new intr changes. Signed-off-by: Cunming Liang --- lib/librte_eal/bsdapp/eal/eal_interrupts.c| 15 +++ .../bsdapp/eal/include/exec-env/rte_interrupts.h | 4 lib/librte_eal/bsdapp/eal/rte_eal_version.map | 2

[dpdk-dev] [PATCH v6 2/8] eal/linux: add rx queue interrupt FDs to intr handle struct

2015-02-27 Thread Cunming Liang
Per vector event fd will store in rte_intr_handle during init. Device drivers take responsibility to fill queue-vec mapping table(vec_num[]). Signed-off-by: Danny Zhou Signed-off-by: Cunming Liang --- v6 changes: - add mapping table between irq vector number and queue id. v5 changes: - Create

[dpdk-dev] [PATCH v6 1/8] eal: declare new interrupt api

2015-02-27 Thread Cunming Liang
Add two API *rte_intr_rx_wait* and *rte_intr_rx_set* for RX interrupt. They're only available in VFIO_MSIX. Signed-off-by: Cunming Liang --- lib/librte_eal/common/include/rte_interrupts.h | 38 ++ 1 file changed, 38 insertions(+) diff --git a/lib/librte_eal/common/includ

[dpdk-dev] [PATCH v6 0/8] Interrupt mode PMD

2015-02-27 Thread Cunming Liang
v6 changes - split rte_intr_wait_rx_pkt into two APIs 'wait' and 'set'. - rewrite rte_intr_rx_wait/rte_intr_rx_set. - using vector number instead of queue_id as interrupt API params. - patch reorder and split. v5 changes - Rebase the patchset onto the HEAD - Isolate ethdev from EAL for new-a

[dpdk-dev] [PATCH v3 08/16] vmxnet3: support of unified packet type

2015-02-27 Thread Zhang, Helin
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, February 27, 2015 7:26 PM > To: dev at dpdk.org; Zhang, Helin > Subject: Re: [dpdk-dev] [PATCH v3 08/16] vmxnet3: support of unified packet > type > > 2015-02-17 14:59, Helin Zhang: > > To

[dpdk-dev] [PATCH v6 4/8] eal/linux: add per rx queue interrupt handling based on VFIO

2015-02-27 Thread Liang, Cunming
Hi, From: David Marchand [mailto:david.march...@6wind.com] Sent: Friday, February 27, 2015 6:34 PM To: Liang, Cunming Cc: dev at dpdk.org; Stephen Hemminger; Thomas Monjalon; Zhou, Danny Subject: Re: [PATCH v6 4/8] eal/linux: add per rx queue interrupt handling based on VFIO I am not really comf

[dpdk-dev] Why only rx queue "0" can receive network packet by i40e NIC

2015-02-27 Thread Thomas Monjalon
2015-02-27 16:47, lhffjzh: > Hi All, > > We use 4 cores loop 4 rx queues on one i40e port, but only rx queue "0" can > receive network packet, do anyone kindly know why? BTW, all of network > packet has same destination ip address but has more than 200 different > source ip address. It's possible

[dpdk-dev] [PATCH 2/2] doc: update programmers guide for uio_pci_generic

2015-02-27 Thread Bruce Richardson
On Wed, Feb 25, 2015 at 01:20:43PM +, Bruce Richardson wrote: > On Wed, Feb 25, 2015 at 01:12:43PM +, Iremonger, Bernard wrote: > > > > > > > -Original Message- > > > From: Richardson, Bruce > > > Sent: Wednesday, February 25, 2015 12:28 PM > > > To: Iremonger, Bernard > > > Cc: d

[dpdk-dev] [PATCH v6 0/6] enicpmd: Cisco Systems Inc. VIC Ethernet PMD

2015-02-27 Thread Thomas Monjalon
2015-02-27 08:09, Sujith Sankar: > Hi Thomas, > > No update on it from my side :-( > It would take some more time for me to start working on it (and flow > director api) as a few other things are keeping me busy. It's unfortunate. We now have a PMD without documentation and blocking the removal o

[dpdk-dev] [PATCH v6 0/8] Interrupt mode PMD

2015-02-27 Thread David Marchand
On Fri, Feb 27, 2015 at 5:56 AM, Cunming Liang wrote: > v6 changes > - split rte_intr_wait_rx_pkt into two APIs 'wait' and 'set'. > - rewrite rte_intr_rx_wait/rte_intr_rx_set. > - using vector number instead of queue_id as interrupt API params. > - patch reorder and split. > > Ok, so after lo

[dpdk-dev] [PATCH v6 4/8] eal/linux: add per rx queue interrupt handling based on VFIO

2015-02-27 Thread David Marchand
I am not really comfortable with this api. This is just creating something on top of the standard epoll api with limitations. In the end, we could just use an external lib that does this already. So ok, this will work for your limited use case, but this will not be really useful for anything else

[dpdk-dev] [PATCH v6 2/8] eal/linux: add rx queue interrupt FDs to intr handle struct

2015-02-27 Thread David Marchand
Hello, On Fri, Feb 27, 2015 at 5:56 AM, Cunming Liang wrote: > Per vector event fd will store in rte_intr_handle during init. > Device drivers take responsibility to fill queue-vec mapping > table(vec_num[]). > > Signed-off-by: Danny Zhou > Signed-off-by: Cunming Liang > --- > v6 changes: > -

[dpdk-dev] [PATCH v6 2/8] eal/linux: add rx queue interrupt FDs to intr handle struct

2015-02-27 Thread Liang, Cunming
From: David Marchand [mailto:david.march...@6wind.com] Sent: Friday, February 27, 2015 6:33 PM To: Liang, Cunming Cc: dev at dpdk.org; Stephen Hemminger; Thomas Monjalon; Zhou, Danny Subject: Re: [PATCH v6 2/8] eal/linux: add rx queue interrupt FDs to intr handle struct Hello, On Fri, Feb 27,

[dpdk-dev] [PATCH] vhost: Add a hint on how to add or remove the device to a data core

2015-02-27 Thread BenoƮt Canet
Let's make sure people will not forget to set and unset VIRTIO_DEV_RUNNING. Signed-off-by: Beno?t Canet --- doc/guides/prog_guide/vhost_lib.rst | 3 ++- lib/librte_vhost/rte_virtio_net.h | 4 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/guides/prog_guide/vhost_lib.rst

[dpdk-dev] [PATCH v6 3/8] eal/bsd: dummy for new intr definition

2015-02-27 Thread Liang, Cunming
From: David Marchand [mailto:david.march...@6wind.com] Sent: Friday, February 27, 2015 6:00 PM To: Liang, Cunming Cc: dev at dpdk.org; Stephen Hemminger; Thomas Monjalon Subject: Re: [PATCH v6 3/8] eal/bsd: dummy for new intr definition Hello, On Fri, Feb 27, 2015 at 5:56 AM, Cunming Liang mail

[dpdk-dev] [PATCH] testpmd: stop pkt forwarding when quitting testpmd

2015-02-27 Thread Pablo de Lara
When user quits testpmd, and there is traffic being forwarded, that may produce a segmentation fault, due to ports being closed, while they are still transmitting packets. This patch prevents the issue from happening, by stopping packet forwarding before closing the ports. Signed-off-by: Pablo de

[dpdk-dev] [PATCH] rte_mbuf: scattered pktmbufs freeing optimization

2015-02-27 Thread Ananyev, Konstantin
Hi Vadim, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of vadim.suraev at > gmail.com > Sent: Thursday, February 26, 2015 11:15 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] rte_mbuf: scattered pktmbufs freeing optimization > > From: "vadim.suraev

[dpdk-dev] [Dpdk-ovs] problem in binding interfaces of virtio-pci on the VM

2015-02-27 Thread Bruce Richardson
On Fri, Feb 27, 2015 at 04:29:36PM +0530, Srinivasreddy R wrote: > hi , > > please fine the oputput On the VM . > > /tools/dpdk_nic_bind.py --status > > Network devices using DPDK-compatible driver > == > == > > > Network devices using kernel driver > =

[dpdk-dev] [PATCH v6 3/8] eal/bsd: dummy for new intr definition

2015-02-27 Thread David Marchand
Hello, On Fri, Feb 27, 2015 at 5:56 AM, Cunming Liang wrote: > > diff --git a/lib/librte_eal/bsdapp/eal/include/exec-env/rte_interrupts.h > b/lib/librte_eal/bsdapp/eal/include/exec-env/rte_interrupts.h > index 87a9cf6..b114aac 100644 > --- a/lib/librte_eal/bsdapp/eal/include/exec-env/rte_interrup

[dpdk-dev] [PATCH v11 2/2] librte_pmd_null: Support port hotplug function

2015-02-27 Thread Tetsuya Mukawa
On 2015/02/27 0:36, Mcnamara, John wrote: >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Mcnamara, John >> Sent: Thursday, February 26, 2015 12:21 PM >> To: Tetsuya Mukawa; Thomas Monjalon >> Cc: dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v11 2/2] li

[dpdk-dev] [PATCH] virtio: Fix compilation issue on freebsd

2015-02-27 Thread Ouyang Changchun
This patch fixes the compilation issue on freebsd: /root/qwan/tmp/dpdk_org/lib/librte_pmd_virtio/virtio_ethdev.c: In function 'virtio_resource_init': /root/qwan/tmp/dpdk_org/lib/librte_pmd_virtio/virtio_ethdev.c:1071:56: error: unused parameter 'pci_dev' [-Werror=unused-parameter] static int v

[dpdk-dev] [PATCH] testpmd: Fix segmentation fault when portmask is specified

2015-02-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Friday, February 27, 2015 7:16 AM > To: dev at dpdk.org > Cc: De Lara Guarch, Pablo; Tetsuya Mukawa > Subject: [PATCH] testpmd: Fix segmentation fault when portmask is > specified > > If testpmd is invoked

[dpdk-dev] [Dpdk-ovs] problem in binding interfaces of virtio-pci on the VM

2015-02-27 Thread Bruce Richardson
On Thu, Feb 26, 2015 at 10:46:58PM +0530, Srinivasreddy R wrote: > hi Bruce , > Thank you for your response . > I am accessing my VM via " vncviewer " . so ssh doesn't come into picture . > Is there any way to find the root cause of my problem . does dpdk stores > any logs while binding interfaces

[dpdk-dev] [PATCH 0/3] additional sample app guides

2015-02-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of John McNamara > Sent: Wednesday, February 25, 2015 7:46 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 0/3] additional sample app guides > > This patchset includes two new sample app guides. > > The fi

[dpdk-dev] [PATCH v3 09/11] lib/librte_vhost: vhost user support

2015-02-27 Thread Xie, Huawei
On 2/24/2015 1:36 AM, Czesnowicz, Przemyslaw wrote: > From: "Xie, Huawei" > > In rte_vhost_driver_register(), vhost unix domain socket listener fd is > created > and added to polled(based on select) fdset. > > In rte_vhost_driver_session_start(), fds in the fdset are checked for > processing. If

[dpdk-dev] [Dpdk-ovs] problem in binding interfaces of virtio-pci on the VM

2015-02-27 Thread Mussar, Gary
This may be a long shot, but I have noticed that using dissimilar device types when launching the VM that these devices might not be bound to the same eth devices in the VM. Are you sure that esn3 is the device you are expecting to use to talk to the host? Gary -Original Message- From:

[dpdk-dev] [PATCH v2] af_packet: Fix some klocwork errors

2015-02-27 Thread Neil Horman
On Fri, Feb 27, 2015 at 08:49:13AM +0800, Ouyang Changchun wrote: > Fix possible memory leak issue: free kvlist before return; > Fix possible resource lost issue: close qssockfd before return; > > Signed-off-by: Changchun Ouyang > --- > change in v2: > - Make the error exit point a common path.

[dpdk-dev] [PATCH v2] af_packet: Fix some klocwork errors

2015-02-27 Thread Ouyang Changchun
Fix possible memory leak issue: free kvlist before return; Fix possible resource lost issue: close qssockfd before return; Signed-off-by: Changchun Ouyang --- change in v2: - Make the error exit point a common path. lib/librte_pmd_af_packet/rte_eth_af_packet.c | 11 +-- 1 file changed

[dpdk-dev] [PATCH v2] ABI: Add abi checking utility

2015-02-27 Thread Neil Horman
On Mon, Feb 02, 2015 at 01:18:26PM -0500, Neil Horman wrote: > There was a request for an abi validation utiltyfor the ongoing ABI stability > work. As it turns out there is a abi compliance checker in development that > seems to be under active development and provides fairly detailed ABI > comp

[dpdk-dev] [PATCH v6 0/6] enicpmd: Cisco Systems Inc. VIC Ethernet PMD

2015-02-27 Thread Sujith Sankar (ssujith)
Hi Thomas, No update on it from my side :-( It would take some more time for me to start working on it (and flow director api) as a few other things are keeping me busy. Keith, Thanks ! I shall get back in case of questions. Regards, -Sujith On 26/02/15 6:38 pm, "Wiles, Keith" wrote: >On 2/2

[dpdk-dev] [PATCH v6 0/8] Interrupt mode PMD

2015-02-27 Thread Liu, Yong
Tested-by: Yong Liu - Tested Commit: 00c685634b8a43e4594e26949a6c4f1cf5b67047 - OS: Fedora20 3.15.8-200.fc20.x86_64 - GCC: gcc version 4.8.3 20140911 (Red Hat 4.8.3-7) (GCC) - CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz - NIC: Intel Corporation 82599ES 10-Gigabit SFI/SFP+ Network Connection -

[dpdk-dev] [PATCH v3] eal: Clean up export of per_lcore__socket_id

2015-02-27 Thread Neil Horman
Theres no need to export this variable. Its set and queried from an API call that doesn't exist in the hot path. Instead just export the rte_socket_id symbol and make the variable private to protect it from type changes. We should do this with the other exported variables too, but I think its to

[dpdk-dev] [PATCH v2] eal: Clean up export of per_lcore__socket_id

2015-02-27 Thread David Marchand
Hello Neil, On Thu, Feb 26, 2015 at 1:48 PM, Neil Horman wrote: > diff --git a/lib/librte_eal/bsdapp/eal/eal_thread.c > b/lib/librte_eal/bsdapp/eal/eal_thread.c > index ca95c72..3672cdb 100644 > --- a/lib/librte_eal/bsdapp/eal/eal_thread.c > +++ b/lib/librte_eal/bsdapp/eal/eal_thread.c > @@ -59,

[dpdk-dev] [PATCH] virtio: Fix compilation issue on freebsd

2015-02-27 Thread Liang, Cunming
Hi, > -Original Message- > From: Ouyang, Changchun > Sent: Friday, February 27, 2015 10:30 AM > To: dev at dpdk.org > Cc: Liang, Cunming; Cao, Waterman; Ouyang, Changchun > Subject: [PATCH] virtio: Fix compilation issue on freebsd > > This patch fixes the compilation issue on freebsd: >

[dpdk-dev] [PATCH v3 08/16] vmxnet3: support of unified packet type

2015-02-27 Thread Thomas Monjalon
2015-02-17 14:59, Helin Zhang: > To unify packet types among all PMDs, bit masks of packet type for > 'ol_flags' are replaced by unified packet type. > > Signed-off-by: Helin Zhang Helin, this patch was already acked in v2 and you didn't change it. Please keep the Acked-by line in such case. Not

[dpdk-dev] [PATCH] rte_mbuf: scattered pktmbufs freeing optimization

2015-02-27 Thread vadim.sur...@gmail.com
From: "vadim.suraev at gmail.com" new function - rte_pktmbuf_free_bulk makes freeing long scattered (chained) pktmbufs belonging to the same pool more optimal using rte_mempool_put_bulk rather than calling rte_mempool_put for each segment. Inlike rte_pktmbuf_free, which calls rte_pktmbuf_free_s

[dpdk-dev] closing version 2.0.0-rc1

2015-02-27 Thread Zhang, Helin
Hi Thomas For "unified packet type", it has been acked by Konstantin, and carefully reviewed by Oliver, and reviewed by Cunming, Bruce, Jingjing, etc. The only open comment is that detailed description of each packet type should be added. I will complete it today and hopefully it can be in R2.0.

[dpdk-dev] [PATCH v2] eal: Clean up export of per_lcore__socket_id

2015-02-27 Thread Liang, Cunming
Hi, > -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Thursday, February 26, 2015 8:48 PM > To: dev at dpdk.org > Cc: thomas.monjalon at 6wind.com; Liang, Cunming; Neil Horman > Subject: [PATCH v2] eal: Clean up export of per_lcore__socket_id > > Theres no