[dpdk-dev] [PATCH 00/10] eal: rte_tailq api cleanup

2015-03-04 22:50, David Marchand: > 143 files changed, 310 insertions(+), 685 deletions(-) Great job. As it removes more lines than it adds, it's probably a good cleanup patchset ;) -- Thomas When there is no more things to remove, it's becoming perfect.

[dpdk-dev] KNI with multiple kthreads per port

On Wed, Mar 4, 2015 at 9:40 PM, Zhang, Helin wrote: >> * 32-bit (yes, KNI works fine, after a few tweaks hugepage init strategy) > Interesting! How did you get it works? In a nutshell: The current (circa r1.8.0) approach does mmap starting from the bottom of the address space, then does a

[dpdk-dev] [PATCH 10/10] eal: no need for E_RTE_NO_TAILQ anymore

There is no remaining reference to this errno. Signed-off-by: David Marchand --- app/test/test_errno.c |2 +- lib/librte_eal/common/eal_common_errno.c |2 -- lib/librte_eal/common/include/rte_errno.h |1 - 3 files changed, 1 insertion(+), 4 deletions(-) diff

[dpdk-dev] [PATCH 09/10] tailq: remove static slots

No static entry remaining, the rte_tailq api is for "internal use" only, get rid of the static slots. Signed-off-by: David Marchand --- lib/librte_eal/bsdapp/eal/rte_eal_version.map |1 - lib/librte_eal/common/Makefile|2 +-

[dpdk-dev] [PATCH 08/10] tailq: move to dynamic tailq

Use dynamic tailq rather than static entries. Signed-off-by: David Marchand --- lib/librte_acl/rte_acl.c | 33 +++ lib/librte_acl/rte_acl.h |1 - lib/librte_distributor/rte_distributor.c | 16 +--

[dpdk-dev] [PATCH 07/10] tailq: introduce dynamic register system

This register system makes it possible to reserve a tailq for the dpdk libraries. The "dynamic" tailqs are right after the "static" tailqs in shared mem. Primary process is responsible for writing the tailq names, so that secondary processes can find them. This is a temp commit, "static" tailqs

[dpdk-dev] [PATCH 06/10] tailq: remove unused RTE_EAL_TAILQ_* macros

A lot of places just protect against concurrent access and I can not see the gain of having those macros. Signed-off-by: David Marchand --- lib/librte_eal/common/include/rte_eal.h | 58 --- lib/librte_mempool/rte_mempool.c| 10 -- 2 files changed, 7

[dpdk-dev] [PATCH 05/10] tailq: get rid of broken "reserve" api

The "reserve" macros and functions do not check if the requested entry is free. They do nothing more than the lookup function (which itself "creates" entries ...). The rte_tailq api is marked as "internal use" in documentation and these macros are only used in test application, so just get rid of

[dpdk-dev] [PATCH 03/10] tailq: remove unneeded inclusion of rte_tailq.h

Only keep inclusion where really needed. Signed-off-by: David Marchand --- app/test-pipeline/config.c |1 - app/test-pipeline/init.c |1 - app/test-pipeline/main.c |1 -

[dpdk-dev] [PATCH 02/10] pci: use lookup tailq api

There is no reason why we should use the "reserve" tailq api, since the pci entry is already statically reserved. Signed-off-by: David Marchand --- lib/librte_eal/bsdapp/eal/eal_pci.c |2 +- lib/librte_eal/linuxapp/eal/eal_pci.c |4 ++-- 2 files changed, 3 insertions(+), 3

[dpdk-dev] [PATCH 01/10] eal: remove yet another remaining reference to pm

Hopefully, this is the last reference to pm. Signed-off-by: David Marchand --- lib/librte_eal/common/include/rte_tailq_elem.h |2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_eal/common/include/rte_tailq_elem.h b/lib/librte_eal/common/include/rte_tailq_elem.h index

[dpdk-dev] [PATCH 00/10] eal: rte_tailq api cleanup

This is a first cleanup at trying to remove references to other dpdk libraries from eal. This cleanup is focused on rte_tailq api which has been marked as "for internal use" for quite some time now. Rather than have a static list in eal for all users of rte_tailq, a new register system is

[dpdk-dev] [PATCH] ixgbe: do not include CRC in Tx byte count

Anyone to carefully review this patch? 2015-01-27 11:38, Stephen Hemminger: > On Tue, 27 Jan 2015 11:11:39 +0100 > Thomas Monjalon wrote: > > > Hi Stephen, > > > > 2015-01-22 22:23, stephen at networkplumber.org: > > > From: Stephen Hemminger > > > > > > The ixgbe driver was including CRC in

[dpdk-dev] [PATCH 1/6] test: remove unneeded casts

2015-02-19 14:53, Bruce Richardson: > On Sat, Feb 14, 2015 at 09:59:05AM -0500, Stephen Hemminger wrote: > > The malloc family returns void * and therefore cast is unnecessary. > > Use calloc rather than zmalloc with multiply for array. > > > > Signed-off-by: Stephen Hemminger > > Looks like a

[dpdk-dev] [PATCH] External app builds need to locate common make fragments and includes.

Hi Keith, On 03/04/2015 05:47 PM, Wiles, Keith wrote: > Hi Olivier > > On 3/4/15, 10:40 AM, "Olivier MATZ" wrote: > >> Hi Keith, >> >> On 03/04/2015 05:11 PM, Wiles, Keith wrote: >>> >>> >>> On 3/4/15, 3:08 AM, "Olivier MATZ" wrote: >>> Hi Keith, On 02/28/2015 05:56 PM, Keith

[dpdk-dev] [PATCH v3] ABI: Add abi checking utility

2015-03-04 11:26, Neil Horman: > +#trap on ctrl-c to clean up > +trap cleanup_and_exit SIGINT I think INT is preffered over SIGINT. You may also add QUIT and TERM. With QUIT, you can replace cleanup_and_exit calls by a simple exit. > + CURRENT_BRANCH=`git log --pretty=format:%H HEAD~1..HEAD`

[dpdk-dev] [PATCH] External app builds need to locate common make fragments and includes.

Hi Keith, On 03/04/2015 05:11 PM, Wiles, Keith wrote: > > > On 3/4/15, 3:08 AM, "Olivier MATZ" wrote: > >> Hi Keith, >> >> On 02/28/2015 05:56 PM, Keith Wiles wrote: >>> When building an external application like Pktgen and using the proper >>> makefile fragments rte.extXYZ.mk NOT rte.XYZ.mk

[dpdk-dev] [PATCH v2] ABI: Add abi checking utility

2015-03-04 10:42, Neil Horman: > On Wed, Mar 04, 2015 at 04:15:18PM +0100, Thomas Monjalon wrote: > > 2015-03-04 09:39, Neil Horman: > > > On Wed, Mar 04, 2015 at 01:54:49PM +0100, Thomas Monjalon wrote: > > > > Hi Neil, > > > > > > > > I remove parts that I agree and reply to those which deserve

[dpdk-dev] [PATCH] External app builds need to locate common make fragments and includes.

Hi Olivier, On 3/4/15, 11:04 AM, "Olivier MATZ" wrote: >Hi Keith, > >On 03/04/2015 05:47 PM, Wiles, Keith wrote: >> Hi Olivier >> >> On 3/4/15, 10:40 AM, "Olivier MATZ" wrote: >> >>> Hi Keith, >>> >>> On 03/04/2015 05:11 PM, Wiles, Keith wrote: On 3/4/15, 3:08 AM, "Olivier MATZ"

[dpdk-dev] [PATCH] External app builds need to locate common make fragments and includes.

On 3/4/15, 10:47 AM, "Wiles, Keith" wrote: >Hi Olivier > >On 3/4/15, 10:40 AM, "Olivier MATZ" wrote: > >>Hi Keith, >> >>On 03/04/2015 05:11 PM, Wiles, Keith wrote: >>> >>> >>> On 3/4/15, 3:08 AM, "Olivier MATZ" wrote: >>> Hi Keith, On 02/28/2015 05:56 PM, Keith Wiles wrote:

[dpdk-dev] [PATCH] External app builds need to locate common make fragments and includes.

Hi Olivier On 3/4/15, 10:40 AM, "Olivier MATZ" wrote: >Hi Keith, > >On 03/04/2015 05:11 PM, Wiles, Keith wrote: >> >> >> On 3/4/15, 3:08 AM, "Olivier MATZ" wrote: >> >>> Hi Keith, >>> >>> On 02/28/2015 05:56 PM, Keith Wiles wrote: When building an external application like Pktgen and

[dpdk-dev] [PATCH v2] ABI: Add abi checking utility

2015-03-04 09:39, Neil Horman: > On Wed, Mar 04, 2015 at 01:54:49PM +0100, Thomas Monjalon wrote: > > Hi Neil, > > > > I remove parts that I agree and reply to those which deserve more > > discussion. > > > > 2015-03-04 06:49, Neil Horman: > > > On Tue, Mar 03, 2015 at 11:18:47PM +0100, Thomas

[dpdk-dev] [PATCH] External app builds need to locate common make fragments and includes.

On 3/4/15, 3:08 AM, "Olivier MATZ" wrote: >Hi Keith, > >On 02/28/2015 05:56 PM, Keith Wiles wrote: >> When building an external application like Pktgen and using the proper >> makefile fragments rte.extXYZ.mk NOT rte.XYZ.mk files as you would >> use with example applications in the same

[dpdk-dev] [PATCH] config: default to shared library

On 03/04/2015 03:31 PM, Bruce Richardson wrote: > On Wed, Mar 04, 2015 at 03:24:12PM +0200, Panu Matilainen wrote: >> On 03/04/2015 03:08 PM, Bruce Richardson wrote: >>> On Wed, Mar 04, 2015 at 06:28:05AM -0500, Neil Horman wrote: On Wed, Mar 04, 2015 at 01:05:07PM +0200, Panu Matilainen

[dpdk-dev] [PATCH] config: default to shared library

On 03/04/2015 03:08 PM, Bruce Richardson wrote: > On Wed, Mar 04, 2015 at 06:28:05AM -0500, Neil Horman wrote: >> On Wed, Mar 04, 2015 at 01:05:07PM +0200, Panu Matilainen wrote: >>> On 03/04/2015 11:24 AM, Thomas Monjalon wrote: Hi Panu, 2015-03-04 08:17, Panu Matilainen: >

[dpdk-dev] [PATCH] config: default to shared library

On Wed, Mar 4, 2015 at 2:49 PM, Bruce Richardson wrote: > On Wed, Mar 04, 2015 at 03:41:49PM +0200, Panu Matilainen wrote: > > Right, but then there's "ivshmem" that doesn't fit that description > either > > AFAICS. > > Ah, yes, forgotten about that one! :-) Well, this is out of scope, but

[dpdk-dev] [PATCH] librte_lpm: define tbl entry reversely for big endian

From: Xuelin Shi This module uses type conversion between struct and int. Also truncation and comparison is used with this int. It is not safe for different endian arch. Add ifdef for big endian struct to fix this issue. Signed-off-by: Xuelin Shi ---

[dpdk-dev] [PATCH] config: default to shared library

On Wed, Mar 04, 2015 at 02:57:50PM +0100, David Marchand wrote: > On Wed, Mar 4, 2015 at 2:49 PM, Bruce Richardson intel.com > > wrote: > > > On Wed, Mar 04, 2015 at 03:41:49PM +0200, Panu Matilainen wrote: > > > Right, but then there's "ivshmem" that doesn't fit that description > > either > >

[dpdk-dev] [PATCH v2] ABI: Add abi checking utility

Hi Neil, I remove parts that I agree and reply to those which deserve more discussion. 2015-03-04 06:49, Neil Horman: > On Tue, Mar 03, 2015 at 11:18:47PM +0100, Thomas Monjalon wrote: > > 2015-02-02 13:18, Neil Horman: > > > +# Validate that we have all the arguments we need > > >

[dpdk-dev] [PATCH] config: default to shared library

On Wed, Mar 04, 2015 at 03:24:12PM +0200, Panu Matilainen wrote: > On 03/04/2015 03:08 PM, Bruce Richardson wrote: > >On Wed, Mar 04, 2015 at 06:28:05AM -0500, Neil Horman wrote: > >>On Wed, Mar 04, 2015 at 01:05:07PM +0200, Panu Matilainen wrote: > >>>On 03/04/2015 11:24 AM, Thomas Monjalon

[dpdk-dev] [PATCH v3] pci: save list of detached devices, and re-probe during driver unload

Added code that saves the pointers to the detached devices, during driver loading, and during driver unloading, go over the list, and re-attach them by calling device_probe_and_attach on each device. Signed-off-by: Raz Amir --- lib/librte_eal/bsdapp/nic_uio/nic_uio.c | 32

[dpdk-dev] [PATCH] config: default to shared library

On Wed, Mar 04, 2015 at 06:28:05AM -0500, Neil Horman wrote: > On Wed, Mar 04, 2015 at 01:05:07PM +0200, Panu Matilainen wrote: > > On 03/04/2015 11:24 AM, Thomas Monjalon wrote: > > >Hi Panu, > > > > > >2015-03-04 08:17, Panu Matilainen: > > >>With symbol versioning its vital that developers test

[dpdk-dev] proposal: remove separate doc tree

2015-02-11 14:28, Butler, Siobhan A: > Hi all, > > In creating documentation for DPDK 1.8.0 dpdk.org used a separate repository > 'dpdk-doc' to work on the conversion of old documentation from PDF to .rst > with sphinx for maintainability and usability purposes. > Now that the conversion has

[dpdk-dev] [PATCH] config: default to shared library

On 03/04/2015 11:24 AM, Thomas Monjalon wrote: > Hi Panu, > > 2015-03-04 08:17, Panu Matilainen: >> With symbol versioning its vital that developers test their code in >> shared library mode, otherwise we'll be playing "add the forgotten >> symbol export" from here to eternity. > > Yes we must

[dpdk-dev] Guest Machine is not Pingable from Host Machine

Hi Team, Guest machine is not pingable from Host machine after creating a bridge with datapath_type "netdev" in the configuration database and adding dpdk ports. Can anyone please let me know what is the issue. Thanks in advance. Thanks & Regards Arkajit Ghosh =-=-=

[dpdk-dev] [PATCH v11 2/2] librte_pmd_null: Support port hotplug function

2015-02-26 19:57 GMT+09:00 Thomas Monjalon : > 2015-02-26 18:06, Tetsuya Mukawa: >> 2015-02-26 16:03 GMT+09:00 Thomas Monjalon : >> > 2015-02-25 16:49, Stephen Hemminger: >> >> Build fails if HOTPLUG is disabled >> >> Hi Stephen, >> >> I appreciate for you reporting. >> >> > >> > OK thanks for

[dpdk-dev] Build failure on FreeBSD-10.1-RELEASE

On 2015/03/02 19:22, Bruce Richardson wrote: > On Mon, Mar 02, 2015 at 12:47:42PM +0900, Tetsuya Mukawa wrote: >> Hi, >> >> I got a error while building master branch on FreeBSD. >> Here is a log. >> >> $ gmake T=x86_64-native-bsdapp-clang config >> cc: error: unknown argument: '-fdirectives-only'

[dpdk-dev] [PATCH] config: default to shared library

2015-03-04 13:05, Panu Matilainen: > On 03/04/2015 11:24 AM, Thomas Monjalon wrote: > > Hi Panu, > > > > 2015-03-04 08:17, Panu Matilainen: > >> With symbol versioning its vital that developers test their code in > >> shared library mode, otherwise we'll be playing "add the forgotten > >> symbol

[dpdk-dev] [PATCH] pci: save list of detached devices, and re-probe during driver unload

Understood. I already sent the updated patch, so I will fix this and resend it soon. -Original Message- From: Bruce Richardson [mailto:bruce.richard...@intel.com] Sent: 04 March 2015 12:13 To: Raz Amir Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH] pci: save list of detached

[dpdk-dev] [PATCH 3/3] doc: Remove BSD limitation from hotplug section of programmer's guide

This patch removes below limitation from hotplug section of programmer's guide. - The framework can only be enabled with Linux. BSD is not supported. Signed-off-by: Tetsuya Mukawa --- doc/guides/prog_guide/port_hotplug_framework.rst | 2 -- 1 file changed, 2 deletions(-) diff --git

[dpdk-dev] [PATCH 2/3] eal, ethdev: Remove CONFIG_RTE_LIBRTE_EAL_HOTPLUG

The patch removes CONFIG_RTE_LIBRTE_EAL_HOTPLUG option from DPDK. Signed-off-by: Tetsuya Mukawa --- config/common_bsdapp | 6 -- config/common_linuxapp | 5 - lib/librte_eal/common/eal_common_dev.c | 2 --

[dpdk-dev] [PATCH 1/3] BSD: Support Port Hotplug function

This patch adds Hotplug support to BSD. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/bsdapp/eal/eal_pci.c | 169 +- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 6 + lib/librte_eal/common/include/rte_pci.h | 1 + lib/librte_ether/rte_ethdev.c

[dpdk-dev] [PATCH] lib/librte_vhost: remove vhost device from data plane when receive VHOST_SET_MEM_TABLE message

Acked-by: Tommy Long -Original Message- From: Xie, Huawei Sent: Tuesday, March 3, 2015 2:26 AM To: dev at dpdk.org Cc: haifeng.lin at huawei.com; mukawa at igel.co.jp; Long, Thomas; Xie, Huawei Subject: [PATCH] lib/librte_vhost: remove vhost device from data plane when receive

[dpdk-dev] [PATCH v2] pci: save list of detached devices, and re-probe during driver unload

Added code that saves the pointers to the detached devices, during driver loading, and during driver unloading, go over the list, and re-attach them by calling device_probe_and_attach on each device. Signed-off-by: Raz Amir --- lib/librte_eal/bsdapp/nic_uio/nic_uio.c | 32

[dpdk-dev] [PATCH v2] tools/dpdk_nic_bind: Fix can't bind virtio-pci issue

On 3/4/2015 10:56 AM, Ouyang Changchun wrote: > The dpdk_nic_bind script will not allow ports to be bound or unbound if none > of the > kernel modules supported by DPDK is loaded. This patch relaxes this > restriction by > checking if a DPDK module is actually requested. The example below >

[dpdk-dev] [PATCH v2 0/4] Fix issues reported by static analysis tool

> > Static analysis report some issues against current DPDK version. Most of > > them need only cosmetic code changes (changing type of variable). > > > > One issue related with ring pmd fix real memory leak problem. > > > > PATCH v2 changes: > > - remove patch 5/5 as it was NACKed > > -

[dpdk-dev] [PATCH v3] ABI: Add abi checking utility

There was a request for an abi validation utilty for the ongoing ABI stability work. As it turns out there is a abi compliance checker in development that seems to be under active development and provides fairly detailed ABI compliance reports. Its not yet intellegent enough to understand symbol

[dpdk-dev] [PATCH 0/7] fix build with debug enabled

2015-03-03 16:23, Thomas Monjalon: > There are some compilation errors when debug options are enabled. > We should start thinking to test every patch with an all-yes configuration. > Unfortunately, we cannot force this kind of configuration because > some libraries depend on the availability of

[dpdk-dev] [PATCH v6 0/8] Interrupt mode PMD

Hi Stephen, On 3/4/2015 8:52 AM, Stephen Hemminger wrote: > On Fri, 27 Feb 2015 11:38:25 +0100 > David Marchand wrote: > >> Ok, so after looking at this patchset, I would say this is the right >> direction, but still this is too limited. >> The ethdev part and the vfio eventfds part look

[dpdk-dev] [PATCH] Move mk/rte.extvars.mk to mk/internal/rte.extvars.mk

Move the rte.extvars.mk to an internal directory and update rte.vars.mk to find the file in the new location. Signed-off-by: Keith Wiles --- mk/internal/rte.extvars.mk | 81 ++ mk/rte.extvars.mk | 81

[dpdk-dev] [PATCH] pci: save list of detached devices, and re-probe during driver unload

Thank you. See answers inline (mostly ack, but not only), and I will send the updated patch soon. > -Original Message- > From: Bruce Richardson [mailto:bruce.richardson at intel.com] > Sent: 03 March 2015 15:33 > To: Raz Amir > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH]

[dpdk-dev] [PATCH 1/7] mempool: fix build with debug enabled

Hi Thomas, On 03/03/2015 04:23 PM, Thomas Monjalon wrote: > error: format ?%p? expects argument of type ?void *?, > but argument 5 has type ?const struct rte_mempool *? [-Werror=format=] > > mp type is (const struct rte_mempool *) and must be casted into a simpler > type to be printed. I was a

[dpdk-dev] [PATCH v4 01/18] mbuf: redefinition of packet_type in rte_mbuf

> -Original Message- > From: Zhang, Helin > Sent: Wednesday, March 4, 2015 8:34 AM > To: Chilikin, Andrey; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH v4 01/18] mbuf: redefinition of packet_type > in rte_mbuf > > > > > -Original Message- > > From: Chilikin, Andrey > > Sent:

[dpdk-dev] [PATCH v2] tools/dpdk_nic_bind: Fix can't bind virtio-pci issue

The dpdk_nic_bind script will not allow ports to be bound or unbound if none of the kernel modules supported by DPDK is loaded. This patch relaxes this restriction by checking if a DPDK module is actually requested. The example below illustrates this problem: In virtio test, on the guest 1.

[dpdk-dev] [PATCH v1 5/5] ixgbe: Add LRO support

On Wed, 04 Mar 2015 09:57:24 +0200 Vlad Zolotarov wrote: > > > On 03/04/15 02:33, Stephen Hemminger wrote: > > On Tue, 3 Mar 2015 21:48:43 +0200 > > Vlad Zolotarov wrote: > > > >> + next_desc: > >> + /* > >> + * The code in this whole file uses the volatile pointer to >

[dpdk-dev] Regarding dpdk_qat example

Hi, In the dpdk_qat example, the function alloc_memzone_region does the allocation for the memory of a crypto session context. Now in a real application, the sessions will be torn down as well. So if a similar strategy is followed as that of alloc_memzone_region, then how can the memory be

[dpdk-dev] [PATCH v1 5/5] ixgbe: Add LRO support

On Wed, 04 Mar 2015 09:59:38 +0200 Vlad Zolotarov wrote: > > Checkpatch warnings (edited to remove ones that should be ok) > > I was unaware that checkpatch rules apply here - at least looking at the > current code it looks like it... ;) > But I'm all for it! I'll fix all the issues and

[dpdk-dev] [PATCH] ring: cleanup file-local macros at end-of-file

On Wed, Mar 04, 2015 at 10:26:24AM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > > Sent: Wednesday, March 04, 2015 10:23 AM > > To: Thomas Monjalon > > Cc: dev at dpdk.org > > Subject: Re:

[dpdk-dev] [PATCH] librte_lpm: define tbl entry reversely for big endian

On Wed, Mar 04, 2015 at 02:34:12PM +0800, xuelin.shi at freescale.com wrote: > From: Xuelin Shi > > This module uses type conversion between struct and int. > Also truncation and comparison is used with this int. > It is not safe for different endian arch. > > Add ifdef for big endian struct to

[dpdk-dev] [PATCH] mk: add support for gdb debug info generation

Hi Marc, On 03/03/2015 02:27 PM, Marc Sune wrote: > > On 03/03/15 14:03, Bruce Richardson wrote: >> On Tue, Mar 03, 2015 at 01:56:19PM +0100, Marc Sune wrote: >> [...] >> I believe that the global option of overriding the CFLAGS is already >> sufficiently >> covered - including being documented

[dpdk-dev] [PATCH] config: default to shared library

On Wed, Mar 04, 2015 at 10:24:44AM +0100, Thomas Monjalon wrote: > Hi Panu, > > 2015-03-04 08:17, Panu Matilainen: > > With symbol versioning its vital that developers test their code in > > shared library mode, otherwise we'll be playing "add the forgotten > > symbol export" from here to

[dpdk-dev] [PATCH v2] ABI: Add abi checking utility

On Wed, Mar 04, 2015 at 04:15:18PM +0100, Thomas Monjalon wrote: > 2015-03-04 09:39, Neil Horman: > > On Wed, Mar 04, 2015 at 01:54:49PM +0100, Thomas Monjalon wrote: > > > Hi Neil, > > > > > > I remove parts that I agree and reply to those which deserve more > > > discussion. > > > > > >

[dpdk-dev] Build failure on FreeBSD-10.1-RELEASE

Hi Tetsuya, Hi Bruce, On 03/04/2015 04:34 AM, Tetsuya Mukawa wrote: > On 2015/03/02 19:22, Bruce Richardson wrote: >> On Mon, Mar 02, 2015 at 12:47:42PM +0900, Tetsuya Mukawa wrote: >>> Hi, >>> >>> I got a error while building master branch on FreeBSD. >>> Here is a log. >>> >>> $ gmake

[dpdk-dev] [PATCH] ring: cleanup file-local macros at end-of-file

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, March 04, 2015 10:23 AM > To: Thomas Monjalon > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ring: cleanup file-local macros at end-of-file > > On Tue, Mar 03,

[dpdk-dev] [PATCH] config: default to shared library

Hi Panu, 2015-03-04 08:17, Panu Matilainen: > With symbol versioning its vital that developers test their code in > shared library mode, otherwise we'll be playing "add the forgotten > symbol export" from here to eternity. Yes we must improve the sanity checks. A lot of options must be tested

[dpdk-dev] [PATCH] ring: cleanup file-local macros at end-of-file

On Tue, Mar 03, 2015 at 10:03:45PM +0100, Thomas Monjalon wrote: > 2015-03-03 16:38, Bruce Richardson: > > The ENQUEUE_PTRS and DEQUEUE_PTRS macros defined in rte_ring.h are > > not meant to be global and are not prefixed with the RTE_ prefix. > > Therefore undef the macros at end of file to avoid

[dpdk-dev] [PATCH] A fix to work around strict-aliasing rules breaking

On Wed, Mar 04, 2015 at 02:07:20AM +, Wang, Zhihong wrote: > > > > -Original Message- > > From: Richardson, Bruce > > Sent: Monday, March 02, 2015 6:32 PM > > To: Wang, Zhihong > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] A fix to work around strict-aliasing rules > >

[dpdk-dev] Build failure on FreeBSD-10.1-RELEASE

On Wed, Mar 04, 2015 at 10:33:14AM +0100, Olivier MATZ wrote: > Hi Tetsuya, Hi Bruce, > > On 03/04/2015 04:34 AM, Tetsuya Mukawa wrote: > >On 2015/03/02 19:22, Bruce Richardson wrote: > >>On Mon, Mar 02, 2015 at 12:47:42PM +0900, Tetsuya Mukawa wrote: > >>>Hi, > >>> > >>>I got a error while

[dpdk-dev] [PATCH] pci: save list of detached devices, and re-probe during driver unload

On Wed, Mar 04, 2015 at 11:07:41AM +0200, Raz Amir wrote: > Thank you. > > See answers inline (mostly ack, but not only), and I will send the updated > patch soon. > > > > > -Original Message- > > > From: Bruce Richardson [mailto:bruce.richardson at intel.com] > > > Sent: 03 March

[dpdk-dev] [PATCH] External app builds need to locate common make fragments and includes.

Hi Keith, On 02/28/2015 05:56 PM, Keith Wiles wrote: > When building an external application like Pktgen and using the proper > makefile fragments rte.extXYZ.mk NOT rte.XYZ.mk files as you would > use with example applications in the same RTE_SDK directory the rte.extXYZ.mk > files are missing

[dpdk-dev] [PATCH v1 5/5] ixgbe: Add LRO support

On 03/04/2015 02:33 AM, Stephen Hemminger wrote: > On Tue, 3 Mar 2015 21:48:43 +0200 > Vlad Zolotarov wrote: > >> + * TODO: >> + *- Get rid of "volatile" crap and let the compiler do its >> + * job. >> + *- Use the proper memory

[dpdk-dev] [PATCH v1 5/5] ixgbe: Add LRO support

On 03/04/15 02:36, Stephen Hemminger wrote: > On Tue, 3 Mar 2015 21:48:43 +0200 > Vlad Zolotarov wrote: > >> - Only x540 and 82599 devices support LRO. >> - Add the appropriate HW configuration. >> - Add RSC aware rx_pkt_burst() handlers: >> - Implemented bulk allocation

[dpdk-dev] [PATCH v1 5/5] ixgbe: Add LRO support

On 03/04/15 02:34, Stephen Hemminger wrote: > On Tue, 3 Mar 2015 21:48:43 +0200 > Vlad Zolotarov wrote: > >> + >> +if (!bulk_alloc) { >> +__le64 dma = >> + rte_cpu_to_le_64(RTE_MBUF_DATA_DMA_ADDR_DEFAULT(nmb)); >> +/* >>

[dpdk-dev] [PATCH v1 5/5] ixgbe: Add LRO support

On 03/04/15 02:33, Stephen Hemminger wrote: > On Tue, 3 Mar 2015 21:48:43 +0200 > Vlad Zolotarov wrote: > >> +next_desc: >> +/* >> + * The code in this whole file uses the volatile pointer to >> + * ensure the read ordering of the status and the rest of

[dpdk-dev] [PATCH] rte_mbuf: scattered pktmbufs freeing optimization

Hi Vadim, On 02/27/2015 06:09 PM, Vadim Suraev wrote: > >Indeed, this function looks useful, and I also have a work in progress > >on this topic, but currently it is not well tested. > I'm sorry, I didn't know. I'll not interfere with my patch)) That not what I wanted to say :) You are very

[dpdk-dev] [PATCH 7/7] bond: remove debug function to fix link with shared lib

On 03/03/15 15:23, Thomas Monjalon wrote: > The function print_client_stats was used in the example without being > clearly exported in the map file. So it breaks linking with shared library > when debug is enabled. > It's better to remove this function as it probably could be implemented > with

[dpdk-dev] [PATCH v2] ABI: Add abi checking utility

On Wed, Mar 04, 2015 at 01:54:49PM +0100, Thomas Monjalon wrote: > Hi Neil, > > I remove parts that I agree and reply to those which deserve more discussion. > > 2015-03-04 06:49, Neil Horman: > > On Tue, Mar 03, 2015 at 11:18:47PM +0100, Thomas Monjalon wrote: > > > 2015-02-02 13:18, Neil

[dpdk-dev] [PATCH v1 5/5] ixgbe: Add LRO support

On 03/04/15 02:33, Stephen Hemminger wrote: > On Tue, 3 Mar 2015 21:48:43 +0200 > Vlad Zolotarov wrote: > >> +lro_bulk_alloc: 1, /**< RX LRO with bulk alloc is ON(1) / >> OFF(0) */ > This is an internal decision and should not be exposed in the API. > We need less knobs not more.

[dpdk-dev] [PATCH v2] librte_eal/common: Fix cast from pointer to integer of different size

On 2015-03-04 02:58, Qiu, Michael wrote: > On 3/3/2015 9:38 PM, Wodkowski, PawelX wrote: >>> -Original Message- >>> From: Qiu, Michael >>> Sent: Tuesday, March 03, 2015 11:00 AM >>> To: Wodkowski, PawelX; dev at dpdk.org >>> Subject: Re: [dpdk-dev] [PATCH v2] librte_eal/common: Fix cast

[dpdk-dev] [PATCH] doc: prog guide cleanup for eal multi-pthread

Reported-by: Butler, Siobhan A Signed-off-by: Cunming Liang --- Fixes: 1733be6d3147(doc: new eal multi-pthread feature) doc/guides/prog_guide/env_abstraction_layer.rst | 82 - 1 file changed, 40 insertions(+), 42 deletions(-) diff --git

[dpdk-dev] [PATCH v4 01/18] mbuf: redefinition of packet_type in rte_mbuf

> -Original Message- > From: Chilikin, Andrey > Sent: Monday, March 2, 2015 7:48 PM > To: Zhang, Helin; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH v4 01/18] mbuf: redefinition of packet_type in > rte_mbuf > > Hi Helin, > > I see that you have removed "uint16_t reserved" member

[dpdk-dev] [PATCH] config: default to shared library

With symbol versioning its vital that developers test their code in shared library mode, otherwise we'll be playing "add the forgotten symbol export" from here to eternity. By defaulting to shared we should catch more of these cases early, but without taking away anybodys ability to build static.

[dpdk-dev] [PATCH] ethdev: add missing symbol export for rte_eth_dev_release_port

Fixes: 36ec8585b298 ("ethdev: release port") Signed-off-by: Panu Matilainen --- lib/librte_ether/rte_ether_version.map | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map index 0d46578..a2d25a6 100644 ---

[dpdk-dev] [PATCH v2] ABI: Add abi checking utility

On Tue, Mar 03, 2015 at 11:18:47PM +0100, Thomas Monjalon wrote: > 2015-02-02 13:18, Neil Horman: > > There was a request for an abi validation utiltyfor the ongoing ABI > > stability > > work. As it turns out there is a abi compliance checker in development that > > seems to be under active

[dpdk-dev] [PATCH] config: default to shared library

On Wed, Mar 04, 2015 at 01:05:07PM +0200, Panu Matilainen wrote: > On 03/04/2015 11:24 AM, Thomas Monjalon wrote: > >Hi Panu, > > > >2015-03-04 08:17, Panu Matilainen: > >>With symbol versioning its vital that developers test their code in > >>shared library mode, otherwise we'll be playing "add

[dpdk-dev] [PATCH] A fix to work around strict-aliasing rules breaking

> -Original Message- > From: Wodkowski, PawelX > Sent: Monday, March 02, 2015 8:32 PM > To: Richardson, Bruce; Wang, Zhihong > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] A fix to work around strict-aliasing rules > breaking > > On 2015-03-02 11:32, Bruce Richardson wrote: > >

[dpdk-dev] [PATCH v4 0/6] Link Bonding mode 6 support (ALB)

Tested-by: Jiajia, SunX - Tested Commit: 8bfc4e3c4cb922d9c7e6b8934fdaffba268c7ed2 - OS: Fedora20 3.11.10-301.fc20.x86_64 - GCC: gcc version 4.8.3 - CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz - NIC: Intel Corporation 82599ES 10-Gigabit SFI/SFP+ Network Connection [8086:10fb] - Target

[dpdk-dev] [PATCH] tools/dpdk_nic_bind: Fix can't bind virtio-pci issue

Hi, > -Original Message- > From: Richardson, Bruce > Sent: Tuesday, March 3, 2015 7:44 PM > To: Ouyang, Changchun > Cc: dev at dpdk.org; Cao, Waterman > Subject: Re: [PATCH] tools/dpdk_nic_bind: Fix can't bind virtio-pci issue > > On Thu, Feb 26, 2015 at 12:57:49PM +0800, Ouyang

[dpdk-dev] [PATCH] A fix to work around strict-aliasing rules breaking

> -Original Message- > From: Richardson, Bruce > Sent: Monday, March 02, 2015 6:32 PM > To: Wang, Zhihong > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] A fix to work around strict-aliasing rules > breaking > > On Mon, Mar 02, 2015 at 05:03:50PM +0800, zhihong.wang at intel.com

[dpdk-dev] [PATCH v2] librte_eal/common: Fix cast from pointer to integer of different size

On 3/3/2015 9:38 PM, Wodkowski, PawelX wrote: >> -Original Message- >> From: Qiu, Michael >> Sent: Tuesday, March 03, 2015 11:00 AM >> To: Wodkowski, PawelX; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v2] librte_eal/common: Fix cast from pointer >> to >> integer of different size

[dpdk-dev] [PATCH 4/7] virtio: fix build with debug enabled

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, March 3, 2015 11:24 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 4/7] virtio: fix build with debug enabled > > With CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_INIT=y: >

[dpdk-dev] [PATCH 3/7] virtio: fix build with mempool debug enabled

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, March 3, 2015 11:24 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 3/7] virtio: fix build with mempool debug > enabled > > The mempool header forces error on