[dpdk-dev] tools brainstorming

2015-04-09 Thread Wiles, Keith
On 4/9/15, 4:23 PM, "Stephen Hemminger" wrote: >On Thu, 9 Apr 2015 21:10:19 + >"Wiles, Keith" wrote: > >> >> >> On 4/9/15, 2:38 PM, "Jay Rolette" wrote: >> >> >On Thu, Apr 9, 2015 at 2:16 PM, Neil Horman >>wrote: >> > >> >> On Thu, Apr 09, 2015 at 11:31:39AM -0500, Jay Rolette wrote:

[dpdk-dev] tools brainstorming

2015-04-09 Thread Wiles, Keith
On 4/9/15, 2:38 PM, "Jay Rolette" wrote: >On Thu, Apr 9, 2015 at 2:16 PM, Neil Horman wrote: > >> On Thu, Apr 09, 2015 at 11:31:39AM -0500, Jay Rolette wrote: >> > On Wed, Apr 8, 2015 at 5:38 PM, Stephen Hemminger < >> > stephen at networkplumber.org> wrote: >> > >> > > On Wed, 8 Apr 2015

[dpdk-dev] tools brainstorming

2015-04-09 Thread Neil Horman
On Thu, Apr 09, 2015 at 09:10:19PM +, Wiles, Keith wrote: > > > On 4/9/15, 2:38 PM, "Jay Rolette" wrote: > > >On Thu, Apr 9, 2015 at 2:16 PM, Neil Horman wrote: > > > >> On Thu, Apr 09, 2015 at 11:31:39AM -0500, Jay Rolette wrote: > >> > On Wed, Apr 8, 2015 at 5:38 PM, Stephen Hemminger <

[dpdk-dev] tools brainstorming

2015-04-09 Thread Neil Horman
On Thu, Apr 09, 2015 at 09:29:14PM +, Wiles, Keith wrote: > > > On 4/9/15, 4:23 PM, "Stephen Hemminger" wrote: > > >On Thu, 9 Apr 2015 21:10:19 + > >"Wiles, Keith" wrote: > > > >> > >> > >> On 4/9/15, 2:38 PM, "Jay Rolette" wrote: > >> > >> >On Thu, Apr 9, 2015 at 2:16 PM, Neil

[dpdk-dev] [PATCH v3 1/5] mk: remove combined library and related options

2015-04-09 Thread Avi Kivity
On 04/09/2015 02:19 PM, Neil Horman wrote: > On Thu, Apr 09, 2015 at 12:06:47PM +0300, Avi Kivity wrote: >> >> On 04/09/2015 11:33 AM, Gonzalez Monroy, Sergio wrote: >>> On 08/04/2015 19:26, Stephen Hemminger wrote: On Wed, 8 Apr 2015 16:07:21 +0100 Sergio Gonzalez Monroy wrote:

[dpdk-dev] [PATCH v3 1/5] mk: remove combined library and related options

2015-04-09 Thread Neil Horman
On Thu, Apr 09, 2015 at 08:00:26PM +0300, Avi Kivity wrote: > On 04/09/2015 02:19 PM, Neil Horman wrote: > >On Thu, Apr 09, 2015 at 12:06:47PM +0300, Avi Kivity wrote: > >> > >>On 04/09/2015 11:33 AM, Gonzalez Monroy, Sergio wrote: > >>>On 08/04/2015 19:26, Stephen Hemminger wrote: > On Wed,

[dpdk-dev] tools brainstorming

2015-04-09 Thread Neil Horman
On Thu, Apr 09, 2015 at 02:38:32PM -0500, Jay Rolette wrote: > On Thu, Apr 9, 2015 at 2:16 PM, Neil Horman wrote: > > > On Thu, Apr 09, 2015 at 11:31:39AM -0500, Jay Rolette wrote: > > > On Wed, Apr 8, 2015 at 5:38 PM, Stephen Hemminger < > > > stephen at networkplumber.org> wrote: > > > > > > >

[dpdk-dev] [PATCH] Add toeplitz hash algorithm

2015-04-09 Thread Vladimir Medvedkin
Hi Gleb, 2015-04-09 9:37 GMT+03:00 Gleb Natapov : > On Wed, Apr 08, 2015 at 03:06:13PM -0400, Vladimir Medvedkin wrote: > > Software implementation of the Toeplitz hash function used by RSS. > > Can be used either for packet distribution on single queue NIC > > or for simulating of RSS

[dpdk-dev] [PATCH] Add toeplitz hash algorithm

2015-04-09 Thread Vladimir Medvedkin
Hi Stephen, 2015-04-09 1:24 GMT+03:00 Stephen Hemminger : > On Wed, 8 Apr 2015 15:06:13 -0400 > Vladimir Medvedkin wrote: > > > Software implementation of the Toeplitz hash function used by RSS. > > Can be used either for packet distribution on single queue NIC > > or for simulating of RSS

[dpdk-dev] [PATCH v3 1/5] mk: remove combined library and related options

2015-04-09 Thread Thomas Monjalon
2015-04-09 07:19, Neil Horman: > On Thu, Apr 09, 2015 at 12:06:47PM +0300, Avi Kivity wrote: > > On 04/09/2015 11:33 AM, Gonzalez Monroy, Sergio wrote: > > >On 08/04/2015 19:26, Stephen Hemminger wrote: > > >>On Wed, 8 Apr 2015 16:07:21 +0100 > > >>Sergio Gonzalez Monroy wrote: > > >> > >

[dpdk-dev] Polling too often at lower packet rates?

2015-04-09 Thread Aaron Campbell
Hi Stephen, Thanks, that was an informative talk. In this case, are you referring to your comments about the thermal budget? That?s definitely interesting, but there must be more to it than that. Again, if I loop over all 6 ports (i.e., continue to keep the CPU busy), it works around the

[dpdk-dev] tools brainstorming

2015-04-09 Thread Neil Horman
On Thu, Apr 09, 2015 at 11:31:39AM -0500, Jay Rolette wrote: > On Wed, Apr 8, 2015 at 5:38 PM, Stephen Hemminger < > stephen at networkplumber.org> wrote: > > > On Wed, 8 Apr 2015 16:29:54 -0600 > > Jay Rolette wrote: > > > > > "C comments" includes //, right? It's been part of the C standard

[dpdk-dev] [PATCH v3 1/5] mbuf: fix clone support when application uses private mbuf data

2015-04-09 Thread Olivier MATZ
Hi Konstantin, On 04/08/2015 03:45 PM, Ananyev, Konstantin wrote: > Hi Olivier, > >> -Original Message- >> From: Olivier MATZ [mailto:olivier.matz at 6wind.com] >> Sent: Wednesday, April 08, 2015 10:44 AM >> To: Ananyev, Konstantin; dev at dpdk.org >> Cc: zoltan.kiss at linaro.org;

[dpdk-dev] [snabb-devel] Re: memory barriers in virtq.lua?

2015-04-09 Thread Xie, Huawei
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Luke Gorrie > Sent: Thursday, April 09, 2015 11:13 AM > To: snabb-devel at googlegroups.com > Cc: dev at dpdk.org; VirtualOpenSystems Technical Team; Michael S. Tsirkin; > virtualization at

[dpdk-dev] [PATCH] enic: migrating to new fdir api

2015-04-09 Thread Sujith Sankar
This patch helps enic migrate to the new flow-director API. It takes care of the following. 1. The change in fdir_filter structure and stats structure 2. DPDK interface functions in enic_ethdev.c 3. ENIC driver functions that deal with the VIC adapter Signed-off-by: Sujith Sankar ---

[dpdk-dev] [PATCH v3 1/5] mk: remove combined library and related options

2015-04-09 Thread Gonzalez Monroy, Sergio
On 09/04/2015 14:33, Thomas Monjalon wrote: > 2015-04-09 07:19, Neil Horman: >> On Thu, Apr 09, 2015 at 12:06:47PM +0300, Avi Kivity wrote: >>> On 04/09/2015 11:33 AM, Gonzalez Monroy, Sergio wrote: On 08/04/2015 19:26, Stephen Hemminger wrote: > On Wed, 8 Apr 2015 16:07:21 +0100 >

[dpdk-dev] tools brainstorming

2015-04-09 Thread Jay Rolette
On Thu, Apr 9, 2015 at 2:16 PM, Neil Horman wrote: > On Thu, Apr 09, 2015 at 11:31:39AM -0500, Jay Rolette wrote: > > On Wed, Apr 8, 2015 at 5:38 PM, Stephen Hemminger < > > stephen at networkplumber.org> wrote: > > > > > On Wed, 8 Apr 2015 16:29:54 -0600 > > > Jay Rolette wrote: > > > > > > >

[dpdk-dev] Running DPDK Binaries on a different Target

2015-04-09 Thread Venkat Thummala
I have the following ACL rule configured in the ACL Table. Priority - 20 SIP - 0 SIP MASK - 0 DIP - 0 DIP MASK - 0 PROTO - 17 [UDP] PROTO MASK - 0xFF SPORT - 0 SPORT RANGE - 0x DPORT - 0 DPORT RANGE - 0x And pumping UDP traffic. On Machine 1, it always HITS the rule as expected. But On

[dpdk-dev] [PATCH 4/4] rte_ethdev: remove unnecessary paren on return

2015-04-09 Thread Stephen Hemminger
The Linux style is not to put extra useless paren's around the expression passed to return statement. Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.c | 298 +- 1 file changed, 149 insertions(+), 149 deletions(-) diff --git

[dpdk-dev] [PATCH 3/4] rte_ethdev: make tables const

2015-04-09 Thread Stephen Hemminger
The statistics tables and null mac address should be immutable. Fix up get_addr routines to accept const args. Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.c | 44 +-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git

[dpdk-dev] [PATCH 2/4] rte_ethdev: whitespace cleanup

2015-04-09 Thread Stephen Hemminger
Fix space after keywords, and other missing whitespace. Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.c | 191 ++ lib/librte_ether/rte_ethdev.h | 57 ++--- 2 files changed, 128 insertions(+), 120 deletions(-) diff --git

[dpdk-dev] [PATCH 1/4] rte_ethdev: remove extra inline

2015-04-09 Thread Stephen Hemminger
There is no reason to inline functions that are not in the critical path. Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index

[dpdk-dev] [PATCH 0/4] rte_ethdev: cleanups

2015-04-09 Thread Stephen Hemminger
A bunch of small (almost trivial) patches to fix style and other issues in the base Ethernet driver interface code. Stephen Hemminger (4): rte_ethdev: remove extra inline rte_ethdev: whitespace cleanup rte_ethdev: make tables const rte_ethdev: remove unnecessary paren on return

[dpdk-dev] Polling too often at lower packet rates?

2015-04-09 Thread Stephen Hemminger
On Thu, 9 Apr 2015 15:26:23 -0300 Aaron Campbell wrote: > Hi Stephen, > > Thanks, that was an informative talk. In this case, are you referring to > your comments about the thermal budget? > > That?s definitely interesting, but there must be more to it than that. > Again, if I loop over

[dpdk-dev] tools brainstorming

2015-04-09 Thread Stephen Hemminger
On Thu, 9 Apr 2015 21:10:19 + "Wiles, Keith" wrote: > > > On 4/9/15, 2:38 PM, "Jay Rolette" wrote: > > >On Thu, Apr 9, 2015 at 2:16 PM, Neil Horman wrote: > > > >> On Thu, Apr 09, 2015 at 11:31:39AM -0500, Jay Rolette wrote: > >> > On Wed, Apr 8, 2015 at 5:38 PM, Stephen Hemminger < >

[dpdk-dev] [PATCH v4 0/7] Move EAL common function

2015-04-09 Thread Ravi Kerur
Thomas, Any additional tests i need to do on linux/bsd for v5 series please let me know. Thanks, Ravi On Tue, Mar 31, 2015 at 11:39 AM, Ravi Kerur wrote: > I will work on it and send out patches by next week. If you need it > earlier please let me know. > > Thanks, > Ravi > > On Mon, Mar 30,

[dpdk-dev] [PATCH v5 6/8] Move common functions in eal_pci.c

2015-04-09 Thread Ravi Kerur
Changes in v5 Rebase to latest code. Removed RTE_EXEC_ENV_BSDAPP from earlier changes. Changes in v4 Move common functions in eal_pci.c to librte_eal/common/ eal_common_pci.c file. Following functions are moved to eal_common_pci.c file. void *pci_map_resource(void *requested_addr, const int

[dpdk-dev] [PATCH v5 5/8] Move common functions in eal_memory.c

2015-04-09 Thread Ravi Kerur
Changes in v5 Rebase to latest code. Changes in v4 Make rte_eal_hugepage_init and rte_eal_hugepage_attach as wrapper functions for BSD. Changes in v3 Changed subject to be more explicit on file name inclusion. Changes in v2 Use common function names rte_eal_hugepage_init and

[dpdk-dev] [PATCH v5 4/8] Move common functions in eal_timer.c

2015-04-09 Thread Ravi Kerur
Changes in v5 Rebase to latest code. Changes in v4 Removed extern declaration of eal_tsc_resolution_hz, instead provided _set_ API. Make set_tsc_freq_from_clock as wrapper function for BSD. Changes in v3 Changed subject to be more explicit on file name inclusion. Changes in v2 Use common

[dpdk-dev] [PATCH v5 3/8] Move common functions in eal_lcore.c

2015-04-09 Thread Ravi Kerur
Changes in v5 Rebase to latest code. Changes in v4 Implement cpu_detected() for BSD. Have common RTE_LOG for Linux and BSD in rte_eal_cpu_init(). Remove RTE_EXEC_ENV_BSDAPP in common file. Changes in v3 Changed subject to be more explicit on file name inclusion. Changes in v2 None Changes in

[dpdk-dev] [PATCH v5 2/8] Move common functions in eal.c

2015-04-09 Thread Ravi Kerur
Changes in v5 Rebase to latest code. Changes in v4 Remove eal_externs.h file, instead use _get_ and _set_ APIS to access those variables. Split eal_common.c into eal_common_system.c and and eal_common_runtime.c rte_eal prefix functions are moved to _runtime_ and eal prefix functions are moved to

[dpdk-dev] [PATCH v5 1/8] Move common functions in eal_thread.c

2015-04-09 Thread Ravi Kerur
Changes in v5 Rebase to latest code. Changes in v4 None Changes in v3 Changed subject to be more explicit on file name inclusion. Changes in v2 None Changes in v1 eal_thread.c has minor differences between Linux and BSD, move entire file into common directory. Use RTE_EXEC_ENV_BSDAPP to

[dpdk-dev] [PATCH v5 0/8] Move common functions in EAL

2015-04-09 Thread Ravi Kerur
Changes include moving common functions in BSD and Linux into common directory. Use appropriate wrapper functions to mask minor differences. Testing: Linux - Ubuntu x86_64 14.04 Compilation successful (x86_64-native-linuxapp-gcc). "make test" results match baseline code. testpmd utility on

[dpdk-dev] [PATCH v5 0/8] Move common functions in EAL

2015-04-09 Thread Ravi Kerur
Changes include moving common functions in BSD and Linux into common directory. Use appropriate wrapper functions to mask minor differences. Testing: Linux - Ubuntu x86_64 14.04 Compilation successful (x86_64-native-linuxapp-gcc). "make test" results match baseline code. testpmd utility on

[dpdk-dev] [PATCH v3 1/5] mk: remove combined library and related options

2015-04-09 Thread Avi Kivity
On 04/09/2015 11:33 AM, Gonzalez Monroy, Sergio wrote: > On 08/04/2015 19:26, Stephen Hemminger wrote: >> On Wed, 8 Apr 2015 16:07:21 +0100 >> Sergio Gonzalez Monroy wrote: >> >>> Currently, the target/rules to build combined libraries is different >>> than the one to build individual

[dpdk-dev] [RFC PATCH 0/6] DPDK support to bifurcated driver

2015-04-09 Thread 贾学涛
Hi Cunming, I applyed bifurc dirver patches and tested it follow your example. But I can't received packets with testpmd and l2fwd. Kernel stack can receive packets from 10.0.0.2 before "ethtool -N XGE4.1 flow-type ip4 src-ip 10.0.0.2 action 12". After "thtool -N XGE4.1 flow-type ip4

[dpdk-dev] Running DPDK Binaries on a different Target

2015-04-09 Thread Ananyev, Konstantin
Hi Venkat, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Venkat Thummala > Sent: Thursday, April 09, 2015 10:07 AM > To: Neil Horman > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] Running DPDK Binaries on a different Target > > I have the following ACL

[dpdk-dev] tools brainstorming

2015-04-09 Thread Jay Rolette
On Wed, Apr 8, 2015 at 5:38 PM, Stephen Hemminger < stephen at networkplumber.org> wrote: > On Wed, 8 Apr 2015 16:29:54 -0600 > Jay Rolette wrote: > > > "C comments" includes //, right? It's been part of the C standard for a > long time now... > > Yes but. > I like to use checkpatch and

[dpdk-dev] [PATCH v3 1/5] mk: remove combined library and related options

2015-04-09 Thread Gonzalez Monroy, Sergio
On 09/04/2015 10:06, Avi Kivity wrote: > > > On 04/09/2015 11:33 AM, Gonzalez Monroy, Sergio wrote: >> On 08/04/2015 19:26, Stephen Hemminger wrote: >>> On Wed, 8 Apr 2015 16:07:21 +0100 >>> Sergio Gonzalez Monroy wrote: >>> Currently, the target/rules to build combined libraries is

[dpdk-dev] [PATCH] enic: disable debug traces

2015-04-09 Thread Adrien Mazarguil
On Tue, Apr 07, 2015 at 07:40:19PM +0200, Thomas Monjalon wrote: > The function name is printed in each enic_ethdev function. > Disable it by default with a new build option. > > Signed-off-by: Thomas Monjalon > --- > config/common_bsdapp | 1 + > config/common_linuxapp

[dpdk-dev] [PATCH] Add toeplitz hash algorithm

2015-04-09 Thread Gleb Natapov
On Wed, Apr 08, 2015 at 03:06:13PM -0400, Vladimir Medvedkin wrote: > Software implementation of the Toeplitz hash function used by RSS. > Can be used either for packet distribution on single queue NIC > or for simulating of RSS computation on specific NIC (for example > after GRE header

[dpdk-dev] [PATCH v3 1/5] mk: remove combined library and related options

2015-04-09 Thread Gonzalez Monroy, Sergio
On 08/04/2015 19:26, Stephen Hemminger wrote: > On Wed, 8 Apr 2015 16:07:21 +0100 > Sergio Gonzalez Monroy wrote: > >> Currently, the target/rules to build combined libraries is different >> than the one to build individual libraries. >> >> By removing the combined library option as a build

[dpdk-dev] [PATCH] enic: disable debug traces

2015-04-09 Thread Stephen Hemminger
On Thu, 9 Apr 2015 10:32:24 +0200 Adrien Mazarguil wrote: > > > > +#ifdef RTE_LIBRTE_ENIC_DEBUG > > #define ENICPMD_FUNC_TRACE() \ > > RTE_LOG(DEBUG, PMD, "ENICPMD trace: %s\n", __func__) > > +#else > > +#define ENICPMD_FUNC_TRACE() do {} while (0) > > How about defining it as (void)0

[dpdk-dev] [RFC PATCH 2/4] Add the new common device header and C file.

2015-04-09 Thread Neil Horman
On Wed, Apr 08, 2015 at 03:58:38PM -0500, Keith Wiles wrote: > Move a number of device specific define, structures and functions > into a generic device base set of files for all device not just Ethernet. > > Signed-off-by: Keith Wiles > --- > lib/librte_eal/common/eal_common_device.c |

[dpdk-dev] [PATCH v3 1/5] mk: remove combined library and related options

2015-04-09 Thread Neil Horman
On Thu, Apr 09, 2015 at 12:06:47PM +0300, Avi Kivity wrote: > > > On 04/09/2015 11:33 AM, Gonzalez Monroy, Sergio wrote: > >On 08/04/2015 19:26, Stephen Hemminger wrote: > >>On Wed, 8 Apr 2015 16:07:21 +0100 > >>Sergio Gonzalez Monroy wrote: > >> > >>>Currently, the target/rules to build

[dpdk-dev] [snabb-devel] Re: memory barriers in virtq.lua?

2015-04-09 Thread Luke Gorrie
Howdy, On 8 April 2015 at 17:15, Xie, Huawei wrote: > luke: > 1. host read the flag. 2 guest toggles the flag 3.guest checks the used. > 4. host update used. > Is this your case? > Yep, that is exactly the case I mean. Cheers, -Luke