[dpdk-dev] [PATCH 3/3] ACL: remove subtree_id calculations at build stage

2015-06-02 Thread Thomas Monjalon
2015-05-22 18:48, Konstantin Ananyev: > As now subtree_id is not used acl_merge_trie() any more, > there is no point to calculate and maintain that information. > > Signed-off-by: Konstantin Ananyev There is an error with GCC 5.1: lib/librte_acl/acl_bld.c:1324:22: error: array subscript is abov

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-06-02 Thread Thomas Monjalon
I have the feeling we are not progressing in this discussion. Please bring new explanations or I'll give up. David Harton already acked it so maybe he could explain why it is useful. Comments below 2015-06-02 17:06, Wang, Liang-min: > >2015-06-02 15:47, Wang, Liang-min: > >> From: Thomas Monjalon

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-06-02 Thread Wang, Liang-min
>I have the feeling we are not progressing in this discussion. >Please bring new explanations or I'll give up. >David Harton already acked it so maybe he could explain why it is useful. > >Comments below > >2015-06-02 17:06, Wang, Liang-min: >> >2015-06-02 15:47, Wang, Liang-min: >> >> From: Thomas

[dpdk-dev] [PATCH] config:enlarge the default value of RTE_MAX_QUEUES_PER_PORT to 1024

2015-06-02 Thread Thomas Monjalon
2015-06-01 01:00, Zhang, Helin: > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jijiang Liu > > The default value of RTE_MAX_QUEUES_PER_PORT is 256, which is too small for > > some configurations for i40e. There will return an error when configured > > queue > > number is larger than 256

[dpdk-dev] [PATCH] librte_pmd_fm10k: Fix max_vfs issue in fm10k PMD

2015-06-02 Thread Thomas Monjalon
2015-06-02 10:28, Michael Qiu: > In DPDK, max_vfs means vf numbers created, not the max number vfs > the device supported. > > Signed-off-by: Michael Qiu > Acked-by Jing Chen Applied, thanks

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-06-02 Thread Thomas Monjalon
2015-06-02 15:47, Wang, Liang-min: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > >>I'm curious to understand how renaming rte_eth_dev_set_mtu() to > > >>rte_ethtool_net_change_mtu() will help anyone. > >> > >> As described, this interface is designed to provide API closely to

[dpdk-dev] [PATCH] ixgbe: fix checking for tx_free_thresh

2015-06-02 Thread Ananyev, Konstantin
> -Original Message- > From: Zoltan Kiss [mailto:zoltan.kiss at linaro.org] > Sent: Tuesday, June 02, 2015 4:08 PM > To: Ananyev, Konstantin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix checking for tx_free_thresh > > > > On 02/06/15 14:31, Ananyev, Konstantin wrote: >

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-06-02 Thread Wang, Liang-min
>2015-06-02 15:47, Wang, Liang-min: >> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] >> > >>I'm curious to understand how renaming rte_eth_dev_set_mtu() to >> > >>rte_ethtool_net_change_mtu() will help anyone. >> >> >> >> As described, this interface is designed to provide API close

[dpdk-dev] add support for HTM lock elision for x86

2015-06-02 Thread Roman Dementiev
Hello Jay, Tuesday, June 2, 2015, 3:21:24 PM, you wrote: > On Tue, Jun 2, 2015 at 8:11 AM, Roman Dementiev intel.com>wrote: > This series of patches adds methods that use hardware memory transactions > (HTM) > on fast-path for DPDK locks (a.k.a. lock elision). Here the methods are > implem

[dpdk-dev] [PATCH v4 4/4] lib_vhost: Remove unnecessary vring descriptor length updating

2015-06-02 Thread Ouyang Changchun
Remove these unnecessary vring descriptor length updating, vhost should not change them. virtio in front end should assign value to desc.len for both rx and tx. Signed-off-by: Changchun Ouyang --- lib/librte_vhost/vhost_rxtx.c | 18 +- 1 file changed, 1 insertion(+), 17 deletion

[dpdk-dev] [PATCH v4 3/4] lib_vhost: Extract function

2015-06-02 Thread Ouyang Changchun
Extract codes into 2 common functions: update_secure_len which is used to accumulate the buffer len in the vring descriptors. and fill_buf_vec which is used to fill struct buf_vec. Signed-off-by: Changchun Ouyang --- lib/librte_vhost/vhost_rxtx.c | 79 +--

[dpdk-dev] [PATCH v4 2/4] lib_vhost: Refine code style

2015-06-02 Thread Ouyang Changchun
Remove unnecessary new line. Signed-off-by: Changchun Ouyang --- lib/librte_vhost/vhost_rxtx.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/lib/librte_vhost/vhost_rxtx.c b/lib/librte_vhost/vhost_rxtx.c index dc555a8..0286a92 100644 --- a/lib/librte_vhost/vhost_rxt

[dpdk-dev] [PATCH v4 1/4] lib_vhost: Fix enqueue/dequeue can't handle chained vring descriptors

2015-06-02 Thread Ouyang Changchun
Vring enqueue need consider the 2 cases: 1. use separate descriptors to contain virtio header and actual data, e.g. the first descriptor is for virtio header, and then followed by descriptors for actual data. 2. virtio header and some data are put together in one descriptor, e.g. the first

[dpdk-dev] [PATCH v4 0/4] Fix vhost enqueue/dequeue issue

2015-06-02 Thread Ouyang Changchun
Fix enqueue/dequeue can't handle chained vring descriptors; Remove unnecessary vring descriptor length updating; Add support copying scattered mbuf to vring; Changchun Ouyang (4): lib_vhost: Fix enqueue/dequeue can't handle chained vring descriptors lib_vhost: Refine code style lib_vhost: Ex

[dpdk-dev] [PATCH] examples/load_balancer: fix build with gcc 5.1

2015-06-02 Thread Thomas Monjalon
GCC 5.1 detects more out-of-bounds accesses: error: array subscript is above array bounds [-Werror=array-bounds] Signed-off-by: Thomas Monjalon --- examples/load_balancer/config.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/examples/load_balancer

[dpdk-dev] [PATCH] ixgbe: fix checking for tx_free_thresh

2015-06-02 Thread Zoltan Kiss
On 02/06/15 14:31, Ananyev, Konstantin wrote: > Hi Zoltan, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zoltan Kiss >> Sent: Monday, June 01, 2015 5:16 PM >> To: dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix checking for tx_free_thresh

[dpdk-dev] [PATCH v2 4/4] doc: modify the command about mirror in testpmd guide

2015-06-02 Thread Jingjing Wu
This patch modifies the mirror command about type extension and adds link mirror command. Signed-off-by: Jingjing Wu --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/gui

[dpdk-dev] [PATCH v2 3/4] i40e: enable mirror functionality in i40e driver

2015-06-02 Thread Jingjing Wu
enable mirror functionality in i40e driver .mirror_rule_set .mirror_rule_reset Signed-off-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev.c | 334 + drivers/net/i40e/i40e_ethdev.h | 23 +++ 2 files changed, 357 insertions(+) diff --git a/drivers/net/i40

[dpdk-dev] [PATCH v2 2/4] ethdev: redefine the mirror type

2015-06-02 Thread Jingjing Wu
This path renames the mirror type in rte_eth_mirror_conf and macros, and rework the mirror set in ixgbe dirvers by using new definition. It also fixes some coding style. Signed-off-by: Jingjing Wu --- app/test-pmd/cmdline.c | 42 +++ drivers/net/ixgbe/ixgbe_ethd

[dpdk-dev] [PATCH v2 1/4] ethdev: rename rte_eth_vmdq_mirror_conf

2015-06-02 Thread Jingjing Wu
rename rte_eth_vmdq_mirror_conf to rte_eth_mirror_conf and move the maximum rule id check from ethdev level to driver Signed-off-by: Jingjing Wu --- app/test-pmd/cmdline.c | 22 +++--- drivers/net/ixgbe/ixgbe_ethdev.c | 11 +++ drivers/net/ixgbe/ixgbe_ethdev.h |

[dpdk-dev] [PATCH v2 0/4] enable mirror functionality in i40e driver

2015-06-02 Thread Jingjing Wu
This patch set enables mirror functionality in i40e driver, and redefines structure and macros used to configure mirror. v2 changes: - correct comments style - add doc change Jingjing Wu (4): ethdev: rename rte_eth_vmdq_mirror_conf ethdev: redefine the mirror type i40e: enable mirror fun

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-06-02 Thread Wang, Liang-min
-Original Message- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Tuesday, June 02, 2015 10:33 AM To: Wang, Liang-min Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs >Wang, hope it's clear that any new devel

[dpdk-dev] [PATCH 3/3] test scaling of HTM lock elision protecting rte_hash

2015-06-02 Thread Roman Dementiev
This patch adds a new auto-test for testing the scaling of concurrent inserts into rte_hash when protected by the normal spinlock vs. the spinlock with HTM lock elision. The test also benchmarks single-threaded access without any locks. Signed-off-by: Roman Dementiev --- app/test/Makefile

[dpdk-dev] [PATCH 2/3] rwlock: add support for HTM lock elision for x86

2015-06-02 Thread Roman Dementiev
This patch adds methods that use hardware memory transactions (HTM) on fast-path for rwlock (a.k.a. lock elision). Here the methods are implemented for x86 using Restricted Transactional Memory instructions (Intel(r) Transactional Synchronization Extensions). The implementation fall-backs to the no

[dpdk-dev] [PATCH 1/3] spinlock: add support for HTM lock elision for x86

2015-06-02 Thread Roman Dementiev
This patch adds methods that use hardware memory transactions (HTM) on fast-path for spinlocks (a.k.a. lock elision). Here the methods are implemented for x86 using Restricted Transactional Memory instructions (Intel(r) Transactional Synchronization Extensions). The implementation fall-backs to the

[dpdk-dev] add support for HTM lock elision for x86

2015-06-02 Thread Roman Dementiev
This series of patches adds methods that use hardware memory transactions (HTM) on fast-path for DPDK locks (a.k.a. lock elision). Here the methods are implemented for x86 using Restricted Transactional Memory instructions (Intel(r) Transactional Synchronization Extensions). The implementation

[dpdk-dev] [PATCH 1/2] ethdev: add api to set default mac address

2015-06-02 Thread Wang, Liang-min
>On Tue, 02 Jun 2015 14:23:22 +0200 >Thomas Monjalon wrote: >> 2015-06-02 10:52, Ananyev, Konstantin: > >> From: Wang, Liang-min > > >> int > > >>+rte_eth_dev_default_mac_addr_set(uint8_t port_id, struct > > >> +ether_addr *addr) { > > >> +struct rte_eth_dev *dev; > > >> + > > >> +

[dpdk-dev] [PATCH] doc: add coding standards documentation

2015-06-02 Thread Thomas Monjalon
2015-05-13 16:30, Bruce Richardson: > Add coding standards document to guides directory. This document > codifies the current DPDK C coding conventions, to make it easier for > contributors to see the format their code should be in. > > Signed-off-by: Bruce Richardson > Signed-off-by: Siobhan But

[dpdk-dev] KNI app error: Could not setup up RX queue for port0 (-12)

2015-06-02 Thread Navneet Rao
./kni -c f0 -n 4 -- -p 0x3 -P --config="(0,4,6),(1,5,7)" ... ... EAL: PCI device :b0:00.0 on NUMA socket 1 EAL: probe driver: 8086:105e rte_em_pmd EAL: Not managed by a supported kernel driver, skipped EAL: PCI device :b0:00.1 on NUMA socket 1 EAL: probe driver: 8086:105e r

[dpdk-dev] [PATCH v10 13/13] abi: fix v2.1 abi broken issue

2015-06-02 Thread Cunming Liang
RTE_EAL_RX_INTR will be removed from v2.2. It's only used to avoid ABI(unannounced) broken in v2.1. The usrs should make sure understand the impact before turning on the feature. There are two abi changes required in this interrupt patch set. They're 1) struct rte_intr_handle; 2) struct rte_intr_c

[dpdk-dev] [PATCH v10 12/13] l3fwd-power: enable one-shot rx interrupt and polling/interrupt mode switch

2015-06-02 Thread Cunming Liang
Demonstrate how to handle per rx queue interrupt in a NAPI-like implementation in usersapce. PDK polling thread mainly works in polling mode and switch to interrupt mode only if there is no any packet received in recent polls. Usersapce interrupt notification generally takes a lot more cycles than

[dpdk-dev] [PATCH v10 11/13] igb: enable rx queue interrupts for PF

2015-06-02 Thread Cunming Liang
The patch does below for igb PF: - Setup NIC to generate MSI-X interrupts - Set the IVAR register to map interrupt causes to vectors - Implement interrupt enable/disable functions Signed-off-by: Danny Zhou Signed-off-by: Cunming Liang --- v9 changes - move queue-vec mapping init from dev_config

[dpdk-dev] [PATCH v10 10/13] ixgbe: enable rx queue interrupts for both PF and VF

2015-06-02 Thread Cunming Liang
The patch does below things for ixgbe PF and VF: - Setup NIC to generate MSI-X interrupts - Set the IVAR register to map interrupt causes to vectors - Implement interrupt enable/disable functions Signed-off-by: Danny Zhou Signed-off-by: Yong Liu Signed-off-by: Cunming Liang --- v10 changes - r

[dpdk-dev] [PATCH v10 09/13] ethdev: add rx intr enable, disable and ctl functions

2015-06-02 Thread Cunming Liang
The patch adds two dev_ops functions to enable and disable rx queue interrupts. In addtion, it adds rte_eth_dev_rx_intr_ctl/rx_intr_q to support per port or per queue rx intr event set. Signed-off-by: Danny Zhou Signed-off-by: Cunming Liang --- v9 changes - remove unnecessary check after rte_e

[dpdk-dev] [PATCH v10 08/13] eal/bsd: dummy for new intr definition

2015-06-02 Thread Cunming Liang
To make bsd compiling happy with new intr changes. Signed-off-by: Cunming Liang --- v8 changes - add stub for new function v7 changes - remove stub 'linux only' function from source file lib/librte_eal/bsdapp/eal/eal_interrupts.c | 19 ++ .../bsdapp/eal/include/exec-env/rte_inter

[dpdk-dev] [PATCH v10 07/13] eal/linux: fix lsc read error in uio_pci_generic

2015-06-02 Thread Cunming Liang
The new UIO generic handle type was introduced by patch. http://dpdk.org/ml/archives/dev/2015-April/017008.html When using uio_pci_generic and turning on lsc interrupt, it complains fd read error. The root cause is the 'count' size of read is not correct. Reported-by: Yong Liu Signed-off-by: Cun

[dpdk-dev] [PATCH v10 06/13] eal/linux: standalone intr event fd create support

2015-06-02 Thread Cunming Liang
The patch exposes intr event fd create and release for PMD. The device driver can assign the number of event associated with interrupt vector. It also provides misc funtions to check 1) allows other slowpath intr(e.g. lsc); 2) intr event on fastpath is enabled or not. Signed-off-by: Cunming Liang

[dpdk-dev] [PATCH v10 05/13] eal/linux: add interrupt vectors handling on VFIO

2015-06-02 Thread Cunming Liang
This patch does below: - Create VFIO eventfds for each interrupt vector (move to next) - Assign per interrupt vector's eventfd to VFIO by ioctl Signed-off-by: Danny Zhou Signed-off-by: Cunming Liang --- v8 changes - move eventfd creation out of the setup_interrupts to a standalone function v

[dpdk-dev] [PATCH v10 04/13] eal/linux: fix comments typo on vfio msi

2015-06-02 Thread Cunming Liang
Signed-off-by: Cunming Liang --- lib/librte_eal/linuxapp/eal/eal_interrupts.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_interrupts.c b/lib/librte_eal/linuxapp/eal/eal_interrupts.c index 302ceda..c970c66 100644 --- a/lib/librte_eal/li

[dpdk-dev] [PATCH v10 03/13] eal/linux: add API to set rx interrupt event monitor

2015-06-02 Thread Cunming Liang
The patch adds 'rte_intr_rx_ctl' to add or delete interrupt vector events monitor on specified epoll instance. Signed-off-by: Cunming Liang --- v10 changes: - add RTE_INTR_HANDLE_UIO_INTX for uio_pci_generic v8 changes - fix EWOULDBLOCK and EINTR processing - add event status check v7 chan

[dpdk-dev] [PATCH v10 02/13] eal/linux: add rte_epoll_wait/ctl support

2015-06-02 Thread Cunming Liang
The patch adds 'rte_epoll_wait' and 'rte_epoll_ctl' for async event wakeup. It defines 'struct rte_epoll_event' as the event param. The 'op' uses the same enum as epoll_wait/ctl does. The epoll event support to carry a raw user data and to register a callback which is exectuted during wakeup. Sig

[dpdk-dev] [PATCH v10 01/13] eal/linux: add interrupt vectors support in intr_handle

2015-06-02 Thread Cunming Liang
The patch adds interrupt vectors support in rte_intr_handle. 'vec_en' is set when interrupt vectors are detected and associated event fds are set. Those event fds are stored in efds[]. 'intr_vec' is reserved for device driver to initialize the vector mapping table. When the event fds add to a spec

[dpdk-dev] [PATCH v10 00/13] Interrupt mode PMD

2015-06-02 Thread Cunming Liang
v10 changes - code rework to return actual error code - bug fix for lsc when using uio_pci_generic v9 changes - code rework to fix open comment - bug fix for igb lsc when both lsc and rxq are enabled in vfio-msix - new patch to turn off the feature by defalut so as to avoid v2.1 abi broken v

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-06-02 Thread Thomas Monjalon
2015-05-29 15:26, Liang-Min Larry Wang: > adding a new library based upon ethdev APIs to provide API's that bear > the same functionality as ethtool_ops (linux/ethtool.h) and net_device_ops > (linux/netdevice.h). > > Signed-off-by: Liang-Min Larry Wang > --- > MAINTAINERS

[dpdk-dev] [PATCH 1/2] ethdev: add api to set default mac address

2015-06-02 Thread Thomas Monjalon
2015-06-02 10:52, Ananyev, Konstantin: > From: Wang, Liang-min > > int > > +rte_eth_dev_default_mac_addr_set(uint8_t port_id, struct ether_addr *addr) > > +{ > > + struct rte_eth_dev *dev; > > + > > + if (!rte_eth_dev_is_valid_port(port_id)) { > > + PMD_DEBUG_TRACE("Invalid port_id=%

[dpdk-dev] [PATCH v10 00/13] Interrupt mode PMD

2015-06-02 Thread Liu, Yong
Tested-by: Yong Liu - Tested Commit: 7c4c66bf666b8059ed0ad2f2478ef349b3272f51 - OS: Fedora20 3.15.5 - GCC: gcc version 4.8.3 20140911 - CPU: Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz - NIC: Intel Corporation 82599ES 10-Gigabit SFI/SFP+ [8086:10fb] - NIC: Intel Corporation I350 Gigabit Network Con

[dpdk-dev] add support for HTM lock elision for x86

2015-06-02 Thread Dementiev, Roman
Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (

[dpdk-dev] [PATCH] ixgbe: fix checking for tx_free_thresh

2015-06-02 Thread Ananyev, Konstantin
Hi Zoltan, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zoltan Kiss > Sent: Monday, June 01, 2015 5:16 PM > To: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix checking for tx_free_thresh > > Hi, > > Anyone would like to review this patch? V

[dpdk-dev] [PATCH v6 01/18] mbuf: redefine packet_type in rte_mbuf

2015-06-02 Thread O'Driscoll, Tim
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier MATZ > Sent: Monday, June 1, 2015 9:15 AM > To: Zhang, Helin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 01/18] mbuf: redefine packet_type in > rte_mbuf > > Hi Helin, > > +CC Neil > > On 06/0

[dpdk-dev] add support for HTM lock elision for x86

2015-06-02 Thread Dementiev, Roman
Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-06-02 Thread Wang, Liang-min
>2015-05-29 15:26, Liang-Min Larry Wang: >> adding a new library based upon ethdev APIs to provide API's that bear >> the same functionality as ethtool_ops (linux/ethtool.h) and >> net_device_ops (linux/netdevice.h). >> >> Signed-off-by: Liang-Min Larry Wang >> --- >> MAINTAINERS

[dpdk-dev] [PATCH 1/2] ethdev: add api to set default mac address

2015-06-02 Thread Ananyev, Konstantin
> -Original Message- > From: Wang, Liang-min > Sent: Tuesday, June 02, 2015 1:24 PM > To: Ananyev, Konstantin; dev at dpdk.org > Cc: Richardson, Bruce; dharton at cisco.com; agh at cisco.com > Subject: RE: [PATCH 1/2] ethdev: add api to set default mac address > > > >> -Original Mes

[dpdk-dev] [PATCH 1/2] ethdev: add api to set default mac address

2015-06-02 Thread Wang, Liang-min
>> -Original Message- >> From: Wang, Liang-min >> Sent: Friday, May 29, 2015 8:27 PM >> To: dev at dpdk.org >> Cc: Richardson, Bruce; Ananyev, Konstantin; dharton at cisco.com; > >agh at cisco.com; Wang, Liang-min >> Subject: [PATCH 1/2] ethdev: add api to set default mac address > > >> a

[dpdk-dev] [RFC PATCH V3] ixgbe: changes to support PCI Port Hotplug

2015-06-02 Thread Bernard Iremonger
This patch depends on the Port Hotplug Framework. It implements the eth_dev_uninit functions for rte_ixgbe_pmd and rte_ixgbevf_pmd. Changes in V3: Rebased to use drivers/net/ixgbe directory. Changes in V2: Added call to dev_close() in dev_uninit() functions. Removed input parameter checks from de

[dpdk-dev] [PATCH v2 6/6] examples/ipv4_multicast: support double vlan stripping and insertion

2015-06-02 Thread Helin Zhang
The outer vlan should be copied from source packet buffer to support double vlan stripping and insertion, as double vlan can be stripped or inserted by some of NIC hardware. Signed-off-by: Helin Zhang --- examples/ipv4_multicast/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples

[dpdk-dev] [PATCH v2 5/6] app/testpmd: add test cases for qinq stripping and insertion

2015-06-02 Thread Helin Zhang
If double vlan is detected, its stripped flag and vlan tags can be printed on rxonly mode. Test command of 'tx_vlan set' is expanded to set both single and double vlan tags on TX side for each packets to be sent out. Signed-off-by: Helin Zhang --- app/test-pmd/cmdline.c | 78

[dpdk-dev] [PATCH v2 4/6] i40evf: add supported offload capability flags

2015-06-02 Thread Helin Zhang
Add checksum offload capability flags which have already been supported for a long time. Signed-off-by: Helin Zhang --- drivers/net/i40e/i40e_ethdev_vf.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_eth

[dpdk-dev] [PATCH v2 3/6] i40e: support double vlan stripping and insertion

2015-06-02 Thread Helin Zhang
It configures specific registers to enable double vlan stripping on RX side and insertion on TX side. The RX descriptors will be parsed, the vlan tags and flags will be saved to corresponding mbuf fields if vlan tag is detected. The TX descriptors will be configured according to the configurations

[dpdk-dev] [PATCH v2 2/6] mbuf: use the reserved 16 bits for double vlan

2015-06-02 Thread Helin Zhang
Use the reserved 16 bits in rte_mbuf structure for the outer vlan, also add QinQ offloading flags for both RX and TX sides. Signed-off-by: Helin Zhang --- lib/librte_mbuf/rte_mbuf.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) v2 changes: * Fixed a typo. diff --git a/lib/lib

[dpdk-dev] [PATCH v2 1/6] ixgbe: remove a discarded source line

2015-06-02 Thread Helin Zhang
Little endian to CPU order conversion had been added for reading vlan tag from RX descriptor, while its original source line was forgotten to delete. That's a discarded source line and should be deleted. Fixes: 23fcffe8ffac ("ixgbe: fix id and hash with flow director") Signed-off-by: Helin Zhang

[dpdk-dev] [PATCH v2 0/6] support i40e QinQ stripping and insertion

2015-06-02 Thread Helin Zhang
As i40e hardware can be reconfigured to support QinQ stripping and insertion, this patch set is to enable that together with using the reserved 16 bits in 'struct rte_mbuf' for the second vlan tag. Corresponding command is added in testpmd for testing. Note that no need to rework vPMD, as nothings

[dpdk-dev] [PATCH 3/3] fm10k: update VLAN offload features

2015-06-02 Thread Shaopeng He
Fm10k PF/VF does not support QinQ; VLAN strip and filter are always on for PF/VF ports. Signed-off-by: Shaopeng He --- drivers/net/fm10k/fm10k_ethdev.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c

[dpdk-dev] [PATCH 2/3] fm10k: add MAC filter

2015-06-02 Thread Shaopeng He
MAC filter function was newly added, each PF and VF can have up to 64 MAC addresses. VF filter needs support from PF host, which is not available now. Signed-off-by: Shaopeng He --- drivers/net/fm10k/fm10k.h| 3 +- drivers/net/fm10k/fm10k_ethdev.c | 90 ++

[dpdk-dev] [PATCH 1/3] fm10k: update VLAN filter

2015-06-02 Thread Shaopeng He
VLAN filter was updated to add/delete one static entry in MAC table for each combination of VLAN and MAC address. More sanity checks were added. Signed-off-by: Shaopeng He --- drivers/net/fm10k/fm10k.h| 23 + drivers/net/fm10k/fm10k_ethdev.c | 55 +

[dpdk-dev] [PATCH 0/3] fm10k: update MAC/VLAN filter and VLAN offload features

2015-06-02 Thread Shaopeng He
MAC filter was newly added, VLAN filter was updated to add/delete one static entry in MAC table for each combination of VLAN and MAC address. Fm10k PF/VF does not support QinQ; VLAN strip and filter are always on. Shaopeng He (3): fm10k: update VLAN filter fm10k: add MAC filter fm10k: updat

[dpdk-dev] [PATCH 1/2] ethdev: add api to set default mac address

2015-06-02 Thread Ananyev, Konstantin
> -Original Message- > From: Wang, Liang-min > Sent: Friday, May 29, 2015 8:27 PM > To: dev at dpdk.org > Cc: Richardson, Bruce; Ananyev, Konstantin; dharton at cisco.com; agh at > cisco.com; Wang, Liang-min > Subject: [PATCH 1/2] ethdev: add api to set default mac address > > add a new

[dpdk-dev] no packets with i40e when setting up more than 1 rx queue

2015-06-02 Thread Nikita Kozlov
Hello, To introduce myself, I am working on a slightly enhanced version of l3fwd which support some more features like dynamically adding new routes in a lpm table, adding some acls, rate-limiting per dest, a command line through unixsock etc. We hope to open source it as soon as it is shiny enoug

[dpdk-dev] [PATCH] librte_pmd_fm10k: Fix max_vfs issue in fm10k PMD

2015-06-02 Thread Michael Qiu
In DPDK, max_vfs means vf numbers created, not the max number vfs the device supported. Signed-off-by: Michael Qiu Acked-by Jing Chen --- lib/librte_pmd_fm10k/fm10k_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_pmd_fm10k/fm10k_ethdev.c b/lib/librte_pmd

[dpdk-dev] [PATCH v9 12/12] abi: fix v2.1 abi broken issue

2015-06-02 Thread Liang, Cunming
Hi Stephen, On 6/1/2015 9:27 PM, Stephen Hemminger wrote: > On Mon, 1 Jun 2015 16:48:01 +0800 > "Liang, Cunming" wrote: > >> Hi Stephen, >> >> On 5/29/2015 11:27 PM, Stephen Hemminger wrote: >>> On Fri, 29 May 2015 16:45:25 +0800 >>> Cunming Liang wrote: >>> +#ifdef RTE_EAL_RX_INTR

[dpdk-dev] [PATCH] vhost: provide vhost API to unregister vhost unix domain socket

2015-06-02 Thread Huawei Xie
rte_vhost_driver_unregister will remove the listenfd from event list, and then close it. Signed-off-by: Huawei Xie Signed-off-by: Peng Sun --- lib/librte_vhost/rte_virtio_net.h| 3 ++ lib/librte_vhost/vhost_cuse/vhost-net-cdev.c | 9 lib/librte_vhost/vhost_user/vhost-net-use

[dpdk-dev] [RFC PATCH] librte_pmd_fm10k: Add hotplug support for fm10k

2015-06-02 Thread Qiu, Michael
On 6/2/2015 4:26 PM, Iremonger, Bernard wrote: > > -Original Message- > From: Qiu, Michael > Sent: Sunday, May 31, 2015 3:37 PM > To: dev at dpdk.org > Cc: Chen, Jing D; Iremonger, Bernard; He, Shaopeng; Qiu, Michael > Subject: [RFC PATCH] librte_pmd_fm10k: Add hotplug support for fm10k >

[dpdk-dev] [PATCH v10 06/13] eal/linux: standalone intr event fd create support

2015-06-02 Thread Stephen Hemminger
Minor spelling and stuff. I am a terrible speller... > The patch exposes intr event fd create and release for PMD. > The device driver can assign the number of event associated with interrupt > vector. > It also provides misc funtions to check 1) allows other slowpath intr(e.g. > lsc); 'funtion

[dpdk-dev] [PATCH v10 03/13] eal/linux: add API to set rx interrupt event monitor

2015-06-02 Thread Stephen Hemminger
On Tue, 2 Jun 2015 14:53:16 +0800 Cunming Liang wrote: > + if (!rc) > + RTE_LOG(DEBUG, EAL, "eventfd %d associated with vec %d" > + " is added on epfd %d\n", rev->fd, vec, epfd); Awkward line split here. Better to keep string on one li

[dpdk-dev] [PATCH v10 03/13] eal/linux: add API to set rx interrupt event monitor

2015-06-02 Thread Stephen Hemminger
On Tue, 2 Jun 2015 14:53:16 +0800 Cunming Liang wrote: > + bytes_read = read(fd, &buf, bytes_read); > + if (bytes_read < 0) { > + if (errno == EINTR || errno == EWOULDBLOCK || > + errno == EAGAIN) > +

[dpdk-dev] [PATCH v2] kni: Add set_rx_mode callback to handle multicast groups

2015-06-02 Thread Simon Kagstrom
We did some (very basic) tests with IGMP, which involves adding multicast addresses to ETH interfaces. This is done via the ip tool, an example can be found on e.g., http://superuser.com/questions/324824/linux-built-in-or-open-source-program-to-join-multicast-group and this will fail on KNI in

[dpdk-dev] [PATCH v10 02/13] eal/linux: add rte_epoll_wait/ctl support

2015-06-02 Thread Stephen Hemminger
On Tue, 2 Jun 2015 14:53:15 +0800 Cunming Liang wrote: > The patch adds 'rte_epoll_wait' and 'rte_epoll_ctl' for async event wakeup. > It defines 'struct rte_epoll_event' as the event param. > The 'op' uses the same enum as epoll_wait/ctl does. > The epoll event support to carry a raw user data

[dpdk-dev] [RFC PATCH] librte_pmd_fm10k: Add hotplug support for fm10k

2015-06-02 Thread Iremonger, Bernard
-Original Message- From: Qiu, Michael Sent: Sunday, May 31, 2015 3:37 PM To: dev at dpdk.org Cc: Chen, Jing D; Iremonger, Bernard; He, Shaopeng; Qiu, Michael Subject: [RFC PATCH] librte_pmd_fm10k: Add hotplug support for fm10k Add hotplug support for fm10k Signed-off-by: Michael Qiu -

[dpdk-dev] add support for HTM lock elision for x86

2015-06-02 Thread Jay Rolette
On Tue, Jun 2, 2015 at 8:11 AM, Roman Dementiev wrote: > > This series of patches adds methods that use hardware memory transactions > (HTM) > on fast-path for DPDK locks (a.k.a. lock elision). Here the methods are > implemented > for x86 using Restricted Transactional Memory instructions (Intel(

[dpdk-dev] [PATCH v3 1/4] lib_vhost: Fix enqueue/dequeue can't handle chained vring descriptors

2015-06-02 Thread Ouyang, Changchun
> -Original Message- > From: Xie, Huawei > Sent: Tuesday, June 2, 2015 3:51 PM > To: Ouyang, Changchun; dev at dpdk.org > Cc: Cao, Waterman > Subject: Re: [PATCH v3 1/4] lib_vhost: Fix enqueue/dequeue can't handle > chained vring descriptors > > On 6/1/2015 4:26 PM, Ouyang, Changchun wro

[dpdk-dev] [PATCH 1/2] ethdev: add api to set default mac address

2015-06-02 Thread Stephen Hemminger
On Tue, 02 Jun 2015 14:23:22 +0200 Thomas Monjalon wrote: > 2015-06-02 10:52, Ananyev, Konstantin: > > From: Wang, Liang-min > > > int > > > +rte_eth_dev_default_mac_addr_set(uint8_t port_id, struct ether_addr > > > *addr) > > > +{ > > > + struct rte_eth_dev *dev; > > > + > > > + if (!rte_eth

[dpdk-dev] [PATCH v3 1/4] lib_vhost: Fix enqueue/dequeue can't handle chained vring descriptors

2015-06-02 Thread Xie, Huawei
On 6/1/2015 4:26 PM, Ouyang, Changchun wrote: > Vring enqueue need consider the 2 cases: > 1. use separate descriptors to contain virtio header and actual data, e.g. > the first descriptor > is for virtio header, and then followed by descriptors for actual data. > 2. virtio header and some d

[PATCH] vmxnet3: support setting primary MAC address

2015-06-02 Thread Stephen Hemminger
This allows setting primary MAC address on VMXNET3. Signed-off-by: Stephen Hemminger --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 45 +--- 1 file changed, 31 insertions(+), 14 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmx

[dpdk-dev] [PATCH / RFC] kni: Add set_rx_mode callback to handle multicast groups

2015-06-02 Thread Simon Kågström
On 2015-06-02 05:44, Zhang, Helin wrote: >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Simon Kagstrom >> Sent: Thursday, May 7, 2015 9:18 PM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH / RFC] kni: Add set_rx_mode callback to handle >> multicast gr

[dpdk-dev] [PATCH v2 0/6] support i40e QinQ stripping and insertion

2015-06-02 Thread Liu, Jijiang
Acked-by: Jijiang Liu > -Original Message- > From: Zhang, Helin > Sent: Tuesday, June 2, 2015 11:16 AM > To: dev at dpdk.org > Cc: Cao, Min; Liu, Jijiang; Wu, Jingjing; Ananyev, Konstantin; Richardson, > Bruce; > olivier.matz at 6wind.com; Zhang, Helin > Subject: [PATCH v2 0/6] support

[dpdk-dev] [PATCH 0/6] extend flow director to support L2_paylod type and VF filtering in i40e driver

2015-06-02 Thread Zhang, Helin
Acked-by: Helin Zhang > -Original Message- > From: Wu, Jingjing > Sent: Monday, May 11, 2015 11:46 AM > To: dev at dpdk.org > Cc: Wu, Jingjing; Zhang, Helin; Cao, Min; Liu, Jijiang > Subject: [PATCH 0/6] extend flow director to support L2_paylod type and VF > filtering in i40e driver > >

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-06-02 Thread Thomas Monjalon
Wang, hope it's clear that any new development is welcomed. One step before integration is to clearly explain why your code is needed. That's why a nack vote may help to discuss and decide. Comments below 2015-06-02 13:15, Wang, Liang-min: > >2015-05-29 15:26, Liang-Min Larry Wang: > >> adding a

[dpdk-dev] [PATCH v2] kni: Add set_rx_mode callback to handle multicast groups

2015-06-02 Thread Zhang, Helin
> -Original Message- > From: Simon Kagstrom [mailto:simon.kagstrom at netinsight.net] > Sent: Tuesday, June 2, 2015 3:22 PM > To: dev at dpdk.org; Zhang, Helin; stephen at networkplumber.org > Subject: [PATCH v2] kni: Add set_rx_mode callback to handle multicast groups > > We did some (v

[dpdk-dev] [PATCH / RFC] kni: Add set_rx_mode callback to handle multicast groups

2015-06-02 Thread Zhang, Helin
> -Original Message- > From: Simon K?gstr?m [mailto:simon.kagstrom at netinsight.net] > Sent: Tuesday, June 2, 2015 1:44 PM > To: Zhang, Helin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH / RFC] kni: Add set_rx_mode callback to handle > multicast groups > > On 2015-06-02 05:44, Zhan

[dpdk-dev] [PATCH v9 01/12] eal/linux: add interrupt vectors support in intr_handle

2015-06-02 Thread Liu, Yong
Tested-by: Yong Liu - Tested Commit: 7c4c66bf666b8059ed0ad2f2478ef349b3272f51 - OS: Fedora20 3.15.5 - GCC: gcc version 4.8.3 20140911 - CPU: Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz - NIC: Intel Corporation 82599ES 10-Gigabit SFI/SFP+ [8086:10fb] - NIC: Intel Corporation I350 Gigabit Network Con

[dpdk-dev] [PATCH / RFC] kni: Add set_rx_mode callback to handle multicast groups

2015-06-02 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Simon Kagstrom > Sent: Thursday, May 7, 2015 9:18 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH / RFC] kni: Add set_rx_mode callback to handle > multicast groups > > This is needed to add / remove interf

[dpdk-dev] [PATCH 3/6] lib_vhost: Set memory layout for multiple queues mode

2015-06-02 Thread Xie, Huawei
Is there any possibility that different queue has different memory translation? How about we use the memory region of the first queue discovered? On 5/21/2015 3:50 PM, Ouyang Changchun wrote: > QEMU sends separate commands orderly to set the memory layout for each queue > in one virtio device, ac

[dpdk-dev] [PATCH] fm10k: support XEN domain0

2015-06-02 Thread He, Shaopeng
Hi Stephen, Do you see any problem of preventing your patch of "xen: allow choosing dom0 support at runtime" into upcoming 2.1 release? It will be better that fm10k's XEN support can base on your modifications, and I will rework this fm10k patch. But in case your patch cannot make it into 2.1,

[dpdk-dev] [PATCH 1/3] ethdev: rename rte_eth_vmdq_mirror_conf

2015-06-02 Thread Liu, Jijiang
> -Original Message- > From: Wu, Jingjing > Sent: Wednesday, May 13, 2015 4:47 PM > To: dev at dpdk.org > Cc: Wu, Jingjing; Jiajia, SunX; Zhang, Helin; Liu, Jijiang > Subject: [PATCH 1/3] ethdev: rename rte_eth_vmdq_mirror_conf > > This patch renames rte_eth_vmdq_mirror_conf to rte_eth_m

[dpdk-dev] [PATCH 3/5] i40e: support double vlan stripping and insertion

2015-06-02 Thread Zhang, Helin
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Monday, June 1, 2015 4:51 PM > To: Zhang, Helin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 3/5] i40e: support double vlan stripping and > insertion > > Hi Helin, > > On 05/26/2015 10:36 AM, Helin

[dpdk-dev] [PATCH 2/5] mbuf: use the reserved 16 bits for double vlan

2015-06-02 Thread Zhang, Helin
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Monday, June 1, 2015 4:50 PM > To: Zhang, Helin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/5] mbuf: use the reserved 16 bits for double > vlan > > Hi Helin, > > On 05/26/2015 10:36 AM, Helin Zh

[dpdk-dev] [PATCH] librte_pmd_fm10k: Fix max_vfs issue in fm10k PMD

2015-06-02 Thread Qiu, Michael
On 6/1/2015 9:47 PM, Thomas Monjalon wrote: > 2015-05-12 05:30, Qiu, Michael: >> Hi, thomas >> >> What about this patch? > It seems this patch was not *really* sent to dev at dpdk.org. > Please re-send, keeping the Acked-by line. OK, I will resend it. Thanks, Michael >> On 4/16/2015 4:09 PM, Chen

[dpdk-dev] [PATCH 1/5] ixgbe: remove a discarded source line

2015-06-02 Thread Zhang, Helin
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Monday, June 1, 2015 4:50 PM > To: Zhang, Helin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/5] ixgbe: remove a discarded source line > > Hi Helin, > > On 05/26/2015 10:36 AM, Helin Zhang wrote: