[dpdk-dev] [PATCH v2 0/3] mempool: clean-up

2015-06-19 Thread Thomas Monjalon
2015-06-19 18:16, Olivier Matz: > These 3 patches try to make mempool code easier to read, they > have no functional impact. > > Changes in v2: > - fix compilation between patch 1 and 2 > > Olivier Matz (3): > mempool: introduce objhdr structure for object headers > mempool: introduce objtlr

[dpdk-dev] [PATCH] Add unit test for thash library

2015-06-19 Thread Vladimir Medvedkin
2015-06-19 19:14 GMT+03:00 Richardson, Bruce : > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vladimir Medvedkin > > Sent: Friday, June 19, 2015 3:56 PM > > To: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH] Add unit test for thash library > > > > A

[dpdk-dev] [PATCH v4] Add toeplitz hash algorithm used by RSS

2015-06-19 Thread Vladimir Medvedkin
Hi Bruce, 2015-06-19 18:59 GMT+03:00 Richardson, Bruce : > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vladimir Medvedkin > > Sent: Friday, June 19, 2015 3:56 PM > > To: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH v4] Add toeplitz hash algorithm

[dpdk-dev] [dpdk-announce] important design choices - statistics - ABI

2015-06-19 Thread Thomas Monjalon
2015-06-19 12:13, Thomas F Herbert: > > On 6/19/15 9:16 AM, Thomas Monjalon wrote: > > 2015-06-19 09:02, Neil Horman: > >> On Fri, Jun 19, 2015 at 02:32:33PM +0200, Thomas Monjalon wrote: > >>> 2015-06-19 06:26, Neil Horman: > On Thu, Jun 18, 2015 at 04:55:45PM +, O'Driscoll, Tim wrote: >

[dpdk-dev] [PATCH v3 9/9] doc: update malloc documentation

2015-06-19 Thread Sergio Gonzalez Monroy
Update malloc documentation to reflect new implementation details. Signed-off-by: Sergio Gonzalez Monroy --- doc/guides/prog_guide/env_abstraction_layer.rst | 220 +- doc/guides/prog_guide/img/malloc_heap.png | Bin 81329 -> 80952 bytes doc/guides/prog_guide/index.rst

[dpdk-dev] [PATCH v3 8/9] doc: announce ABI change of librte_malloc

2015-06-19 Thread Sergio Gonzalez Monroy
Announce the creation of dummy malloc library for 2.1 and removal of such library, now integrated in librte_eal, for 2.2 release. Signed-off-by: Sergio Gonzalez Monroy --- doc/guides/rel_notes/abi.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/rel_notes/abi.rst b/doc/guides/r

[dpdk-dev] [PATCH v3 7/9] app/test: update unit test with rte_memzone_free

2015-06-19 Thread Sergio Gonzalez Monroy
Update memzone unit test for the new rte_memzone_free API. Signed-off-by: Sergio Gonzalez Monroy --- app/test/test_memzone.c | 53 + 1 file changed, 53 insertions(+) diff --git a/app/test/test_memzone.c b/app/test/test_memzone.c index 6934eee..501

[dpdk-dev] [PATCH v3 6/9] eal: new rte_memzone_free

2015-06-19 Thread Sergio Gonzalez Monroy
Implement rte_memzone_free which, as its name implies, would free a memzone. Currently memzone are tracked in an array and cannot be free. To be able to reuse the same array to track memzones, we have to change how we keep track of reserved memzones. With this patch, any memzone with addr NULL is

[dpdk-dev] [PATCH v3 5/9] eal: remove free_memseg and references to it

2015-06-19 Thread Sergio Gonzalez Monroy
Remove free_memseg field from internal mem config structure as it is not used anymore. Also remove code in ivshmem that was setting up free_memseg on init. Signed-off-by: Sergio Gonzalez Monroy --- lib/librte_eal/common/include/rte_eal_memconfig.h | 3 --- lib/librte_eal/linuxapp/eal/eal_ivshmem

[dpdk-dev] [PATCH v3 4/9] config: remove CONFIG_RTE_MALLOC_MEMZONE_SIZE

2015-06-19 Thread Sergio Gonzalez Monroy
During initializaio malloc sets all available memory as part of the heaps. CONFIG_RTE_MALLOC_MEMZONE_SIZE was used to specify the default memory block size to expand the heap. The option is not used/relevant anymore, so we remove it. Signed-off-by: Sergio Gonzalez Monroy --- config/common_bsdap

[dpdk-dev] [PATCH v3 3/9] app/test: update malloc/memzone unit tests

2015-06-19 Thread Sergio Gonzalez Monroy
Some unit test are not relevant anymore. It is the case of those malloc UTs that checked corner cases when allocating MALLOC_MEMZONE_SIZE chunks, and the case of those memzone UTs relaying of specific free memsegs of rhte reserved memzone. Other UTs just need to be update, for example, to calculat

[dpdk-dev] [PATCH v3 2/9] eal: memzone allocated by malloc

2015-06-19 Thread Sergio Gonzalez Monroy
In the current memory hierarchy, memsegs are groups of physically contiguous hugepages, memzones are slices of memsegs and malloc further slices memzones into smaller memory chunks. This patch modifies malloc so it partitions memsegs instead of memzones. Thus memzones would call malloc internally

[dpdk-dev] [PATCH v3 1/9] eal: move librte_malloc to eal/common

2015-06-19 Thread Sergio Gonzalez Monroy
Move malloc inside eal. Create a dummy malloc library to avoid breaking applications that have librte_malloc in their DT_NEEDED entries. This is the first step towards using malloc to allocate memory directly from memsegs. Thus, memzones would allocate memory through malloc, allowing to free memz

[dpdk-dev] [PATCH v3 0/9] Dynamic memzone

2015-06-19 Thread Sergio Gonzalez Monroy
Current implemetation allows reserving/creating memzones but not the opposite (unreserve/free). This affects mempools and other memzone based objects. >From my point of view, implementing free functionality for memzones would look like malloc over memsegs. Thus, this approach moves malloc inside e

[dpdk-dev] [PATCH v2 3/3] mempool: fix typos, indentation, and doxygen style

2015-06-19 Thread Olivier Matz
Do some cosmetic clean-up. Signed-off-by: Olivier Matz --- lib/librte_mempool/rte_dom0_mempool.c | 36 lib/librte_mempool/rte_mempool.c | 10 ++--- lib/librte_mempool/rte_mempool.h | 80 ++- 3 files changed, 73 insertions(+), 53 deletion

[dpdk-dev] [PATCH v2 2/3] mempool: introduce objtlr structure for object trailers

2015-06-19 Thread Olivier Matz
Each object stored in mempools are suffixed by a trailer, storing a cookie in debug mode which help to detect memory corruptions. Like for headers, introduce a structure that materializes the content of this trailer. Signed-off-by: Olivier Matz --- lib/librte_mempool/rte_mempool.c | 4 +++- li

[dpdk-dev] [PATCH v2 1/3] mempool: introduce objhdr structure for object headers

2015-06-19 Thread Olivier Matz
Each object stored in mempools are prefixed by a header, allowing for instance to retrieve the mempool pointer from the object. When debug is enabled, a cookie is also added in this header that helps to detect corruptions and double-frees. Introduce a structure that materializes the content of thi

[dpdk-dev] [PATCH v2 0/3] mempool: clean-up

2015-06-19 Thread Olivier Matz
These 3 patches try to make mempool code easier to read, they have no functional impact. Changes in v2: - fix compilation between patch 1 and 2 Olivier Matz (3): mempool: introduce objhdr structure for object headers mempool: introduce objtlr structure for object trailers mempool: fix typos

[dpdk-dev] [PATCH v5 6/6] i40e: check rxq parameter in i40e_reset_rx_queue

2015-06-19 Thread Bernard Iremonger
There is a segmentation fault if rxq is NULL Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_rxtx.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index 2de0ac4..2a89e84 100644 --- a/drivers/net/

[dpdk-dev] [PATCH v5 5/6] i40e: clear queues in i40evf_dev_stop

2015-06-19 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev_vf.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 6f3ecff..f0ddfed 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/driver

[dpdk-dev] [PATCH v5 4/6] i40e: call _clear_cmd() when error occurs

2015-06-19 Thread Bernard Iremonger
_clear_cmd() was not being called in failure situations, resulting in the next command also failing. Fix several typos. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev_vf.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/i40e/i40e_

[dpdk-dev] [PATCH v5 3/6] i40e: increase ASQ_DELAY_MS to 100 and MAX_TRY_TIMES to 20 in i40evf_wait_cmd_done()

2015-06-19 Thread Bernard Iremonger
Increase delay from 50 * 10 to 100 * 20 to avoid i40evf_read_pfmsg() failures. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev_vf.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c

[dpdk-dev] [PATCH v5 2/6] i40e: release vmdq vsi's in dev_close

2015-06-19 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 9ae68d6..4661436 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net

[dpdk-dev] [PATCH v5 1/6] i40e: changes to support PCI Port Hotplug

2015-06-19 Thread Bernard Iremonger
This patch depends on the Port Hotplug Framework. It implements the eth_dev_uninit functions for rte_i40e_pmd and rte_i40evf_pmd. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 81 - drivers/net/i40e/i40e_ethdev_vf.c | 59

[dpdk-dev] [PATCH v5 0/6] i40e: PCI Port Hotplug Changes

2015-06-19 Thread Bernard Iremonger
Changes in V5: Increased timeout in i40evf_wait_cmd_done() Set nb_rx_queues and nb_tx_queues to 0 in uninit functions. Rebased to latest i40e code. Changes in V4: added patch 6 to fix segmentation fault reported by Michael Qiu. Rebase to latest i40e code. Changes in V3: Release rx and tx queues i

[dpdk-dev] [PATCH 08/10] librte_mbuf: Add rte_pktmbuf_mtod_offset()

2015-06-19 Thread Olivier MATZ
On 04/29/2015 06:15 PM, Cyril Chemparathy wrote: > There are a number of instances in the code where rte_pktmbuf_mtod() is used > to get the mbuf data pointer, only to add an offset before casting the result > to some other header type. This patch adds a new rte_pktmbuf_mtod_offset() > macro to

[dpdk-dev] [PATCH 01/10] eal: add and use unaligned integer types

2015-06-19 Thread Olivier MATZ
Hello Cyril, First, sorry commenting that late. My first intent was to benchmark with your modifications, but I did not find the time for it. So, please find some comments on your series below so it can be pushed for 2.1. On 04/29/2015 06:15 PM, Cyril Chemparathy wrote: > On machines that are st

[dpdk-dev] [dpdk-announce] important design choices - statistics - ABI

2015-06-19 Thread Thomas Monjalon
2015-06-19 11:27, Neil Horman: > On Fri, Jun 19, 2015 at 03:16:53PM +0200, Thomas Monjalon wrote: > > 2015-06-19 09:02, Neil Horman: > > > On Fri, Jun 19, 2015 at 02:32:33PM +0200, Thomas Monjalon wrote: > > > > 2015-06-19 06:26, Neil Horman: > > > > > On Thu, Jun 18, 2015 at 04:55:45PM +, O'Dr

[dpdk-dev] [PATCH v3 0/2] bonding PCI Port Hotplug

2015-06-19 Thread Declan Doherty
On 12/06/15 17:21, Bernard Iremonger wrote: > Changes in V3: > Modified testpmd to handle attach/detach of bonding pmd. > > Bernard Iremonger (2): >bonding: add support for PCI Port Hotplug >test-pmd: modified testpmd for link_bonding > > app/test-pmd/cmdline.c |4

[dpdk-dev] [PATCH 2/2] bonding: fix name and port validation

2015-06-19 Thread Declan Doherty
On 10/06/15 23:06, Stephen Hemminger wrote: > From: Stephen Hemminger > > Cleanup the code in bonding that checks ports. >* Use standard rte_eth_dev_is_valid_port >* Change name of driver string to avoid variable namespace conflicts >* Get rid of unnecessary string comparison stuff. A

[dpdk-dev] [PATCH v3 0/3] add support for HTM lock elision for x86

2015-06-19 Thread Thomas Monjalon
2015-06-19 13:08, Roman Dementiev: > This series of patches adds methods that use hardware memory transactions > (HTM) > on fast-path for DPDK locks (a.k.a. lock elision). Here the methods are > implemented for x86 using Restricted Transactional Memory instructions > (Intel(r) > Transactional Syn

[dpdk-dev] [PATCH v4] Add toeplitz hash algorithm used by RSS

2015-06-19 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Richardson, Bruce > Sent: Friday, June 19, 2015 5:00 PM > To: Vladimir Medvedkin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4] Add toeplitz hash algorithm used by RSS > > Missing signoff line. > Hi, I

[dpdk-dev] [PATCH 2/2 v2] fm10k: Add hotplug support for fm10k

2015-06-19 Thread Michael Qiu
Add hotplug support for fm10k. Signed-off-by: Michael Qiu --- drivers/net/fm10k/fm10k_ethdev.c | 97 +++- 1 file changed, 96 insertions(+), 1 deletion(-) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index 6a14633..38d1eb7 1

[dpdk-dev] [PATCH 1/2 v3] fm10k: Free queues when close port

2015-06-19 Thread Michael Qiu
When close a port, lots of memory should be released, such as software rings, queues, etc. Signed-off-by: Michael Qiu --- drivers/net/fm10k/fm10k_ethdev.c | 39 +++ 1 file changed, 35 insertions(+), 4 deletions(-) diff --git a/drivers/net/fm10k/fm10k_ethdev.c

[dpdk-dev] [PATCH 0/2 v3] Enable hotplug support for fm10k

2015-06-19 Thread Michael Qiu
Hotplug feature is supported in EAL, this patch set is to enable this feature in driver side. change log: v3-->v2: reset queue numbers to zero. v2 --> v1: remove __rte_unused flag Michael Qiu (2): fm10k: Free queues when close port fm10k: Add hotplug support fo

[dpdk-dev] [PULL REQUEST] fm10k: new features promisc, mac/vlan, checksum

2015-06-19 Thread Chen Jing D(Mark)
The fm10k driver changes include below features: - Checksum offload - Promiscuous Mode - MAC filter add/delete - VLAN stripping/insert - Vlan filter add/delete - A series of bug fixing The following changes since commit 043ef28b391644229d9c4a671defb2304fefee69: acl: add new test cases (20

[dpdk-dev] [PATCH] Add unit test for thash library

2015-06-19 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vladimir Medvedkin > Sent: Friday, June 19, 2015 3:56 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] Add unit test for thash library > > Add unit test for thash library > Missing sign-off. > --- > a

[dpdk-dev] [PATCH v7 18/18] mbuf: remove old packet type bit masks

2015-06-19 Thread Helin Zhang
As unified packet types are used instead, those old bit masks and the relevant macros for packet type indication need to be removed. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- lib/librte_mbuf

[dpdk-dev] [PATCH v7 17/18] examples/l3fwd: replace bit mask based packet type with unified packet type

2015-06-19 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- examples/l3fwd/main.c | 123 +

[dpdk-dev] [PATCH v7 16/18] examples/l3fwd-power: replace bit mask based packet type with unified packet type

2015-06-19 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- examples/l3fwd-power/main.c | 8 +

[dpdk-dev] [PATCH v7 15/18] examples/l3fwd-acl: replace bit mask based packet type with unified packet type

2015-06-19 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- examples/l3fwd-acl/main.c | 29 ++

[dpdk-dev] [PATCH v7 14/18] examples/ip_reassembly: replace bit mask based packet type with unified packet type

2015-06-19 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- examples/ip_reassembly/main.c | 9

[dpdk-dev] [PATCH v7 13/18] examples/ip_fragmentation: replace bit mask based packet type with unified packet type

2015-06-19 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- examples/ip_fragmentation/main.c

[dpdk-dev] [PATCH v7 12/18] app/test: Remove useless code

2015-06-19 Thread Helin Zhang
Severl useless code lines are added accidently, which blocks packet type unification. They should be deleted at all. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- app/test/packet_burst_generator

[dpdk-dev] [PATCH v7 11/18] app/testpmd: replace bit mask based packet type with unified packet type

2015-06-19 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang Signed-off-by: Jijiang Liu --- app/t

[dpdk-dev] [PATCH v7 10/18] app/test-pipeline: replace bit mask based packet type with unified packet type

2015-06-19 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- app/test-pipeline/pipeline_hash.c

[dpdk-dev] [PATCH v7 09/18] fm10k: replace bit mask based packet type with unified packet type

2015-06-19 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- drivers/net/fm10k/fm10k_rxtx.c |

[dpdk-dev] [PATCH v7 08/18] vmxnet3: replace bit mask based packet type with unified packet type

2015-06-19 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- drivers/net/vmxnet3/vmxnet3_rxtx.

[dpdk-dev] [PATCH v7 07/18] enic: replace bit mask based packet type with unified packet type

2015-06-19 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- drivers/net/enic/enic_main.c | 26

[dpdk-dev] [PATCH v7 06/18] i40e: replace bit mask based packet type with unified packet type

2015-06-19 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- drivers/net/i40e/i40e_rxtx.c | 52

[dpdk-dev] [PATCH v7 05/18] ixgbe: replace bit mask based packet type with unified packet type

2015-06-19 Thread Helin Zhang
To unify packet type among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Note that around 2.5% performance drop (64B) was observed of doing 4

[dpdk-dev] [PATCH v7 04/18] e1000: replace bit mask based packet type with unified packet type

2015-06-19 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- drivers/net/e1000/igb_rxtx.c | 10

[dpdk-dev] [PATCH v7 03/18] mbuf: add definitions of unified packet types

2015-06-19 Thread Helin Zhang
As there are only 6 bit flags in ol_flags for indicating packet types, which is not enough to describe all the possible packet types hardware can recognize. For example, i40e hardware can recognize more than 150 packet types. Unified packet type is composed of L2 type, L3 type, L4 type, tunnel type

[dpdk-dev] [PATCH v7 02/18] ixgbe: support unified packet type in vectorized PMD

2015-06-19 Thread Helin Zhang
To unify the packet type, bit masks of packet type for ol_flags are replaced. In addition, more packet types (UDP, TCP and SCTP) are supported in vectorized ixgbe PMD. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Note that arou

[dpdk-dev] [PATCH v7 01/18] mbuf: redefine packet_type in rte_mbuf

2015-06-19 Thread Helin Zhang
In order to unify the packet type, the field of 'packet_type' in 'struct rte_mbuf' needs to be extended from 16 to 32 bits. Accordingly, some fields in 'struct rte_mbuf' are re-organized to support this change for Vector PMD. As 'struct rte_kni_mbuf' for KNI should be right mapped to 'struct rte_mb

[dpdk-dev] [PATCH v7 00/18] unified packet type

2015-06-19 Thread Helin Zhang
Currently only 6 bits which are stored in ol_flags are used to indicate the packet types. This is not enough, as some NIC hardware can recognize quite a lot of packet types, e.g i40e hardware can recognize more than 150 packet types. Hiding those packet types hides hardware offload capabilities whi

[dpdk-dev] [PATCH v2 8/8] doc: dynamic rss configuration for bonding

2015-06-19 Thread Tomasz Kulasek
Documentation update about implementation details and requirements for Dynamic RSS Configuration for Bonding. Signed-off-by: Tomasz Kulasek --- .../prog_guide/link_bonding_poll_mode_drv_lib.rst | 34 ++-- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/doc/guide

[dpdk-dev] [PATCH v2 7/8] doc: fixed spellings and typos

2015-06-19 Thread Tomasz Kulasek
Signed-off-by: Tomasz Kulasek --- .../prog_guide/link_bonding_poll_mode_drv_lib.rst |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst b/doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst index 96e554f..0

[dpdk-dev] [PATCH v2 6/8] examples: dynamic rss configuration for bonding

2015-06-19 Thread Tomasz Kulasek
This application allows you to test RSS configuration for bonded devices changing configuration dynamically, during receiving packets on slaves and observe the changes in its distribution over queues. After initialization process, all accessible ports are attached to one bonding as slaves. Monito

[dpdk-dev] [PATCH v2 5/8] ring: queue stats mapping set dummy implementation

2015-06-19 Thread Tomasz Kulasek
Per queue statistics are already implemented for ring device, but with static mapping (stat_idx == queue_id). This fix is required, if you want to use ring device in test application and is used only to point that per queue statistics are provided for this device. Signed-off-by: Tomasz Kulasek -

[dpdk-dev] [PATCH v2 4/8] bond: queue stats mapping

2015-06-19 Thread Tomasz Kulasek
Queue stats mapping is used in example application. This patch adds propagation of mapping over the slaves, and fills bonding port's stats with a sum of corresponding values taken from bonded slaves, when stats are requested for bonding port. Signed-off-by: Tomasz Kulasek --- drivers/net/bonding

[dpdk-dev] [PATCH v2 3/8] test: dynamic rss configuration

2015-06-19 Thread Tomasz Kulasek
This test module uses ring device to check right RSS configuration propagation. 1) Propagation test a) Set RSS hash function for bonding, fetch RSS hash function from bonded slave, check if same. Do it for all slaves. b) Repeat above for RSS key and RETA. 2)Dynamic adding slave to the bo

[dpdk-dev] [PATCH v2 2/8] ring: dynamic rss configuration

2015-06-19 Thread Tomasz Kulasek
This implementation allows to set and read RSS configuration for ring device, and is used to validate right values propagation over the slaves, in test units for dynamic RSS configuration for bonding. It have no impact on packet processing by ring device. Signed-off-by: Tomasz Kulasek --- drive

[dpdk-dev] [PATCH v2 1/8] bond: rss dynamic configuration

2015-06-19 Thread Tomasz Kulasek
Bonding device implements independent management of RSS settings. It stores its own copies of settings i.e. RETA, RSS hash function and RSS key. It?s required to ensure consistency. 1) RSS hash function set for bonding device is maximal set of RSS hash functions supported by all bonded devices. Th

[dpdk-dev] [PATCH v2 0/8] Dynamic RSS Configuration for Bonding

2015-06-19 Thread Tomasz Kulasek
OVERVIEW 1) Setting .rxmode.mq_mode for bonding device to ETH_MQ_RX_RSS makes bonding device fully RSS-capable, so all slaves are synchronized with its configuration. This mode is intended to provide RSS configuration as known from "dynamic RSS configuration for one port" and made slaves t

[dpdk-dev] [PATCH] ixgbe: fix the flow director flexbytes offset issues

2015-06-19 Thread David Marchand
On Fri, Jun 19, 2015 at 3:57 PM, Gaetan Rivet wrote: > On Fri, Jun 19, 2015 at 8:35 AM, Jingjing Wu > wrote: > > The flexbytes offset can not be set, because the value is over written > > when fdir is enabled. > > This patch fixes this issue, and also removes some reduplicate lines. > > > > Repo

[dpdk-dev] [PATCH v4] Add toeplitz hash algorithm used by RSS

2015-06-19 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vladimir Medvedkin > Sent: Friday, June 19, 2015 3:56 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v4] Add toeplitz hash algorithm used by RSS > > v4 changes > - Fix copyright > - rename bswap_mask co

[dpdk-dev] [PATCH] ixgbe: fix the flow director flexbytes offset issues

2015-06-19 Thread Gaetan Rivet
On Fri, Jun 19, 2015 at 8:35 AM, Jingjing Wu wrote: > The flexbytes offset can not be set, because the value is over written > when fdir is enabled. > This patch fixes this issue, and also removes some reduplicate lines. > > Reported-by: David Marchand > Signed-off-by: Jingjing Wu Tested-by: Ga

[dpdk-dev] [PATCH v2 1/3] spinlock: add support for HTM lock elision for x86

2015-06-19 Thread Thomas Monjalon
2015-06-18 11:00, Bruce Richardson: > On Wed, Jun 17, 2015 at 11:29:49PM +0200, Thomas Monjalon wrote: > > Introducing rte_cpuflags.h in this header breaks the compilation of > > the mlx4 pmd with CONFIG_RTE_LIBRTE_MLX4_DEBUG=y. > > Indeed, it triggers the -pedantic flag which is not supported by

[dpdk-dev] [dpdk-announce] important design choices - statistics - ABI

2015-06-19 Thread Thomas Monjalon
2015-06-19 09:02, Neil Horman: > On Fri, Jun 19, 2015 at 02:32:33PM +0200, Thomas Monjalon wrote: > > 2015-06-19 06:26, Neil Horman: > > > On Thu, Jun 18, 2015 at 04:55:45PM +, O'Driscoll, Tim wrote: > > > > For the 2.1 release, I think we should agree to make patches that change > > > > the AB

[dpdk-dev] Issue with rte_compat versioning macros

2015-06-19 Thread Gajdzica, MaciejX T
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, June 19, 2015 4:48 PM > To: Gajdzica, MaciejX T > Cc: dev at dpdk.org; nhorman at tuxdriver.com > Subject: Re: [dpdk-dev] Issue with rte_compat versioning macros > > 2015-06-19 14:38, Gajdzic

[dpdk-dev] Issue with rte_compat versioning macros

2015-06-19 Thread Gajdzica, MaciejX T
Hi There is an issue with macros in rte_compat.h. For shared library case, macro BIND_DEFAULT_SYMBOL takes three arguments and for other case it takes only two arguments. Also letters for macro variable names are not consistent in these two cases. Best Regards Maciek

[dpdk-dev] [PATCH] ixgbe: fix the flow director flexbytes offset issues

2015-06-19 Thread Jingjing Wu
The flexbytes offset can not be set, because the value is over written when fdir is enabled. This patch fixes this issue, and also removes some reduplicate lines. Reported-by: David Marchand Signed-off-by: Jingjing Wu --- drivers/net/ixgbe/ixgbe_fdir.c | 24 1 file chan

[dpdk-dev] [dpdk-announce] important design choices - statistics - ABI

2015-06-19 Thread Thomas Monjalon
2015-06-19 06:26, Neil Horman: > On Thu, Jun 18, 2015 at 04:55:45PM +, O'Driscoll, Tim wrote: > > For the 2.1 release, I think we should agree to make patches that change > > the ABI controllable via a compile-time option. I like Olivier's proposal > > on using a single option (CONFIG_RTE_NEXT_

[dpdk-dev] [PATCH] examples/l2fwd: Add forward count limit.

2015-06-19 Thread Cyril Chemparathy
This commit adds a forward count argument, which is used to terminate the test once a certain number of packets have been forwarded. Change-Id: Ia3e7ff5d41c3e947509b0653d53271b882fc04de Signed-off-by: Cyril Chemparathy --- examples/l2fwd/main.c | 46 --

[dpdk-dev] [PATCH] mk: add support for gdb debug info generation

2015-06-19 Thread Cyril Chemparathy
From: Cyril Chemparathy It is often useful to build with debug enabled, we add a config (CONFIG_RTE_TOOLCHAIN_DEBUG) to do so. Note: This patch does not include corresponding changes for ICC. The author pleads abject ignorance in this regard, and welcomes recommendations. :-) Change-Id: I499e5

[dpdk-dev] [dpdk-announce] important design choices - statistics - ABI

2015-06-19 Thread Thomas F Herbert
On 6/19/15 1:02 PM, Thomas Monjalon wrote: > 2015-06-19 12:13, Thomas F Herbert: >> >> On 6/19/15 9:16 AM, Thomas Monjalon wrote: >>> 2015-06-19 09:02, Neil Horman: On Fri, Jun 19, 2015 at 02:32:33PM +0200, Thomas Monjalon wrote: > 2015-06-19 06:26, Neil Horman: >> On Thu, Jun 18, 20

[dpdk-dev] [PATCH v3] Add unit test for thash library

2015-06-19 Thread Vladimir Medvedkin
Add unit test for thash library v3 changes - Fix checkpatch errors v2 changes - fix typo - remove unnecessary comments Signed-off-by: Vladimir Medvedkin --- app/test/Makefile | 2 + app/test/autotest_data.py | 13 app/test/test_thash.c | 176

[dpdk-dev] [PATCH v5] Add toeplitz hash algorithm used by RSS

2015-06-19 Thread Vladimir Medvedkin
Software implementation of the Toeplitz hash function used by RSS. Can be used either for packet distribution on single queue NIC or for simulating of RSS computation on specific NIC (for example after GRE header decapsulating). v5 changes - Fix errors reported by checkpatch.pl v4 changes - Fix c

[dpdk-dev] [PATCH v5 1/1] pipeline: add statistics for librte_pipeline ports and tables

2015-06-19 Thread Maciej Gajdzica
This patch adds statistics collection for librte_pipeline. Those statistics ale disabled by default during build time. Signed-off-by: Pawel Wodkowski --- config/common_bsdapp |1 + config/common_linuxapp |1 + lib/librte_pipeline/rte_pipeline.c | 185 ++

[dpdk-dev] [PATCH v3 3/3] test scaling of HTM lock elision protecting rte_hash

2015-06-19 Thread Roman Dementiev
This patch adds a new auto-test for testing the scaling of concurrent inserts into rte_hash when protected by the normal spinlock vs. the spinlock with HTM lock elision. The test also benchmarks single-threaded access without any locks. Signed-off-by: Roman Dementiev Acked-by: Bruce Richardson -

[dpdk-dev] [PATCH v3 2/3] rwlock: add support for HTM lock elision for x86

2015-06-19 Thread Roman Dementiev
This patch adds methods that use hardware memory transactions (HTM) on fast-path for rwlock (a.k.a. lock elision). Here the methods are implemented for x86 using Restricted Transactional Memory instructions (Intel(r) Transactional Synchronization Extensions). The implementation fall-backs to the no

[dpdk-dev] [PATCH v3 1/3] spinlock: add support for HTM lock elision for x86

2015-06-19 Thread Roman Dementiev
This patch adds methods that use hardware memory transactions (HTM) on fast-path for spinlocks (a.k.a. lock elision). Here the methods are implemented for x86 using Restricted Transactional Memory instructions (Intel(r) Transactional Synchronization Extensions). The implementation fall-backs to the

[dpdk-dev] [PATCH v3 0/3] add support for HTM lock elision for x86

2015-06-19 Thread Roman Dementiev
This series of patches adds methods that use hardware memory transactions (HTM) on fast-path for DPDK locks (a.k.a. lock elision). Here the methods are implemented for x86 using Restricted Transactional Memory instructions (Intel(r) Transactional Synchronization Extensions). The implementation fall

[dpdk-dev] [PATCH v5 11/11] table: added stub table stats

2015-06-19 Thread Maciej Gajdzica
Added stub table statistics. Signed-off-by: Maciej Gajdzica --- lib/librte_table/rte_table_stub.c | 56 - 1 file changed, 55 insertions(+), 1 deletion(-) diff --git a/lib/librte_table/rte_table_stub.c b/lib/librte_table/rte_table_stub.c index 876b7e4..c106

[dpdk-dev] [PATCH v5 10/11] table: added lpm table stats

2015-06-19 Thread Maciej Gajdzica
Added lpm table statistics. Signed-off-by: Maciej Gajdzica --- lib/librte_table/rte_table_lpm.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/lib/librte_table/rte_table_lpm.c b/lib/librte_table/rte_table_lpm.c index 64c684d..300e680 100644 --- a/lib/li

[dpdk-dev] [PATCH v5 09/11] table: added lpm_ipv6 table stats

2015-06-19 Thread Maciej Gajdzica
Added lpm ipv6 table statistics. Signed-off-by: Maciej Gajdzica --- lib/librte_table/rte_table_lpm_ipv6.c | 34 + 1 file changed, 34 insertions(+) diff --git a/lib/librte_table/rte_table_lpm_ipv6.c b/lib/librte_table/rte_table_lpm_ipv6.c index ce4ddc0..ce7fa02

[dpdk-dev] [PATCH v5 08/11] table: added hash_lru table stats

2015-06-19 Thread Maciej Gajdzica
Added statistics for hash_lru table. Signed-off-by: Maciej Gajdzica --- lib/librte_table/rte_table_hash_lru.c | 44 + 1 file changed, 44 insertions(+) diff --git a/lib/librte_table/rte_table_hash_lru.c b/lib/librte_table/rte_table_hash_lru.c index c9a8afd..c4b

[dpdk-dev] [PATCH v5 07/11] table: added hash_key8 table stats

2015-06-19 Thread Maciej Gajdzica
Added statistics for hash key8 table. Signed-off-by: Maciej Gajdzica --- lib/librte_table/rte_table_hash_key8.c | 52 1 file changed, 52 insertions(+) diff --git a/lib/librte_table/rte_table_hash_key8.c b/lib/librte_table/rte_table_hash_key8.c index 6803eb2..

[dpdk-dev] [PATCH v5 06/11] table: added hash_key32 table stats

2015-06-19 Thread Maciej Gajdzica
Added statistics for hash key32 table. Signed-off-by: Maciej Gajdzica --- lib/librte_table/rte_table_hash_key32.c | 41 +++ 1 file changed, 41 insertions(+) diff --git a/lib/librte_table/rte_table_hash_key32.c b/lib/librte_table/rte_table_hash_key32.c index 679059

[dpdk-dev] [PATCH v5 05/11] table: added hash_key16 table stats

2015-06-19 Thread Maciej Gajdzica
Added statistics for hash key16 table. Signed-off-by: Maciej Gajdzica --- lib/librte_table/rte_table_hash_key16.c | 41 +++ 1 file changed, 41 insertions(+) diff --git a/lib/librte_table/rte_table_hash_key16.c b/lib/librte_table/rte_table_hash_key16.c index f87ea0

[dpdk-dev] [PATCH v5 04/11] table: added hash_ext table stats

2015-06-19 Thread Maciej Gajdzica
Added statistics for hash ext table. Signed-off-by: Maciej Gajdzica --- lib/librte_table/rte_table_hash_ext.c | 44 + 1 file changed, 44 insertions(+) diff --git a/lib/librte_table/rte_table_hash_ext.c b/lib/librte_table/rte_table_hash_ext.c index 66e416b..3c1

[dpdk-dev] [PATCH v5 03/11] table: added array table stats

2015-06-19 Thread Maciej Gajdzica
Added statistics for array table. Signed-off-by: Maciej Gajdzica --- lib/librte_table/rte_table_array.c | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/lib/librte_table/rte_table_array.c b/lib/librte_table/rte_table_array.c index c031070.

[dpdk-dev] [PATCH v5 02/11] table: added acl table stats

2015-06-19 Thread Maciej Gajdzica
Added statistics for ACL table. Signed-off-by: Maciej Gajdzica --- lib/librte_table/rte_table_acl.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/lib/librte_table/rte_table_acl.c b/lib/librte_table/rte_table_acl.c index 4416311..f02de3e 100644 --- a/l

[dpdk-dev] [PATCH v5 01/11] table: added structure for storing table stats and config option

2015-06-19 Thread Maciej Gajdzica
Added common structure for table statistics. Added config option to enable table stats collecting. Signed-off-by: Maciej Gajdzica --- config/common_bsdapp |1 + config/common_linuxapp |1 + lib/librte_table/rte_table.h | 25 + 3 files changed, 27 i

[dpdk-dev] [PATCH v5 00/11] table: added table statistics

2015-06-19 Thread Maciej Gajdzica
Added statistics for every type of table. By default all table statistics are disabled, user must activate them in config file. Changes in v2: - added missing signoffs Changes in v3: - removed new config options to enable/disable stats - using RTE_LOG_LEVEL instead Change

[dpdk-dev] [PATCH 11/11] maintainers: claim responsibility for TILE-Gx platform

2015-06-19 Thread Cyril Chemparathy
Change-Id: I6491108ff86c1249bf4ffa4d4624c01b4594805e Signed-off-by: Cyril Chemparathy --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9362c19..bffc1e6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -113,6 +113,10 @@ M: Bruce Richardson M: K

[dpdk-dev] [PATCH 10/11] tile: Add TILE-Gx mPIPE poll mode driver.

2015-06-19 Thread Cyril Chemparathy
This commit adds a poll mode driver for the mPIPE hardware present on TILE-Gx SoCs. Change-Id: I1b9a9ef2c9f1c96810ec58b4d2ae77b870a6ec94 Signed-off-by: Cyril Chemparathy --- config/defconfig_tile-tilegx-linuxapp-gcc |1 + drivers/net/Makefile |1 + drivers/net/mpipe/

[dpdk-dev] [PATCH 09/11] tile: initial TILE-Gx support.

2015-06-19 Thread Cyril Chemparathy
This commit adds support for the TILE-Gx platform, as well as the TILE CPU architecture. This architecture port is fairly simple due to its reliance on generics for most arch stuff. Change-Id: I809fcf740e25ba5976a6b7736c1673515338cf80 Signed-off-by: Cyril Chemparathy --- config/defconfig_tile-t

[dpdk-dev] [PATCH 08/11] tile: add page sizes for TILE-Gx/Mx platforms

2015-06-19 Thread Cyril Chemparathy
This patch adds a few new page sizes that are supported on the TILE-Gx and TILE-Mx platforms. Change-Id: I7da783703149c4f96b84d0017fa4f1191fc029c6 Signed-off-by: Cyril Chemparathy --- lib/librte_eal/common/eal_common_memzone.c | 8 + lib/librte_eal/common/include/rte_memory.h | 16 +--

  1   2   3   >