2015-07-28 19:16, Thomas Monjalon:
> This driver has too many issues:
> - too big
> - bad coding style
> - no git history (dropped in 2 patches)
> - no documentation
> - no BSD support
> - no maintainer
> And the biggest one, constraining this disabling:
>
2015-07-28 19:05 GMT+03:00 Thomas Monjalon :
> 2015-07-28 18:33, Vladimir Medvedkin:
> > 2015-07-28 16:47 GMT+03:00 Thomas Monjalon :
> > > 2015-07-28 09:06, Vladimir Medvedkin:
> > > Please explain how it was broken and how you fixed it.
> > > It would be interesting to know which part is __SSE3_
Hello all,
I am learning how to measure throughput with dpdk. I have 4 cores
Intel(R) Core(TM) i3-4360 CPU @ 3.70GHz and two 82545GM NICs connected
together. I do not understand very well, how to setup testpmd.
I've successfully bound the NICs to dpdk:
$ dpdk_nic_bind --status
Network devices u
> > When adding with cuckoo hash a key which was already inserted
> > a new slot is dequeued and then enqueued back, but the enqueue
> > operation was not done properly.
> >
> > Signed-off-by: Xavier Simonart
> Acked-by: Sergio Gonzalez Monroy
Fixes: 48a399119619 ("hash: replace with cuckoo hash
This driver has too many issues:
- too big
- bad coding style
- no git history (dropped in 2 patches)
- no documentation
- no BSD support
- no maintainer
And the biggest one, constraining this disabling:
- many build issues
If the last 4 issu
On 2015/7/8 2:04, Richardson, Bruce wrote:
> On Wed, Jul 08, 2015 at 07:16:21AM +, Qiu, Michael wrote:
[.../...]
>>> port = &ports[pi];
>>> if (rte_atomic16_cmpset(&(port->port_status),
>>> + RTE_PORT_CLOSED, RTE_PORT_CLOSED) == 1) {
>>> +
Hi Thomas,
2015-07-28 16:47 GMT+03:00 Thomas Monjalon :
> Hi Vladimir,
> Thanks for fixing.
> Comments below.
>
> 2015-07-28 09:06, Vladimir Medvedkin:
> > Signed-off-by: Vladimir Medvedkin
>
> Please explain how it was broken and how you fixed it.
> It would be interesting to know which part i
2015-07-28 18:33, Vladimir Medvedkin:
> 2015-07-28 16:47 GMT+03:00 Thomas Monjalon :
> > 2015-07-28 09:06, Vladimir Medvedkin:
> > Please explain how it was broken and how you fixed it.
> > It would be interesting to know which part is __SSE3__ and __SSE__.
> >
> As mentioned in http://dpdk.org/ml
This patch adds support for pthread_setname_np on Linux and
pthread_set_name_np on FreeBSD.
Changes in V2:
Remove config support for max thread name len.
Restrict max thread name len to 16 on Linux and FreeBSD.
Fix checkpatch.pl errors.
Changes based on code review comments from Thomas.
Changes i
This patch adds support for pthread_setname_np on Linux
and pthread_set_name_np on FreeBSD to aid in debugging by
identifying DPDK threads by it name. Following is the sample
output on Linux and FreeBSD.
On Linux:
rkerur at dpdk-ubuntu# ps H -C testpmd -o 'pid tid cmd comm'
PID TID CMD
Example of errors:
error: cast to pointer from integer of different size
[-Werror=int-to-pointer-cast]
error: format ?%lx? expects argument of type ?long unsigned int?, but
argument 5 has type ?uint64_t
error: format ?%lu? expects argument of type ?long unsigned int?, but
Build log:
error: unused function 'bnx2x_hilo'
No need to keep an unused function.
Signed-off-by: Thomas Monjalon
---
drivers/net/bnx2x/bnx2x_stats.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/net/bnx2x/bnx2x_stats.c b/drivers/net/bnx2x/bnx2x_stats.c
index
Build log:
error: unused variable ?cid?
error: ?RTE_LOG_WARN? undeclared
error: expected ?)? before ?sc?
There were unused variables defined for debug but not used in debug log because
it was ifdef'ed a the wrong condition (RTE_LIBRTE_BNX2X_DEBUG_DRIVER).
The warning were
Build log:
Must Specify a librte_pmd_bnx2x.so..1 ABI version
Signed-off-by: Thomas Monjalon
---
drivers/net/bnx2x/Makefile | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/bnx2x/Makefile b/drivers/net/bnx2x/Makefile
index 0de5db9..87f31b6 100644
--- a/drivers/net/bnx2x
The basic build tests fail in many ways.
The driver was disabled by error in first test before applying it.
That's why it has been accepted.
This is a first try to fix most of the errors.
It has not been tested with old compilers, nor icc.
The 32-bit build fix is not complete.
Please review it and
When adding a "depth small" entry, if its extended flag is not set
and its depth is smaller than the one in the tbl24, nothing should
be done otherwise will operate on the wrong memory area.
Signed-off-by: Zhe Tao
---
lib/librte_lpm/rte_lpm.c | 51 +--
From: "jingjing.wu"
This patch fixes the issue:
Testpmd crashed with Segmentation fault when setup tx queues on vf
Steps for reproduce:
- create one vf device from i40e driver
- bind vf device to igb_uio and start testpmd
With debugging tools, we saw the struct i40e_vf is cleared after
memcp
When adding with cuckoo hash a key which was already inserted
a new slot is dequeued and then enqueued back, but the enqueue
operation was not done properly.
Signed-off-by: Xavier Simonart
---
lib/librte_hash/rte_cuckoo_hash.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Hi,
On 7/28/2015 8:10 AM, Ananyev, Konstantin wrote:
> Hi Zoltan,
>
>> -Original Message-
>> From: Zoltan Kiss [mailto:zoltan.kiss at linaro.org]
>> Sent: Monday, July 27, 2015 12:38 PM
>> To: Ananyev, Konstantin; Richardson, Bruce; dev at dpdk.org
>> Subject: Re: [dpdk-dev] ixgbe vPMD RX
This patch fixes a build error caused by undeclared PAGE_SIZE when
compiling for non-X86 arches. On some arches, PAGE_SIZE is not fixed
so that header files do not define it. A better way to get it is
via sysconf(3) or getpagesize(2).
Fixes: 540a211084a7 ("bnx2x: driver core")
== Build drivers/n
Fix afebc86be1346136125af8026dc215f81c202c50. oerrors was txdgpc -
hw_stats->gptc, txdgpc is the number of packets DMA'ed by the host
and was being reset on every call to read stats so it could be < gptc.
Because we currently have no way to add txdgpc to struct hw_stats so
that we can maintain a pe
On 28/07/2015 15:54, Xavier Simonart wrote:
> When adding with cuckoo hash a key which was already inserted
> a new slot is dequeued and then enqueued back, but the enqueue
> operation was not done properly.
>
> Signed-off-by: Xavier Simonart
> ---
> lib/librte_hash/rte_cuckoo_hash.c | 4 ++--
>
Hi Vladimir,
Thanks for fixing.
Comments below.
2015-07-28 09:06, Vladimir Medvedkin:
> Signed-off-by: Vladimir Medvedkin
Please explain how it was broken and how you fixed it.
It would be interesting to know which part is __SSE3__ and __SSE__.
> +#ifdef __SSE3__
> +#include
> +#endif /* __SSE
On Tue, 28 Jul 2015 19:16:39 +0200
Thomas Monjalon wrote:
> This driver has too many issues:
> - too big
FYI - the DPDK version of the driver is already much smaller
than other OS. Still all versions seem to be bigger than necessary
but that is what vendor code looks like.
Driver
Fixes: cf4b4708a88a (ixgbe: improve slow-path perf with vector scattered Rx)
v2: changes:
- updated commit message with 'Fixes'.
Signed-off-by: Konstantin Ananyev
---
drivers/net/ixgbe/ixgbe_rxtx_vec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec.c
b/d
For 2.1 release, in attempt to minimize number of RX routines to support,
ixgbe scatter and ixgbe LRO RX routines were merged into one
that can handle both cases.
Though I completely missed the fact, that while LRO could only be used
when HW CRC strip is enabled, scatter RX should work for both cas
Konstantin Ananyev (2):
ixgbe: fix scalar scatter RX doesn't take into account CRC length
ixgbe: fix vector scatter RX could produce wrong nb_segs value
drivers/net/ixgbe/ixgbe_rxtx.c | 19 +++
drivers/net/ixgbe/ixgbe_rxtx_vec.c | 2 ++
2 files changed, 21 insertions(+)
2015-06-16 11:45, Tetsuya Mukawa:
> On 2015/06/11 23:33, Bernard Iremonger wrote:
> > Signed-off-by: Bernard Iremonger
>
> Acked-by: Tetsuya Mukawa
Applied, thanks
On Tue, 28 Jul 2015 19:16:39 +0200
Thomas Monjalon wrote:
> This driver has too many issues:
> - too big
> - bad coding style
> - no git history (dropped in 2 patches)
> - no documentation
> - no BSD support
The main issue with BSD is loading the firmware.
Probably
2015-07-28 16:48, Zhigang Lu:
> This patch fixes a build error caused by undeclared PAGE_SIZE when
> compiling for non-X86 arches. On some arches, PAGE_SIZE is not fixed
> so that header files do not define it. A better way to get it is
> via sysconf(3) or getpagesize(2).
>
> Fixes: 540a211084a7
Hello. I'm a DPDK newbie, playing with KNI.
I have a packet analysis application like tshark,
which receives packets from network interface or pcap file.
My plan with KNI is
1) Performance improvement without modifying my program
2) Add ip_reassembly, acl to kni example.
(rte_eth_rx_burst -> i
Signed-off-by: Konstantin Ananyev
---
drivers/net/ixgbe/ixgbe_rxtx_vec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec.c
b/drivers/net/ixgbe/ixgbe_rxtx_vec.c
index 6c1647e..1c16dec 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx_vec.c
+++ b/drivers/net/ixgbe/ix
For 2.1 release, in attempt to minimize number of RX routines to support,
ixgbe scatter and ixgbe LRO RX routines were merged into one
that can handle both cases.
Though I completely missed the fact, that while LRO could only be used
when HW CRC strip is enabled, scatter RX should work for both cas
Konstantin Ananyev (2):
ixgbe: fix scalar scatter RX doesn't take into account CRC length
ixgbe: fix vector scatter RX could produce wrong nb_segs value
drivers/net/ixgbe/ixgbe_rxtx.c | 19 +++
drivers/net/ixgbe/ixgbe_rxtx_vec.c | 2 ++
2 files changed, 21 insertions(+)
Hi Jingjing,
Few comments about the patch message.
The title must tell what issue is fixed, e.g. "fix crash when...".
the end "for i40e vf driver" is useless if it starts with "i40evf:".
2015-07-28 09:13, Jingjing Wu:
> The patch fixes the i40e VF crash issue. The issue's root cause is that
> the
The patch fixes the i40e VF crash issue. The issue's root cause is that
the dev_private_size in i40e virtual function driver struct
rte_i40evf_pmd was set incorrectly.
Signed-off-by: jingjing.wu
---
drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
Signed-off-by: Vladimir Medvedkin
---
lib/librte_hash/rte_thash.h | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/lib/librte_hash/rte_thash.h b/lib/librte_hash/rte_thash.h
index 6156e8a..ddb650a 100644
--- a/lib/librte_hash/rte_thash.h
+++ b/lib/librte_ha
Hi,
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jingjing Wu
> Sent: Monday, July 20, 2015 3:04 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: announce ABI change for rte_eth_fdir_filter
>
> To fix the FVL's flow director issue for SCTP flow,
Maybe I just haven't had enough caffeine this morning yet, but why would
you add IP reassembly to KNI? If packets are going through KNI, they
already have IP reassembly via the normal Linux networking stack...
Jay
On Mon, Jul 27, 2015 at 8:55 PM, EaseTheWorld Mr.
wrote:
> Hello. I'm a DPDK newb
> -Original Message-
> From: Chen, Jing D
> Sent: Monday, July 27, 2015 3:57 PM
> To: dev at dpdk.org
> Cc: He, Shaopeng; Qiu, Michael; Chen, Jing D
> Subject: [PATCH] fm10k: expose TX checksum capability
>
> From: "Chen Jing D(Mark)"
>
> fm10k has the capability to do checksum offload
Tested-by: Marvin Liu
> -Original Message-
> From: Wu, Jingjing
> Sent: Tuesday, July 28, 2015 9:14 AM
> To: dev at dpdk.org
> Cc: Wu, Jingjing; Zhang, Helin; Chen, Jing D; Liu, Yong
> Subject: [PATCH] i40e: correct the private data size for i40e vf driver
>
> The patch fixes the i40e VF
A new DPDK release candidate is ready for testing:
http://dpdk.org/browse/dpdk/tag/?id=v2.1.0-rc2
Except some fixes, there are more features in drivers, a new bnx2x driver
and the introduction of the interrupt mode which was pending for a long time.
Having such features in a RC2 is unusual
Hi Zoltan,
> -Original Message-
> From: Zoltan Kiss [mailto:zoltan.kiss at linaro.org]
> Sent: Monday, July 27, 2015 12:38 PM
> To: Ananyev, Konstantin; Richardson, Bruce; dev at dpdk.org
> Subject: Re: [dpdk-dev] ixgbe vPMD RX functions and buffer number minimum
> requirement
>
> Hi Kon
43 matches
Mail list logo