[dpdk-dev] [PATCH v7 4/8] vhost: rxtx: use queue id instead of constant ring index

2015-10-22 Thread Yuanhan Liu
On Thu, Oct 22, 2015 at 02:32:31PM +0300, Michael S. Tsirkin wrote: > On Thu, Oct 22, 2015 at 05:49:55PM +0800, Yuanhan Liu wrote: > > On Wed, Oct 21, 2015 at 05:26:18PM +0300, Michael S. Tsirkin wrote: > > > On Wed, Oct 21, 2015 at 08:48:15PM +0800, Yuanhan Liu wrote: > > > > > Please note that

[dpdk-dev] vmxnet3 can not active device in 5.5

2015-10-22 Thread Bin Zhang
Hi, I got this issue in recent update esxi 5.5 VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_ACTIVATE_DEV) status = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_CMD); status is not 0, so device can not be activated. Has anybody got same problem? Thanks, Bin -- This message is for the

[dpdk-dev] [PATCH v8 8/8] doc: update release note for vhost-user mq support

2015-10-22 Thread Yuanhan Liu
Signed-off-by: Yuanhan Liu --- doc/guides/rel_notes/release_2_2.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.rst index 4f75cff..612ddd9 100644 --- a/doc/guides/rel_notes/release_2_2.rst +++

[dpdk-dev] [PATCH v8 7/8] vhost-user: enable vhost-user multiple queue

2015-10-22 Thread Yuanhan Liu
By setting VHOST_USER_PROTOCOL_F_MQ protocol feature bit, and VIRTIO_NET_F_MQ feature bit. Signed-off-by: Yuanhan Liu Acked-by: Flavio Leitner --- lib/librte_vhost/vhost_user/virtio-net-user.h | 4 +++- lib/librte_vhost/virtio-net.c | 1 + 2 files changed, 4 insertions(+), 1

[dpdk-dev] [PATCH v8 6/8] vhost: add VHOST_USER_SET_VRING_ENABLE message

2015-10-22 Thread Yuanhan Liu
From: Changchun Ouyang This message is used to enable/disable a specific vring queue pair. The first queue pair is enabled by default. Signed-off-by: Changchun Ouyang Signed-off-by: Yuanhan Liu Acked-by: Flavio Leitner --- v7: invoke vring_state_changed()

[dpdk-dev] [PATCH v8 5/8] virtio: fix deadloop due to reading virtio_net_config incorrectly

2015-10-22 Thread Yuanhan Liu
From: Changchun Ouyang The old code adjusts the config bytes we want to read depending on what kind of features we have, but we later cast the entire buf we read with "struct virtio_net_config", which is obviously wrong. The wrong config reading results to a dead

[dpdk-dev] [PATCH v8 3/8] vhost: vring queue setup for multiple queue support

2015-10-22 Thread Yuanhan Liu
All queue pairs, including the default (the first) queue pair, are allocated dynamically, when a vring_call message is received first time for a specific queue pair. This is a refactor work for enabling vhost-user multiple queue; it should not break anything as it does no functional changes: we

[dpdk-dev] [PATCH v8 2/8] vhost-user: add VHOST_USER_GET_QUEUE_NUM message

2015-10-22 Thread Yuanhan Liu
To tell the frontend (qemu) how many queue pairs we support. And it is initiated to VIRTIO_NET_CTRL_MQ_VQ_PAIRS_MAX. Signed-off-by: Yuanhan Liu Acked-by: Flavio Leitner --- lib/librte_vhost/vhost_user/vhost-net-user.c | 7 +++ lib/librte_vhost/vhost_user/vhost-net-user.h | 1 + 2 files

[dpdk-dev] [PATCH v8 1/8] vhost-user: add protocol features support

2015-10-22 Thread Yuanhan Liu
The two protocol features messages are introduced by qemu vhost maintainer(Michael) for extendting vhost-user interface. Here is an excerpta from the vhost-user spec: Any protocol extensions are gated by protocol feature bits, which allows full backwards compatibility on both master

[dpdk-dev] [PATCH v8 0/8] vhost-user multiple queues enabling

2015-10-22 Thread Yuanhan Liu
This patch set enables vhost-user multiple queue feature. v8: - put SET_VRING_ENABLE() patch before the patch actually enable mq, since that make more sense. - don't change the kickfd reset behavior for patch 3 - move virt_queue field to the end of virtio_net struct. -

[dpdk-dev] [PATCH v4 7/7] virtio: pick simple rx/tx func

2015-10-22 Thread Huawei Xie
Changes in v4: Check merge-able feature when select simple rx/tx functions. simple rx/tx func is chose when merge-able rx is disabled and user specifies single segment and no offload support. Signed-off-by: Huawei Xie --- drivers/net/virtio/virtio_rxtx.c | 15 +++ 1 file changed,

[dpdk-dev] [PATCH v4 6/7] virtio: simple tx routine

2015-10-22 Thread Huawei Xie
Changes in v4: - move virtio_xmit_cleanup ahead to free descriptors earlier Changes in v3: - Remove return at the end of void function - Remove always_inline attribute for virtio_xmit_cleanup bulk free of mbufs when clean used ring. shift operation of idx could be saved if vq_free_cnt means free

[dpdk-dev] [PATCH v4 5/7] virtio: virtio vec rx

2015-10-22 Thread Huawei Xie
With fixed avail ring, we don't need to get desc idx from avail ring. virtio driver only has to deal with desc ring. This patch uses vector instruction to accelerate processing desc ring. Signed-off-by: Huawei Xie --- drivers/net/virtio/virtio_ethdev.h | 2 +

[dpdk-dev] [PATCH v4 4/7] virtio: fill RX avail ring with blank mbufs

2015-10-22 Thread Huawei Xie
fill avail ring with blank mbufs in virtio_dev_vring_start Signed-off-by: Huawei Xie --- drivers/net/virtio/Makefile | 2 +- drivers/net/virtio/virtio_rxtx.c| 6 ++- drivers/net/virtio/virtio_rxtx.h| 3 ++ drivers/net/virtio/virtio_rxtx_simple.c | 84

[dpdk-dev] [PATCH v4 3/7] virtio: rx/tx ring layout optimization

2015-10-22 Thread Huawei Xie
Changes in V4: - fix the error in tx ring layout chart in this commit message. In DPDK based switching envrioment, mostly vhost runs on a dedicated core while virtio processing in guest VMs runs on different cores. Take RX for example, with generic implementation, for each guest buffer, a) virtio

[dpdk-dev] [PATCH v4 2/7] virtio: add software rx ring, fake_buf into virtqueue

2015-10-22 Thread Huawei Xie
Changes in v3: - Remove unnecessary NULL test for rte_free - Remove unnecessary assign of local var vq after free Add software RX ring in virtqueue. Add fake_mbuf in virtqueue for wraparound processing. Use global simple_rxtx to indicate whether simple rxtx is enabled Signed-off-by: Huawei Xie

[dpdk-dev] [PATCH v4 1/7] virtio: add virtio_rxtx.h header file

2015-10-22 Thread Huawei Xie
Would move all rx/tx related declarations into this header file in future. Add RTE_VIRTIO_PMD_MAX_BURST. Signed-off-by: Huawei Xie --- drivers/net/virtio/virtio_ethdev.c | 1 + drivers/net/virtio/virtio_rxtx.c | 1 + drivers/net/virtio/virtio_rxtx.h | 34 ++

[dpdk-dev] [PATCH v4 0/7] virtio ring layout optimization and simple rx/tx processing

2015-10-22 Thread Huawei Xie
Changes in v2: - Remove the configure macro - Enable simple R/TX processing when user specifies simple txq flags - Reword some comments and commit messages Changes in v3: - Remove unnecessary NULL test for rte_free - Remove unnecessary assign of local var after free - Remove return at the end of

[dpdk-dev] [PATCH v7 3/8] vhost: vring queue setup for multiple queue support

2015-10-22 Thread Yuanhan Liu
On Thu, Oct 22, 2015 at 09:49:58AM +, Xie, Huawei wrote: > On 10/21/2015 11:48 AM, Yuanhan Liu wrote: > > All queue pairs, including the default (the first) queue pair, > > are allocated dynamically, when a vring_call message is received > > first time for a specific queue pair. > > > > This

[dpdk-dev] [RFC PATCH v2] vhost: Add VHOST PMD

2015-10-22 Thread Tetsuya Mukawa
On 2015/10/21 19:22, Bruce Richardson wrote: > On Wed, Oct 21, 2015 at 09:25:12AM +0300, Panu Matilainen wrote: >> On 10/21/2015 07:35 AM, Tetsuya Mukawa wrote: >>> On 2015/10/19 22:27, Richardson, Bruce wrote: > -Original Message- > From: Panu Matilainen [mailto:pmatilai at

[dpdk-dev] [RFC PATCH v3 2/2] vhost: Add VHOST PMD

2015-10-22 Thread Tetsuya Mukawa
The patch introduces a new PMD. This PMD is implemented as thin wrapper of librte_vhost. It means librte_vhost is also needed to compile the PMD. The vhost messages will be handled only when a port is started. So start a port first, then invoke QEMU. The PMD has 2 parameters. - iface: The

[dpdk-dev] [RFC PATCH v3 1/2] vhost: Add callback and private data for vhost PMD

2015-10-22 Thread Tetsuya Mukawa
These variables are needed to be able to manage one of virtio devices using both vhost library APIs and vhost PMD. For example, if vhost PMD uses current callback handler and private data provided by vhost library, A DPDK application that links vhost library cannot use some of vhost library APIs.

[dpdk-dev] [RFC PATCH v3 0/2] Add VHOST PMD

2015-10-22 Thread Tetsuya Mukawa
The patch introduces a new PMD. This PMD is implemented as thin wrapper of librte_vhost. I've submitted below patches in former patch sets. But it seems some issues were fixed already. - [PATCH 1/3] vhost: Fix return value of GET_VRING_BASE message - [PATCH 2/3] vhost: Fix RESET_OWNER handling

[dpdk-dev] [PATCH v4 0/2] cfgfile: modify the macros values

2015-10-22 Thread Thomas Monjalon
> Michal Jastrzebski (1): > qos_sched: fix example modification to use librte_cfgfile > > Jasvinder Singh (1): > librte_cfgfile(rte_cfgfile.h): modify the macros values Applied with more meaningful titles: examples/qos_sched: remove duplicated cfgfile library cfgfile:

[dpdk-dev] [PATCH] eal: fix C++ build (struct member: virtual)

2015-10-22 Thread Thomas Monjalon
2015-10-13 14:23, David Marchand: > On Tue, Oct 13, 2015 at 11:13 AM, David Marchand > > christoph.gysin at gmail.com> wrote: > >> Is there anything I can do to help getting this merged? > > > > This is ok for me, cc-ing Thomas. > > Thought I already did, but just in case, > Acked-by: David

[dpdk-dev] [PATCH v7 4/8] vhost: rxtx: use queue id instead of constant ring index

2015-10-22 Thread Yuanhan Liu
On Wed, Oct 21, 2015 at 05:26:18PM +0300, Michael S. Tsirkin wrote: > On Wed, Oct 21, 2015 at 08:48:15PM +0800, Yuanhan Liu wrote: > > > Please note that for virtio devices, guest is supposed to > > > control the placement of incoming packets in RX queues. > > > > I may not follow you. > > > >

[dpdk-dev] [PATCH v2 16/16] doc: release notes update for fm10k Vector PMD

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Update 2.2 release notes, add descriptions for Vector PMD implementation in fm10k driver. Signed-off-by: Chen Jing D(Mark) --- doc/guides/rel_notes/release_2_2.rst |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git

[dpdk-dev] [PATCH v2 15/16] fm10k: fix a crash issue in vector RX func

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Vector RX function will process 4 packets at a time. When the RX ring wrapps to the tail and the left descriptor size is not multiple of 4, SW will overwrite memory that not belongs to it and cause crash. The fix will allocate additional 4 HW/SW

[dpdk-dev] [PATCH v2 14/16] fm10k: Add function to decide best TX func

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add func fm10k_set_tx_function to decide the best TX func in fm10k_dev_tx_init. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h|1 + drivers/net/fm10k/fm10k_ethdev.c | 38 -- 2

[dpdk-dev] [PATCH v2 13/16] fm10k: introduce 2 funcs to reset TX queue and mbuf release

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add 2 funcs to reset TX queue and mbuf release when Vector TX applied. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k_rxtx_vec.c | 68 1 files changed, 68 insertions(+), 0 deletions(-) diff

[dpdk-dev] [PATCH v2 12/16] fm10k: use func pointer to reset TX queue and mbuf release

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Vector TX use different way to manage TX queue, it's necessary to use different functions to reset TX queue and release mbuf in TX queue. So, introduce 2 function pointers to do such ops. Signed-off-by: Chen Jing D(Mark) ---

[dpdk-dev] [PATCH v2 11/16] fm10k: add Vector TX function

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add Vector TX func fm10k_xmit_pkts_vec to transmit packets. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h |5 + drivers/net/fm10k/fm10k_rxtx_vec.c | 150 2 files changed, 155

[dpdk-dev] [PATCH v2 10/16] fm10k: add func to release mbuf in case Vector RX applied

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Since Vector RX use different variables to trace RX HW ring, it leads to need different func to release mbuf properly. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h |1 + drivers/net/fm10k/fm10k_ethdev.c |6

[dpdk-dev] [PATCH v2 09/16] fm10k: add function to decide best RX function

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add func fm10k_set_rx_function to decide best RX func in fm10k_dev_rx_init Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h|1 + drivers/net/fm10k/fm10k_ethdev.c | 36 2 files

[dpdk-dev] [PATCH v2 08/16] fm10k: add Vector RX scatter function

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add func fm10k_recv_scattered_pkts_vec to receive chained packets with SSE instructions. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h |2 + drivers/net/fm10k/fm10k_rxtx_vec.c | 88

[dpdk-dev] [PATCH v2 07/16] fm10k: add func to do Vector RX condition check

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add func fm10k_rx_vec_condition_check to check if Vector RX func can be applied. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h |1 + drivers/net/fm10k/fm10k_rxtx_vec.c | 31 +++ 2

[dpdk-dev] [PATCH v2 06/16] fm10k: add Vector RX function

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add func fm10k_recv_raw_pkts_vec to parse raw packets, in which includes possible chained packets. Add func fm10k_recv_pkts_vec to receive single mbuf packet. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h |1 +

[dpdk-dev] [PATCH v2 05/16] fm10k: add 2 functions to parse pkt_type and offload flag

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add 2 functions, in which using SSE instructions to parse RX desc to get pkt_type and ol_flags in mbuf. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k_rxtx_vec.c | 127 1 files changed, 127

[dpdk-dev] [PATCH v2 04/16] fm10k: add func to re-allocate mbuf for RX ring

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add function fm10k_rxq_rearm to re-allocate mbuf for used desc in RX HW ring. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h |9 drivers/net/fm10k/fm10k_ethdev.c |3 + drivers/net/fm10k/fm10k_rxtx_vec.c |

[dpdk-dev] [PATCH v2 03/16] fm10k: Add a new func to initialize all parameters

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add new function fm10k_params_init to initialize all fm10k related variables. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k_ethdev.c | 34 ++ 1 files changed, 22 insertions(+), 12 deletions(-)

[dpdk-dev] [PATCH v2 02/16] fm10k: add vPMD pre-condition check for each RX queue

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add condition check in rx_queue_setup func. If number of RX desc can't satisfy vPMD requirement, record it into a variable. Or call fm10k_rxq_vec_setup to initialize Vector RX. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h

[dpdk-dev] [PATCH v2 01/16] fm10k: add new vPMD file

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add new file fm10k_rxtx_vec.c and add it into compiling. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/Makefile |1 + drivers/net/fm10k/fm10k_rxtx_vec.c | 45 2 files changed, 46

[dpdk-dev] [PATCH v2 00/16] Vector Rx/Tx PMD implementation for fm10k

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" v2: - Fix a typo issue - Fix an improper prefetch in vector RX function, in which prefetches un-initialized mbuf. - Remove limitation on number of desc pointer in vector RX function. - Re-organize some comments. - Add a new patch to fix a

[dpdk-dev] [PATCH v7 4/8] vhost: rxtx: use queue id instead of constant ring index

2015-10-22 Thread Michael S. Tsirkin
On Thu, Oct 22, 2015 at 10:07:10PM +0800, Yuanhan Liu wrote: > On Thu, Oct 22, 2015 at 02:32:31PM +0300, Michael S. Tsirkin wrote: > > On Thu, Oct 22, 2015 at 05:49:55PM +0800, Yuanhan Liu wrote: > > > On Wed, Oct 21, 2015 at 05:26:18PM +0300, Michael S. Tsirkin wrote: > > > > On Wed, Oct 21, 2015

[dpdk-dev] [PATCH v3 11/11] fm10k: add xstats() implementation

2015-10-22 Thread Harry van Haaren
Add xstats() functions and statistic strings. Signed-off-by: Harry van Haaren --- drivers/net/fm10k/fm10k_ethdev.c | 87 1 file changed, 87 insertions(+) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index

[dpdk-dev] [PATCH v3 10/11] i40evf: add xstats() implementation

2015-10-22 Thread Harry van Haaren
Add implementation of xstats() functions in i40evf PMD. Signed-off-by: Harry van Haaren --- drivers/net/i40e/i40e_ethdev_vf.c | 89 +-- 1 file changed, 86 insertions(+), 3 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c

[dpdk-dev] [PATCH v3 09/11] i40e: add xstats() implementation

2015-10-22 Thread Harry van Haaren
Add xstats functions to i40e PMD, allowing extended statistics to be retrieved from the NIC and exposed to the DPDK. Signed-off-by: Harry van Haaren --- drivers/net/i40e/i40e_ethdev.c | 265 +++-- 1 file changed, 258 insertions(+), 7 deletions(-) diff --git

[dpdk-dev] [PATCH v3 08/11] ixgbevf: add xstats() functions to VF

2015-10-22 Thread Harry van Haaren
Add xstats() functions and stat strings as necessary to ixgbevf PMD. Signed-off-by: Harry van Haaren --- drivers/net/ixgbe/ixgbe_ethdev.c | 51 ++-- 1 file changed, 49 insertions(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c

[dpdk-dev] [PATCH v3 07/11] ixgbe: update statistic strings to scheme

2015-10-22 Thread Harry van Haaren
Updated and add statistic strings as used by xstats_get(). Signed-off-by: Harry van Haaren --- drivers/net/ixgbe/ixgbe_ethdev.c | 295 --- 1 file changed, 273 insertions(+), 22 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c

[dpdk-dev] [PATCH v3 06/11] igbvf: add xstats() implementation

2015-10-22 Thread Harry van Haaren
Add xstats functionality to igbvf PMD, adding necessary statistic strings. Signed-off-by: Harry van Haaren --- drivers/net/e1000/igb_ethdev.c | 62 +- 1 file changed, 55 insertions(+), 7 deletions(-) diff --git a/drivers/net/e1000/igb_ethdev.c

[dpdk-dev] [PATCH v3 05/11] igb: add xstats() implementation

2015-10-22 Thread Harry van Haaren
Add xstats_get() and xstats_reset() functions to igb driver, and the neccessary strings to expose these NIC statistics. Signed-off-by: Harry van Haaren --- drivers/net/e1000/igb_ethdev.c | 136 +++-- 1 file changed, 131 insertions(+), 5 deletions(-) diff

[dpdk-dev] [PATCH v3 04/11] virtio: add xstats() implementation

2015-10-22 Thread Harry van Haaren
Add xstats() functions and statistic strings to virtio PMD. Signed-off-by: Harry van Haaren --- drivers/net/virtio/virtio_ethdev.c | 98 +- drivers/net/virtio/virtio_rxtx.c | 32 + drivers/net/virtio/virtqueue.h | 4 ++ 3 files changed, 132

[dpdk-dev] [PATCH v3 03/11] ethdev: update xstats_get() strings and Q handling

2015-10-22 Thread Harry van Haaren
Update the strings used for presenting stats to adhere to the scheme previously presented. Updated xstats_get() function to handle Q information only if xstats() is not implemented in the PMD, providing the PMD with the needed flexibility to expose its extended Q stats. Signed-off-by: Harry van

[dpdk-dev] [PATCH v3 02/11] doc: add extended statistics to prog_guide

2015-10-22 Thread Harry van Haaren
Add extended statistic section to the programmers guide, poll mode driver section. This section describes how the strings stats are formatted, and how the client code can use this to gather information about the stat. Signed-off-by: Harry van Haaren --- doc/guides/prog_guide/poll_mode_drv.rst |

[dpdk-dev] [PATCH v3 01/11] doc: add extended statistics notes

2015-10-22 Thread Harry van Haaren
Add release notes for this patchset. Signed-off-by: Harry van Haaren --- doc/guides/rel_notes/release_2_2.rst | 12 1 file changed, 12 insertions(+) diff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.rst index 4f75cff..fe93629 100644 ---

[dpdk-dev] [PATCH v3 00/11] Port XStats

2015-10-22 Thread Harry van Haaren
This patchset adds an implementation of the xstats_get() and xstats_reset() API to the following PMDs: virtio, igb, igbvf, ixgbe, ixgbevf, i40e, i40evf and fm10k. The xstats API allows DPDK apps to gain access to extended statistics from each port on a NIC. These statistics are structured as per

[dpdk-dev] [PATCH v3] mem: command line option to delete hugepage backing files

2015-10-22 Thread Bruce Richardson
On Thu, Oct 22, 2015 at 09:51:28AM +0100, Sergio Gonzalez Monroy wrote: > On 21/10/2015 17:34, Bruce Richardson wrote: > >On Wed, Oct 21, 2015 at 04:22:45PM +, shesha Sreenivasamurthy (shesha) > >wrote: > >>When an application using huge-pages crash or exists, the hugetlbfs > >>backing files

[dpdk-dev] [PATCH] e1000: fix rx/tx total byte statistics

2015-10-22 Thread Harry van Haaren
This patch fixes a bug in reading the 64 bit register reading which was causing the total octets counters to show zero. Now the code reads both the lower and higher 32 bits. Tested in testpmd, byte values are correct. Fixes: 805803445a02 ("e1000: support EM devices (also known as e1000/e1000e)")

[dpdk-dev] Hyperscan open source release

2015-10-22 Thread O'Driscoll, Tim
At the recent DPDK Userspace event in Dublin, Mohammad Abdul Awal gave a brief talk on the Hyperscan pattern match software. We said at the time that it wasn't open sourced yet but it would be soon. It's now available at: https://01.org/hyperscan and https://github.com/01org/hyperscan. Tim

[dpdk-dev] [PATCH v3] mem: command line option to delete hugepage backing files

2015-10-22 Thread shesha Sreenivasamurthy (shesha)
Sergio, Your comment regarding remap_all_functions is correct and can be fixed by unlinking in remap_all_hugepages() too. However, regarding you comment that ?unmap_unneeded_hugepages? will fail ? in the unmap_unneeded_hugepages() we do not unlink if final_va is equal to NULL guarded by

[dpdk-dev] dpdk proposal installation process

2015-10-22 Thread Bruce Richardson
On Thu, Oct 22, 2015 at 08:55:41AM +0300, Panu Matilainen wrote: > On 10/21/2015 10:15 PM, Olivier MATZ wrote: > >Hi Mario, > > > >On 10/20/2015 11:17 AM, Bruce Richardson wrote: > >>On Tue, Oct 20, 2015 at 12:21:00AM +, Arevalo, Mario Alfredo C wrote: > >>>Hi folks, > >>> > >>> Good

[dpdk-dev] [PATCH] net:bonding: fix free_queues function when no queues exist

2015-10-22 Thread Yaacov Hazan
From: Raslsn Darawsheh In case of creating bond device without add any slaves and quit from testpmd, application crashed since rx/tx queues are NULL. add checking of this paramters before trying to free. Signed-off-by: Raslsn Darawsheh Signed-off-by: Yaacov Hazan ---

[dpdk-dev] [PATCH v2 0/2] i40e: Enlarge the number of supported queues

2015-10-22 Thread Wu, Jingjing
> -Original Message- > From: Zhang, Helin > Sent: Thursday, October 22, 2015 3:28 PM > To: dev at dpdk.org > Cc: Pei, Yulong; Liu, Yong; Wu, Jingjing; Zhang, Helin > Subject: [PATCH v2 0/2] i40e: Enlarge the number of supported queues > > It enlarges the number of supported queues to

[dpdk-dev] [PATCH v2] ixgbe: Drop flow control frames from VFs

2015-10-22 Thread Wenzhuo Lu
This patch will drop flow control frames from being transmitted from VSIs. With this patch in place a malicious VF cannot send flow control or PFC packets out on the wire. V2: Reword the comments. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/ixgbe_pf.c | 43

[dpdk-dev] [PATCH v2 1/1] vmxnet3: add PCI Port Hotplug support

2015-10-22 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- doc/guides/rel_notes/release_2_2.rst | 1 + drivers/net/vmxnet3/vmxnet3_ethdev.c | 33 + 2 files changed, 30 insertions(+), 4 deletions(-) diff --git a/doc/guides/rel_notes/release_2_2.rst

[dpdk-dev] [PATCH v2 0/1] vmxnet3 hotplug support

2015-10-22 Thread Bernard Iremonger
add PCI Port Hotplug support to the vmxnet3 PMD This patch depends on 4 patches from the following patch set: -remove-pci-driver-from-vdevs.patch 0001-librte_eal-add-RTE_KDRV_NONE-for-vdevs.patch 0002-librte_ether-add-fields-from-rte_pci_driver-to-rte_e.patch

[dpdk-dev] [PATCH v2 2/2] i40e: Enlarge the number of supported queues

2015-10-22 Thread Helin Zhang
It enlarges the number of supported queues to hardware allowed maximum. There was a software limitation of 64 per physical port which is not reasonable. Signed-off-by: Helin Zhang --- config/common_bsdapp | 3 +- config/common_linuxapp | 3 +-

[dpdk-dev] [PATCH v2 1/2] i40e: adjust the number of queues for RSS

2015-10-22 Thread Helin Zhang
It adjusts the number of queues for RSS from power of 2 to any as long as it does not exceeds the hardware allowed. Signed-off-by: Helin Zhang --- drivers/net/i40e/i40e_ethdev.c| 8 drivers/net/i40e/i40e_ethdev_vf.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff

[dpdk-dev] [PATCH v2 0/2] i40e: Enlarge the number of supported queues

2015-10-22 Thread Helin Zhang
It enlarges the number of supported queues to hardware allowed maximum. There was a software limitation of 64 per physical port which is not reasonable. v2 changes: Fixed issues of using wrong configured number of VF queues. Helin Zhang (2): i40e: adjust the number of queues for RSS i40e:

[dpdk-dev] [PATCH v3 7/7] doc: release notes update for flow director enhancement

2015-10-22 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- doc/guides/rel_notes/release_2_2.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.rst index bc9b00f..9d0a4d7 100644 --- a/doc/guides/rel_notes/release_2_2.rst +++

[dpdk-dev] [PATCH v3 5/7] app/testpmd: modify and add fdir filter and mask CLIs for new modes

2015-10-22 Thread Wenzhuo Lu
The different fdir mode needs different parameters, so, the parameter *mode* is introduced to the CLI flow_director_filter and flow_director_mask. This parameter can pormpt the user to input the appropriate parameters for different mode. Please be aware, as we should set the fdir mode, the value

[dpdk-dev] [PATCH v3 4/7] app/testpmd: modify the output of the CLI show port fdir

2015-10-22 Thread Wenzhuo Lu
There're fdir mask and supported flow type in the output of the CLI, show port fdir. But not every parameter has meaning for all the fdir modes, and the supported flow type is meaningless for mac vlan and tunnel modes. So, we output different thing for different mode. Signed-off-by: Wenzhuo Lu

[dpdk-dev] [PATCH v3 3/7] app/testpmd: new fdir modes for testpmd parameter

2015-10-22 Thread Wenzhuo Lu
For testpmd CLI's parameter pkt-filter-mode, there're new values supported for fdir new modes, perfect-mac-vlan, perfect-tunnel. Signed-off-by: Wenzhuo Lu --- app/test-pmd/parameters.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/parameters.c

[dpdk-dev] [PATCH v3 2/7] app/testpmd: initialize the new fields for fdir mask

2015-10-22 Thread Wenzhuo Lu
When a port is enabled, there're default values for the parameters of fdir mask. For the new parameters, the default values also need to be set. Signed-off-by: Wenzhuo Lu --- app/test-pmd/testpmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/testpmd.c

[dpdk-dev] [PATCH v3 1/7] lib/librte_ether: modify the structures for fdir new modes

2015-10-22 Thread Wenzhuo Lu
Define the new modes and modify the filter and mask structures for the mac vlan and tunnel modes. Signed-off-by: Wenzhuo Lu --- lib/librte_ether/rte_eth_ctrl.h | 69 ++--- 1 file changed, 51 insertions(+), 18 deletions(-) diff --git

[dpdk-dev] [PATCH v3 0/7] Support new flow director modes on Intel x550 NIC

2015-10-22 Thread Wenzhuo Lu
This patch set adds 2 new flow director modes on Intel x550 NIC. The 2 new fdir modes are mac vlan mode and tunnel mode. The mac vlan mode can direct the flow based on the MAC address and VLAN TCI. The tunnel mode provides the support for VxLAN and NVGRE. x550 can recognize VxLAN and NVGRE

[dpdk-dev] [PATCH v4 2/2] librte_cfgfile(rte_cfgfile.h): modify the macros values

2015-10-22 Thread Jasvinder Singh
This patch refers to the ABI change proposed for librte_cfgfile(rte_cfgfile.h). In order to allow for longer names and values, the values of macro CFG_NAME_LEN and CFG_VAL_LEN is increased. Signed-off-by: Jasvinder Singh --- doc/guides/rel_notes/deprecation.rst | 4

[dpdk-dev] [PATCH v4 1/2] qos_sched: fix example modification to use librte_cfgfile

2015-10-22 Thread Jasvinder Singh
From: Michal Jastrzebski This is a supplement for previous patch that was incomplete. Previous commit message: This is a modification of qos_sched example to use librte_cfgfile for parsing configuration file. Fixes: db935d0171dd ("examples/qos_sched: use

[dpdk-dev] [PATCH v4 0/2] cfgfile: modify the macros values

2015-10-22 Thread Jasvinder Singh
This patchset is modifying two macros in rte_cfgfile library thus ABI needs versioning. To meet requirements of ABI compatibility release notes and Makefile is also modified. Additionally a fix for qos_sched application is send as previously it was incomplete in 2.1 and application was redefining

[dpdk-dev] [PATCH v7 4/8] vhost: rxtx: use queue id instead of constant ring index

2015-10-22 Thread Michael S. Tsirkin
On Thu, Oct 22, 2015 at 05:49:55PM +0800, Yuanhan Liu wrote: > On Wed, Oct 21, 2015 at 05:26:18PM +0300, Michael S. Tsirkin wrote: > > On Wed, Oct 21, 2015 at 08:48:15PM +0800, Yuanhan Liu wrote: > > > > Please note that for virtio devices, guest is supposed to > > > > control the placement of

[dpdk-dev] [PATCH v2 1/1] vhost_xen: fix compile error in main.c

2015-10-22 Thread Bernard Iremonger
changes in v2: update release notes Signed-off-by: Bernard Iremonger --- doc/guides/rel_notes/release_2_2.rst | 3 +++ examples/vhost_xen/main.c| 8 +--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/doc/guides/rel_notes/release_2_2.rst

[dpdk-dev] Inconsistent statistics counters for pmd_i40e

2015-10-22 Thread Arnon Warshavsky
You are right. Given this thread updated today http://dpdk.org/ml/archives/dev/2015-September/023480.html (updates from today still not there) It seems I was too quick to jump to conclusion. Just in case, when bound to i40e, can you run ethtool -i on that interface? It should show the fw version.

[dpdk-dev] GIT workflow model to help solve some of the problems

2015-10-22 Thread Wiles, Keith
? Regards, ++Keith Wiles Intel Corporation On 10/22/15, 6:56 AM, "Richardson, Bruce" wrote: > > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wiles, Keith >> Sent: Thursday, October 22, 2015 2:14 PM >> To: dev at dpdk.org >> Subject:

[dpdk-dev] [PATCH v3 1/7] lib/librte_ether: modify the structures for fdir new modes

2015-10-22 Thread Bruce Richardson
On Thu, Oct 22, 2015 at 03:11:36PM +0800, Wenzhuo Lu wrote: > Define the new modes and modify the filter and mask structures for > the mac vlan and tunnel modes. > > Signed-off-by: Wenzhuo Lu Hi Wenzhuo, couple of stylistic comments below, which would help with patch review, especially with

[dpdk-dev] GIT workflow model to help solve some of the problems

2015-10-22 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wiles, Keith > Sent: Thursday, October 22, 2015 2:14 PM > To: dev at dpdk.org > Subject: [dpdk-dev] GIT workflow model to help solve some of the problems > > I have been looking at the a GIT flow model that

[dpdk-dev] [RFC PATCH v3 2/2] vhost: Add VHOST PMD

2015-10-22 Thread Bruce Richardson
On Thu, Oct 22, 2015 at 06:45:50PM +0900, Tetsuya Mukawa wrote: > The patch introduces a new PMD. This PMD is implemented as thin wrapper > of librte_vhost. It means librte_vhost is also needed to compile the PMD. > The vhost messages will be handled only when a port is started. So start > a port

[dpdk-dev] Inconsistent statistics counters for pmd_i40e

2015-10-22 Thread Eimear Morrissey
Arnon Warshavsky wrote on 10/22/2015 12:12:47 PM: > From: Arnon Warshavsky > To: Eimear Morrissey/Ireland/IBM at IBMIE > Cc: dev at dpdk.org > Date: 10/22/2015 12:12 PM > Subject: Re: [dpdk-dev] Inconsistent statistics counters for pmd_i40e > > You are right. > Given this thread updated today

[dpdk-dev] GIT workflow model to help solve some of the problems

2015-10-22 Thread Wiles, Keith
I have been looking at the a GIT flow model that seems to help with our backlog problem and how we stage releases. I found this model a few years ago and find it to be very reasonable and helps us with development. http://nvie.com/posts/a-successful-git-branching-model/ The model may not be

[dpdk-dev] [PATCHv6 9/9] doc: release notes update for queue_info_get()

2015-10-22 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- doc/guides/rel_notes/release_2_2.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.rst index 4f75cff..33ea399 100644 --- a/doc/guides/rel_notes/release_2_2.rst +++

[dpdk-dev] [PATCHv6 8/9] testpmd: add new command to display RX/TX queue information

2015-10-22 Thread Konstantin Ananyev
From: "Ananyev, Konstantin" Signed-off-by: Konstantin Ananyev --- app/test-pmd/cmdline.c | 48 +++ app/test-pmd/config.c | 77 ++ app/test-pmd/testpmd.h | 2 ++ 3 files changed, 127

[dpdk-dev] [PATCHv6 7/9] vmxnet3: add HW specific desc_lim data into dev_info

2015-10-22 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index a70be5c..3745b7d 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++

[dpdk-dev] [PATCHv6 6/9] cxgbe: add HW specific desc_lim data into dev_info

2015-10-22 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- drivers/net/cxgbe/cxgbe_ethdev.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c index a8e057b..920e071 100644 --- a/drivers/net/cxgbe/cxgbe_ethdev.c +++

[dpdk-dev] [PATCHv6 5/9] fm10k: add HW specific desc_lim data into dev_info

2015-10-22 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- drivers/net/fm10k/fm10k_ethdev.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index a69c990..9588dab 100644 --- a/drivers/net/fm10k/fm10k_ethdev.c +++

[dpdk-dev] [PATCHv6 4/9] e1000: add support for eth_(rxq|txq)_info_get and (rx|tx)_desc_lim

2015-10-22 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- drivers/net/e1000/e1000_ethdev.h | 36 drivers/net/e1000/em_ethdev.c| 14 drivers/net/e1000/em_rxtx.c | 71 +++- drivers/net/e1000/igb_ethdev.c | 22 +

[dpdk-dev] [PATCHv6 3/9] ixgbe: add support for eth_(rxq|txq)_info_get and (rx|tx)_desc_lim

2015-10-22 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- drivers/net/ixgbe/ixgbe_ethdev.c | 23 ++ drivers/net/ixgbe/ixgbe_ethdev.h | 6 drivers/net/ixgbe/ixgbe_rxtx.c | 68 +--- drivers/net/ixgbe/ixgbe_rxtx.h | 21 + 4 files changed, 93

[dpdk-dev] [PATCHv6 2/9] i40e: add support for eth_(rxq|txq)_info_get and (rx|tx)_desc_lim

2015-10-22 Thread Konstantin Ananyev
This patch assumes that the patch: i40e: fix wrong alignment for the number of HW descriptors already applied. Signed-off-by: Konstantin Ananyev --- drivers/net/i40e/i40e_ethdev.c| 14 ++ drivers/net/i40e/i40e_ethdev.h| 5 + drivers/net/i40e/i40e_ethdev_vf.c | 12

[dpdk-dev] [PATCHv6 1/9] ethdev: add new API to retrieve RX/TX queue information

2015-10-22 Thread Konstantin Ananyev
From: "Ananyev, Konstantin" Add the ability for the upper layer to query RX/TX queue information. Add into rte_eth_dev_info new fields to represent information about RX/TX descriptors min/max/alig nnumbers per queue for the device. Add new structures: struct

[dpdk-dev] [PATCHv6 0/9] ethdev: add new API to retrieve RX/TX queue information

2015-10-22 Thread Konstantin Ananyev
Add the ability for the upper layer to query: 1) configured RX/TX queue information. 2) information about RX/TX descriptors min/max/align numbers per queue for the device. v2 changes: - Add formal check for the qinfo input parameter. - As suggested rename 'rx_qinfo/tx_qinfo' to

[dpdk-dev] ixgbe: ierrors counter spuriously increasing in DPDK 2.1

2015-10-22 Thread Andriy Berestovskyy
Hi Martin, We agreed on the main point: it's an issue. IMO the implementation details are up to Maryam. There have been few patches, so I guess it will be fixed in 2.2. Andriy On Thu, Oct 22, 2015 at 9:46 AM, Martin Weiser wrote: > Hi Andriy, > > thank you for pointing this discussion out to

[dpdk-dev] [PATCH v3 2/4] nfp-uio: new uio driver for netronome nfp6000 card

2015-10-22 Thread Alejandro Lucero
Submitting just the PMD for integration makes sense. I will remove all the references to nfp_uio. My doubt is with documentation. Working with the NFP PMD will not be possible without nfp_uio. We could modify the documentation saying it is possible to use igb_uio, but this is not the right thing

  1   2   >