[dpdk-dev] [PATCH v2 2/2] examples: new example: l2fwd-ethtool

Thomas, Could you explain why this patch is put on RFC? Thanks, Larry > -Original Message- > From: Wang, Liang-min > Sent: Wednesday, October 21, 2015 12:47 PM > To: 'Thomas Monjalon' > Cc: dev at dpdk.org; Andrew Harvey (agh) (agh at cisco.com) > Subject: RE: [dpdk-dev] [PATCH

[dpdk-dev] [RFC PATCH 2/2] lib/librte_eal: Remove unnecessary hugepage zero-filling

The kernel fills new allocated (huge) pages with zeros. DPDK just has to touch the pages to trigger the allocation. Signed-off-by: Zhihong Wang --- lib/librte_eal/linuxapp/eal/eal_memory.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

[dpdk-dev] [RFC PATCH 1/2] lib/librte_eal: Reduce timer initialization time

Changing from 1/2 second to 1/10 doesn't compromise the precision, and a 4/10 second is worth saving. Signed-off-by: Zhihong Wang --- lib/librte_eal/linuxapp/eal/eal_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_timer.c

[dpdk-dev] [RFC PATCH 0/2] Reduce DPDK initialization time

This RFC patch aims to reduce DPDK initialization time, which is important in cases such as micro service. Changes are: 1. Reduce timer initialization time 2. Remove unnecessary hugepage zero-filling operations With this patch: 1. Timer initialization time can be reduced by 4/10 second 2.

[dpdk-dev] [PATCH v4 1/2] vhost: Add callback and private data for vhost PMD

On Fri, Nov 13, 2015 at 02:20:30PM +0900, Tetsuya Mukawa wrote: > These variables are needed to be able to manage one of virtio devices > using both vhost library APIs and vhost PMD. > For example, if vhost PMD uses current callback handler and private data > provided by vhost library, A DPDK

[dpdk-dev] [PATCH] vhost: avoid buffer overflow in update_secure_len

On Tue, Nov 17, 2015 at 6:56 PM, Yuanhan Liu wrote: > @@ -519,6 +526,8 @@ virtio_dev_merge_rx(struct virtio_net *dev, uint16_t > queue_id, > goto merge_rx_exit; > } else { >

[dpdk-dev] [PATCH v4 0/2] Add VHOST PMD

On Fri, Nov 13, 2015 at 03:50:16PM +0900, Tetsuya Mukawa wrote: > On 2015/11/13 14:32, Yuanhan Liu wrote: > > On Fri, Nov 13, 2015 at 02:20:29PM +0900, Tetsuya Mukawa wrote: > >> The patch introduces a new PMD. This PMD is implemented as thin wrapper > >> of librte_vhost. > >> > >> * Known issue.

[dpdk-dev] [PATCH] vhost: avoid buffer overflow in update_secure_len

On Thu, Nov 12, 2015 at 01:46:03PM -0800, Rich Lane wrote: > You can reproduce this with l2fwd and the vhost PMD. > > You'll need this patch on top of the vhost PMD patches: > --- a/lib/librte_vhost/virtio-net.c > +++ b/lib/librte_vhost/virtio-net.c > @@ -471,7 +471,7 @@ reset_owner(struct

[dpdk-dev] [PATCH v4] doc: add nic performance guide on linux gsg

Add a new guide doc as part of the Linux Getting Started Guide. The document is a step-by-step guide on how to get high performance with DPDK on an Intel platform. It is designed for users who are not familiar with DPDK but would like to get the best performance with NICs. Signed-off-by: Qian

[dpdk-dev] [PATCH] ACL: fix build for native-icc target on haswell fails

On HSW box with icc 16.0.0 build for x86_64-default-linuxapp-icc fails with: icc: command line warning #10120: overriding '-march=native' with '-msse4.1' ... dpdk.org/x86_64-native-linuxapp-icc/include/rte_memcpy.h(96): error: identifier "__m256i" is undefined The reason is that icc treats

[dpdk-dev] [PATCH v7 4/8] vhost: rxtx: use queue id instead of constant ring index

On 11/17/2015 04:23 PM, Michael S. Tsirkin wrote: > On Mon, Nov 16, 2015 at 02:20:57PM -0800, Flavio Leitner wrote: >> > On Wed, Oct 28, 2015 at 11:12:25PM +0200, Michael S. Tsirkin wrote: >>> > > On Wed, Oct 28, 2015 at 06:30:41PM -0200, Flavio Leitner wrote: > > > On Sat, Oct 24, 2015 at

[dpdk-dev] DPDK Community Call - ARM Support

There's been a lot of activity on the mailing list recently on DPDK support for ARM. It's great to see the project being enhanced to embrace a new architecture. We have seen some duplication of efforts on this, so we think it would make a good topic for a community call. This will give

[dpdk-dev] Making rte_eal_pci_probe() in rte_eal_init() optional?

2015-11-17 08:56, Roger B. Melton: > Hi David, in-line -Roger > > On 11/16/15 4:46 AM, David Marchand wrote: > > Hello Roger, > > > > On Sun, Nov 15, 2015 at 3:45 PM, Roger B. Melton > > wrote: > > > > I like the "-b all" and "-w none" idea, but I think it might

[dpdk-dev] [PATCH v7 01/10] ethdev: rename macros to have RTE_ prefix

2015-11-17 14:44, Declan Doherty: > Hey Thomas, > > this patch needs to be re-based due to the committal of Daniel's patch > "ethdev: add ieee1588 functions for device clock time" is it ok to just > send an updated patch for this single patch as it doesn't effect the > other 9 patches in the

[dpdk-dev] How to approach packet TX lockups

Hi Matt, As I said, at least try to upgrade contents of shared code to the latest one. In previous releases: lib/librte_pmd_ixgbe/ixgbe, now located at: drivers/net/ixgbe/. > For reference, my transmit function is rte_eth_tx_burst(). I meant what ixgbe TX function it points to:

[dpdk-dev] [PATCH v7.1 01/10] ethdev: rename macros to have RTE_ prefix

The macros to check that the function pointers and port ids are valid for an ethdev are potentially useful to have in a common headers for use with all PMDs. However, since they would then become externally visible, we apply the RTE_ & RTE_ETH_ prefix to them as approtiate. Signed-off-by: Declan

[dpdk-dev] [PATCH] app/test: fix memory_autotest integer overflow/wraparound

memory_autotest loops infinitely when at least one the memsegs is bigger than 4GB. The issue is the result of an integer overflow/wraparound of the offset variable. Fix it by using the correct type (size_t). Signed-off-by: Sergio Gonzalez Monroy --- app/test/test_memory.c | 3 ++- 1 file

[dpdk-dev] [PATCH 1/1] mpipe: add missing version map for mpipe pmd driver

Without it, compiling error occurs when CONFIG_RTE_BUILD_SHARED_LIB is enabled. Reported-by: Guo Xin Signed-off-by: Zhigang Lu --- drivers/net/mpipe/rte_pmd_mpipe_version.map | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 drivers/net/mpipe/rte_pmd_mpipe_version.map diff --git

[dpdk-dev] [PATCH] i40e: skip any phy config as a workaround

As firmware does not support any link control from software driver side, any phy config should be ignored as a workaround. Otherwise the link might not be up again after binding back to kernel driver. Signed-off-by: Helin Zhang --- drivers/net/i40e/i40e_ethdev.c | 61

[dpdk-dev] [PATCH v3 2/2] examples: add pthread-shim in performance-thread sample app

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of ibetts > Sent: Tuesday, November 17, 2015 12:11 PM > To: dev at dpdk.org > Cc: Betts, Ian > Subject: [dpdk-dev] [PATCH v3 2/2] examples: add pthread-shim in > performance-thread sample app Hi Ian, For some

[dpdk-dev] [PATCH v7 4/8] vhost: rxtx: use queue id instead of constant ring index

On Tue, Nov 17, 2015 at 10:23:38AM +0200, Michael S. Tsirkin wrote: > On Mon, Nov 16, 2015 at 02:20:57PM -0800, Flavio Leitner wrote: > > On Wed, Oct 28, 2015 at 11:12:25PM +0200, Michael S. Tsirkin wrote: > > > On Wed, Oct 28, 2015 at 06:30:41PM -0200, Flavio Leitner wrote: > > > > On Sat, Oct

[dpdk-dev] [PATCH v7 01/10] ethdev: rename macros to have RTE_ prefix

On 13/11/15 18:58, Declan Doherty wrote: > The macros to check that the function pointers and port ids are valid > for an ethdev are potentially useful to have in a common headers for > use with all PMDs. However, since they would then become externally > visible, we apply the RTE_ & RTE_ETH_

[dpdk-dev] How to approach packet TX lockups

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Matt Laswell > Sent: Tuesday, November 17, 2015 2:24 PM > To: Stephen Hemminger > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] How to approach packet TX lockups > > Yes, we're on 1.6r2. That said, I've

[dpdk-dev] [PATCH 1/1] config/tile: disable KNI kmod option on tile

Commit 36080ff96b0e causes compiling error on tile, as tile does not support KNI, so we disable the CONFIG_RTE_KNI_KMOD. Fixes: 36080ff96b0e ("config: add KNI kmod option") Reported-by: Guo Xin Signed-off-by: Zhigang Lu --- config/defconfig_tile-tilegx-linuxapp-gcc | 1 + 1 file changed, 1

[dpdk-dev] [PATCH v4 2/2] ethdev: add sanity checks to functions

The functions rte_eth_rx_queue_count and rte_eth_descriptor_done are supported by very few PMDs. Therefore, it is best to check for support for the functions in the ethdev library, so as to avoid run-time crashes at run-time if the application goes to use those APIs. Similarly, the port parameter

[dpdk-dev] [PATCH v4 1/2] ethdev: remove duplicated debug functions

The functions for rx/tx burst, for rx_queue_count and descriptor_done in the ethdev library all had two copies of the code. One copy in rte_ethdev.h was inlined for performance, while a second was in rte_ethdev.c for debugging purposes only. We can eliminate the second copy of the functions by

[dpdk-dev] [PATCH v4 0/2] ethdev: debug code cleanup

This patchset performs two cleanups: 1. Four functions in ethdev.c which were enabled for debug only have been merged into their inlined header-file counterparts. This change required that a number of macros be renamed and moved to the header file too. The macro changes are in patches 1 &

[dpdk-dev] [PATCH v3 1/2] examples: add performance thread sample application

From: Ian Betts This example comprises a layer 3 forwarding derivative intended to facilitate characterization of performance with different threading models, specifically:- 1. EAL threads running on different physical cores 2. EAL threads running on the same physical core

[dpdk-dev] [PATCH] fm10k: fix a crash bug when quit from testpmd

On 2015/11/12 12:58, Chen Jing D(Mark) wrote: > From: "Chen Jing D(Mark)" > > When the fm10k port is closed, both func tx_queue_clean() and > fm10k_tx_queue_release_mbufs_vec() will try to release buffer in > SW ring. The latter func won't do sanity check on those pointers > and cause crash. > >

[dpdk-dev] Recent changes related to interrupt thread

> From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Monday, November 16, 2015 5:40 PM > To: Ananyev, Konstantin > Cc: Thomas Monjalon; dev at dpdk.org; Nirranjan Kirubaharan; Felix Marti; > Kumar Sanghvi > Subject: Re: [dpdk-dev] Recent changes related to interrupt thread

[dpdk-dev] URGENT please help. Issue on ixgbe_tx_free_bufs version 2.0.0

On Sun, Nov 15, 2015 at 07:58:27PM -0300, Ariel Rodriguez wrote: > Hi Bruce, im going to list the results after the test?s. > > I will start with the second hint you proposed: > > 2) I upgrade our custom dpdk application with the latest dpdk code (2.1.0) > and the issue still there. > > 1) I

[dpdk-dev] How to approach packet TX lockups

Thanks, I'll give that a try. In my environment, I'm pretty sure we're using the fully-featured ixgbe_xmit_pkts() and not _simple(). If setting rs_thresh=1 is safer, I'll stick with that. Again, thanks to all for the assistance. - Matt On Tue, Nov 17, 2015 at 10:20 AM, Ananyev, Konstantin <

[dpdk-dev] [PATCH v7 4/8] vhost: rxtx: use queue id instead of constant ring index

On Mon, Nov 16, 2015 at 02:20:57PM -0800, Flavio Leitner wrote: > On Wed, Oct 28, 2015 at 11:12:25PM +0200, Michael S. Tsirkin wrote: > > On Wed, Oct 28, 2015 at 06:30:41PM -0200, Flavio Leitner wrote: > > > On Sat, Oct 24, 2015 at 08:47:10PM +0300, Michael S. Tsirkin wrote: > > > > On Sat, Oct

[dpdk-dev] [PATCH v2] rte_sched: release enqueued mbufs on rte_sched_port_free()

Otherwise mbufs will leak when the port is destroyed. The rte_sched_port_qbase() and rte_sched_port_qsize() functions are used in free now, so move them up. Signed-off-by: Simon Kagstrom --- ChangeLog: v2: * Break long line in rte_sched_port_qbase() * Provide some air after variable in

[dpdk-dev] How to approach packet TX lockups

Hey Konstantin, Moving from 1.6r2 to 2.2 is going to be a pretty significant change due to things like changes in the MBuf format, API differences, etc. Even as an experiment, that's an awfully large change to absorb. Is there a subset that you're referring to that could be more readily

[dpdk-dev] Making rte_eal_pci_probe() in rte_eal_init() optional?

Hi David, in-line -Roger On 11/16/15 4:46 AM, David Marchand wrote: > Hello Roger, > > On Sun, Nov 15, 2015 at 3:45 PM, Roger B. Melton > wrote: > > I like the "-b all" and "-w none" idea, but I think it might be > complicated to implement it the way we

[dpdk-dev] [PATCH] rte_sched: release enqueued mbufs on rte_sched_port_free()

On 2015-11-04 19:14, Stephen Hemminger wrote: > On Wed, 28 Oct 2015 10:56:33 +0100 > Simon Kagstrom wrote: > >> Otherwise mbufs will leak when the port is destroyed. The >> rte_sched_port_qbase() and rte_sched_port_qsize() functions are used >> in free now, so move them up. >> >> Signed-off-by:

[dpdk-dev] [PATCH] vhost: avoid buffer overflow in update_secure_len

On Tue, Nov 17, 2015 at 5:23 AM, Yuanhan Liu wrote: > On Thu, Nov 12, 2015 at 01:46:03PM -0800, Rich Lane wrote: > > You can reproduce this with l2fwd and the vhost PMD. > > > > You'll need this patch on top of the vhost PMD patches: > > --- a/lib/librte_vhost/virtio-net.c > > +++

[dpdk-dev] How to approach packet TX lockups

Yes, we're on 1.6r2. That said, I've tried a number of different values for the thresholds without a lot of luck. Setting wthresh/hthresh/pthresh to 0/0/32 or 0/0/0 doesn't appear to fix things. And, as Matthew suggested, I'm pretty sure using 0 for the thresholds leads to auto-config by the

[dpdk-dev] [PATCH v4 2/2] ethdev: add sanity checks to functions

On Tue, 17 Nov 2015 12:21:07 + Bruce Richardson wrote: > The functions rte_eth_rx_queue_count and rte_eth_descriptor_done are > supported by very few PMDs. Therefore, it is best to check for support > for the functions in the ethdev library, so as to avoid run-time crashes > at run-time if

[dpdk-dev] [PATCH 1/2] ixgbe: fix vfio ioctl SET_IRQS error

Hi, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Liu, Yong > Sent: Friday, November 13, 2015 2:08 PM > To: Liang, Cunming ; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] ixgbe: fix vfio ioctl SET_IRQS error > > Tested-by: Yong Liu > > >

[dpdk-dev] [PATCH 2/2] igb: fix vfio ioctl SET_IRQS error

Hi, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Cunming Liang > Sent: Friday, November 13, 2015 10:50 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 2/2] igb: fix vfio ioctl SET_IRQS error > > The vector number may change during 'dev_start'.

[dpdk-dev] [PATCH 4/4] fm10k: remove crc size from all byte counters

Hi, Harry Have you ever tested this patch by yourself? fm10k's stats should already remove the crc bytes by default. After your patch applied, if send a packet without vlan(64 bytes), we expect receive 60 bytes, but it will disappoint you, that only 56 bytes shows in system. Thanks, Michael