[dpdk-dev] [PATCH v11 0/8] ethdev: 100G and link speed API refactoring

On 26 March 2016 at 09:08, Thomas Monjalon wrote: > Hi Marc, > > Thanks for finding time to help. > > 2016-03-25 22:30, Marc: > > From v9 to v10 patchset the values ETH_LINK_SPEED_AUTONEG and > ETH_LINK_SPEED_FIXED were flipped. Reverting this makes it work: > > > > marc at

[dpdk-dev] [PATCH v3] ixgbe: add check for tx queue number

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara > Sent: Thursday, March 24, 2016 3:18 PM > To: dev at dpdk.org > Cc: Lu, Wenzhuo ; De Lara Guarch, Pablo > > Subject: [dpdk-dev] [PATCH v3] ixgbe: add check for tx queue number > > From:

[dpdk-dev] [PATCH v13 0/8] ethdev: 100G and link speed API refactoring

> v13: > - Fix startup regression; revert flip of ETH_LINK_SPEED_FIXED and > ETH_LINK_SPEED_AUTONEG values. ETH_LINK_SPEED_AUTONEG is now 0. As commented earlier, I would prefer avoiding this revert. Comments are welcome.

[dpdk-dev] [PATCH v4 3/3] ixgbe: fix incorrect max tx queue number

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Mcnamara, John > Sent: Thursday, March 24, 2016 4:58 PM > To: De Lara Guarch, Pablo ; dev at dpdk.org > Cc: Lu, Wenzhuo ; Richardson, Bruce > ; De Lara Guarch, Pablo > > Subject: Re: [dpdk-dev] [PATCH v4 3/3]

[dpdk-dev] [PATCH v11 0/8] ethdev: 100G and link speed API refactoring

Hi Marc, Thanks for finding time to help. 2016-03-25 22:30, Marc: > From v9 to v10 patchset the values ETH_LINK_SPEED_AUTONEG and > ETH_LINK_SPEED_FIXED were flipped. Reverting this makes it work: > > marc at Beluga:~/personal/dpdk/tools$ git diff > diff --git a/lib/librte_ether/rte_ethdev.h

[dpdk-dev] [PATCH] i40e: Remove redundant fdir forward declarations.

This patch removes several redundant forward declarations in i40e_fdir.c. Signed-off-by: Rami Rosen --- drivers/net/i40e/i40e_fdir.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index f15a080..be3d0dd 100644

[dpdk-dev] e1000: randomly loosing link change events triggered by the peer

I found that in the current HEAD in master testing it with an I218-LM in autoneg mode, when link is forced to be renegociated by the peer (e.g. via ethtool on a peer Linux box) _some_ change events are lost. It is quite random, but it seems to happen more while changing the speed than when

[dpdk-dev] [PATCH v13 8/8] ethdev: add 100G link speed

From: Thomas Monjalon The link speed configuration is now done with bitmaps so 100G speed requires only a new bit flag. The actual link speed is a number so its size must be increased from 16-bit to 32-bit. Signed-off-by: Marc Sune Signed-off-by: Thomas Monjalon

[dpdk-dev] [PATCH v13 7/8] ethdev: convert speed number to bitmap flag

It is a helper for the bitmap configuration. Signed-off-by: Marc Sune Signed-off-by: Thomas Monjalon --- lib/librte_ether/rte_ethdev.c | 31 +++ lib/librte_ether/rte_ethdev.h | 13 + lib/librte_ether/rte_ether_version.map | 1 + 3

[dpdk-dev] [PATCH v13 6/8] ethdev: redesign link speed config

This patch redesigns the API to set the link speed/s configuration of an ethernet port. Specifically: - it allows to define a set of advertised speeds for auto-negociation. - it allows to disable link auto-negociation (single fixed speed). - default: auto-negociate all supported speeds. A flag

[dpdk-dev] [PATCH v13 5/8] ethdev: add speed capabilities

The speed capabilities of a device can be retrieved with rte_eth_dev_info_get(). The new field speed_capa is initialized in the drivers without taking care of device characteristics in this patch. When the capabilities of a driver are accurate, the table in overview.rst must be filled.

[dpdk-dev] [PATCH v13 4/8] ethdev: rename link speed constants

The speed numbers ETH_LINK_SPEED_ are renamed ETH_SPEED_NUM_. The prefix ETH_LINK_SPEED_ is kept for AUTONEG and will be used for bit flags in next patch. Signed-off-by: Marc Sune --- app/test-pmd/cmdline.c| 10 +- app/test/virtual_pmd.c| 2 +-

[dpdk-dev] [PATCH v13 3/8] app/testpmd: move speed and duplex parsing in a function

The code for checking and parsing speed/duplex was duplicated. The new function is also checking the speed/duplex combination. Signed-off-by: Marc Sune --- app/test-pmd/cmdline.c | 99 -- 1 file changed, 47 insertions(+), 52 deletions(-) diff

[dpdk-dev] [PATCH v13 2/8] ethdev: use constants for link duplex

Some duplex values are replaced from 0 to half-duplex when link is down. Some drivers are still using their own constants for duplex modes. Signed-off-by: Marc Sune --- drivers/net/e1000/em_ethdev.c | 2 +- drivers/net/e1000/igb_ethdev.c | 2 +- drivers/net/ixgbe/ixgbe_ethdev.c | 2

[dpdk-dev] [PATCH v13 1/8] ethdev: use constants for link state

From: Thomas Monjalon Define and use ETH_LINK_UP and ETH_LINK_DOWN where appropriate. Signed-off-by: Marc Sune Signed-off-by: Thomas Monjalon --- app/test-pipeline/init.c | 2 +- app/test-pmd/testpmd.c

[dpdk-dev] [PATCH v13 0/8] ethdev: 100G and link speed API refactoring

There are still too few tests and reviews, especially for autonegotiation with Intel devices (patch #6). I would not be surprised to see some bugs in this rework. The capabilities must be adapted per device. It can be improved in a separate patch. It will be integrated in 16.04-rc3. Please test

[dpdk-dev] [PATCH v11 0/8] ethdev: 100G and link speed API refactoring

On 25 March 2016 at 22:30, Marc wrote: > > > On 25 March 2016 at 21:41, Marc wrote: > >> >> On 25 March 2016 at 16:07, Zhang, Helin wrote: >> >>> Hi Thomas >>> >>> Beilei is investigating that, she will give her findings soon later, and >>> possibly a fix after validating that. >>> Thanks! >>>

[dpdk-dev] [RFC 0/6] Flattened Device Tree access from DPDK

Hello, while extending the DPDK by a kind of platform devices (for the 16.07), an access to the FDT might be necessary (or at least very helpful). This patch series for 16.07 introduces an approach to solve this topic. The API is designed from scratch and there is only the Linux backend for it.

[dpdk-dev] [RFC 6/6] eal/fdt: export for dpdk 16.07

Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/rte_eal_version.map | 20 1 file changed, 20 insertions(+) diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map index 12503ef..0c54859 100644 ---

[dpdk-dev] [RFC 5/6] eal/fdt: test Linux implementation on xgene-1 FDT

The test assumes a partial copy of a /proc/device-tree from the xgene-1 Linux runtime located at $(PWD)/linux-dt/xgene-1. We introduce tests of: * rte_fdt_open/close * rte_fdt_path_read * rte_fdt_path_walk It was not possible to implement those with no real device-tree available. Signed-off-by:

[dpdk-dev] [RFC 5/6] eal/fdt: test FDT for Linux on real data source

The test assumes a partial copy of a /proc/device-tree from the xgene-1 Linux runtime located at $(PWD)/linux-dt/xgene-1. We introduce tests of: * rte_fdt_open/close * rte_fdt_path_read * rte_fdt_path_walk It was not possible to implement those with no real device-tree available. Signed-off-by:

[dpdk-dev] [RFC 4/6] eal/fdt: add testing FDT of xgene-1 got from Linux runtime

Signed-off-by: Jan Viktorin --- app/test/linux-fdt/xgene1/#address-cells | Bin 0 -> 4 bytes app/test/linux-fdt/xgene1/#size-cells | Bin 0 -> 4 bytes app/test/linux-fdt/xgene1/compatible | Bin 0 -> 28 bytes

[dpdk-dev] [RFC 3/6] eal/fdt: test FDT API

Signed-off-by: Jan Viktorin --- app/test/Makefile | 1 + app/test/test_fdt.c | 270 2 files changed, 271 insertions(+) create mode 100644 app/test/test_fdt.c diff --git a/app/test/Makefile b/app/test/Makefile index a4907d5..ce4ec263

[dpdk-dev] [RFC 2/6] eal/fdt: implement FDT API for Linux

The Linux FDT API implementation reads the /proc/device-tree structure. Each FDT entry is represented by a file or directory there. Signed-off-by: Jan Viktorin --- lib/librte_eal/common/eal_common_fdt.c | 317 +++ lib/librte_eal/linuxapp/eal/Makefile | 3 +

[dpdk-dev] [RFC 1/6] eal/fdt: introduce Flattened Device Tree API

The API provides a way to access Flat Device Tree from EAL or from drivers. This makes possible to discover platform devices which are not discoverable via the PCI bus. Signed-off-by: Jan Viktorin --- lib/librte_eal/common/Makefile | 2 +- lib/librte_eal/common/include/rte_fdt.h |

[dpdk-dev] [RFC 0/6] Flattened Device Tree access from DPDK

Hello, while extending the DPDK by a kind of platform devices (for the 16.07), an access to the FDT might be necessary (or at least very helpful). This patch series for 16.07 introduces an approach to solve this topic. The API is designed from scratch and there is only the Linux backend for it.

[dpdk-dev] [PATCH 2/2] doc: update which PMDs can parse packet type

Hi Bruce, On 3/25/2016 10:21 PM, Bruce Richardson wrote: > On Fri, Mar 25, 2016 at 11:15:36AM +0800, Jianfeng Tan wrote: >> Signed-off-by: Jianfeng Tan >> --- >> doc/guides/nics/overview.rst | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git