[dpdk-dev] Multiple Ring for Multiple Cores

2016-04-15 Thread Mahdi Moradmand Badie
Dear All, I have a written code which doesn't work like I want, I wanna have a separate ring_buffer for each core (each core has its own ring), So I have a 2D array with initial values, Each core start read each row of values array, do the counter (or function) and write it back on own ring, I

[dpdk-dev] [PATCH] examples/exception_path: bad shift operation in setup_port_lcore_affinities

2016-04-15 Thread Daniel Mrzyglod
CID: #30688 The operaton may have an undefined behavior or yield to an unexpected result. In setup_port_lcore_affinities: A bit shift operation has a shift amount which is too large or has a negative value. Fixes: af75078fece3 ("first public release") Signed-off-by: Daniel Mrzyglod ---

[dpdk-dev] [PATCH] ixgbe: fix bad shift operation in ixgbe_set_pool_tx

2016-04-15 Thread Tomasz Kulasek
CID 13190 (#1 of 1): Bad bit shift operation (BAD_SHIFT) large_shift: In expression 1 << pool, left shifting by more than 31 bits has undefined behavior. The shift amount, pool, is at least 32. This patch limits mask shift to be in range of 32 bit PFVFTE[1] register, for pool > 31. Fixes:

[dpdk-dev] KNI port type in IP pipeline

2016-04-15 Thread Moon-Sang Lee
According to pp. 145 of DPDK programmer's guide 2.2.0, the KNI port type is described in table 23.1. But, I cannot find any material about how to specify the KNI port type in pipeline configuration file. Unfortunately, it seems there is no related source file in $DPDK_TOP/lib/librte_port. Does

[dpdk-dev] ethtool doesnt work on some interface after unbinding dpdk

2016-04-15 Thread Gopakumar Choorakkot Edakkunni
Well, I jumped to a conclusion too soon on the ACPI, that was a wrong statement (wishful thinking), I recreated the issue even with ACPI off This time the problem statement is more narrowed down. 1. dpdk is enabled on the interface, interfaces bound to igb_uio 3. kill the process using dpdk 3.

[dpdk-dev] [RFC PATCH v1 3/3] examples/ethtool: add xstats display command

2016-04-15 Thread Remy Horton
Signed-off-by: Remy Horton --- examples/ethtool/ethtool-app/ethapp.c | 57 +++ 1 file changed, 57 insertions(+) diff --git a/examples/ethtool/ethtool-app/ethapp.c b/examples/ethtool/ethtool-app/ethapp.c index 2ed4796..16ae4e9 100644 ---

[dpdk-dev] [RFC PATCH v1 2/3] drivers/net/ixgbe: change xstats to use integers

2016-04-15 Thread Remy Horton
Signed-off-by: Remy Horton --- drivers/net/ixgbe/ixgbe_ethdev.c | 87 +++- 1 file changed, 78 insertions(+), 9 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 3f1ebc1..4d31fe9 100644 ---

[dpdk-dev] [RFC PATCH v1 1/3] rte: change xstats to use integer keys

2016-04-15 Thread Remy Horton
Signed-off-by: Remy Horton --- lib/librte_ether/rte_ethdev.c | 87 +++ lib/librte_ether/rte_ethdev.h | 38 +++ 2 files changed, 117 insertions(+), 8 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c

[dpdk-dev] [RFC PATCH v1 0/3] Remove string operations from xstats

2016-04-15 Thread Remy Horton
The current extended ethernet statistics fetching involve doing several string operations, which causes performance issues if there are lots of statistics and/or network interfaces. This RFC patchset changes the API for xstats to use integer identifiers instead of strings and implements this new

[dpdk-dev] [PATCH PktGen/PCAP] let multi tx queues with pcap work

2016-04-15 Thread Zhouyi Zhou
Currently, dpdk-pktgen will panic when assigning multi tx queues with pcap packet, for example: ./app/app/build/pktgen -c f -n 2 -- -P -m "[0:1-3].0" -s 0:pcap/large.pcap This patch fix this bug by assigning qid to memory pool name. Signed-off-by: Zhouyi Zhou --- app/pktgen-pcap.c | 2 +- 1

[dpdk-dev] [PATCH] ixgbe: fix bad shift operation in ixgbe_set_pool_rx

2016-04-15 Thread Tomasz Kulasek
CID 13193 (#1 of 1): Bad bit shift operation (BAD_SHIFT) large_shift: In expression 1 << pool, left shifting by more than 31 bits has undefined behavior. The shift amount, pool, is at least 32. This patch limits mask shift to be in range of 32 bit PFVFRE[1] register, for pool > 31. Fixes:

[dpdk-dev] [PATCH v2 1/1] cmdline: add any multi string mode to token string

2016-04-15 Thread Wiles, Keith
>While parsing token string there may be several modes: >- fixed single string >- multi-choice single string >- any single string > >This patch add one more mode - any multi string. > >Signed-off-by: Piotr Azarewicz Does this patch also require updates to the documentation? > Regards, Keith

[dpdk-dev] [PATCH 06/36] mempool: update library version

2016-04-15 Thread Olivier Matz
On 04/14/2016 12:19 PM, Olivier Matz wrote: > Next changes of this patch series are too heavy to keep a compat > layer. So bump the version number of the library. > > Signed-off-by: Olivier Matz > --- > doc/guides/rel_notes/release_16_04.rst | 2 +- > lib/librte_mempool/Makefile

[dpdk-dev] [PATCH PktGen/PCAP] let multi tx queues with pcap work

2016-04-15 Thread Wiles, Keith
Thank you. >Currently, dpdk-pktgen will panic when assigning multi tx queues with pcap >packet, for example: >./app/app/build/pktgen -c f -n 2 -- -P -m "[0:1-3].0" -s 0:pcap/large.pcap > >This patch fix this bug by assigning qid to memory pool name. > >Signed-off-by: Zhouyi Zhou >--- >

[dpdk-dev] [PATCH 26/36] mempool: introduce a function to create an empty mempool

2016-04-15 Thread Wiles, Keith
> > >On 04/14/2016 05:57 PM, Wiles, Keith wrote: >>> Introduce a new function rte_mempool_create_empty() >>> that allocates a mempool that is not populated. >>> >>> The functions rte_mempool_create() and rte_mempool_xmem_create() >>> now make use of it, making their code much easier to read. >>>

[dpdk-dev] [PATCH 10/36] mempool: use the list to iterate the mempool elements

2016-04-15 Thread Wiles, Keith
>Hi, > >On 04/14/2016 05:33 PM, Wiles, Keith wrote: >>> >>> static void >>> -txq_mp2mr_mbuf_check(void *arg, void *start, void *end, >>> -uint32_t index __rte_unused) >>> +txq_mp2mr_mbuf_check(struct rte_mempool *mp, void *arg, void *obj, >>> + __rte_unused uint32_t index) >> >>

[dpdk-dev] [RFC 2/2] librte_ether: add new fields to rte_eth_dev_info struct

2016-04-15 Thread Thomas Monjalon
2016-04-14 10:44, Reshma Pattan: > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -908,6 +908,9 @@ struct rte_eth_dev_info { > struct rte_eth_desc_lim rx_desc_lim; /**< RX descriptors limits */ > struct rte_eth_desc_lim tx_desc_lim; /**< TX descriptors

[dpdk-dev] ethtool doesnt work on some interface after unbinding dpdk

2016-04-15 Thread Gopakumar Choorakkot Edakkunni
So looks like I figured it out .. I came across this bug reference https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=728692 and thought of checking out my problem with ACPI turned off. And with ACPI turned off, the problem doesnt happen. So theres something that the igb driver is not happy about

[dpdk-dev] [RFC 1/2] doc: announce ABI change for rte_eth_dev_info structure

2016-04-15 Thread Thomas Monjalon
2016-04-14 10:44, Reshma Pattan: > New fields nb_rx_queues and nb_tx_queues will be added to > rte_eth_dev_info structure. > Changes to API rte_eth_dev_info_get() will be done to update > these new fields to rte_eth_dev_info object. > > Signed-off-by:reshma Pattan In general the Signed-off lines

[dpdk-dev] [PATCH] examples: fix CID 30690 bad bit shift operation

2016-04-15 Thread Slawomir Mrozowicz
It fix coverity issue: CID 30690 (#1 of 1): Bad bit shift operation (BAD_SHIFT) 10. large_shift: In expression 1ULL << i, left shifting by more than 63 bits has undefined behavior. The shift amount, i, is as much as 127. Fixes: de3cfa2c9823 ("sched: initial import") Signed-off-by: Slawomir

[dpdk-dev] [PATCH] mlx4: use dummy rxqs when a non-pow2 number is requested

2016-04-15 Thread Olivier Matz
Hi, On 03/22/2016 03:27 PM, Wiles, Keith wrote: > Hi Olivier, > >> Hi Keith, >> >> On 03/21/2016 06:38 PM, Wiles, Keith wrote: On Mar 21, 2016, at 11:10 AM, Olivier Matz wrote: When using RSS, the number of rxqs has to be a power of two. This is a problem because there

[dpdk-dev] ethtool doesnt work on some interface after unbinding dpdk

2016-04-15 Thread Gopakumar Choorakkot Edakkunni
Nothing in dmesg .. The ethtool was just a side-observation, the biggest problem was that after unbinding from igb_uio and rebinding to igb, if I follow it up with an /etc/init.d/network restart, that completely hoses the linux system - anyone trying to open a socket (ifconfig for example) just

[dpdk-dev] [PATCH] port: bump ABI for pcap file support

2016-04-15 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, April 14, 2016 7:34 PM > To: Zhang, Roy Fan > Cc: dev at dpdk.org; Dumitrescu, Cristian ; > Singh, Jasvinder > Subject: [PATCH] port: bump ABI for pcap file support > > Support of PCAP

[dpdk-dev] [PATCH v2] mem: fix freeing of memzone used by ivshmem

2016-04-15 Thread Mauricio Vasquez B
although previous implementation returned an error when trying to release a memzone assigned to an ivshmem device, it stills freed it. Fixes: cd10c42eb5bc ("mem: fix ivshmem freeing") Signed-off-by: Mauricio Vasquez B --- v2: solved compilation problem when ivshmem is disabled

[dpdk-dev] [PATCH] mem: fix freeing of memzone used by ivshmem

2016-04-15 Thread Mauricio Vásquez
This patch does not compile when ivshmem is disabled: compile error: CC malloc_heap.o /home/patchWorkOrg/compilation/lib/librte_eal/common/eal_common_memzone.c(353): error #177: label "error" was declared but never referenced error: ^ I'll send a v2 solving this issue On Thu, Apr 14,

[dpdk-dev] memory allocation requirements

2016-04-15 Thread Sergio Gonzalez Monroy
On 15/04/2016 08:12, Olivier Matz wrote: > Hi, > > On 04/14/2016 05:39 PM, Sergio Gonzalez Monroy wrote: >>> Just to mention that some evolutions [1] are planned in mempool in >>> 16.07, allowing to populate a mempool with several chunks of memory, >>> and still ensuring that the objects are

[dpdk-dev] [RFC 2/2] librte_ether: add new fields to rte_eth_dev_info struct

2016-04-15 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Reshma Pattan > Sent: Thursday, April 14, 2016 10:45 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [RFC 2/2] librte_ether: add new fields to > rte_eth_dev_info struct > > New fields nb_rx_queues and

[dpdk-dev] [PATCH 26/36] mempool: introduce a function to create an empty mempool

2016-04-15 Thread Olivier Matz
On 04/14/2016 05:57 PM, Wiles, Keith wrote: >> Introduce a new function rte_mempool_create_empty() >> that allocates a mempool that is not populated. >> >> The functions rte_mempool_create() and rte_mempool_xmem_create() >> now make use of it, making their code much easier to read. >> Currently,

[dpdk-dev] [RFC 1/2] doc: announce ABI change for rte_eth_dev_info structure

2016-04-15 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Reshma Pattan > Sent: Thursday, April 14, 2016 10:45 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [RFC 1/2] doc: announce ABI change for > rte_eth_dev_info structure > > New fields nb_rx_queues and

[dpdk-dev] [PATCH 14/36] mempool: store physaddr in mempool objects

2016-04-15 Thread Olivier Matz
On 04/14/2016 05:40 PM, Wiles, Keith wrote: >> Store the physical address of the object in its header. It simplifies >> rte_mempool_virt2phy() and prepares the removing of the paddr[] table >> in the mempool header. >> >> Signed-off-by: Olivier Matz >> --- >> lib/librte_mempool/rte_mempool.c |

[dpdk-dev] [PATCH] pci: remove deprecated specific config

2016-04-15 Thread David Marchand
On Fri, Apr 15, 2016 at 2:53 AM, Zhang, Helin wrote: > > >> -Original Message- >> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] >> Sent: Friday, April 15, 2016 5:33 AM >> To: Zhang, Helin >> Cc: dev at dpdk.org >> Subject: [PATCH] pci: remove deprecated specific config >>

[dpdk-dev] memory allocation requirements

2016-04-15 Thread Olivier Matz
Hi, On 04/14/2016 05:39 PM, Sergio Gonzalez Monroy wrote: >> Just to mention that some evolutions [1] are planned in mempool in >> 16.07, allowing to populate a mempool with several chunks of memory, >> and still ensuring that the objects are physically contiguous. It >> completely removes the

[dpdk-dev] ethtool doesnt work on some interface after unbinding dpdk

2016-04-15 Thread Remy Horton
On 14/04/2016 20:25, Gopakumar Choorakkot Edakkunni wrote: [..] > ge8-> 06:00.0 Ethernet controller: Intel Corporation 82576 Gigabit > Network Connection (rev 01) > > root:~# ls /sys/class/net/ge8/device/driver/module/drivers/ > pci:igb > root:~# > > root:~# ethtool ge8 > Settings for ge8: >

[dpdk-dev] [PATCH] i40evf: Ignore disabled HW CRC strip for Linux PF hosts

2016-04-15 Thread Zhang, Helin
> -Original Message- > From: David Marchand [mailto:david.marchand at 6wind.com] > Sent: Friday, April 15, 2016 3:41 PM > To: Topel, Bjorn > Cc: dev at dpdk.org; Zhang, Helin ; Wu, Jingjing > > Subject: Re: [dpdk-dev] [PATCH] i40evf: Ignore disabled HW CRC strip for > Linux PF > hosts

[dpdk-dev] [PATCH v1 1/1] ixgbe: fix queue stop

2016-04-15 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Piotr Azarewicz > Sent: Thursday, April 14, 2016 6:00 PM > To: Zhang, Helin; Ananyev, Konstantin > Cc: dev at dpdk.org; Azarewicz, PiotrX T > Subject: [dpdk-dev] [PATCH v1 1/1] ixgbe: fix queue stop > > It

[dpdk-dev] [PATCH] pci: remove deprecated specific config

2016-04-15 Thread Zhang, Helin
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, April 15, 2016 5:33 AM > To: Zhang, Helin > Cc: dev at dpdk.org > Subject: [PATCH] pci: remove deprecated specific config > > The driver i40e was using a specific PCI config before the

[dpdk-dev] [PATCH] pci: remove deprecated specific config

2016-04-15 Thread Thomas Monjalon
The driver i40e was using a specific PCI config before the release 16.04. >From 16.04, it is always enabled in i40e (commit 56465cfaf). The API has been deprecated in the commit 68f77593823cab. The igb_uio implementation has been deprecated in commit b7cf8e155. The config helper - through igb_uio